Re: [ANNOUNCE] Two new committers: Xingcan Cui and Nico Kruber

2018-05-08 Thread Hequn Cheng
Congratulations! On Wed, May 9, 2018 at 4:40 AM, Rong Rong wrote: > Congratulations :-) > > On Tue, May 8, 2018 at 1:24 PM, Matthias J. Sax wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > Congrats! > > > > On 5/8/18 12:28 PM,

Re: [TABLE][SQL] Unify UniqueKeyExtractor and DataStreamRetractionRules

2018-06-16 Thread Hequn Cheng
traction traits > with respect of parent/children). > > I was thinking about the last approach - rules executed after adding > traits should preserve consistency of those traits. That’s why I didn’t > mind setting up retractions rules in a shuttle. > > Piotrek > > >

Re: [TABLE][SQL] Unify UniqueKeyExtractor and DataStreamRetractionRules

2018-06-05 Thread Hequn Cheng
Hi, thanks for bringing up this discussion. I agree to unify the UniqueKeyExtractor and DataStreamRetractionRules, however I am not sure if it is a good idea to implement it with RelShuttle. Theoretically, retraction rules and other rules may depend on each other. So, by using a RelShuttle

Re: Using SQL with dynamic tables where rows are updated

2018-01-05 Thread Hequn Cheng
hi Ghassan, TableSource in Flink doesn't support primary key now, but you can achieve it by doing a group by manually. Such as: val resultTable = tableEnv.sql( " SELECT ProductID, AVG(Rating) FROM ( SELECT ReviewID, LAST_VALUE(ProductID), LAST_VALUE(Approved) ,

Re: [TABLE][SQL] Unify UniqueKeyExtractor and DataStreamRetractionRules

2018-06-20 Thread Hequn Cheng
ules that on their own DO > brake those traits and converting them into rules that DO NOT brake them. > We could use such visitor/shuttle as a validation step or a clean up step > after a rewrite. > > Piotrek > > On 16 Jun 2018, at 10:42, Hequn Cheng wrote: > > Hi Piotr :-) > >

[DISCUSS][TABLE] How to handle empty delete for UpsertSource

2018-08-19 Thread Hequn Cheng
Hi all, Currently, I am working on FLINK-8577 Implement proctime DataStream to Table upsert conversion . And a design doc can be found here . It

Re: [Proposal] Utilities for reading, transforming and creating Streaming savepoints

2018-08-22 Thread Hequn Cheng
Hi Gyula, +1 for this feature. State bootstrapping and state analytics will be very helpful. On Thu, Aug 23, 2018 at 4:09 AM Gyula Fóra wrote: > Hi Shuyi, > > The tool allows you to convert a Flink DataSet containing the individual > state rows, (key, state) pairs, into a state for a streaming

Re: [DISCUSS][TABLE] How to handle empty delete for UpsertSource

2018-08-23 Thread Hequn Cheng
define that the upsert source ignore empty deletes. Flink only skip or ingest messages according to the sql/table-api provided by users. Thanks, Hequn On Thu, Aug 23, 2018 at 6:04 PM Piotr Nowojski wrote: > Hi, > > Thanks for very detailed explanation :) Please check my inlined responses.

Re: [DISCUSS] Remove the slides under "Community & Project Info"

2018-08-26 Thread Hequn Cheng
Hi Stephan, Thanks for bringing up this discussion. I think we can just remove it, because slides have already be provided from the `Flink Forward` section in this page. Adding another slides section not only brings redundancy but also introduces problems you listed above. Best, Hequn On Sun,

Re: [DISCUSS][TABLE] How to handle empty delete for UpsertSource

2018-08-22 Thread Hequn Cheng
Calc -> > UpsertSink, but also for example in the future for joins or ORDER BY > (especially with LIMIT) as well. > > > > I would apply same reasoning to FLINK-9528. > > > > Piotrek > > > >> On 19 Aug 2018, at 08:21, Hequn Cheng wrote: >

Re: [DISCUSS][TABLE] How to handle empty delete for UpsertSource

2018-08-29 Thread Hequn Cheng
; handle messages as follows: > - upsert message/flag=true: upsert messages are handled as regular > message. If the predicate evaluates to false, all but the key fields are > set to null and the message is forwarded as a delete message > - delete message/flag=false: delete messages are conver

Re: [ANNOUNCE] New committer Gary Yao

2018-09-07 Thread Hequn Cheng
Congratulations Gary! Hequn On Fri, Sep 7, 2018 at 11:16 PM Matthias J. Sax wrote: > Congrats! > > On 09/07/2018 08:15 AM, Timo Walther wrote: > > Congratulations, Gary! > > > > Timo > > > > > > Am 07.09.18 um 16:46 schrieb Ufuk Celebi: > >> Great addition to the committers. Congrats, Gary! >

Re: Facing issue in RichSinkFunction

2018-07-05 Thread Hequn Cheng
Hi Amol, The implementation of the RichSinkFunction probably contains a field that is not serializable. To avoid serializable exception, you can: 1. Marking the field as transient. This makes the serialization mechanism skip the field. 2. If the field is part of the object's persistent state, the

Re: Confusions About JDBCOutputFormat

2018-07-10 Thread Hequn Cheng
Hi wangsan, I agree with you. It would be kind of you to open a jira to check the problem. For the first problem, I think we need to establish connection each time execute batch write. And, it is better to get the connection from a connection pool. For the second problem, to avoid multithread

Re: Confusions About JDBCOutputFormat

2018-07-11 Thread Hequn Cheng
connection is closed? > > May be we could use a Timer to test the connection periodically and keep > it alive. What do you think? > > I will open a jira and try to work on that issue. > > Best, > wangsan > > > > On Jul 10, 2018, at 8:38 PM, Hequn Cheng wrote: >

Re: Confusions About JDBCOutputFormat

2018-07-11 Thread Hequn Cheng
> connection pools. Test and refresh the connection periodically can simply > solve this problem. I’ve implemented this at https://github.com/apache/ > flink/pull/6301, It would be kind of you to review this. > > Best, > wangsan > > > > On Jul 11, 2018, at 2:25 PM, Hequ

Re: [ANNOUNCE] Apache Flink 1.5.1 released

2018-07-13 Thread Hequn Cheng
Cool, thanks to Chesnay! Best, Hequn On Fri, Jul 13, 2018 at 8:25 PM, vino yang wrote: > Thanks Chesnay, great job! > > Thanks, > Vino > > 2018-07-13 20:20 GMT+08:00 Till Rohrmann : > >> Great to hear. Big thank you to the community for the hard work and to >> Chesnay for being our release

Re: Creating a slide set for a Flink intro talk

2018-10-16 Thread Hequn Cheng
Hi @Fabian Thanks a lot for creating the slide. It is great to have an introduction slide to our users. I have taken a look at the slide. The content of the slide is good and I only left some minor suggestions. Best, Hequn On Sat, Oct 13, 2018 at 10:12 AM jincheng sun wrote: > @Fabian Hueske

Re: [DISCUSS] [Contributing] (3) - Review Tooling

2018-10-17 Thread Hequn Cheng
Hi, I'm slightly prefer the bot option. The bot can post the review template automatically. But I do agree that we can start with a low-tech solution and add a bot later if find it helpful. Best, Hequn On Wed, Oct 17, 2018 at 11:17 AM Jin Sun wrote: > +1 > > On Tue, Oct 16, 2018 at 7:51 PM

Re: [DISCUSS] Enhancing the functionality and productivity of Table API

2018-11-01 Thread Hequn Cheng
Hi Jincheng, Thanks a lot for your proposal. It is very encouraging! As we all know, SQL is a widely used language. It follows standards, is a descriptive language, and is easy to use. A powerful feature of SQL is that it supports optimization. Users only need to care about the logic of the

Re: [DISCUSS] [Contributing] (2) - Review Steps

2018-10-09 Thread Hequn Cheng
+1 On Tue, Oct 9, 2018 at 3:25 PM Till Rohrmann wrote: > +1 > > On Tue, Oct 9, 2018 at 9:08 AM Zhijiang(wangzhijiang999) > wrote: > > > +1 > > -- > > 发件人:vino yang > > 发送时间:2018年10月9日(星期二) 14:08 > > 收件人:dev > > 主 题:Re: [DISCUSS]

Re: [DISCUSS] Improvements to the Unified SQL Connector API

2018-10-04 Thread Hequn Cheng
Hi, Thanks a lot for the proposal. I like the idea to unify table definitions. I think we can drop the table type since the type can be derived from the sql, i.e, a table be inserted can only be a sink table. I left some minor suggestions in the document, mainly include: - Maybe we also need to

Re: [DISCUSS] Improvements to the Unified SQL Connector API

2018-10-05 Thread Hequn Cheng
s > supposed to be written only by some producer. What do you guys think? > > Shuyi > > On Thu, Oct 4, 2018 at 7:31 AM Hequn Cheng wrote: > > > Hi, > > > > Thanks a lot for the proposal. I like the idea to unify table > definitions. > > I think we can drop the

Re: [DISCUSS] Dropping flink-storm?

2018-09-28 Thread Hequn Cheng
Hi, +1 to drop it. It seems that few people use it. Best, Hequn On Fri, Sep 28, 2018 at 10:22 PM Chesnay Schepler wrote: > I'm very much in favor of dropping it. > > Flink has been continually growing in terms of features, and IMO we've > reached the point where we should cull some of the

Re: [ANNOUNCE] Contributing Alibaba's Blink

2019-01-22 Thread Hequn Cheng
Hi all, @Stephan Thanks a lot for driving these efforts. I think a lot of people is already waiting for this. +1 for opening the blink source code. Both a separate repository or a special branch is ok for me. Hopefully, this will not last too long. Best, Hequn On Tue, Jan 22, 2019 at 11:35 PM

Re: [DISCUSS] Releasing Flink 1.6.3

2018-12-12 Thread Hequn Cheng
Hi Gordon, Thanks for the discussion! +1 for creating the 1.6.3 release. It would be nice if we have a new fix for the previous release. Best, Hequn On Wed, Dec 12, 2018 at 11:05 PM Till Rohrmann wrote: > Thanks for starting this discussion Gordon. +1 for creating the 1.6.3 > release since we

Re: [DISCUSS] Releasing Flink 1.7.1

2018-12-12 Thread Hequn Cheng
Hi Chesnay, Thanks for the efforts. +1 for the release. It's nice to have these fixes. Best, Hequn On Wed, Dec 12, 2018 at 11:09 PM Till Rohrmann wrote: > Thanks for starting this discussion Chesnay. +1 for creating the 1.7.1 > release since it already contains very useful fixes. > > Cheers,

Re: Flink 1.7 doesn't work with Kafka Table Source Descriptors

2018-12-22 Thread Hequn Cheng
Hi dhanuka, I failed to reproduce your error with release-1.7.0. It seems Kafka.toConnectorProperties() should be called instead of ConnectorDescriptor.toConnectorProperties(), the latter one is an abstract class, which lead to the AbstractMethodError. >From the picture uploaded, it is strange

Re: [VOTE] Release 1.7.1, release candidate #2

2018-12-16 Thread Hequn Cheng
Hi Chesnay, Thanks for the vote and great job! I checked the release notes and found the following errors: - Missing bugs: [FLINK-10874] Kafka 2.0 connector testMigrateFromAtLeastOnceToExactlyOnce failure [FLINK-10987] LICENSE and NOTICE files are not correct - Improvement should be removed:

Re: Flink 1.7 doesn't work with Kafka Table Source Descriptors

2018-12-23 Thread Hequn Cheng
escriptors.ConnectTableDescriptor.registerTableSource(ConnectTableDescriptor.scala:46) > at > org.monitoring.stream.analytics.FlinkTableSourceLatest.main(FlinkTableSourceLatest.java:97) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(Nati

Re: [ANNOUNCE] Apache Flink 1.7.0 released

2018-11-30 Thread Hequn Cheng
A great release, Thanks a lot for the great work Till! And also thanks to the whole Flink community! Let's moving forward. Best, Hequn On Sat, Dec 1, 2018 at 12:31 AM Tzu-Li Chen wrote: > Thanks a lot for being the release manager Till! And > thanks for the great work Flink community! > >

Re: [DISCUSS] Long-term goal of making flink-table Scala-free

2018-11-24 Thread Hequn Cheng
Hi Timo, Thanks for the effort and writing up this document. I like the idea to make flink-table scala free, so +1 for the proposal! It's good to make Java the first-class citizen. For a long time, we have neglected java so that many features in Table are missed in Java Test cases, such as this

Re: [DISCUSS] Table API Enhancement Outline

2018-11-21 Thread Hequn Cheng
Hi, Thank you all for the great proposal and discussion! I also prefer to move on to the next step, so +1 for opening the JIRAs to start the work. We can have more detailed discussion there. Btw, we can start with JIRAs which we have agreed on. Best, Hequn On Tue, Nov 20, 2018 at 11:38 PM

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-22 Thread Hequn Cheng
Hi, I'm trying to check if the source release is building properly. And found that NonHAQueryableStateFsBackendITCase failed when run `mvn install`. This should not be a release blocker, however, I ceated a pr[1] to make it more stable. Best, Hequn [1]

Re: Multiple select single result

2019-01-13 Thread Hequn Cheng
Hi dhanuka, > I am trying to deploy 200 SQL unions and it seems all the tasks getting failing after some time. Would be great if you can show us some information(say exception stack) about the failure. Is it caused by OOM of job manager? > How do i allocate memory for task manager and job

Re: [DISCUSS] Towards a leaner flink-dist

2019-01-25 Thread Hequn Cheng
Hi Chesnay, Thanks a lot for the proposal! +1 for a leaner flink-dist and improve the "Download" page. I think a leaner flink-dist would be very helpful. If we bundle all jars into a single one, this will easily cause class conflict problem. Best, Hequn On Fri, Jan 25, 2019 at 2:48 PM

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

2019-01-24 Thread Hequn Cheng
+1 This would be very helpful! On Fri, Jan 25, 2019 at 8:15 AM Guowei Ma wrote: > +1 > > This not only helps Chinese users but also helps the community to collect > more feedback and scenarios. > > > > 在 2019年1月25日,上午2:29,Zhang, Xuefu 写道: > > > > +1 on the idea. This will certainly help

Re: [DISCUSS] A more restrictive JIRA workflow

2019-02-26 Thread Hequn Cheng
Hi, Timo Thanks for putting this together and bring the discussion. +1 to making our JIRAs a bit more restrictive! I think this makes a good point of view. It would be helpful to force the contributors to think more about the issues rather than take it directly or maybe rashly. One little

Re: [ANNOUNCE] Apache Flink 1.6.4 released

2019-02-24 Thread Hequn Cheng
Thanks Jincheng for managing the release and everybody who contributed! Best, Hequn On Mon, Feb 25, 2019 at 9:46 AM jincheng sun wrote: > Hi, > > The Apache Flink community is very happy to announce the release of > Apache Flink 1.6.4, which is the fourth bugfix release for the Apache > Flink

Re: [ANNOUNCE] Flink 1.8 release branch has been cut

2019-02-25 Thread Hequn Cheng
@Aljoscha Thanks for driving this and cutting the new branch. Looking forward to the release candidate :-) Best, Hequn On Mon, Feb 25, 2019 at 6:23 PM Kurt Young wrote: > Thanks Aljoscha! > > Best, > Kurt > > > On Mon, Feb 25, 2019 at 5:43 PM jincheng sun > wrote: > > > Thanks, Aljoscha! > >

Re: [DISCUSS] Adding a mid-term roadmap to the Flink website

2019-02-21 Thread Hequn Cheng
Hi Stephan, Thanks for summarizing the great roadmap! It is very helpful for users and developers to track the direction of Flink. +1 for putting the roadmap on the website and update it per release. Besides, would be great if the roadmap can add the UpsertSource feature(maybe put it under

Re: [DISCUSS] Add column operations in Table API

2019-03-16 Thread Hequn Cheng
Hi Jincheng, Thanks a lot for the discussion. The enhancement of column operations has been asked for many times. The design in the document gives a whole picture on it. I think it is very good. I left some minor comments in the document. Looking forward to the JIRA and the new features. Best,

Re: [ANNOUNCE] Apache Flink 1.7.2 released

2019-02-17 Thread Hequn Cheng
Thanks a lot for the great release @Gordon. Also thanks for the work by the whole community. :-) Best, Hequn On Mon, Feb 18, 2019 at 2:12 PM jincheng sun wrote: > Thanks a lot for being our release manager Gordon , > Great job! > And also a big thanks to the community for making this release

Re: [DISCUSS] Releasing Flink 1.8 / Feature Freeze

2019-02-17 Thread Hequn Cheng
Thanks for planning on the 1.8 release. +1 for cutting the release branch soon. As Stephan and Jincheng said, the refactoring of Table API may block the release. Fortunately, some issues have already been merged into the master, for example, deprecate methods in TableEnvironment and Table. And

Re: [DISCUSS] Releasing Flink 1.6.4

2019-02-12 Thread Hequn Cheng
Hi Jincheng, +1 Thank you for the discuss and writing a very nice google doc. Looking forward to the 1.6.4 release. :-) Best, Hequn On Tue, Feb 12, 2019 at 5:23 PM Shaoxuan Wang wrote: > Thanks for driving this release, Jincheng. > +1 for release 1.6.4. > > On Tue, Feb 12, 2019 at 5:06 PM

Re: [VOTE] Release Apache Flink 1.6.4, release candidate #1

2019-02-16 Thread Hequn Cheng
Great job! Thanks jincheng for your efforts on the RC1 of Flink 1.6.4! +1 (non-binding) I have checked the following things: - download the dist source - compiled from the downloaded source - check repositories folder for 1.6.4, and jars can be download successfully - Check the

Re: [DISCUSS] Releasing Flink 1.7.2

2019-02-11 Thread Hequn Cheng
Hi, +1 on both 1.7.2 and 1.6.4. By then we can have a more stable release. Best, Hequn On Mon, Feb 11, 2019 at 8:46 PM Robert Metzger wrote: > Cool! Then let's do the release together. I haven't done it in a while, but > we'll manage. > > Could you start a separate [DISCUSS] thread for the

Re: Flink Table Case Statements appending spaces

2019-01-29 Thread Hequn Cheng
Hi Ramya, Fabian is right. The behavior in strict SQL standard mode(SQL:2003) returns a CHAR(N) type with blank-padded. Best, Hequn On Wed, Jan 30, 2019 at 1:59 AM Fabian Hueske wrote: > Hi, > > Table API queries are executed with SQL semantics. > In SQL, the strings are padded because the

Re: [DISCUSS] FLIP-32: Restructure flink-table for future contributions

2019-01-25 Thread Hequn Cheng
Hi Timo, +1 for the FLIP! Great work and thanks a lot for the detailed document! The task dependency graph is very helpful for teasing out relationships between tasks. Looking forward to the JIRAs and hoping to contribute to it! Best, Hequn On Fri, Jan 25, 2019 at 7:54 PM Piotr Nowojski

Re: [DISCUSS] Contributing Chinese website and docs to Apache Flink

2019-02-04 Thread Hequn Cheng
Hi, big +1 for this! Thank you Jark for writing the great document. I totally agree with the proposal. It not only keep the English document same as before but also proposes a way to integrate with Chinese ones. Best, Hequn On Mon, Feb 4, 2019 at 6:18 PM Fabian Hueske wrote: > Happy Chinese

Re: [ANNOUNCE] Apache Flink 1.8.0 released

2019-04-10 Thread Hequn Cheng
Thanks a lot for the great release Aljoscha! Also thanks for the work by the whole community. :-) Best, Hequn On Wed, Apr 10, 2019 at 6:03 PM Fabian Hueske wrote: > Congrats to everyone! > > Thanks Aljoscha and all contributors. > > Cheers, Fabian > > Am Mi., 10. Apr. 2019 um 11:54 Uhr schrieb

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-27 Thread Hequn Cheng
+1 (non-binding) - Release notes are correct. - Built from source archive successfully. - Signatures and hash are correct. - All artifacts(11 artifacts including flink-shaded) have been deployed to the maven central repository. - javax annotations are not included in the slim jar any more.

Re: [SURVEY] Usage of flink-ml and [DISCUSS] Delete flink-ml

2019-05-27 Thread Hequn Cheng
Hi Shaoxuan, Thanks a lot for driving this. +1 to remove the module. The git log of this module shows that it has been inactive for a long time. I think it's ok to remove it for now. It would also be good to switch to the new interface earlier. Best, Hequn On Mon, May 27, 2019 at 8:58 PM

Re: [ANNOUNCE] Apache Flink-shaded 7.0 released

2019-06-03 Thread Hequn Cheng
Thanks a lot to Jincheng and Chesnay and to the community making this release possible! Best, Hequn On Mon, Jun 3, 2019 at 3:16 PM Jark Wu wrote: > Thanks Jincheng for your effort! > > On Sat, 1 Jun 2019 at 05:19, Bowen Li wrote: > > > Thanks Jincheng for driving this release! > > > > On Thu,

Re: [DISCUSS] Releasing Flink 1.8.1

2019-05-29 Thread Hequn Cheng
Hi Jincheng, Thanks for putting these together with a nice document. +1 to release 1.8.1. I think it would be nice if we can have a new release with so many fixes. Best, Hequn On Wed, May 29, 2019 at 5:25 PM jincheng sun wrote: > Hi all, > Thank you for your support of the release of 1.8.1. >

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

2019-06-15 Thread Hequn Cheng
Hi, Thank Robert for raising the discussion. Thank Bowen and Jark for your nice thoughts. The DingTalk group grows bigger and bigger. I think the reason is that a lot of problems are solved quickly in the group. There are a lot of people who are willing to answer questions in the DingTalk group.

Re: [DISCUSS] FLIP-44: Support Local Aggregation in Flink

2019-06-19 Thread Hequn Cheng
gt;>>>> Users should know its semantics and the difference with keyBy > API, > > > >> so > > > >>>> if > > > >>>>>> they want to the average aggregation, they should carry local > sum > > > >>>> result > > >

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

2019-06-19 Thread Hequn Cheng
? > > - I think the primary search engine in China is still Baidu for most > > technicians. So we still need a way to improve SEO. > > Maybe the Flink China operation team have some experience on this. > > > > A big +1 to Hequn's survey proposal. It's a good wa

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

2019-06-21 Thread Hequn Cheng
rt Young > > wrote: > > >>> > > > >>> > > Thanks Robert, I left a comment in the JIRA you gave and see what > > >>> will > > >>> > > happen. > > >>> > > > > >>> > > Best, > >

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

2019-06-21 Thread Hequn Cheng
rk normally in the future. Please > report it here again. > > Best, > Vino > > > Hequn Cheng 于2019年6月21日周五 下午2:39写道: > > > Hi Vino, > > > > Great thanks for your help. > > > > > So if someone reports that they can't receive the email f

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

2019-06-23 Thread Hequn Cheng
ple should also be involved to answer the problems. I don't know whether is it possible for the Chinese Flink team on duty to answer the problems. I think that would help. Great to have other opinions. Best, Hequn On Fri, Jun 21, 2019 at 7:50 PM Hequn Cheng wrote: > Hi vino, > >

Re: [DISCUSS] Ground Source and Sink Concepts in Flink SQL

2019-06-24 Thread Hequn Cheng
Hi Jark, Impressive document! I have gone over the document quickly and left some comments. I will have a detailed look later. Below are two main thoughts from my side: 1. In the TableSource interface, can we move the getBoundedness() method into the underneath Source? This brings some benefits

Re: [ANNOUNCE] Jincheng Sun is now part of the Flink PMC

2019-06-24 Thread Hequn Cheng
Congratulations Jincheng! Best, Hequn On Mon, Jun 24, 2019 at 11:43 PM Dian Fu wrote: > Congratulations Jincheng! > > On Mon, Jun 24, 2019 at 11:09 PM Robert Metzger > wrote: > > > Hi all, > > > > On behalf of the Flink PMC, I'm happy to announce that Jincheng Sun is > now > > part of the

Re: [DISCUSS] Deprecate previous Python APIs

2019-06-11 Thread Hequn Cheng
+1 on the proposal! Maintaining only one Python API is helpful for users and contributors. Best, Hequn On Wed, Jun 12, 2019 at 9:41 AM Jark Wu wrote: > +1 and looking forward to the new Python API world. > > Best, > Jark > > On Wed, 12 Jun 2019 at 09:22, Becket Qin wrote: > >> +1 on

Re: [DISCUSS] FLIP-44: Support Local Aggregation in Flink

2019-06-17 Thread Hequn Cheng
Hi Vino, Thanks for the proposal, I think it is a very good feature! One thing I want to make sure is the semantics for the `localKeyBy`. From the document, the `localKeyBy` API returns an instance of `KeyedStream` which can also perform sum(), so in this case, what's the semantics for

Re: [VOTE] Release flink-shaded 7.0, release candidate 2

2019-05-21 Thread Hequn Cheng
Thank you Jincheng for the release! +1 (non-binding) - Release notes are correct. - Built from source archive successfully. - Signatures and hash are correct. - All artifacts(11 artifacts including flink-shaded) have been deployed to the maven central repository. One minor comment for the

Re: [DISCUSS] Features for Apache Flink 1.9.0

2019-05-05 Thread Hequn Cheng
Hi, Great job, Gordon! Thanks a lot for driving this and wrapping features up to a detailed list. +1 on it! Would be great if we can also add flip29 to the list. @jincheng sun and I are focusing on it these days. I think these features in flip29 would bring big enhancements to the Table API.

Re: [DISCUSS]Support Upsert mode for Streaming Non-window FlatAggregate

2019-07-04 Thread Hequn Cheng
key and it >> seems it will only work correctly only if the user choose the *right* key >> this UDTAGG has. >> >> Let me know if this makes sense to you. >> >> Best, >> Kurt >> >> >> On Thu, Jul 4, 2019 at 4:32 PM jincheng sun >> wrote: >>

Re: [VOTE] Migrate to sponsored Travis account

2019-07-04 Thread Hequn Cheng
+1. And thanks a lot to Chesnay for pushing this. Best, Hequn On Thu, Jul 4, 2019 at 8:07 PM Chesnay Schepler wrote: > Note that the Flinkbot approach isn't that trivial either; we can't > _just_ trigger builds for a branch in the apache repo, but would first > have to clone the branch/pr

Re: [DISCUSS]Support Upsert mode for Streaming Non-window FlatAggregate

2019-06-26 Thread Hequn Cheng
Hi Jincheng, Thanks for raising the discussion! The key information is very important for query optimizations. It would be nice if we can use upsert mode to achieve better performance. +1 for the `withKeys` proposal. :) Best, Hequn On Wed, Jun 26, 2019 at 4:37 PM jincheng sun wrote: > Hi

Re: [VOTE] Release 1.8.1, release candidate #1

2019-06-27 Thread Hequn Cheng
Hi Jincheng, Thanks a lot for the release which contains so many fixes! I have done the following checks: Local Tests - Built from source archive successfully. - Signatures and hash are correct. - All artifacts have been deployed to the maven central repository. - Run WordCount(batch)

Re: [ANNOUNCE] Flink 1.9 release branch has been created

2019-07-12 Thread Hequn Cheng
Hi Kurt, Great work and thanks for the update. FYI, I find a bug[1] on Table API accidentally. The PR has already been opened. I think it would be good if the fix can be included in the 1.9. Best, Hequn [1] https://issues.apache.org/jira/browse/FLINK-13196 On Fri, Jul 12, 2019 at 2:40 PM Kurt

Re: [ANNOUNCE] Rong Rong becomes a Flink committer

2019-07-11 Thread Hequn Cheng
Congratulations Rong! Best, Hequn On Fri, Jul 12, 2019 at 12:19 PM Jeff Zhang wrote: > Congrats, Rong! > > > vino yang 于2019年7月12日周五 上午10:08写道: > >> congratulations Rong Rong! >> >> Fabian Hueske 于2019年7月11日周四 下午10:25写道: >> >>> Hi everyone, >>> >>> I'm very happy to announce that Rong Rong

Re: [ANNOUNCE] Apache Flink 1.8.1 released

2019-07-02 Thread Hequn Cheng
Thanks for being the release manager and the great work Jincheng! Also thanks to Gorden and the community making this release possible! Best, Hequn On Wed, Jul 3, 2019 at 9:40 AM jincheng sun wrote: > Hi, > > The Apache Flink community is very happy to announce the release of Apache > Flink

Re: [DISCUSS]Support Upsert mode for Streaming Non-window FlatAggregate

2019-07-01 Thread Hequn Cheng
ableAggregateFunction user wrote? Should the user know that there > will a > > > key and make some changes > > > to this function? > > > > > > If so, what's the semantic the user should learned. If not, how will > > > framework deal with t

Re: [DISCUSS] META-FLIP: Sticking (or not) to a strict FLIP voting process

2019-06-27 Thread Hequn Cheng
Hi all, Thanks for raising the nice discussion @Aljoscha. +1 to sticking to the "lazy majority" voting process. It is good to get more people involved in the design discussion and get enough binding votes. As for the scope of the FLIP, previous replies show a lot of good thoughts. On the other

Re: [ANNOUNCE] Andrey Zagrebin becomes a Flink committer

2019-08-15 Thread Hequn Cheng
Congratulations Andrey! On Thu, Aug 15, 2019 at 3:30 PM Fabian Hueske wrote: > Congrats Andrey! > > Am Do., 15. Aug. 2019 um 07:58 Uhr schrieb Gary Yao : > > > Congratulations Andrey, well deserved! > > > > Best, > > Gary > > > > On Thu, Aug 15, 2019 at 7:50 AM Bowen Li wrote: > > > > >

Re: CiBot Update

2019-08-22 Thread Hequn Cheng
Cool, thanks Chesnay a lot for the improvement! Best, Hequn On Thu, Aug 22, 2019 at 5:02 PM Zhu Zhu wrote: > Thanks Chesnay for the CI improvement! > It is very helpful. > > Thanks, > Zhu Zhu > > zhijiang 于2019年8月22日周四 下午4:18写道: > > > It is really very convenient now. Valuable work, Chesnay!

Re: [DISCUSS] Releasing Flink 1.8.2

2019-08-30 Thread Hequn Cheng
Hi Jincheng, +1 for a 1.8.2 release. Thanks a lot for raising the discussion. It would be nice to have these critical fixes. Best, Hequn On Fri, Aug 30, 2019 at 6:31 PM Maximilian Michels wrote: > Hi Jincheng, > > +1 I would be for a 1.8.2 release such that we can fix the problems with > the

Re: [ANNOUNCE] Apache Flink-shaded 8.0 released

2019-08-30 Thread Hequn Cheng
Thanks a lot to Chesney! Also thanks to everyone who helped to make this release possible. Best, Hequn On Fri, Aug 30, 2019 at 7:17 PM jincheng sun wrote: > Thanks a lot Chesnay and to the community for making this release possible > ! > > Cheers, > Jincheng > > Chesnay Schepler 于2019年8月30日周五

Re: Build failure on flink-python

2019-09-02 Thread Hequn Cheng
Hi Biao, Thanks a lot for reporting the problem. The fix has been merged into the master just now. You can rebase to the master and try again. Thanks to @Wei Zhong for the fixing. Best, Hequn On Mon, Sep 2, 2019 at 4:41 PM Biao Liu wrote: > There are already some Jira tickets opened for this

Re: [VOTE] FLIP-58: Flink Python User-Defined Function for Table API

2019-08-28 Thread Hequn Cheng
Hi Dian, +1 Thanks a lot for driving this. Best, Hequn On Wed, Aug 28, 2019 at 2:01 PM jincheng sun wrote: > Hi Dian, > > +1, Thanks for your great job! > > Best, > Jincheng > > Dian Fu 于2019年8月28日周三 上午11:04写道: > > > Hi all, > > > > I'd like to start a voting thread for FLIP-58 [1] since

Re: [DISCUSS] Flink Python User-Defined Function for Table API

2019-08-22 Thread Hequn Cheng
+1 for starting the vote. Thanks Jincheng a lot for the discussion. Best, Hequn On Fri, Aug 23, 2019 at 10:06 AM Dian Fu wrote: > Hi Jincheng, > > +1 to start the FLIP create and VOTE on this feature. I'm willing to help > on the FLIP create if you don't mind. As I haven't created a FLIP

Re: [ANNOUNCE] Zili Chen becomes a Flink committer

2019-09-11 Thread Hequn Cheng
Congratulations! Best, Hequn On Thu, Sep 12, 2019 at 9:24 AM Jark Wu wrote: > Congratulations Zili! > > Best, > Jark > > On Wed, 11 Sep 2019 at 23:06, wrote: > > > Congratulations, Zili. > > > > > > > > Best, > > > > Xingcan > > > > > > > > *From:* SHI Xiaogang > > *Sent:* Wednesday,

Re: [ANNOUNCE] Kostas Kloudas joins the Flink PMC

2019-09-06 Thread Hequn Cheng
Congratulations Kostas! Well deserved. Best, Hequn On Sat, Sep 7, 2019 at 10:48 AM Jark Wu wrote: > Congratulations Klou! > > > > 在 2019年9月7日,00:21,zhijiang 写道: > > > > Congratulations Klou! > > > > Best, > > Zhijiang > > -- > >

Re: [ANNOUNCE] Hequn becomes a Flink committer

2019-08-07 Thread Hequn Cheng
Thanks everyone for the warm welcome! It's a great honor for me to be a committer. Looking forward to contributing more to the community. Best, Hequn On Thu, Aug 8, 2019 at 3:39 AM zhijiang wrote: > Congratulations Hequn! > > Best, > Zhijiang >

Re: [VOTE] Publish the PyFlink into PyPI

2019-08-01 Thread Hequn Cheng
+1 (non-binding) Thanks a lot for driving this! @jincheng sun Best, Hequn On Thu, Aug 1, 2019 at 11:00 PM Biao Liu wrote: > Thanks Jincheng for working on this. > > +1 (non-binding) > > Thanks, > Biao /'bɪ.aʊ/ > > > > On Thu, Aug 1, 2019 at 8:55 PM Jark Wu wrote: > > > +1 (non-binding) > >

Re: [DISCUSS] Flink project bylaws

2019-07-20 Thread Hequn Cheng
Hi Becket, Big +1 on this. > Regarding the vote of FLIP, preferably at least includes a PMC vote. Perhaps what Jincheng means is to hold at least one PMC in the 3 binding votes? i.e, the vote could have 2 binding committers and 1 PMC. I think this makes sense considering a FLIP could somehow be

Re: [ANNOUNCE] Kete Young is now part of the Flink PMC

2019-07-23 Thread Hequn Cheng
Congratulations Kurt! Best, Hequn On Tue, Jul 23, 2019 at 7:27 PM vino yang wrote: > Congratulations Kurt! > > Bo WANG 于2019年7月23日周二 下午7:13写道: > > > Congratulations Kurt! > > > > > > Best, > > > > Bo WANG > > > > > > On Tue, Jul 23, 2019 at 5:24 PM Robert Metzger > > wrote: > > > > > Hi all,

Re: Re: [ANNOUNCE] Zhijiang Wang has been added as a committer to the Flink project

2019-07-23 Thread Hequn Cheng
Congratulations Zhijiang! Best, Hequn On Tue, Jul 23, 2019 at 6:17 PM JingsongLee wrote: > Congratulations Zhijiang! > > Best, Jingsong Lee > > > -- > From:wenlong.lwl > Send Time:2019年7月23日(星期二) 17:34 > To:dev > Subject:Re: Re:

Re: [DISCUSS] Setup a bui...@flink.apache.org mailing list for travis builds

2019-07-23 Thread Hequn Cheng
Hi Jark, Good idea. +1! On Tue, Jul 23, 2019 at 6:23 PM Jark Wu wrote: > Thank you all for your positive feedback. > > We have three binding +1s, so I think, we can proceed with this. > > Hi @Robert Metzger , could you create a request to > INFRA for the mailing list? > I'm not sure if this

Re: [ANNOUNCE] Jiangjie (Becket) Qin has been added as a committer to the Flink project

2019-07-18 Thread Hequn Cheng
Congratulations Becket! Best, Hequn On Thu, Jul 18, 2019 at 5:34 PM vino yang wrote: > Congratulations! > > Best, > Vino > > Yun Gao 于2019年7月18日周四 下午5:31写道: > > > Congratulations! > > > > Best, > > Yun > > > > > > -- > >

Re: [COMMITTER] repo locked due to synchronization issues

2019-09-24 Thread Hequn Cheng
I met the same problem. Pushing to the GitHub repo directly works fine and it seems will resync the two repos. Best, Hequn On Tue, Sep 24, 2019 at 4:59 PM Fabian Hueske wrote: > Maybe it's a mix of pushing to the ASF repository and Github mirrors? > I'm only pushing to the ASF repositories

Re: [DISCUSS] Releasing Flink 1.9.1

2019-09-29 Thread Hequn Cheng
Hi, @jincheng sun @Dian Fu Thanks a lot for reporting and fixing the problem! @Jark Wu The PR of FLINK-14288 has been merged into both master and release-1.9. Looking forward to the first RC of 1.9.1. Best, Hequn On Mon, Sep 30, 2019 at 10:54 AM Jark Wu wrote: > Thanks Jincheng and Dian

Re: [DISCUSS] Releasing Flink 1.8.3

2019-11-09 Thread Hequn Cheng
Hi Jincheng, Thanks for kicking this discussion off! +1 to the 1.8.3 release as it would be nice to have these important fixes and also two months have passed since the last release. Besides, I wonder if I can be the release manager of 1.8.3 or work with you together @Jincheng? It's always

Re: [VOTE] Move flink-orc to flink-formats from flink-connectors

2019-10-30 Thread Hequn Cheng
+1. Good catch Jingsong! Best, Hequn On Wed, Oct 30, 2019 at 7:26 PM Zhenghua Gao wrote: > +1 (non-binding) > > *Best Regards,* > *Zhenghua Gao* > > > On Wed, Oct 30, 2019 at 12:05 PM Jingsong Li > wrote: > > > Hi all: > > > > We already have the parent model of formats. we have put other > >

Re: [DISCUSS] Releasing Flink 1.8.3

2019-11-13 Thread Hequn Cheng
Hi Chesnay, Jincheng Sure, I think it's good to have these fixes. Thanks a lot for providing the information about the security vulnerabilities! @Chesnay Best, Hequn On Thu, Nov 14, 2019 at 10:07 AM jincheng sun wrote: > +1 for try to eliminate the security vulnerabilities. Great thanks for >

Re: [DISCUSS] Expose or setup a secur...@flink.apache.org mailing list for security report and discussion

2019-11-13 Thread Hequn Cheng
Hi Dian, Good idea! +1 to have a security mailing list. It is nice for Flink to have an official procedure to handle security problems, e.g., reporting, addressing and publishing. Best, Hequn On Thu, Nov 14, 2019 at 1:20 PM Jeff Zhang wrote: > Thanks Dian Fu for this proposal. +1 for creating

Re: [DISCUSS] Release flink-shaded 9.0

2019-11-16 Thread Hequn Cheng
Hi, Big +1 to release 9.0. It would be good if we can solve these security vulnerabilities. Thanks a lot for your nice work and kick off the release so quickly. On Fri, Nov 15, 2019 at 11:50 PM Ufuk Celebi wrote: > From what I can see, the Jackson version bump fixes quite a few >

Re: [VOTE] FLIP-83: Flink End-to-end Performance Testing Framework

2019-11-18 Thread Hequn Cheng
+1 (binding)! I think this would be very helpful to detect regression problems. Best, Hequn On Mon, Nov 18, 2019 at 4:28 PM vino yang wrote: > +1 (non-binding) > > Best, > Vino > > jincheng sun 于2019年11月18日周一 下午2:31写道: > > > +1 (binding) > > > > OpenInx 于2019年11月18日周一 下午12:09写道: > > > > >

  1   2   3   4   >