[jira] [Assigned] (GEODE-2690) Use a different thread pool for flush operations

2017-03-24 Thread nabarun (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun reassigned GEODE-2690: -- Assignee: nabarun > Use a different thread pool for flush operations >

[GitHub] geode-native issue #73: GEODE-2513 Unbrand C++ API docs: Getting Started sec...

2017-03-24 Thread davebarnes97
Github user davebarnes97 commented on the issue: https://github.com/apache/geode-native/pull/73 Round 2 incorporates suggestions from reviewers. Per PivotalSarge, more consistency in the uses of "Client" and "Geode Client". Per echobravopapa, a lot less system-specific

Re: New Committer And PMC Member: Ernest Burghardt

2017-03-24 Thread Nabarun Nag
Congrats and welcome !!! :) On Fri, Mar 24, 2017 at 3:41 PM Bruce Schuchardt wrote: > Welcome to the group Ernie! > > Le 3/24/2017 à 3:03 PM, Anthony Baker a écrit : > > The Apache Geode Project Management Committee has invited Ernest > > Burghardt to be committer on the

Re: region with total-max-memory

2017-03-24 Thread Darrel Schneider
For heap lru you want to set eviction-heap-percentage which you can do when you start the server. You should also set the initial and max heap sizes. Read about this here:

[jira] [Created] (GEODE-2719) The total-max-memory region attribute does not appear to do anything

2017-03-24 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-2719: --- Summary: The total-max-memory region attribute does not appear to do anything Key: GEODE-2719 URL: https://issues.apache.org/jira/browse/GEODE-2719 Project:

[jira] [Commented] (GEODE-2472) Oplog.flush method doesn't verify that the entry gets written

2017-03-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941304#comment-15941304 ] ASF subversion and git services commented on GEODE-2472: Commit

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #503 was SUCCESSFUL (with 1680 tests)

2017-03-24 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #503 was successful. --- Scheduled 1682 tests in total. https://build.spring.io/browse/SGF-NAG-503/ -- This

[jira] [Created] (GEODE-2718) inconsistent reads during network partition

2017-03-24 Thread Swapnil Bawaskar (JIRA)
Swapnil Bawaskar created GEODE-2718: --- Summary: inconsistent reads during network partition Key: GEODE-2718 URL: https://issues.apache.org/jira/browse/GEODE-2718 Project: Geode Issue Type:

Re: New Committer And PMC Member: Ernest Burghardt

2017-03-24 Thread Bruce Schuchardt
Welcome to the group Ernie! Le 3/24/2017 à 3:03 PM, Anthony Baker a écrit : The Apache Geode Project Management Committee has invited Ernest Burghardt to be committer on the project and join the Geode PMC. We are pleased to announce he has accepted. Please join me in welcoming Ernie! Thanks,

Re: GEODE-2714 Proposal for new api on Function interface (Please read)

2017-03-24 Thread Jacob Barrett
Hey guys, take the conversation over to the ticket so context is maintained with the ticket. On Fri, Mar 24, 2017 at 3:16 PM Swapnil Bawaskar wrote: > For step 2 above, won't we end up recomputing the list of buckets? > > I agree, however, that we do have the problem of

Re: GEODE-2714 Proposal for new api on Function interface (Please read)

2017-03-24 Thread Swapnil Bawaskar
For step 2 above, won't we end up recomputing the list of buckets? I agree, however, that we do have the problem of moving primary, especially in the middle of iterating over data. We already have an optimizeForWrite() method on Function that makes the function execute on the primary. Do we want

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941235#comment-15941235 ] ASF GitHub Bot commented on GEODE-2513: --- GitHub user karensmolermiller opened a pull request:

[GitHub] geode-native pull request #75: GEODE-2513 Unbrand .NET API docs section

2017-03-24 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-native/pull/75 GEODE-2513 Unbrand .NET API docs section - Remove references to GemFire - Namespace updates - Correct typos and capitalization - Use .NET scoping operator (not C++) -

Re: New Committer And PMC Member: Ernest Burghardt

2017-03-24 Thread Joey McAllister
Woot! Congrats, Ernie! On Fri, Mar 24, 2017 at 3:03 PM Anthony Baker wrote: > The Apache Geode Project Management Committee has invited Ernest > Burghardt to be committer on the project and join the Geode PMC. We > are pleased to announce he has accepted. > > Please join me

New Committer And PMC Member: Ernest Burghardt

2017-03-24 Thread Anthony Baker
The Apache Geode Project Management Committee has invited Ernest Burghardt to be committer on the project and join the Geode PMC. We are pleased to announce he has accepted. Please join me in welcoming Ernie! Thanks, Anthony On behalf of the Apache Geode PMC

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941223#comment-15941223 ] ASF GitHub Bot commented on GEODE-2713: --- Github user pivotal-jbarrett commented on a diff in the

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941224#comment-15941224 ] ASF GitHub Bot commented on GEODE-2713: --- Github user pivotal-jbarrett commented on a diff in the

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941221#comment-15941221 ] ASF GitHub Bot commented on GEODE-2713: --- Github user pivotal-jbarrett commented on a diff in the

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941220#comment-15941220 ] ASF GitHub Bot commented on GEODE-2713: --- Github user pivotal-jbarrett commented on a diff in the

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941222#comment-15941222 ] ASF GitHub Bot commented on GEODE-2713: --- Github user pivotal-jbarrett commented on a diff in the

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r108006315 --- Diff: src/cppcache/src/ThinClientRegion.cpp --- @@ -3350,7 +3350,8 @@ bool ThinClientRegion::executeFunctionSH(

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r108006539 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -407,17 +407,21 @@ class ChunkedFunctionExecutionResponse : public TcrChunkedResult {

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r108006150 --- Diff: src/cppcache/src/ThinClientPoolDM.hpp --- @@ -463,7 +463,8 @@ class FunctionExecution : public PooledWork { void

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r108006001 --- Diff: src/cppcache/src/ThinClientPoolDM.cpp --- @@ -609,7 +609,8 @@ GfErrType ThinClientPoolDM::sendRequestToAllServers(

[jira] [Commented] (GEODE-2714) Proposal for new api on Function interface

2017-03-24 Thread Jacob S. Barrett (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941201#comment-15941201 ] Jacob S. Barrett commented on GEODE-2714: - How about an annotation rather than an interface

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941200#comment-15941200 ] ASF GitHub Bot commented on GEODE-2660: --- Github user asfgit closed the pull request at:

[GitHub] geode pull request #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread bschuchardt
Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 got it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941192#comment-15941192 ] ASF GitHub Bot commented on GEODE-2660: --- Github user bschuchardt commented on the issue:

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @bschuchardt Check it out again; I force-pushed with just the annotation on GeodeRedisServer. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941161#comment-15941161 ] ASF GitHub Bot commented on GEODE-2660: --- Github user bschuchardt commented on the issue:

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread bschuchardt
Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 my bad - I checkout out ggreen's branch by mistake. I don't see any @Experimental at all in your branch. It looks like your second commit removed it from GeodeRedisServer.java when you meant to

[jira] [Commented] (GEODE-2715) Move Pulse to its own repo

2017-03-24 Thread Mark Bretl (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941152#comment-15941152 ] Mark Bretl commented on GEODE-2715: --- This should be discussed on the dev list before any other actions

[jira] [Resolved] (GEODE-2717) export logs should honor the log level set on the server

2017-03-24 Thread Swapnil Bawaskar (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Bawaskar resolved GEODE-2717. - Resolution: Duplicate > export logs should honor the log level set on the server >

Re: GEODE-2714 Proposal for new api on Function interface (Please read)

2017-03-24 Thread Hitesh Khamesra
Hi Swapnil: Right, and then we execute that function on that node. Now assume during that function execution time(first user thread) two things happens simultaneously.. 1. we move that bucket to other node. 2. And other user thread execute function with same set of keys on other node, which

[jira] [Created] (GEODE-2717) export logs should honor the log level set on the server

2017-03-24 Thread Swapnil Bawaskar (JIRA)
Swapnil Bawaskar created GEODE-2717: --- Summary: export logs should honor the log level set on the server Key: GEODE-2717 URL: https://issues.apache.org/jira/browse/GEODE-2717 Project: Geode

[jira] [Created] (GEODE-2716) export logs should honor the log level set on the server

2017-03-24 Thread Swapnil Bawaskar (JIRA)
Swapnil Bawaskar created GEODE-2716: --- Summary: export logs should honor the log level set on the server Key: GEODE-2716 URL: https://issues.apache.org/jira/browse/GEODE-2716 Project: Geode

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941134#comment-15941134 ] ASF GitHub Bot commented on GEODE-2660: --- Github user galen-pivotal commented on the issue:

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @bschuchardt This is just the experimental annotation, not changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Created] (GEODE-2715) Move Pulse to its own repo

2017-03-24 Thread Swapnil Bawaskar (JIRA)
Swapnil Bawaskar created GEODE-2715: --- Summary: Move Pulse to its own repo Key: GEODE-2715 URL: https://issues.apache.org/jira/browse/GEODE-2715 Project: Geode Issue Type: Improvement

Re: GEODE-2714 Proposal for new api on Function interface (Please read)

2017-03-24 Thread Swapnil Bawaskar
Here is the link: https://issues.apache.org/jira/browse/GEODE-2714 Hi Hitesh, Before executing a function, we build a list of buckets that the function needs to execute on and then we build the function context using only those buckets. So, as long as the function is using the context to get the

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941100#comment-15941100 ] ASF GitHub Bot commented on GEODE-2713: --- Github user echobravopapa commented on a diff in the pull

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread PivotalSarge
Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r107995262 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public TcrChunkedResult {

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941096#comment-15941096 ] ASF GitHub Bot commented on GEODE-2713: --- Github user echobravopapa commented on a diff in the pull

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r107994818 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public TcrChunkedResult {

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941081#comment-15941081 ] ASF GitHub Bot commented on GEODE-2713: --- Github user PivotalSarge commented on a diff in the pull

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread PivotalSarge
Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r107993045 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public TcrChunkedResult {

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941076#comment-15941076 ] ASF GitHub Bot commented on GEODE-2713: --- Github user echobravopapa commented on a diff in the pull

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/74#discussion_r107992569 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public TcrChunkedResult {

Re: GEODE-2714 Proposal for new api on Function interface (Please read)

2017-03-24 Thread Jared Stewart
Can you give a link to the proposal? Thanks, Jared > On Mar 24, 2017, at 12:57 PM, Hitesh Khamesra > wrote: > > Please let us know your opinion on that. > Thanks.Hitesh

GEODE-2714 Proposal for new api on Function interface (Please read)

2017-03-24 Thread Hitesh Khamesra
Please let us know your opinion on that. Thanks.Hitesh

[jira] [Created] (GEODE-2714) Proposal for new api on Function interface

2017-03-24 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-2714: -- Summary: Proposal for new api on Function interface Key: GEODE-2714 URL: https://issues.apache.org/jira/browse/GEODE-2714 Project: Geode Issue Type: Bug

[jira] [Commented] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941030#comment-15941030 ] ASF GitHub Bot commented on GEODE-2713: --- GitHub user PivotalSarge opened a pull request:

[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...

2017-03-24 Thread PivotalSarge
GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-native/pull/74 GEODE-2713: Wrap result collector lock in shared_ptr. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PivotalSarge/geode-native

[jira] [Commented] (GEODE-2687) create a test for failed SSL auth

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940834#comment-15940834 ] ASF GitHub Bot commented on GEODE-2687: --- Github user PivotalSarge commented on the issue:

[jira] [Commented] (GEODE-2687) create a test for failed SSL auth

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940835#comment-15940835 ] ASF GitHub Bot commented on GEODE-2687: --- Github user PivotalSarge closed the pull request at:

region with total-max-memory

2017-03-24 Thread Srikrishan Malik
While creating a region in geode you can specify --total-max-memory which should limit the amount of memory used the the region entries. ref: https://geode.apache.org/docs/guide/tools_modules/gfsh/command-pages/create.html#topic_54B0985FEC5241CA9D26B0CE0A5EA863 I created a region of type

[jira] [Created] (GEODE-2713) Function execution can lead to passing the address of a stack variable

2017-03-24 Thread Michael Dodge (JIRA)
Michael Dodge created GEODE-2713: Summary: Function execution can lead to passing the address of a stack variable Key: GEODE-2713 URL: https://issues.apache.org/jira/browse/GEODE-2713 Project: Geode

Re: Review Request 57894: GEODE-2670: do not use local mbs server connection even when pulse is in embeded mode.

2017-03-24 Thread Jinmei Liao
> On March 24, 2017, 4:23 p.m., Anthony Baker wrote: > > Did you test Pulse in non-embedded mode w/ security? Haven't. Will try it out. Theoretically, we didn't change anythign in that aspect. It should behave the same. > On March 24, 2017, 4:23 p.m., Anthony Baker wrote: > >

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940730#comment-15940730 ] ASF GitHub Bot commented on GEODE-2513: --- Github user echobravopapa commented on a diff in the pull

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940733#comment-15940733 ] ASF GitHub Bot commented on GEODE-2513: --- Github user echobravopapa commented on a diff in the pull

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940732#comment-15940732 ] ASF GitHub Bot commented on GEODE-2513: --- Github user echobravopapa commented on a diff in the pull

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940731#comment-15940731 ] ASF GitHub Bot commented on GEODE-2513: --- Github user echobravopapa commented on a diff in the pull

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107950987 --- Diff: docs/geode-native-docs/introduction/developing-windows.html.md.erb --- @@ -21,18 +21,18 @@ limitations under the License.

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107950403 --- Diff: docs/geode-native-docs/introduction/developing-solaris.html.md.erb --- @@ -19,25 +19,25 @@ See the License for the specific language

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107950013 --- Diff: docs/geode-native-docs/introduction/developing-linux.html.md.erb --- @@ -19,48 +19,48 @@ See the License for the specific language

Re: Review Request 57894: GEODE-2670: do not use local mbs server connection even when pulse is in embeded mode.

2017-03-24 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57894/#review170024 --- Did you test Pulse in non-embedded mode w/ security?

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940633#comment-15940633 ] ASF GitHub Bot commented on GEODE-2660: --- Github user bschuchardt commented on the issue:

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread bschuchardt
Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 Also, since we're talking about releasing v 1.2 soon it would be nice to add the Experimental annotation with this same commit since it is breaking compatibility with v 1.1. --- If your project

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review170022 --- We will need to verify that the logs went to the same place as

[jira] [Commented] (GEODE-2660) Mark Redis Adapter as Experimental

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940629#comment-15940629 ] ASF GitHub Bot commented on GEODE-2660: --- Github user bschuchardt commented on the issue:

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

2017-03-24 Thread bschuchardt
Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 I don't think we can merge these changes until the lock-service variables in ExeuctionHandlerContext are made static. As it's currently implemented every ExecutionContextHandler has its own lock

Re: Review Request 57522: check for string "null" in server/locator status message

2017-03-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57522/#review170020 --- Ship it! Ship It! - Jinmei Liao On March 13, 2017, 10:31

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940625#comment-15940625 ] ASF GitHub Bot commented on GEODE-2513: --- Github user PivotalSarge commented on a diff in the pull

[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-24 Thread PivotalSarge
Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107939092 --- Diff: docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb --- @@ -20,26 +20,26 @@ limitations under the License.

Re: Review Request 57894: GEODE-2670: do not use local mbs server connection even when pulse is in embeded mode.

2017-03-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57894/ --- (Updated March 24, 2017, 4:03 p.m.) Review request for geode, Anthony Baker,

JIRA karma

2017-03-24 Thread Anthony Baker
Hi, I’d like to be able to edit versions in JIRA. Can someone adjust permissions so I can do this? Otherwise I’m going to keep bugging y’all for help :-) Thanks, Anthony