Re: Request for Jenkins config ability

2017-08-10 Thread Jens Deppe
Thanks Mark - I'll test it out tomorrow. On Thu, Aug 10, 2017 at 3:42 PM, Mark Bretl wrote: > Hi Jens, > > Skillz have been given. > > Let me know if you have any issues, > > --Mark > > On Thu, Aug 10, 2017 at 10:46 AM, Jens Deppe wrote: > > > Hi, > > >

Re: PdxInitializationException: PDX registry could not be initialized

2017-08-10 Thread Dan Smith
Hi Aashita, Do you have a stack trace for that PdxInitializationException? Maybe there is a cause that has a bit more information? -Dan On Thu, Aug 10, 2017 at 4:24 PM, Mark Bretl wrote: > + user > > --Mark > > On Thu, Aug 10, 2017 at 4:12 PM, Aashita Sharma < >

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132600143 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java --- @@ -96,33 +117,55 @@ void close() { * @throws

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132599897 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java --- @@ -96,33 +117,55 @@ void close() { * @throws

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132599768 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java --- @@ -112,56 +119,43 @@ private void stop(final File

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132599627 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/AttachProcessUtils.java --- @@ -14,21 +14,28 @@ */ package

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132598899 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -104,6 +109,8 @@ helpMap.put("bind-address", ---

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132598795 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -795,25 +785,25 @@ protected String toString(final Date

Re: PdxInitializationException: PDX registry could not be initialized

2017-08-10 Thread Mark Bretl
+ user --Mark On Thu, Aug 10, 2017 at 4:12 PM, Aashita Sharma < aashitasha...@yahoo.co.in.invalid> wrote: > Hello Team, > > We recently got whole gemfire bounced, and every region lost its data. > > > > Later, we were told to populate data to every region through code. Now > while populating we

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-10 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r132591028 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -41,9 +42,8 @@

PdxInitializationException: PDX registry could not be initialized

2017-08-10 Thread Aashita Sharma
Hello Team, We recently got whole gemfire bounced, and every region lost its data.   Later, we were told to populate data to every region through code. Now while populating we got following error:       PdxInitializationException: PDX registry could not be

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-10 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r132591701 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java --- @@ -28,6 +28,8 @@ import

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-10 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r132591361 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -59,13 +59,14 @@

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-10 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r132591888 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java --- @@ -79,9 +81,10 @@

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132592102 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java --- @@ -0,0 +1,182 @@ +/* +

[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/708#discussion_r132591921 --- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb --- @@ -21,7 +21,11 @@ limitations under the License. Run queries

[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...

2017-08-10 Thread karensmolermiller
Github user karensmolermiller commented on a diff in the pull request: https://github.com/apache/geode/pull/708#discussion_r132590875 --- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb --- @@ -21,7 +21,11 @@ limitations under the License. Run queries

[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/708#discussion_r132589415 --- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb --- @@ -21,7 +21,11 @@ limitations under the License. Run queries

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #643 was SUCCESSFUL (with 2027 tests)

2017-08-10 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #643 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-643/ -- This

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132571788 --- Diff: geode-core/src/main/java/org/apache/geode/internal/config/ClusterConfigurationNotAvailableException.java --- @@ -0,0 +1,29 @@ +/* +

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132569537 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1781,8 +1782,8 @@ protected void validate() { *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132568184 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1352,11 +1328,13 @@ protected void parseCommand(final

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132585045 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java --- @@ -112,56 +119,43 @@ private void stop(final File

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132570355 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -104,6 +109,8 @@ helpMap.put("bind-address",

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132562988 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -795,25 +785,25 @@ protected String toString(final Date

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132572256 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/AttachProcessUtils.java --- @@ -14,21 +14,28 @@ */ package

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132585334 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java --- @@ -96,33 +117,55 @@ void close() { *

Re: Request for Jenkins config ability

2017-08-10 Thread Mark Bretl
Hi Jens, Skillz have been given. Let me know if you have any issues, --Mark On Thu, Aug 10, 2017 at 10:46 AM, Jens Deppe wrote: > Hi, > > I'd like to request the ability to make Jenkins config changes for Geode > builds; I want to start implementing parallel dockerized

Failed: jinmeiliao/geode#15 (geode-3096-invoker - f789634)

2017-08-10 Thread Travis CI
Build Update for jinmeiliao/geode - Build: #15 Status: Failed Duration: 17 minutes and 27 seconds Commit: f789634 (geode-3096-invoker) Author: Jinmei Liao Message: GEODE-3096: pulling in refactoring work on HttpOperationInvoker View the changeset:

[GitHub] geode-examples pull request #12: Add OQL example

2017-08-10 Thread PivotalSarge
GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-examples/pull/12 Add OQL example Perry Birch and I paired on an example for OQL. To prepare for that, I also created an example for Region.putAll(). You can merge this pull request into a Git

Review Request 61585: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-08-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61585/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61562/ --- (Updated Aug. 10, 2017, 9:16 p.m.) Review request for geode, Anthony Baker and

[GitHub] geode issue #704: GEODE-3300: Complete and expose parallel export feature fo...

2017-08-10 Thread nreich
Github user nreich commented on the issue: https://github.com/apache/geode/pull/704 The requirement for the ".gfd" extension currently resides in the ExportDataCommand from gfsh, the only non-internal entry point to create/restore a backup. This constraint could be also validated in

[GitHub] geode pull request #688: GEODE-3397: Fixed issue with Tomcat locators in cac...

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-10 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61562/#review182621 --- dev-tools/docker/base/Dockerfile Line 27 (original), 27

[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...

2017-08-10 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/708 GEODE-3410 Doc update for gfsh query command changes - the --interactive option is gone - there is a new --file option - correct default value for APP_FETCH_SIZE gfsh env var -

[GitHub] geode issue #699: GEODE-3413: overhaul launcher and process classes and test...

2017-08-10 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/699 These tests have also now been overhauled or rewritten: * LauncherMemberMXBeanIntegrationTest * ServerLauncherWaitOnServerMultiThreadedTest * ServerLauncherWithProviderIntegrationTest ->

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542184 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542091 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542146 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542169 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542242 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1075,8 +1082,7 @@ private LocatorState

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542157 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542106 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542063 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542016 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderIntegrationTest.java --- @@ -0,0 +1,179 @@ +/* + *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132542008 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java --- @@ -0,0 +1,97 @@ +/* + *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132541957 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1848,8 +1884,7 @@ public LocatorLauncher build() {

[GitHub] geode pull request #703: GEODE-3328 Properties to set Key/Trust Store Type f...

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/703 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132541795 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -228,9 +230,9 @@ private void disconnect() {

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132541592 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -502,7 +507,7 @@ protected static Integer identifyPid() {

Re: Review Request 61540: GEODE-3403: Modify rolling upgrade test configuration for 1.2.x release

2017-08-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61540/#review182619 --- geode-core/src/main/java/org/apache/geode/internal/Version.java

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132535229 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -157,7 +162,7 @@ protected static Properties

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132533643 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java --- @@ -31,7 +31,7 @@ import

Re: Review Request 61540: GEODE-3403: Modify rolling upgrade test configuration for 1.2.x release

2017-08-10 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61540/#review182617 --- Ship it! Ship It! - Brian Rowe On Aug. 9, 2017, 8:45 p.m.,

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132532669 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java --- @@ -0,0 +1,234 @@ +/* + *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132532612 --- Diff: geode-core/src/main/java/org/apache/geode/config/internal/ClusterConfigurationNotAvailableException.java --- @@ -0,0 +1,29 @@ +/* + *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132532641 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java --- @@ -0,0 +1,243 @@ +/* + *

[GitHub] geode issue #688: GEODE-3397: Fixed issue with Tomcat locators in cache-clie...

2017-08-10 Thread jhuynh1
Github user jhuynh1 commented on the issue: https://github.com/apache/geode/pull/688 Looks ok to me...I'll merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-10 Thread WireBaron
GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/707 GEODE-3412: Add simple authentication flow to protobuf protocol. @pivotal-amurmann @galen-pivotal @kohlmu-pivotal @bschuchardt @hiteshk25 This change adds a simple username/password

Re: [DISCUSS] Improvements to backups

2017-08-10 Thread Nick Reich
Dan, you are correct on #3: there is one location where this appears to not be the case, but it is unused and thus timestamped directories is currently implemented and overwrites should not be possible. This therefore also covers incremental backups and negates the need for change #3. However,

Request for Jenkins config ability

2017-08-10 Thread Jens Deppe
Hi, I'd like to request the ability to make Jenkins config changes for Geode builds; I want to start implementing parallel dockerized dunit tests. Could someone with the appropriate skillz set me up please? Thanks --Jens

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132483129 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java --- @@ -14,745 +14,270 @@ */ package

Review Request 61563: GEODE-3383: Refactor deploy tests

2017-08-10 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61563/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132515331 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java --- @@ -810,9 +819,6 @@ public void setStatus(final String

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132520010 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/StartupStatus.java --- @@ -14,29 +14,37 @@ */ package

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132501696 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/mbean/Process.java --- @@ -16,7 +16,6 @@ /** * Extracted from

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-10 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132497014 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java --- @@ -0,0 +1,182 @@ +/*

Re: [DISCUSS] Improvements to backups

2017-08-10 Thread Dan Smith
+1 this all looks good to me. I think #2 in particular would probably simplify the incremental backup code. For #3, I could have sworn the backups were already going into timestamped directories and nothing got overwritten in an existing backup. If that is not already happening that definitely

Build failed in Jenkins: Geode-nightly #919

2017-08-10 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ. [khowe] Revert "GEODE-3277: Fix error path constructors of inner State classes [klund] GEODE-3407: fix deadlock between

Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

2017-08-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61562/ --- Review request for geode, Anthony Baker and Mark Bretl. Repository: geode

[DISCUSS] Improvements to backups

2017-08-10 Thread Nick Reich
There is a desire to improve backup creation and restore. The suggested improvements are listed below and I am seeking feedback from the community: 1) Allow saving of backups to different locations/systems: currently, backups are saved to a directory on each member. Users can manually or through

[GitHub] geode pull request #705: GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START v...

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-08-10 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r132497282 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -331,6 +331,29 @@ public void queryJsonObject()

Re: Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/ --- (Updated Aug. 10, 2017, 3:59 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/ --- (Updated Aug. 10, 2017, 3:35 p.m.) Review request for geode, Emily Yeh, Jared

[GitHub] geode-native pull request #114: GEODE-2729: Remove global variables

2017-08-10 Thread dgkimura
Github user dgkimura closed the pull request at: https://github.com/apache/geode-native/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] geode-native issue #114: GEODE-2729: Remove global variables

2017-08-10 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/114 Please fix up commit messages --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] geode issue #529: GEODE-2980: All the methods in an interface are implicitly...

2017-08-10 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/529 Hi @kirklund Updated the PR and running the tests now again. Please review and you can merge the same. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode issue #609: GEODE-2886 : sent IllegalStateException instead of throwin...

2017-08-10 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/609 @upthewaterspout , @jhuynh1 I have updated PR, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode issue #677: GEODE-3038: A server process shuts down quietly when path ...

2017-08-10 Thread anton-mironenko
Github user anton-mironenko commented on the issue: https://github.com/apache/geode/pull/677 Hello, is there anything I can do to proceed with this pull request? I was asked to put RuntimeException instead of CacheXmlException. This is what I did. This PR contains

Re: Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/ --- (Updated Aug. 10, 2017, 6:34 a.m.) Review request for geode, Emily Yeh, Jared