Re: Review Request 46065: clean up the lucene index support code for RR

2016-04-12 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46065/#review128445 --- Ship it! Ship It! - anilkumar gingade On April 12, 2016, 6

Review Request 45881: GEODE-704: CI failure: HAInterestPart2DUnitTest.testRefreshEntriesFromPrimaryWhenDSMDetectsServerLive

2016-04-07 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45881/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh

Re: Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

2016-04-04 Thread anilkumar gingade
= null ) { // create ccn } if (!isGateWayReciver && haContainer == null) { // create HAContainer. } return. We can remove the logic creating HAContainer in CCN constructor - anilkumar gingade On April 1, 2016, 10:11 p.m., xiaoj

Re: Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

2016-04-01 Thread anilkumar gingade
.as hacontainer is no more final... - anilkumar gingade On April 1, 2016, 12:37 a.m., xiaojian zhou wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: com.gemstone.gemfire.internal.cache.EntriesMap

2016-03-29 Thread Anilkumar Gingade
If it has not come-up in security scan...No its not... -Anil. On Tue, Mar 29, 2016 at 1:37 PM, Kirk Lund wrote: > Looks to me like com.gemstone.gemfire.internal.cache.EntriesMap is unused. > Has anyone done any sort of scan to delete unused classes? > > EntriesMap is/was the

Re: Review Request 45227: GEODE-988: CI Failure: CqPerfUsingPoolDUnitTest.testMatchingCqs failed with AssertionFailedError

2016-03-23 Thread anilkumar gingade
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45227/#review125101 ----------- On March 23, 2016, 8:35 p.m., anilkumar gingade wrote: > > -

Re: Review Request 45227: GEODE-988: CI Failure: CqPerfUsingPoolDUnitTest.testMatchingCqs failed with AssertionFailedError

2016-03-23 Thread anilkumar gingade
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/45227/#review125103 ------- On March 23, 2016, 8:35 p.m., anilkumar gingade wrote: > > --- > This is an au

Re: Review Request 45227: GEODE-988: CI Failure: CqPerfUsingPoolDUnitTest.testMatchingCqs failed with AssertionFailedError

2016-03-23 Thread anilkumar gingade
, anilkumar gingade

Review Request 45227: GEODE-988: CI Failure: CqPerfUsingPoolDUnitTest.testMatchingCqs failed with AssertionFailedError

2016-03-23 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45227/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh

Re: gatewayEventSubstitutionFilter

2016-03-23 Thread Anilkumar Gingade
Hi Dor, Its been done as part of: https://issues.apache.org/jira/browse/GEODE-967 let us know if its not the same... -Anil. On Wed, Mar 23, 2016 at 10:15 AM, Dor Ben Dov wrote: > Hi All, > > Once I told the users group that this missing code will be added or at >

Re: Wan

2016-03-23 Thread Anilkumar Gingade
Yes...Its all in there... -Anil. On Wed, Mar 23, 2016 at 10:14 AM, Dor Ben Dov wrote: > Hi All, > > Does the WAN replication code included all in the geode-wan ? > > Dor > > This message and the information contained herein is proprietary and > confidential and subject

Re: Refactoring gemfire to geode in addition to Replacement of System environment variable GEMFIRE

2016-03-22 Thread Anilkumar Gingade
GEODE-37... Some investigation work has done to do estimate the work involved... -Anil. On Tue, Mar 22, 2016 at 1:16 AM, Dor Ben Dov wrote: > Udo, > Ok thanks. > Dor > > -Original Message- > From: Udo Kohlmeyer [mailto:ukohlme...@pivotal.io] > Sent: יום ג 22

Re: [DISCUSS] Remove setCustomEvictionAttributes that came in with HDFS changes from develop?

2016-03-21 Thread Anilkumar Gingade
It will be nice to start a google doc or wiki to capture requirements, proposals and feedbacks I think the overflow should be treated similar to other data store; as its not different than storing the data in any persistence type...User may want to use one storage type (Disk, HDFS, database,

Re: JVSD status

2016-03-21 Thread Anilkumar Gingade
As I know; initial work was done to donate the code to apache...Its one of the project community can pick-up and contribute without knowing much of the Geode... -Anil. On Sun, Mar 20, 2016 at 11:04 PM, Nitin Lamba wrote: > Just wanted to know where this is at. > > Don't see

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread anilkumar gingade
all timing related, when the client is in pause state and connect happens immediately...and ack getting recieved... - anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4492

Re: [DISCUSS] What to do with the partial HDFS related code on develop?

2016-03-19 Thread Anilkumar Gingade
+1 Good idea...It will allow us to re-visit the HDFS implementation and right way to provide this support... -Anil. On Fri, Mar 18, 2016 at 3:56 PM, Dan Smith wrote: > When geode was donated to apache, there was a partially completed > integration with HDFS built in.

Re: [DISCUSS] M2 issues - what's included and how we're tracking them

2016-03-19 Thread Anilkumar Gingade
+1 fixed version... About what we need to include, depends on time-line (if any) and scope of the release (based on requirement)... If there is no time-line and there is no specific requirement, we can take balanced approach...Have a release time (approximate); identify tickets that can be

Re: Review Request 45048: GEODE-559: CI Failure: ClientInterestNotifyDUnitTest.testInterestNotify failed

2016-03-19 Thread anilkumar gingade
tes, invalidate and destroy... - anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45048/#review124287 ------- On March

Review Request 45048: GEODE-559: CI Failure: ClientInterestNotifyDUnitTest.testInterestNotify failed

2016-03-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45048/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread anilkumar gingade
e the dispatcher thread will already gotten hold of the pause lock... - anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/#review124041 --------

Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh

Re: Review Request 44739: GEODE-249: Retry on local node does not overwrite previously retrieved results

2016-03-19 Thread anilkumar gingade
/gemstone/gemfire/internal/cache/PartitionedRegionQueryEvaluator.java (line 996) <https://reviews.apache.org/r/44739/#comment186506> Can you add comments here... - anilkumar gingade On March 11, 2016, 11:31 p.m., Jason Huynh

Re: Review Request 44877: GEODE-27: Adding a test to verify the bundled jars have not changed

2016-03-18 Thread anilkumar gingade
/com/gemstone/gemfire/BundledJarsJUnitTest.java (line 78) <https://reviews.apache.org/r/44877/#comment186198> Does this work on WindowsOr can we ignore windows platform? - anilkumar gingade On March 16, 2016, 1:23 a.m., Dan Smith

Re: Packaging and dependencies

2016-03-14 Thread Anilkumar Gingade
Adding to that, for mobile apps our recommendation was to use REST APIs. -Anil. On Mon, Mar 14, 2016 at 3:51 PM, Anilkumar Gingade <aging...@pivotal.io> wrote: > Hi Fred, > > You are right, with micro-services and mobile applications getting > prominent there is a need to s

Re: Packaging and dependencies

2016-03-14 Thread Anilkumar Gingade
Hi Fred, You are right, with micro-services and mobile applications getting prominent there is a need to separate our client code...This had came up multiple times in our product road-map (previously)...but never got prioritized as no customer pushed for this... -Anil. On Mon, Mar 14, 2016 at

Re: Review Request 44593: GEODE-1044: Recovery from disk with an initial image put can lead to a duplicate entry in the index

2016-03-11 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44593/#review123230 --- Ship it! Ship It! - anilkumar gingade On March 10, 2016, 5

Re: Review Request 44668: GEODE-1055 Remove unused/dead code from PartitionedRegionQueryEvaluator

2016-03-11 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44668/#review123228 --- Ship it! Ship It! - anilkumar gingade On March 10, 2016, 7

Re: Review Request 44593: GEODE-1044: Recovery from disk with an initial image put can lead to a duplicate entry in the index

2016-03-09 Thread anilkumar gingade
way we will have one common query test util.... - anilkumar gingade On March 9, 2016, 9:51 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Livestreamed Meetup for Geode tonight / quick details on virtual attendance fir Geode Summit

2016-03-07 Thread Anilkumar Gingade
Is the live stream happening??? -Anil. On Mon, Mar 7, 2016 at 4:51 PM, Gregory Chase wrote: > Greetings Apache Geode community, > This is just a reminder that we're live streaming a Meetup tonight about > Apache Geode, that you can access here : >

Re: One Week to Go till #GeodeSummit - March 9 - Palo Alto. Limited Space Remains.

2016-03-02 Thread Anilkumar Gingade
Will it be live telecasted... -Anil. On Wed, Mar 2, 2016 at 2:31 PM, Gregory Chase wrote: > Dear Apache Geode Community, > We're down to one week to go before Geode Summit in Palo Alto, CA. If you > are interested in attending, I recommend signing up before this Friday, >

Re: Valid characters in Region names

2016-03-01 Thread Anilkumar Gingade
>From the existing javadoc it looks like, application can have any chars in region name except the "/". Changing this one may have implication on existing GemFire customers In the past we had to make changes in OQL to support chars like "+", "-", "@"...(since customers used this in their

Re: Review Request 44050: GEODE-966 HashIndex with Overflow region detection/conversion needs to occur sooner

2016-02-29 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44050/#review121361 --- Ship it! Ship It! - anilkumar gingade On Feb. 26, 2016, 12

Re: [DISCUSS] JIRA components

2016-02-29 Thread Anilkumar Gingade
stem upgrades", have them as separate components... Thanks, -Anil. On Thu, Feb 25, 2016 at 8:52 AM, Jens Deppe <jde...@pivotal.io> wrote: > I'm not sure '*tools*' is descriptive enough. What would that cover? > > What about *jvsd*? > > On Wed, Feb 24, 2016 at 2:21

Re: Review Request 43975: Fix for GEODE-106 Invalidate operation fails with IndexMaintenanceException with underlying java.lang.ArrayIndexOutOfBoundsException.

2016-02-26 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43975/#review120906 ------- On Feb. 25, 2016, 1:49 a.m., anilkumar gingade wrote: > >

Re: Review Request 43975: Fix for GEODE-106 Invalidate operation fails with IndexMaintenanceException with underlying java.lang.ArrayIndexOutOfBoundsException.

2016-02-24 Thread anilkumar gingade
. Thanks, anilkumar gingade

Review Request 43975: Fix for GEODE-106 Invalidate operation fails with IndexMaintenanceException with underlying java.lang.ArrayIndexOutOfBoundsException.

2016-02-24 Thread anilkumar gingade
rnal/index/IndexElemArrayJUnitTest.java 8c512646ad3fd259bc28bf5f3988c990cc47df41 Diff: https://reviews.apache.org/r/43975/diff/ Testing --- Fixed the broken functional test for IndexElemArray. Added new test to reproduce the issue. And validate the fix. Thanks, anilkumar gingade

Re: Lucene function added by default

2016-02-19 Thread Anilkumar Gingade
Its about usability and simplicity; the end users look at the product features and expects that to be in the downloaded product/artifacts...Separating out may be additional work for end user... -Anil. On Fri, Feb 19, 2016 at 2:30 PM, Nitin Lamba wrote: > Hi Dan, > > I see -

Re: Review Request 43624: GEODE-323: Primary Key indexes are not being properly used for Partitioned Region Queries

2016-02-18 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43624/#review119741 --- Ship it! Ship It! - anilkumar gingade On Feb. 17, 2016, 12

Re: Review Request 43655: Not including gradle generated directories in the source distribution

2016-02-17 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43655/#review119513 --- Ship it! Ship It! - anilkumar gingade On Feb. 17, 2016, 6

Re: Review Request 43624: GEODE-323: Primary Key indexes are not being properly used for Partitioned Region Queries

2016-02-16 Thread anilkumar gingade
/internal/index/PrimaryKeyIndexCreationHelper.java (line 80) <https://reviews.apache.org/r/43624/#comment180746> How did this use to work for non-pk indexes??? - anilkumar gingade On Feb. 17, 2016, 12:15 a.m., Jason Huynh

Re: Review Request 43502: GEODE-481: CI failure: QueryUsingFunctionContextDUnitTest.testQueriesWithFilterKeysOnPRWithBucketDestroy

2016-02-16 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43502/#review119392 --- Ship it! Ship It! - anilkumar gingade On Feb. 12, 2016, 6

Review Request 43510: Fix for GEODE-106 Invalidate operation fails with IndexMaintenanceException with underlying java.lang.ArrayIndexOutOfBoundsException.

2016-02-11 Thread anilkumar gingade
/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexElemArray.java b94f97500971b37d0ec81a858c4fb4d52e08c3ed Diff: https://reviews.apache.org/r/43510/diff/ Testing --- Unit tests run. Started completed tests. Thanks, anilkumar gingade

Re: Review Request 43449: GEODE-890: CompiledLike member variables are not thread safe

2016-02-11 Thread anilkumar gingade
/com/gemstone/gemfire/cache/query/internal/CompiledLike.java (line 79) <https://reviews.apache.org/r/43449/#comment180214> Will it be a good idea to use Integer.valueOf(-1) - anilkumar gingade On Feb. 10, 2016, 11:28 p.m., Jason Huynh

Re: Review Request 43379: GEODE-794: Unable to match iterators when update in progress

2016-02-09 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43379/#review118510 --- Ship it! Ship It! - anilkumar gingade On Feb. 9, 2016, 11

Re: Review Request 43101: GEODE-886: Passing ENUMs in an IN query possibly returns no results

2016-02-05 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43101/#review118051 --- Ship it! Ship It! - anilkumar gingade On Feb. 2, 2016, 9:02

Re: Review Request 43062: GEODE-730 Optimize single filter join queries

2016-02-05 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43062/#review118059 --- Ship it! Ship It! - anilkumar gingade On Feb. 1, 2016, 8:59

Re: Review Request 43063: GEODE-631 CI failure: PRQueryRegionDestroyedDUnitTest.testPRWithRegionDestroyInOneDatastoreWithDelay

2016-02-02 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43063/#review117411 --- Ship it! - anilkumar gingade On Feb. 1, 2016, 9:10 p.m

Re: Broken javadocs

2016-02-01 Thread Anilkumar Gingade
Agree With Dan... -Anil. On Mon, Feb 1, 2016 at 10:20 AM, Dan Smith wrote: > For GEODE-518, I think we should just generate javadocs for the public API > and not worry about the internal classes right now. That might make this a > lot easier if we do that fix. > > -Dan > >

Re: OQL Group by on PDX objects

2016-01-29 Thread Anilkumar Gingade
rializing only the fields needed by the query. > > > > Thanks! > > > > Sent from my iPhone > > > > > On Jan 29, 2016, at 3:07 AM, Anilkumar Gingade <aging...@pivotal.io> > > wrote: > > > > > > It works if its PdxSerialized in

Re: OQL Group by on PDX objects

2016-01-28 Thread Anilkumar Gingade
PdxInstanceImpl is not comparable... Options are: - group by on inner non-pdx objects (most of the usecases what we have seen). - or not using pdx -Anil. On Thu, Jan 28, 2016 at 4:33 PM, Jason Huynh wrote: > What's probably happening is that the field is being extracted

Re: [VOTE] RC2: Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-28 Thread Anilkumar Gingade
+1 -Anil On Wed, Jan 27, 2016 at 12:40 PM, Nitin Lamba wrote: > The link to source tag got messed-up. Correct link below: > > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M1.RC2 > > Thanks, > Nitin >

Re: OQL Group by on PDX objects

2016-01-28 Thread Anilkumar Gingade
kup_cell.getObject > > -Dan > > > On Thu, Jan 28, 2016 at 4:39 PM, Anilkumar Gingade <aging...@pivotal.io> > wrote: > > > PdxInstanceImpl is not comparable... > > Options are: > > - group by on inner non-pdx objects (most of the usecas

Review Request 42941: Fix for GEODE-877 CacheXmlGenerator creates index xml with internal alias with expression.

2016-01-28 Thread anilkumar gingade
/CacheXml80DUnitTest.java 5ce9b6547b7992a679756f1eee685929172b842c Diff: https://reviews.apache.org/r/42941/diff/ Testing --- Existing test was updated to validate the index info. Thanks, anilkumar gingade

Re: Review Request 42725: Called shutdownOutput and flush while closing the client socket.

2016-01-25 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42725/#review116124 --- Ship it! Ship It! - anilkumar gingade On Jan. 25, 2016, 5

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Anilkumar Gingade
Hi Nitin, Thanks for creating JIRA tickets capturing Niall's concerns/comments regarding the RC candidate... (GEODE-815) RC Feedback: Fix LICENSE and NOTICE files (GEODE-816) Source Distribution NOTICE needs updates (GEODE-817) Binary distribution NOTICE needs update (GEODE-818) RC Feedback: Fix

Re: Review Request 41229: StateFlushOperation flushing/waiting for multicast messages

2015-12-10 Thread anilkumar gingade
senger/JGroupsMessenger.java (line 511) <https://reviews.apache.org/r/41229/#comment169561> includeMulticast not used. - anilkumar gingade On Dec. 10, 2015, 11:01 p.m., Bruce Schuchardt wrote: > > --- > This is an auto

Re: Review Request 40997: GMS - new unit tests for JGroupsMessenger

2015-12-04 Thread anilkumar gingade
ne 838) <https://reviews.apache.org/r/40997/#comment168474> Did we change the behavior, here...Now we are looking for rejection message to be null... - anilkumar gingade On Dec. 4, 2015, 11:30 p.m., Bruce Schu

Re: removing the license from jgroups configuration files

2015-12-04 Thread Anilkumar Gingade
Agree with Jacob... -Anil. On Fri, Dec 4, 2015 at 10:14 AM, Jacob Barrett wrote: > WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE HEADER? > > A file without any degree of creativity in either its literal elements or > its structure is not protected by copyright

Re: Review Request 40927: Disabled throttling queue for SerialExcutor when tcp is disable.

2015-12-03 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40927/#review108920 --- Ship it! Ship It! - anilkumar gingade On Dec. 3, 2015, 7:56

Re: Review Request 40784: GEODE-611: Change findbugs annotations to use ASL library

2015-12-01 Thread anilkumar gingade
good to me... - anilkumar gingade On Dec. 1, 2015, 4:53 p.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review of 1.0.0-alpha1 issues

2015-11-30 Thread Anilkumar Gingade
Here is more detail on versioning http://incubator.apache.org/guides/releasemanagement.html#best-practice-naming (under versioning section) Can we set a release task list... E.g.: What tasks/items are expected to complete to do an alpha, beta and final 1.0 release... -Anil. On

Re: License headers on new source files

2015-11-25 Thread Anilkumar Gingade
The GEODE-18 is helped by external committers; the initial changes were to update the individual files; now the work/change is complete, its time to make this as part of build; so that new files are not merged without the header/agreements... -Anil. On Wed, Nov 25, 2015 at 3:13 PM, Kirk Lund

Re: Review Request 40605: GEODE-585: Simplify hash index code

2015-11-23 Thread anilkumar gingade
/internal/index/HashIndex.java (line 716) <https://reviews.apache.org/r/40605/#comment166887> Lets move this within orderby context. - anilkumar gingade On Nov. 23, 2015, 6:59 p.m., Jason Huynh wrote: > > --- > This is a

Re: Review Request 40605: GEODE-585: Simplify hash index code

2015-11-23 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40605/#review107669 --- Ship it! Ship It! - anilkumar gingade On Nov. 23, 2015, 6:59

Re: Review Request 40397: GEODE-77: initiation of member verification on loss of shared/unordered connection

2015-11-17 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40397/#review106942 --- Ship it! Ship It! - anilkumar gingade On Nov. 17, 2015, 8:21

Re: Geode Definition of Done (DOD)

2015-11-16 Thread Anilkumar Gingade
Hi Nitin, Most of the pre-release activities seems to be part of continuos activity...Why would a change gets merged to develop and marked as resolved without updated docs, code reformat, java doc updates (if any) -Anil. On Mon, Nov 16, 2015 at 5:02 PM, Nitin Lamba

Re: Geode Release 1.0.0

2015-11-02 Thread Anilkumar Gingade
ion? Are we looking at days, weeks or > months? > > > > GEODE-18 is also getting close. That only leaves tests to be resolved > > before we can cut a release. > > > > Kirk: any latest update from the Bug Squashathon from last week? Is there > > a parent J

Re: Geode Release 1.0.0

2015-10-29 Thread Anilkumar Gingade
sue with client/server transaction with HA. - Functions not getting directed to expected nodes. Team is working aggressively to address these issues... -Anil. On Tue, Oct 20, 2015 at 5:54 PM, Anilkumar Gingade <aging...@pivotal.io> wrote: > Update on GEODE-77: > > As part of G

Re: Review Request 39554: GEODE-77: failure to deserialize member IDs from old GemFire clients

2015-10-23 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39554/#review103853 --- Ship it! Ship It! - anilkumar gingade On Oct. 22, 2015, 4:01

Re: Review Request 39488: GEODE-77: deadlock in GMSJoinLeave

2015-10-22 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39488/#review103704 --- Ship it! Ship It! - anilkumar gingade On Oct. 20, 2015, 6:01

Re: Review Request 37904: GEODE-280: GroupByPartitionedQueryDUnitTest.testCompactRangeIndex fails intermittently

2015-10-01 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37904/#review101288 --- Ship it! Ship It! - anilkumar gingade On Oct. 1, 2015, 10:08

Re: Review Request 36993: GEODE-146: Queries are not thread safe due to scopeId variable

2015-10-01 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36993/#review101291 --- Ship it! Ship It! - anilkumar gingade On July 31, 2015, 5:14

Re: Review Request 37404: GEODE-157: Check for colocation not failing if non colocated comparison is first comparison made

2015-10-01 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37404/#review101289 --- Ship it! Ship It! - anilkumar gingade On Aug. 12, 2015, 5:59

Re: Cluster Configuration Service Clarification

2015-09-25 Thread Anilkumar Gingade
Hi Wes, I could see cluster config files getting created under: ~/gem/gemfire82_dev/build/product/locator1/cluster_config/cluster I am trying this with my gemfire 8.2 checkout; it should be same with Geode... The recommended way to generate/get the config files are by using export command:

Re: Review Request 38440: add thread pool for p2p reader threads and async close threads

2015-09-16 Thread Anilkumar Gingade
>> So perhaps we should have a thread pool dedicated to each other member instead of just one. We still have the same issue right? We just moved the problem to peer level pool If there is network or machine issues, most likely this will be across all the peers and this may not be helpful...

Re: DRAFT of August report

2015-09-01 Thread Anilkumar Gingade
Swapnil, Its good...Thanks for taking care of this... -Anil. On Mon, Aug 31, 2015 at 11:48 PM, Swapnil Bawaskar wrote: > Hi All, > The following is a draft of the August report. Please provide any feedback > you may have. > > Geode: > Geode is a data management platform

Re: Review Request 36484: GEODE-105: Null value in Map causes NPE with Map Indexes

2015-08-11 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36484/#review94994 --- Ship it! Ship It! - anilkumar gingade On July 24, 2015, 7:16

Re: Review Request 36484: GEODE-105: Null value in Map causes NPE with Map Indexes

2015-08-11 Thread anilkumar gingade
/internal/index/MapRangeIndexMaintenanceJUnitTest.java (line 335) https://reviews.apache.org/r/36484/#comment149742 Reset after test? - anilkumar gingade On July 24, 2015, 7:16 p.m., Jason Huynh wrote: --- This is an automatically

Re: Review Request 36477: GEODE-100: Nested count(*) query on pr causes NullPointerException

2015-07-24 Thread anilkumar gingade
/internal/CompiledSelect.java (line 361) https://reviews.apache.org/r/36477/#comment147238 javadoc update with new param - anilkumar gingade On July 14, 2015, 3:53 p.m., Jason Huynh wrote: --- This is an automatically generated e-mail

Re: Review Request 36477: GEODE-100: Nested count(*) query on pr causes NullPointerException

2015-07-24 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36477/#review92965 --- Ship it! Ship It! - anilkumar gingade On July 14, 2015, 3:53

Re: Review Request 36484: GEODE-105: Null value in Map causes NPE with Map Indexes

2015-07-23 Thread anilkumar gingade
/internal/index/MapRangeIndexMaintenanceJUnitTest.java (line 325) https://reviews.apache.org/r/36484/#comment147076 Please add query result validation to see the index scan returned the expected results. - anilkumar gingade On July 20, 2015, 7:15 p.m., Jason Huynh wrote

Re: Review Request 36484: GEODE-105: Null value in Map causes NPE with Map Indexes

2015-07-23 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36484/#review92831 --- Ship it! Ship It! - anilkumar gingade On July 20, 2015, 7:15

Re: Review Request 36397: HdfsStore API refactoring

2015-07-15 Thread anilkumar gingade
/HDFSStoreFactory.java (line 157) https://reviews.apache.org/r/36397/#comment145486 GemFireConfigException: do we need to change it to something which is not tied to GemFire or Geode... HDFSStoreConfigException? - anilkumar gingade On July 10, 2015, 8:45 p.m., Ashvin A wrote

Re: OQL Query Limitations?

2015-07-15 Thread Anilkumar Gingade
How can I query collections within my region object? My portfolios region contains objects of Portfolio, which in turn has a ListPosition The query in this case is: select distinct pos.id from /portfolios p, p.positions pos No need to call pos.values, as pos is a collection. If the query

Re: Review Request 36408: Resolve the Geode Spark Connector Build Issue

2015-07-10 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36408/#review91373 --- Ship it! Ship It! - anilkumar gingade On July 10, 2015, 11:32

Re: Review Request 36395: GEODE-90: IN SET Query using Index throws IllegalArgumentException

2015-07-10 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36395/#review91371 --- Ship it! Ship It! - anilkumar gingade On July 10, 2015, 5:11

Where to place Spark + GemFire connector.

2015-07-02 Thread Anilkumar Gingade
Hi Team, We Have build Spark + Geode connector, which allows users to write Spark application to store/retrieve/query RDDs to/from Geode cluster. We are wondering wether to have this as part of Geode repo or on separate public GitHub repo? Why are we thinking about separate GitHub repo: - The

<    1   2