Re: Review Request 50436: GEODE-1695: Parameterize build metadata

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50436/#review143578 --- Ship it! Thanks for doing this! - Dick Cavender On July 26,

Re: Review Request 50364: Adding support for Tomcat 8.5.4 for the session module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50364/ --- (Updated July 26, 2016, 6:37 p.m.) Review request for geode, anilkumar

Re: Build failed in Jenkins: Geode-nightly #541

I don't know how to fix it. I would expect :geode-assembly:flakyTest to look similar to :geode-assembly:distributedTest. -Kirk On Tue, Jul 26, 2016 at 10:19 AM, Bruce Schuchardt wrote: > It looks like the flakyTest target isn't configured to run Rest API > tests. Does

Re: Review Request 50316: add support to lucene's raw Directory (RAMDirectory or NIOFSDirectory)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50316/#review143575 --- Ship it! It might be nice to add some javadocs to the Raw...

[VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC5

All, This is the fourth release candidate Apache Geode, version 1.0.0-incubating.M3. We're including the feedback received in RC3 and fixing intermittent test failure. See GEODE-1594 for more details. Thanks to all the community members to drive towards this milestone! It fixes the following

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

> On July 26, 2016, 10:02 a.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? > > Anthony Baker wrote: > AFAIK, the buildId is only used in

[GitHub] incubator-geode issue #218: GEODE-1682: Adding options for starting Geode RE...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/218 Thank you for the pull request Avinash! Please look into writing some new tests that verify the changes. --- If your project is set up for it, you can reply to this email and have your

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

> On July 26, 2016, 10:02 a.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? > > Anthony Baker wrote: > AFAIK, the buildId is only used in

Review Request 50452: GEODE-1583: Always pass the keep alive flag when destroying a connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50452/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh,

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

> On July 26, 2016, 5:02 p.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? > > Anthony Baker wrote: > AFAIK, the buildId is only used in

Re: Review Request 50420: there is a race that cache is still initializing, some components are not ready

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50420/#review143583 --- I'm a bit confused by this fix actually. The test calls

[GitHub] incubator-geode issue #217: feature/GEODE-11-Defining lucene index

Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/217 This change is mixing internal classes in the public API. You're adding getDefinedIndexes to the public API, but it returns LuceneIndexCreationProfile objects which is an internal

Renaming web api from gemfire-api to geode

There is a story to rename the gemfire-api (Developer API) and gemfire (Management API) to geode and geode-mgmt, respectively. The change itself is rather trivial. Just a couple web.xml changes, rename gemfire-api-servlet.xml, and update unit tests. The non-trivial part is still supporting

Re: Review Request 50462: GEODE-1385: mark testShutDownForTIMEOUT with FlakyTest category

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50462/#review143613 --- Ship it! Ship It! - Anthony Baker On July 26, 2016, 8:53

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC5

Some clarification please - this is the “fourth release candidate” but it’s named …M3.RC5? Ken > On Jul 26, 2016, at 12:16 PM, William Markito wrote: > > All, > > This is the fourth release candidate Apache Geode, version > 1.0.0-incubating.M3. > > We're including the

Review Request 50468: fix stat corrupting when async queue full

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50468/ --- Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #382 was SUCCESSFUL (with 1421 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #382 was successful. --- Scheduled 1423 tests in total. https://build.spring.io/browse/SGF-NAG-382/ -- This

Re: Review Request 50361: GEODE-1687: NPE during CqStatusListener method invocation.

> On July 22, 2016, 10:18 p.m., Jason Huynh wrote: > > geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceImpl.java, > > line 2008 > > > > > > Would it make sense to check the cq state

[GitHub] incubator-geode issue #218: GEODE-1682: Adding options for starting Geode RE...

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/218 Thanks @kirklund for initial review. I have updated the PR with addition of Tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client

Github user doribd commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/199#discussion_r72201660 --- Diff: geode-client-native/src/cppcache/impl/ThinClientRedundancyManager.hpp --- @@ -56,7 +56,7 @@ namespace gemfire { void netDown( );

Re: Renaming web api from gemfire-api to geode

It turns out in ManagementAgent or RestAgent, we are using JettyHelper to add the web apps under each specific context: JettyHelper.addWebApplication(httpServer, "/gemfire-api", gemfireAPIWar); So the solution is to add the same war file in the "/geode" context as well. This does mean that we

Re: Build failed in Jenkins: Geode-nightly #541

I think I have it fixed. It needs to have "flakyTests dependsOnInstalledProduct" Le 7/26/2016 à 1:43 PM, Anthony Baker a écrit : This stuff in geode-assembly/build.gradle configures tests that run in the assembly subproject: test { // test from the actual classpath not the gradle

Re: Renaming web api from gemfire-api to geode

I've followed Jinmei's suggestion and initial testing looks great. I'm going to rejigger existing unit tests to use parameters so it'll test both geode and gemfire-api (as well as management), fire off a precheckin, and see how it plays out. On Tue, Jul 26, 2016 at 3:39 PM, Jinmei Liao

Re: Review Request 50468: fix stat corrupting when async queue full

> On July 26, 2016, 4:06 p.m., Ken Howe wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java, > > lines 1605-1606 > > > > > > Javadoc comment doesn't list all of the method's

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

> On July 26, 2016, 5:02 p.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? > > Anthony Baker wrote: > AFAIK, the buildId is only used in

Re: Build failed in Jenkins: Geode-nightly #541

This stuff in geode-assembly/build.gradle configures tests that run in the assembly subproject: test { // test from the actual classpath not the gradle classpath dependsOn installDist // @TODO: this doesn't seem to be working need to get basename first. classpath += files

Re: Build failed in Jenkins: Geode-nightly #541

Doh! Thanks for catching that one. Anthony > On Jul 26, 2016, at 1:48 PM, Bruce Schuchardt wrote: > > I think I have it fixed. It needs to have "flakyTests > dependsOnInstalledProduct" > > Le 7/26/2016 à 1:43 PM, Anthony Baker a écrit : >> This stuff in

Review Request 50462: GEODE-1385: mark testShutDownForTIMEOUT with FlakyTest category

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50462/ --- Review request for geode, Anthony Baker, Grace Meilen, Jinmei Liao, and Kevin

[GitHub] incubator-geode pull request #218: GEODE-1682: Adding options for starting G...

GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/218 GEODE-1682: Adding options for starting Geode REST API using gfsh GEODE-1682: - Added option in gfsh to start REST `start-rest-api` - Added option for http service port

Re: [GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client

Based on my reading of [1] and [2] I don’t think the comment is necessary and should be removed. Any other opinions? Anthony [1] http://www.apache.org/legal/src-headers.html [2] http://www.apache.org/dev/apply-license.html#contributor-copyright > On Jul 26, 2016, at 12:38 AM, doribd

Build failed in Jenkins: Geode-nightly #541

See Changes: [jiliao] GEODE-1617: Regions can be created with a variety of characters that are [klund] GEODE-1673: fail start if security.json cannot be found [bschuchardt] Marking test as flaky - see GEODE-1594 [huynhja] GEODE-1617:

Re: Proposal - Fail cache creation on persistent PR colocation misconfiguration

Thanks for the responses. Michael, Yes I had considered the case where a parent region is created via the cache.xml and then the child region(s) created later. My thoughts were that that could be the case when creating the original configuration, but it's OK then because at that time there’s

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50436/ --- (Updated July 26, 2016, 4:56 p.m.) Review request for geode, Dick Cavender,

RE: [GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client

Comment will be remove. Dor -Original Message- From: Anthony Baker [mailto:aba...@pivotal.io] Sent: יום ג 26 יולי 2016 18:22 To: dev@geode.incubator.apache.org Subject: Re: [GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client Based on my reading of [1] and

Build failed in Jenkins: Geode-release #16

See Changes: [boglesby] GEODE-1641: The Gateway Conflict Resolver is supported again in [wmarkito] M3 release branch done. Bumping the release version to 1.0.0 [huynhja] GEODE-1614: CI failure: [eshu] GOEDE-1621: Do not throw

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50436/#review143552 --- Looks good - but this does mean that the build id will always be

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

> On July 26, 2016, 5:02 p.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? AFAIK, the buildId is only used in GemFireVersion.properties. That file

Re: Build failed in Jenkins: Geode-nightly #541

It looks like the flakyTest target isn't configured to run Rest API tests. Does anyone know how to fix this? Le 7/26/2016 à 7:31 AM, Apache Jenkins Server a écrit : :geode-assembly:flakyTest com.gemstone.gemfire.rest.internal.web.controllers.RestAPIsOnMembersFunctionExecutionDUnitTest >