Re: Review Request 52655: GEODE-1973: add more tests to cover GMSAuthenticator and SimpleSecurityManager

2016-10-10 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52655/#review152011 --- Ship it! Add license headers (already done I think?) and then

Re: incubator-geode git commit: GEODE-1956: fix the race condition that cause the vm only hosts 1 primary bucket

2016-10-10 Thread Anthony Baker
Just reverted. Thanks for catching this Mark. Anthony > On Oct 10, 2016, at 11:26 AM, Mark Bretl wrote: > > Not sure why this got into master, but probably needs to be reverted. > > --Mark > -- Forwarded message -- > From: > Date:

Review Request 52700: Add more tests to flaky category based on recent CI failures

2016-10-10 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52700/ --- Review request for geode, Kirk Lund and Dan Smith. Repository: geode

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

2016-10-10 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52698/#review152014 --- Ship it! Ship It! - Dan Smith On Oct. 10, 2016, 5:36 p.m.,

Review Request 52699: while accessor is a diskstore for now, there's race that vm_0 only hosted 1 primary bucket.

2016-10-10 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52699/ --- Review request for geode and Dan Smith. Bugs: geode-1956

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

2016-10-10 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52698/#review152021 --- Ship it! Ship It! - Anthony Baker On Oct. 10, 2016, 5:36

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

2016-10-10 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52698/#review152029 --- Ship it! Ship It! - Mark Bretl On Oct. 10, 2016, 10:36

Re: Review Request 52655: GEODE-1973: add more tests to cover GMSAuthenticator and SimpleSecurityManager

2016-10-10 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52655/#review152006 ---

Re: Review Request 52699: while accessor is a diskstore for now, there's race that vm_0 only hosted 1 primary bucket.

2016-10-10 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52699/#review152026 --- Ship it! Ship It! - Dan Smith On Oct. 10, 2016, 6:03 p.m.,

Re: Review Request 52700: Add more tests to flaky category based on recent CI failures

2016-10-10 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52700/#review152061 --- Fix it, then Ship it! Review use of import formatters

Re: Review Request 52724: GEODE-1570: improve rest security framework

2016-10-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52724/ --- (Updated Oct. 11, 2016, 1:31 a.m.) Review request for geode, Jared Stewart,

Re: Review Request 52641: GEODE-1914 removed old versions of dtds

2016-10-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52641/#review152094 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 7, 2016, 7:13

Re: Review Request 52700: Add more tests to flaky category based on recent CI failures

2016-10-10 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52700/#review152067 --- Ship it! Ship It! - Dan Smith On Oct. 10, 2016, 6:54 p.m.,

Review Request 52724: GEODE-1570: improve rest security framework

2016-10-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52724/ --- Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.

Re: First Apache Geode 1.0.0-incubating (GA) release...

2016-10-10 Thread Dan Smith
Switched to the dev list to discuss what to do with the nightly builds. On Mon, Oct 10, 2016 at 5:13 PM, Anthony Baker wrote: > The ‘uploadArchives’ task publishes the maven artifacts into the snapshot > repo. The Geode-Nightly jenkins job publishes the develop branch,

[GitHub] incubator-geode pull request #255: Feature/geode 999

2016-10-10 Thread jaredjstewart
Github user jaredjstewart closed the pull request at: https://github.com/apache/incubator-geode/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

2016-10-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52725/ --- Review request for geode, Bruce Schuchardt and Hitesh Khamesra. Repository:

Using Fix Version on JIRA

2016-10-10 Thread William Markito
This may sound like a simple and not really important, but it's key to track issues and which release the fix is part of. It also helps in generating automated release notes through JIRA, such as this one [1] from M3. Since we already created a release branch for 1.0 but there is work still