GEODE-327: Rename gemfire-junit to gemfire-common

2015-09-11 Thread Kirk Lund
I filed ticket GEODE-327 to propose renaming gemfire-junit to gemfire-common. We'd like to be able to define common annotations in this gemfire-common and not be limited to code that is specific to junit or testing. The first annotation would be Experimental (see GEODE-328). Please vote on

Re: Releasing Geode (was Re: September 2015 Report)

2015-09-11 Thread Kirk Lund
I'll file the ticket to rename gemfire-junit to gemfire-common and create the annotation. -Kirk On Friday, September 11, 2015, Anthony Baker wrote: > @Experimental seems to be more common (spark, rxjava, jgroups, ). > > I would rename the gemfire-junit module to

Re: Releasing Geode (was Re: September 2015 Report)

2015-09-10 Thread Kirk Lund
+1 for having Nitin as RM and for Anthony's list (with the addition below) Any new APIs that are half-baked need cleanup if there's any chance we'll be locked in with them for backwards compatibility... or we have to remove the new API or otherwise mark it as experimental in someway. -Kirk On

Re: GEODE-218: Dunit Fork Every 1

2015-09-04 Thread Kirk Lund
+1 I like the idea of switching to fork=1 for a few months to focus on stabilizing any dunit tests that fail without potential test pollution causes. These failures are mostly like ones that involve race conditions. Once we fix these, then we could change back to fork=30. On Fri, Sep 4, 2015 at

Review Request 38133: Move AgentUtilJUnitTest into a package

2015-09-04 Thread Kirk Lund
0f7563b gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/AgentUtilJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/38133/diff/ Testing --- integrationTest (AgentUtilJUnitTest is an IntegrationTest) Thanks, Kirk Lund

Re: Review Request 38029: GEODE-306: support printing of off-heap compressed nodes

2015-09-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38029/#review97796 --- Ship it! Ship It! - Kirk Lund On Sept. 1, 2015, 11:46 p.m

Re: Review Request 38135: make pdx logging info level

2015-09-04 Thread Kirk Lund
eople won't run in production with debug or trace. - Kirk Lund On Sept. 4, 2015, 8:50 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 38133: Move AgentUtilJUnitTest into a package

2015-09-04 Thread Kirk Lund
> On None, Kirk Lund wrote: > > Ship It! Ignore this. I meant to hit "Publish" instead of "Ship It!" (long week!) - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.ap

gemfire-core:integrationTest failures on Windows

2015-09-04 Thread Kirk Lund
The following is the results of running gemfire-core:integrationTest on Windows. There are 164 failures and it looks like all of the HDFS tests fail on Windows. Are these tests supposed to be passing on Windows? Should I file a JIRA? Should they be ignored on Windows? Do they require Linux?

Re: Review Request 37702: GEODE-264: Fix varargs compiler warnings

2015-09-01 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37702/#review97333 --- Ship it! Ship It! - Kirk Lund On Aug. 22, 2015, 4:03 p.m

Re: Review Request 38015: GEODE-295 - Expecting a suspect string in BridgeMembershipDUnitTet

2015-09-01 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38015/#review97332 --- Ship it! Ship It! - Kirk Lund On Sept. 1, 2015, 8:36 p.m., Dan

Re: DRAFT of August report

2015-09-01 Thread Kirk Lund
+1 Looks good Swapnil! On Mon, Aug 31, 2015 at 11:48 PM, Swapnil Bawaskar wrote: > Hi All, > The following is a draft of the August report. Please provide any feedback > you may have. > > Geode: > Geode is a data management platform that provides real-time, consistent >

Re: Review Request 37737: GEODE-275: fix race in testRegionExpirationAfterMutate

2015-08-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37737/#review96435 --- Ship it! Ship It! - Kirk Lund On Aug. 24, 2015, 11:23 p.m

Review Request 37683: Clean up WanCommandsControllerJUnitTest

2015-08-21 Thread Kirk Lund
- gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java fb39d8c Diff: https://reviews.apache.org/r/37683/diff/ Testing --- WanCommandsControllerJUnitTest test Thanks, Kirk Lund

Re: There was no nightly build yesterday?

2015-08-21 Thread Kirk Lund
Thanks Mark! On Fri, Aug 21, 2015 at 1:13 PM, Mark Bretl mbr...@pivotal.io wrote: I will re-enable the nightly schedule. --Mark On Fri, Aug 21, 2015 at 1:11 PM, Kirk Lund kirk.l...@gmail.com wrote: Hi, We need to have the nightly build reenabled for Apache Geode incubating. Who do

Re: Review Request 37670: Convert resource string to URI string for log4j2-cli.xml

2015-08-20 Thread Kirk Lund
/logging/LoggingUnitTestSuite.java cd39a9d Diff: https://reviews.apache.org/r/37670/diff/ Testing (updated) --- manual testing with gemfire-assembly/build/install/apache-geode/bin/gfsh LoggingUnitTestSuite LoggingIntegrationTestSuite Thanks, Kirk Lund

Re: Updating JIRA issues

2015-08-20 Thread Kirk Lund
GEODE-47 has some comments but is still open (that's the correct state for now). The others appear to be mistakenly left open after committing fixes. -Kirk On Thu, Aug 20, 2015 at 8:49 PM, Anthony Baker aba...@pivotal.io wrote: It looks like several JIRA issues have been fixed but are still

Re: Reviewboard seems to be malfunctioning

2015-08-19 Thread Kirk Lund
Check here to see if ASF already knows about it: http://status.apache.org/ If the problem isn't shown on that status page then report it in the ASF infra hipchat: http://infra.chat/ -Kirk On Wed, Aug 19, 2015 at 9:49 AM, Bruce Schuchardt bschucha...@pivotal.io wrote: I get the same error

Re: Investigate test failures: Build 189

2015-08-19 Thread Kirk Lund
I don't have any ideas about the cause without looking at the full stack of RegionDestroyedException and the rest of the logs. We haven't been seeing anything like this so I would expect it to be a real bug that was committed. It might be caused by race condition(s) in either the test or the

Pull requests, wiki page and multiple git commits

2015-08-19 Thread Kirk Lund
bbc2a5fa5f0bbcd00a8ab64451a2528a22d88bc0 Merge: 9efe74e 581702a Author: Kirk Lund kl...@pivotal.io Date: Wed Aug 19 16:09:21 2015 -0700 Merge branch 'feature/GEODE-213' into develop commit 581702ac1d2a9debe8619680d09fa868b9ca8b05 Author: Kirk Lund kl...@pivotal.io Date: Wed Aug 19 16:01:26 2015 -0700

Re: Review Request 37486: GEODE-214: better Azul support

2015-08-14 Thread Kirk Lund
/gemfire/internal/SharedLibrary.java (line 112) https://reviews.apache.org/r/37486/#comment150432 I would recommend fixing the indentation of this method. Also need to make sure the assumption of compressed oops is not used when using Zing JVM. - Kirk Lund On Aug. 14, 2015, 5:22 p.m., Darrel

Re: So is it time to dump Hipchat and move to Geode conversations to Slack?

2015-08-14 Thread Kirk Lund
Did we ever move to Slack? I don't see any further mention of it. It doesn't look like hipchat is being actively used for Geode anymore. -Kirk On Fri, Jul 17, 2015 at 11:26 AM, John Blum jb...@pivotal.io wrote: +1 for moving to Slack On Fri, Jul 17, 2015 at 11:13 AM, Bruce Schuchardt

Re: 16 days without a green build

2015-08-13 Thread Kirk Lund
For spurious failures, the problematic tests are predominantly dunit tests which are actually end-to-end tests involving 6 jvms. End-to-end tests are notorious for having reliability issues. This is magnified by reusing jvms from one test case to the next. Eventually, one of the 6 jvms hits a

Re: 16 days without a green build

2015-08-13 Thread Kirk Lund
I've created GEODE-218 Change distributedTest task to fork every 1 test case for review and group discussion. -Kirk On Thu, Aug 13, 2015 at 5:29 PM, Kirk Lund kirk.l...@gmail.com wrote: For spurious failures, the problematic tests are predominantly dunit tests which are actually end-to-end

Re: Review Request 37400: GEODE-211: shorten the time ConcurrentRegionOperationsJUnitTest runs

2015-08-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37400/#review95197 --- Ship it! Ship It! - Kirk Lund On Aug. 12, 2015, 5:16 p.m

Re: Review Request 37321: GEODE-138: remove race condition from testEventDelivery

2015-08-10 Thread Kirk Lund
? - Kirk Lund On Aug. 10, 2015, 9:28 p.m., Darrel Schneider wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37321

Re: Review Request 37148: fix race in testEntryTtlDestroyEvent

2015-08-06 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37148/#review94424 --- Ship it! Ship It! - Kirk Lund On Aug. 5, 2015, 11:52 p.m

Re: Review Request 37143: fix races in testRegionIdleInvalidate

2015-08-05 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37143/#review94316 --- Ship it! Ship It! - Kirk Lund On Aug. 5, 2015, 9:22 p.m

Re: Review Request 36963: GEODE-162: remove race condititions and long sleeps from region expiration test methods in RegionTestCase

2015-08-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36963/#review94131 --- Ship it! Ship It! - Kirk Lund On July 30, 2015, 11:50 p.m

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-08-03 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36950/#review93916 --- Ship it! Ship It! - Kirk Lund On July 31, 2015, 12:13 a.m

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

2015-08-03 Thread Kirk Lund
Lund On Aug. 3, 2015, 7:58 p.m., Kirk Lund wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36957/ --- (Updated Aug. 3, 2015

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

2015-08-03 Thread Kirk Lund
, Kirk Lund

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

2015-08-03 Thread Kirk Lund
: https://reviews.apache.org/r/36957/diff/ Testing --- test, integrationTest, new TestSuites, rebuild open+closed Thanks, Kirk Lund

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

2015-08-03 Thread Kirk Lund
TestSuites, rebuild open+closed Thanks, Kirk Lund

Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

2015-07-30 Thread Kirk Lund
/diff/ Testing --- test, integrationTest, new TestSuites, rebuild open+closed Thanks, Kirk Lund

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread Kirk Lund
/#comment148074 Is it possible to use $JAVA_HOME here instead of hardcoding references to /jdk1.8.0_51? - Kirk Lund On July 30, 2015, 8:52 p.m., William Markito wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 36866: GEODE-127: Improve reliability and increase execution speed of some tests

2015-07-28 Thread Kirk Lund
-mail. To reply, visit: https://reviews.apache.org/r/36866/#review93375 --- On July 28, 2015, 9:27 p.m., Kirk Lund wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 36857: Remove rerunTest task from gemfire-core/build.gradle

2015-07-28 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36857/#review93301 --- Ship it! Ship It! - Kirk Lund On July 27, 2015, 8:27 p.m., Mark

Re: Review Request 36866: GEODE-127: Improve reliability and increase execution speed of some tests

2015-07-28 Thread Kirk Lund
://reviews.apache.org/r/36866/diff/ Testing --- test, integrationTest and targeted testing of TestSuites Thanks, Kirk Lund

Re: Review Request 36802: GEODE-86: add getDeserializedValue on OperationContext and add unit test coverage

2015-07-27 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36802/#review93133 --- Ship it! Ship It! - Kirk Lund On July 24, 2015, 11:54 p.m

Review Request 36866: GEODE-127: Improve reliability and increase execution speed of some tests

2015-07-27 Thread Kirk Lund
, integrationTest and targeted testing of TestSuites Thanks, Kirk Lund

Re: Review Request 36747: GEODE-152: fix NPE in fetchJvmThreads

2015-07-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36747/#review92926 --- Ship it! Ship It! - Kirk Lund On July 23, 2015, 9:49 p.m

Re: Review Request 36750: GEODE-153: fix race in testRemoteCacheListener

2015-07-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36750/#review92956 --- Ship it! Ship It! - Kirk Lund On July 24, 2015, 4:23 p.m

Re: Review Request 36594: Adding try-with-resources for Cache

2015-07-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36594/#review92925 --- Ship it! Ship It! - Kirk Lund On July 23, 2015, 6:19 a.m

Re: Review Request 36695: GEODE-148: change expiration tests to not run so long

2015-07-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36695/#review92927 --- Ship it! Ship It! - Kirk Lund On July 22, 2015, 4:36 p.m

Re: Review Request 36695: GEODE-148: change expiration tests to not run so long

2015-07-23 Thread Kirk Lund
/gemfire/cache30/RegionTestCase.java (line 3617) https://reviews.apache.org/r/36695/#comment147062 Did you mean to leave the TODO here? - Kirk Lund On July 22, 2015, 4:36 p.m., Darrel Schneider wrote: --- This is an automatically

Re: Review Request 36714: GEODE-143: logging must not cause cached values to be deserialized

2015-07-23 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36714/#review92822 --- Ship it! Ship It! - Kirk Lund On July 23, 2015, 12:15 a.m

Re: Review Request 36533: GEODE-128: fix expiration tests to run faster with PR regions

2015-07-23 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36533/#review92819 --- Ship it! Ship It! - Kirk Lund On July 16, 2015, 12:11 a.m

Jenkins other testing failures last week

2015-07-20 Thread Kirk Lund
Please join in and select a ticket from the 1st group to assign to yourself. We need to make each of these tests more reliable. Please remove any Thread sleep calls or other actions that can cause a test to intermittently fail. Filed with no assignee yet: GEODE-140

Apache Jenkins question

2015-07-14 Thread Kirk Lund
Does anyone know why the Apache Jenkins does not show details on test failures? Our internal Jenkins has a Test Result link with links for each test failure that you can follow to see detailed info on the test. Apache Jenkins doesn't have this and the only way I can see results is in Console

Re: Nightly build test failures

2015-07-14 Thread Kirk Lund
:29 AM, Kirk Lund kl...@pivotal.io wrote: Looks like we have nightly build failures. I think this means we need to freeze all checkins and work to stabilize these test failures: https://builds.apache.org/view/All/job/Geode-nightly/lastFailedBuild/console Jenkins also ran out

Re: git flow feature publish GEODE-nn step fails

2015-07-13 Thread Kirk Lund
the right thing but you are not able to connect to the apache git server. -Dan On Mon, Jul 13, 2015 at 12:01 PM, Kirk Lund kl...@pivotal.io wrote: I had no trouble doing git fetch and starting a feature branch, but now that I'm ready to publish the feature branch and track it from another

git flow feature publish GEODE-nn step fails

2015-07-13 Thread Kirk Lund
2adb1588cce967c2a4149fa674d431871a3066fd Author: Kirk Lund kl...@pivotal.io Date: Mon Jul 13 11:44:21 2015 -0700 GEODE-94: Add typecast to prevent ambiguous method calls under JDK 8 Add typecast to Object for ambiguous logger arguments. *$ git flow feature publish GEODE-94* fatal: unable

Re: Review Request 36415: GEODE-75: System property to Rebalance multiple regions in parallel

2015-07-13 Thread Kirk Lund
That's good enough! Thanks, Kirk On Mon, Jul 13, 2015 at 10:28 AM, Dan Smith dsm...@pivotal.io wrote: On July 13, 2015, 4:30 p.m., Kirk Lund wrote: gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java, line 62 https

Re: Review Request 36416: GEODE-56 Decrementing bytesOverflowedOnDisk when an update happens to an evicted entry.

2015-07-13 Thread Kirk Lund
for this as well as missing categories. - Kirk Lund On July 11, 2015, 12:26 a.m., Dan Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36416

Re: Review Request 36395: GEODE-90: IN SET Query using Index throws IllegalArgumentException

2015-07-13 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36395/#review91475 --- Ship it! Ship It! - Kirk Lund On July 10, 2015, 5:11 p.m

Review Request 36454: Typecast ambiguous logger arguments to allow JDK 8 compilation

2015-07-13 Thread Kirk Lund
-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java 426b8b4 Diff: https://reviews.apache.org/r/36454/diff/ Testing --- Run existing UnitTest, IntegrationTest, DistributedTest suites Thanks, Kirk Lund

Review Request 36377: Convert FastLoggerJUnitTest to use junit rules

2015-07-09 Thread Kirk Lund
/ Testing --- Unit tests: ./gradlew clean test Thanks, Kirk Lund

Re: Where to place Spark + GemFire connector.

2015-07-07 Thread Kirk Lund
I would think that github would be a better option for the Spark Geode Connector. That way it's not tightly coupled to the Geode release cycle. I don't see why it's desirable to bloat Geode with every single script, tool, or connector that might interact with Geode. Another reason to consider

Re: Review Request 36221: GEODE-81 - Fixing unit test failures from AnalyzeSerializablesJUnitTest

2015-07-06 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36221/#review90591 --- Ship it! Ship It! - Kirk Lund On July 6, 2015, 9:55 p.m., Dan

Repackaging src code to org.apache.geode

2015-07-02 Thread Kirk Lund
I just want to clarify that the reason we are planning to repackage is because of this policy: http://incubator.apache.org/guides/mentor.html#repackaging ...which states that repackaging is recommended, but not mandated. Is there a different source that states that it's mandated? -Kirk

Re: Repackaging src code to org.apache.geode

2015-07-02 Thread Kirk Lund
Yep, having 99% of the code in org.apache.geode pkgs with 1% in com.gemstone.gemfire pkgs just to facilitate rolling upgrades seems like something that would be reasonable to discuss on general@incubator. On Thu, Jul 2, 2015 at 12:35 PM, Bruce Schuchardt bschucha...@pivotal.io wrote: Hey, if

Submitting podling report

2015-07-01 Thread Kirk Lund
According to https://wiki.apache.org/incubator/July2015, the podling report is due today. I don't see where I'm supposed to submit it to though. I'm not seeing any answers on http://incubator.apache.org/guides/mentor.html#Sending+in+an+Incubation+Report either. Any pointers on where to send or

Geode podling report for review

2015-07-01 Thread Kirk Lund
Geode Geode is a data management platform that provides real-time, consistent access to data-intensive applications throughout widely distributed cloud architectures. Geode has been incubating since 2015-04-27. Three most important issues to address in the move towards graduation: 1.

Re: Geode podling report for review

2015-07-01 Thread Kirk Lund
. On Wed, Jul 1, 2015 at 4:20 PM, Kirk Lund kl...@pivotal.io wrote: Geode Geode is a data management platform that provides real-time, consistent access to data-intensive applications throughout widely distributed cloud architectures. Geode has been

Re: Using the LocatorLauncher

2015-06-30 Thread Kirk Lund
Yeah, the LocatorLauncher is intended to be an API for starting a Locator in your local JVM or to use as the main when starting a new JVM. You don't need to have a gemfire.properties file. You can programmatically define all of your config options at runtime and either feed them in via the

Re: Review Request 35542: GEODE-51 - Hostname for clients property for cache servers

2015-06-18 Thread Kirk Lund
). - Kirk Lund On June 16, 2015, 11:18 p.m., William Markito wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35542

Re: geode contribution process proposal

2015-06-15 Thread Kirk Lund
Hi Jun, Here's some info on Geode tests. 1) junit These are unit tests involving mocks as well as end-to-end functional tests. These are currently marked with @Category(UnitTest.class) or @Category(IntegrationTest.class). We need to encourage Geode developers to write a lot of more of the

Re: geode contribution process proposal

2015-06-13 Thread Kirk Lund
+1 Welcome Jun! On Friday, June 12, 2015, jun aoki ja...@apache.org wrote: Hi Geode community My name is Jun Aoki and I work for Pivotal's Ambari project, and am super excited to contribute to Geode! I'd like to propose a few things about contribution process. The Geode community should

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Kirk Lund
1) System Rules for JUnit 4 I really like System Rules for JUnit 4. This library has been added to our build on GitLabs develop but not in ASF git yet http://stefanbirkner.github.io/system-rules/. This line resets all System Properties changes you make in your tests: @Rule public final

<    1   2   3   4   5   6