Re: Review Request 53743: CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53743/#review156086 --- Ship it! Ship It! - Hitesh Khamesra On Nov. 14, 2016, 9:45

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155210 --- Ship it! Ship It! - Hitesh Khamesra On Nov. 7, 2016, 10:13

Re: Review Request 53092: GEODE-2011 Client clears pdx registry needs synchronization

omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53092/#review153605 --- On Oct. 21, 2016, 6:52 p.m., Hitesh Khamesra wrote: > > --- > This is an a

Re: Review Request 53094: GEODE-706 race condition between expiry thread and other user thread.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53094/#review153607 ------- On Oct. 21, 2016, 6:41 p.m., Hitesh Khamesra wrote: > > --

Re: Review Request 53092: GEODE-2011 Client clears pdx registry needs synchronization

--- Thanks, Hitesh Khamesra

Review Request 53094: GEODE-706 race condition between expiry thread and other user thread.

apache.org/r/53094/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 53092: GEODE-2011 Client clears pdx registry needs synchronization

modified that notification to synchronize this. Diffs - geode-core/src/main/java/org/apache/geode/cache/client/internal/EndpointManagerImpl.java 3f3d725 Diff: https://reviews.apache.org/r/53092/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 53034: GEODE-1927 backward compatibility support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53034/#review153312 --- Ship it! Ship It! - Hitesh Khamesra On Oct. 19, 2016, 9:16

Re: Review Request 53001: GEODE-1927: more protection from seeing com.gemstone.gemfire packaged objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53001/#review153192 --- Ship it! Ship It! - Hitesh Khamesra On Oct. 18, 2016, 10:05

Review Request 52896: GEODE-706 Fixed race condition between expiry thread and put thread.

/cache/EntryEventImpl.java 6a964c0 geode-core/src/main/java/org/apache/geode/internal/cache/EntryExpiryTask.java 816f32f geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java a6951de Diff: https://reviews.apache.org/r/52896/diff/ Testing --- Thanks, Hitesh

Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

/InternalDistributedMember.java 775fa24 geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java d63dfa0 Diff: https://reviews.apache.org/r/52836/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 52641: GEODE-1914 removed old versions of dtds

eode-spark-connector/src/it/resources/test-regions.xml 79893d6 geode-spark-connector/geode-spark-connector/src/it/resources/test-retrieve-regions.xml 3023959 Diff: https://reviews.apache.org/r/52641/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 52641: GEODE-1914 removed old versions of dtds

-retrieve-regions.xml 3023959 Diff: https://reviews.apache.org/r/52641/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

/ClientTypeRegistration.java (line 267) <https://reviews.apache.org/r/52271/#comment219985> you may want to put break statement here..As we aleady got exception - Hitesh Khamesra On Oct. 5, 2016, 12:36 a.m., Udo Kohlmeyer

Re: Review Request 52524: GEODE-1927 backward compatibility support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52524/#review151388 --- Ship it! Ship It! - Hitesh Khamesra On Oct. 4, 2016, 7:36

Previous versions dtds

We have following dtds in geode source code. We were thinking to remove previous versions(1.0 to 6.6) of dtds.Please let us know if there is any concern on  this. ./main/resources/org/apache/geode/admin/doc-files/ds4_0.dtd ./main/resources/org/apache/geode/admin/doc-files/ds5_0.dtd

Re: Review Request 52363: GEODE-1947: Renaming SSL_HTTP_SERVICE_REQUIRE_AUTHENTICATION to SSL_WEB_SERVICE_REQUIRE_AUTHENTICATION

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52363/#review150768 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 28, 2016, 7:16

Re: Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52172/#review150767 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 28, 2016, 4:08

Review Request 51974: GEODE-1908 DistributedSystem.connect call not configuring p2p server with SSL

--- Thanks, Hitesh Khamesra

Re: Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51461/#review146978 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 26, 2016, 4:21

Re: Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

/internal/ClientPartitionAdvisor.java (line 120) <https://reviews.apache.org/r/51461/#comment213916> Nice catch Bruce. - Hitesh Khamesra On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote: > > --- > This is an automatica

Review Request 51394: GEODE-1372 Geode UDP communications are not secure when SSL is configured

gradle/rat.gradle 0ce82b9 Diff: https://reviews.apache.org/r/51394/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 51385: GEODE-900 test endup uding old cache

teners, typeRegistry); instance.initialize(); } return instance; } - Hitesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51385/#review146705 -------

Review Request 51385: GEODE-900 test endup uding old cache

51385/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 51340: Added vmkind field in InterbalDistributedMember' wrtieEssentialData/readEssentialData method

it: https://reviews.apache.org/r/51340/#review146541 --- On Aug. 23, 2016, 4:25 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Review Request 51340: Added vmkind field in InterbalDistributedMember' wrtieEssentialData/readEssentialData method

: https://reviews.apache.org/r/51340/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

/#review146361 --- On Aug. 10, 2016, 9:25 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4

Re: Review Request 51249: GEODE-1800 StoppableCondition has faulty code in await()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51249/#review146207 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 19, 2016, 6:45

Re: Review Request 51208: GEODE-1761 Clients don't fail back when servers are bounced

/internal/PutOp.java (line 343) <https://reviews.apache.org/r/51208/#comment212476> I am confuse here. Server sent version and its not matching then we are refreshing. So how this will help if we again fetch the same metadata?? - Hitesh Khamesra On Aug. 18, 2016, 3:54 p.m., Bruce Schu

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

/gms/GMSMemberJUnitTest.java 7eef594 Diff: https://reviews.apache.org/r/49962/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

5c0a327 geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java 7eef594 Diff: https://reviews.apache.org/r/49962/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 50856: GEODE-225 excessive CPU utilization and garbage collection strain for JSON processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50856/#review144941 --- how about keeping ObjectMapper in threadLocal? - Hitesh Khamesra

Re: Review Request 50798: GEODE-1727 NPE in JGroups during shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50798/#review144774 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 4, 2016, 3:44

Re: Flaky tests failing with BindException

Is there any possibility of running multiple test same time on that machine? -Hitesh From: Kirk Lund To: geode Sent: Friday, July 29, 2016 1:21 PM Subject: Flaky tests failing with BindException Many of our flaky tests are flaky

Review Request 50607: Update of cq stats causing disk read

l/cache/ha/HARegionQueue.java c5746ed Diff: https://reviews.apache.org/r/50607/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 50587: Merge from 82 and couple of other perf related improvements

/CqPerfDUnitTest.java ef9e61b geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java dcd3915 Diff: https://reviews.apache.org/r/50587/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 50538: GEODE-1619 PartitionedRegionSingleHopWithServerGroupDUnitTest.test_SingleHopWithServerGroupTwoClientServerGroup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50538/#review143864 --- Ship it! Ship It! - Hitesh Khamesra On July 27, 2016, 10:59

Security - callback

We are calling " GeodeSecurityUtil.authorizeRegionWrite(regionName);" in each client-server command . This call does lots of work to figure out whether security is configured or not. Can we have some boolean check to avoid that as it hurts performance.

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

ted e-mail. To reply, visit: https://reviews.apache.org/r/49962/#review141922 --- On July 12, 2016, 4:52 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated

Review Request 49962: Removed extra fields from distributedmember while serialization/de

/GMSMemberJUnitTest.java 7eef594 Diff: https://reviews.apache.org/r/49962/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 49901: GEODE-1642 Add conveniance method isCancelInProgress to CancelCriterion

/internal/membership/gms/messenger/Transport.java (line 139) <https://reviews.apache.org/r/49901/#comment207091> seems length == 0 is enough here.. - Hitesh Khamesra On July 11, 2016, 3:49 p.m., Bruce Schuchardt

Review Request 49729: Used static instance of logger while logging

/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyRegionOnDataStoreMessage.java 225d1af Diff: https://reviews.apache.org/r/49729/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 49666: GEODE-1613 CI failure: ConnectionPoolDUnitTest.test021ClientGetOfInvalidServerEntry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49666/#review141014 --- Ship it! Ship It! - Hitesh Khamesra On July 5, 2016, 11:21

Re: Review Request 48899: GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48899/#review138422 --- Ship it! Ship It! - Hitesh Khamesra On June 18, 2016, 3:03

Re: Review Request 48665: GEODE-1542 shared/unordered tcp/ip connection times out, initiating suspicion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48665/#review137534 --- Ship it! Ship It! - Hitesh Khamesra On June 13, 2016, 10:50

Re: Review Request 48239: GEODE-1498 CI Failure: DurableClientCommandsDUnitTest.testCloseDurableClients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48239/#review136142 --- Ship it! Ship It! - Hitesh Khamesra On June 3, 2016, 11:42

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48095/#review136024 --- Ship it! Ship It! - Hitesh Khamesra On May 31, 2016, 10:15

Fw: Proposal for Secure UDP communication

- Forwarded Message - From: Hitesh Khamesra <hitesh...@yahoo.com> To: "u...@geode.incubator.apache.org" <u...@geode.incubator.apache.org> Sent: Tuesday, May 31, 2016 10:57 AM Subject: Proposal for Secure UDP communication We propose secure UDP c

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java, > > line 373 > > <https://reviews.apache.org/r/48095/diff/1/?file=1402773#file1402773line373> > > > > We were

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java, > > line 373 > > <https://reviews.apache.org/r/48095/diff/1/?file=1402773#file1402773line373> > > > > We were

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

/HeapDataOutputStream.java (line 373) <https://reviews.apache.org/r/48095/#comment200860> We were doing this.chunks = null, so jvm should claim chunks no?, I am missing something here.. - Hitesh Khamesra On May 31, 2016, 10:15 p.m., Bruce Schuchardt

Re: Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47195/#review132996 --- Ship it! Ship It! - Hitesh Khamesra On May 12, 2016, 10:45

Review Request 47323: GEODE-732 Unable to create PDXInstance from valid JSON using JSONFormatter

--- Thanks, Hitesh Khamesra

Re: Review Request 47245: GEODE-1327 java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47245/#review132924 --- On May 11, 2016, 5:55 p.m., Hitesh Khamesra wrote: > >

Review Request 47245: GEODE-1327 java.util.ConcurrentModificationException while updating log message

--- Thanks, Hitesh Khamesra

Re: Review Request 47189: GEODE-1375 When using multicast a new member needs to receive the multicast message digest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47189/#review132691 --- Ship it! Ship It! - Hitesh Khamesra On May 11, 2016, 5:05

Re: Review Request 47189: GEODE-1375 When using multicast a new member needs to receive the multicast message digest

/internal/membership/gms/membership/GMSJoinLeave.java (line 1138) <https://reviews.apache.org/r/47189/#comment196954> Curious, What issue it was causing? - Hitesh Khamesra On May 11, 2016, 5:05 p.m., Bruce Schuchardt

Re: Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47195/#review132680 --- Ship it! Ship It! - Hitesh Khamesra On May 10, 2016, 10:58

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

ption --- added synchronization with copyOnread Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9f5648b Diff: https://reviews.apache.org/r/46896/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

ion > --- > > added synchronization with copyOnread > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 9f5648b > > Diff: https://reviews.apache.org/r/46896/diff/ > > > Testing > --- > > > Thanks, > > Hitesh Khamesra > >

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9f5648b Diff: https://reviews.apache.org/r/46896/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

n every accesor has to do. - Hitesh ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131357 --- On Ma

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131330 --- On May 2, 2016, 4:36 p.m., Hitesh Khamesra wrote: > > ---

Re: Review Request 46850: GEODE-1329 auto-reconnect attempts cease if kicked out during boot-up of the cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46850/#review131327 --- Ship it! Ship It! - Hitesh Khamesra On April 29, 2016, 8:31

Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

. Repository: geode Description --- added synchronization with copyOnread Diffs - geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9f5648b Diff: https://reviews.apache.org/r/46896/diff/ Testing --- Thanks, Hitesh

Re: Next steps with flickering tests

y for single locator test we can have port "0" functionality.  Let us know if we want to add this. From: Kirk Lund <kl...@pivotal.io> To: geode <dev@geode.incubator.apache.org>; Hitesh Khamesra <hitesh...@yahoo.com> Sent: Friday, April 29, 2016 4:35 PM Subje

Re: Next steps with flickering tests

Kirk, have we considered following pattern to change.. from -->    int port = AvailablePort.getRandomAvailablePort(AvailablePort.SOCKET);     server.setPort(port); to ->  server.setPort(0);  port = server.getPort() This should take care "bind address" issue. From: Kirk Lund

Re: Review Request 46854: GEODE-1224: Modify BucketRegion.getCloningEnabled to call this.partitionedRegion.getCloningEnabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46854/#review131210 --- Ship it! Ship It! - Hitesh Khamesra On April 29, 2016, 10

Re: Review Request 46801: GEDOE-1321 GMSHealthMonitor: java.lang.IllegalStateException: Timer already cancelled

://reviews.apache.org/r/46801/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 46590: GEODE-1237 remove the check for network-partition-detection uniformity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46590/#review130459 --- Ship it! Ship It! - Hitesh Khamesra On April 22, 2016, 10

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129834 --- Ship it! Ship It! - Hitesh Khamesra On April 20, 2016, 10

Re: Review Request 46120: GEODE-1150 LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime(Seems locator unable to join cluster)

/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java 17409a4 Diff: https://reviews.apache.org/r/46120/diff/ Testing --- testing.. Thanks, Hitesh Khamesra

Re: Review Request 46232: GEODE-1174 CI failure: UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer

> On April 15, 2016, 4:24 p.m., Hitesh Khamesra wrote: > > I was trying to ignore this while fixing DurableClient issues. As it can > > increase client cache close time. We may want to track why client didn't > > send close message, i mean is there any thread

Re: Review Request 46232: GEODE-1174 CI failure: UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer

DurableClient issues. As it can increase client cache close time. We may want to track why client didn't send close message, i mean is there any thread which is just closing the connection without sending close message to server.Otherwise it look good. - Hitesh Khamesra On April 14, 2016, 11:06 p.m

Re: Review Request 46120: GEODE-1150 LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime(Seems locator unable to join cluster)

(Line 1975) - Hitesh Khamesra On April 12, 2016, 10:47 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46120/ >

Re: Review Request 46120: GEODE-1150 LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime(Seems locator unable to join cluster)

/ Testing --- testing.. Thanks, Hitesh Khamesra

Review Request 46120: GEODE-1150 LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime(Seems locator unable to join cluster)

/membership/gms/membership/GMSJoinLeave.java d91b247 geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5 Diff: https://reviews.apache.org/r/46120/diff/ Testing --- testing.. Thanks, Hitesh Khamesra

Re: Review Request 46108: GEODE-1216 Fix the scalability of remove member

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46108/#review128557 --- Ship it! Ship It! - Hitesh Khamesra On April 12, 2016, 6:51

Re: Review Request 46056: GEODE-1178 Unexpected DistributedSystemDisconnectedException caused by RejectedExecutionException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46056/#review128454 --- Ship it! Ship It! - Hitesh Khamesra On April 12, 2016, 3:51

Re: Review Request 46056: GEODE-1178 Unexpected DistributedSystemDisconnectedException caused by RejectedExecutionException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46056/#review128292 --- Ship it! Ship It! - Hitesh Khamesra On April 11, 2016, 10

Re: Review Request 45844: GEODE-1187 If a server launched by Gfsh goes into auto-reconnect the server's PID file is deleted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45844/#review127515 --- Ship it! Ship It! - Hitesh Khamesra On April 6, 2016, 11:39

Re: Review Request 45503: GEODE-962: RestAPIsWithSSLDUnitTest.testMutualAuthentication CI failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45503/#review126665 --- Ship it! Ship It! - Hitesh Khamesra On March 30, 2016, 8:22

Review Request 45551: GEODE-1031 and GEODE-1149 make sure client is closing cache properly

/gemstone/gemfire/cache/client/internal/PoolImpl.java 84debc8 Diff: https://reviews.apache.org/r/45551/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 45449: GEODE-923 In test changed "System.currentTimeMillis" to "System.nanoTime()" as Connection mgr uses nantime

, Hitesh Khamesra

Review Request 45448: GEODE-337 Now test waits until client queue has been paused before restarting the client

/gemstone/gemfire/management/ClientHealthStatsDUnitTest.java 721be03 Diff: https://reviews.apache.org/r/45448/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45417/#review125891 --- Ship it! Ship It! - Hitesh Khamesra On March 29, 2016, 5:03

Re: Review Request 45307: GEODE-1129: DistributionManagerDUnitTest.testAckSevereAlertThreshold is disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45307/#review125333 --- Ship it! Ship It! - Hitesh Khamesra On March 24, 2016, 7:22

Re: Review Request 45142: GEODE-722 CI failure: Bug42039JUnitTest.testBug42039

many times.We can log all the threads exist before and after the test, that way, when next time test will fail will know which thread is extra. - Hitesh Khamesra On March 22, 2016, 1:10 a.m., Jianxia Chen wrote

Re: Review Request 45132: GEODE-1115 membership-port-range is not being established properly

I am coming from here "http://www.jgroups.org/manual/html/user-advanced.html; - Hitesh Khamesra On March 21, 2016, 11:25 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To r

Review Request 45131: GEODE-923 Validation for idle Timeout set properly.

/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java d0b2991 Diff: https://reviews.apache.org/r/45131/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 44938: GEODE-514 Make sure we look for quorum check only when networkPartition is enable.

/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc Diff: https://reviews.apache.org/r/44938/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 45047: GEODE-956 Product use log shows duplicate entries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45047/#review124278 --- Ship it! Ship It! - Hitesh Khamesra On March 18, 2016, 8:18

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

not initialized for other thread. But intention of that code was to remove all ack events. if possible fix that part as "pausedLock" can be taken other thread first. - Hitesh Khamesra On March 16, 2016, 7:53 p.m

Review Request 44940: GEODE-1100 Neglect view when it send by member which is not in current view.

/membership/gms/membership/GMSJoinLeave.java 2b7893e Diff: https://reviews.apache.org/r/44940/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

rintStackTrace(); } } this._messageQueue.initializeTransients(); } - Hitesh Khamesra On March 16, 2016, 7:53 p.m., anilkumar gingade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Review Request 44937: GEODE-515 Make sure that we connect to DS using same udp port.

/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc Diff: https://reviews.apache.org/r/44937/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 44939: GEODE-519 Make sure that membership port range is available.

: https://reviews.apache.org/r/44939/diff/ Testing --- Thanks, Hitesh Khamesra

Review Request 45053: GEODE-936 test is seeing DistributedSystemDisconnectedException exception

: https://reviews.apache.org/r/45053/diff/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 44562: GEODE-1053: Adding "filter" on Function Rest API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44562/#review123705 --- Ship it! Ship It! - Hitesh Khamesra On March 9, 2016, 6:38

Re: Review Request 44858: GEODE-639/640: CI failure: CacheXml80DUnitTest.testCacheServerEnableTcpNoDelay

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44858/#review123689 --- Ship it! Ship It! - Hitesh Khamesra On March 15, 2016, 4:55

  1   2   >