[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/435 ---

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-14 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224981272 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224970940 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224956283 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224955984 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224948342 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224952112 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread ahutsunshine
Github user ahutsunshine commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224951998 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-12 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224947629 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224620459 --- Diff: ui/angular/src/app/measure/create-measure/configuration/configuration.component.ts --- @@ -56,47 +56,47 @@ export class

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread gavlyukovskiy
Github user gavlyukovskiy commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224560857 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224482419 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224461843 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224461713 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224459867 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224481345 --- Diff: ui/angular/src/app/measure/create-measure/configuration/configuration.component.ts --- @@ -56,47 +56,47 @@ export class

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224479994 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-10 Thread chemikadze
GitHub user chemikadze opened a pull request: https://github.com/apache/incubator-griffin/pull/435 [GRIFFIN-206] fix job timezone when creating from UI Demonstration: ``` > new Date() Wed Oct 10 2018 11:30:48 GMT-0700 (Pacific Daylight Time) > new