[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Github user ahutsunshine commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224951998
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str)
{
return str.replaceAll(escapeHashTagPattern, hashTag);
}
+public static TimeZone getTimeZone(String timezone) {
+if (StringUtils.isEmpty(timezone)) {
+return TimeZone.getDefault();
+}
+return TimeZone.getTimeZone(timezone);
+}
+
}
--- End diff --
@chemikadze
I suggest this code be kept in its original place. Currently just modify ui
code to fix bug.
---
[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
[
https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648789#comment-16648789
]
ASF GitHub Bot commented on GRIFFIN-206:
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224952112
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str)
{
return str.replaceAll(escapeHashTagPattern, hashTag);
}
+public static TimeZone getTimeZone(String timezone) {
+if (StringUtils.isEmpty(timezone)) {
+return TimeZone.getDefault();
+}
+return TimeZone.getTimeZone(timezone);
+}
+
}
--- End diff --
@ahutsunshine Well, it's about time, it's utility function, static makes it
easier to test. Felt like it belongs here.
> Wrong sign of time zone offset when created from UI
> ---
>
> Key: GRIFFIN-206
> URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> Project: Griffin (Incubating)
> Issue Type: Bug
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Major
>
> When job is created from UI, time zone offset is created by this piece of
> code:
> {code:none}
> let time = new Date().getTimezoneOffset() / 60;
> let timezone = "GMT" + time + ":00";
> {code}
> Problem is, that for GMT-7 it yields positive number, resulting in calculated
> timezone to be GMT+7.
> Turns out that that some formats are not parsed properly, at least UTCXX:XX
> format used by UI is not processed correctly, and GMTXX:XX (without signs):
> {code:none}
> scala> java.util.TimeZone.getTimeZone("GMT6")
> res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("GMT+6")
> res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=2160,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC+6")
> res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224952112
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str)
{
return str.replaceAll(escapeHashTagPattern, hashTag);
}
+public static TimeZone getTimeZone(String timezone) {
+if (StringUtils.isEmpty(timezone)) {
+return TimeZone.getDefault();
+}
+return TimeZone.getTimeZone(timezone);
+}
+
}
--- End diff --
@ahutsunshine Well, it's about time, it's utility function, static makes it
easier to test. Felt like it belongs here.
---
Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP
+1 On Fri, Oct 12, 2018 at 5:39 PM William Guo wrote: > hi all, > > Please vote on the proposal for Apache Griffin graduation to TLP to submit > to > the Incubator PMC. > > Vote: > [ ] +1 - Recommend Graduation of Apache Griffin as a TLP > [ ] -1 - Do not recommend graduation of Apache Griffin because …. > > This vote will stay open for at least 72 hours. > > > At the mentors request they did a maturity model analysis [1] and wrote > contribution guidelines. [2] > > The Graduation Proposal was written and discussed on the dev list. [3] > > [1] > https://cwiki.apache.org/confluence/display/GRIFFIN/ASF+Maturity+Evaluation > > [2] http://griffin.incubator.apache.org/docs/contribute.html > > [3] > > https://lists.apache.org/thread.html/ba389dd1f7a9e8c82912d4dbf06abceda5461429806f5f7b112fc05d@%3Cdev.griffin.apache.org%3E > > > > Establish the Apache Griffin Project > > WHEREAS, the Board of Directors deems it to be in the best interests of > the Foundation and consistent with the Foundation's purpose to establish > a Project Management Committee charged with the creation and maintenance > of open-source software, for distribution at no charge to the public, > related to a data quality solution for big data, including both streaming > and batch mode. > It offers an unified process to measure data quality from different > perspectives. > > NOW, THEREFORE, BE IT RESOLVED, that a Project Management Committee > (PMC), to be known as the "Apache Griffin Project", be and hereby is > established pursuant to Bylaws of the Foundation; and be it further > > RESOLVED, that the Apache Griffin Project be and hereby is responsible > for the creation and maintenance of software related to a data quality > solution for big data, > including both streaming and batch mode. > It offers an unified process to measure data quality from different > perspectives; and be it further > > > RESOLVED, that the office of "Vice President, Apache Griffin" be and > hereby is created, the person holding such office to serve at the > direction of the Board of Directors as the chair of the Apache Griffin > Project, and to have primary responsibility for management of the > projects within the scope of responsibility of the Apache Griffin > Project; and be it further > > RESOLVED, that the persons listed immediately below be and hereby are > appointed to serve as the initial members of the Apache Griffin Project: > > * Alex Lv > * Deyi Yao > * Eugene Liu > * Grant Guo > * He Wang > * Henry Saputra > * Jason Liao > * John Liu > * Juan Li > * Liang Shao > * Lionel Liu > * Luciano Resende > * Nick Sokolov > * Shawn Sha > * Vincent Zhao > * William Guo > * Yuqin Xuan > > > NOW, THEREFORE, BE IT FURTHER RESOLVED, that William Guo be appointed > to the office of Vice President, Apache Griffin, to serve in accordance > with and subject to the direction of the Board of Directors and the > Bylaws of the Foundation until death, resignation, retirement, removal > or disqualification, or until a successor is appointed; and be it > further > > RESOLVED, that the initial Apache Griffin PMC be and hereby is tasked > with the creation of a set of bylaws intended to encourage open > development and increased participation in the Apache Griffin Project; > and be it further > > RESOLVED, that the Apache Griffin Project be and hereby is tasked with > the migration and rationalization of the Apache Incubator Griffin > podling; and be it further > > RESOLVED, that all responsibilities pertaining to the Apache Incubator > Griffin podling encumbered upon the Apache Incubator PMC are hereafter > discharged. > > > Thanks, > William Guo >
[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
[
https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648788#comment-16648788
]
ASF GitHub Bot commented on GRIFFIN-206:
Github user ahutsunshine commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224951998
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str)
{
return str.replaceAll(escapeHashTagPattern, hashTag);
}
+public static TimeZone getTimeZone(String timezone) {
+if (StringUtils.isEmpty(timezone)) {
+return TimeZone.getDefault();
+}
+return TimeZone.getTimeZone(timezone);
+}
+
}
--- End diff --
@chemikadze
I suggest this code be kept in its original place. Currently just modify ui
code to fix bug.
> Wrong sign of time zone offset when created from UI
> ---
>
> Key: GRIFFIN-206
> URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> Project: Griffin (Incubating)
> Issue Type: Bug
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Major
>
> When job is created from UI, time zone offset is created by this piece of
> code:
> {code:none}
> let time = new Date().getTimezoneOffset() / 60;
> let timezone = "GMT" + time + ":00";
> {code}
> Problem is, that for GMT-7 it yields positive number, resulting in calculated
> timezone to be GMT+7.
> Turns out that that some formats are not parsed properly, at least UTCXX:XX
> format used by UI is not processed correctly, and GMTXX:XX (without signs):
> {code:none}
> scala> java.util.TimeZone.getTimeZone("GMT6")
> res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("GMT+6")
> res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=2160,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC+6")
> res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
[
https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648866#comment-16648866
]
ASF GitHub Bot commented on GRIFFIN-206:
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224955984
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str)
{
return str.replaceAll(escapeHashTagPattern, hashTag);
}
+public static TimeZone getTimeZone(String timezone) {
+if (StringUtils.isEmpty(timezone)) {
+return TimeZone.getDefault();
+}
+return TimeZone.getTimeZone(timezone);
+}
+
}
--- End diff --
yes, it is utility function.
> Wrong sign of time zone offset when created from UI
> ---
>
> Key: GRIFFIN-206
> URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> Project: Griffin (Incubating)
> Issue Type: Bug
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Major
>
> When job is created from UI, time zone offset is created by this piece of
> code:
> {code:none}
> let time = new Date().getTimezoneOffset() / 60;
> let timezone = "GMT" + time + ":00";
> {code}
> Problem is, that for GMT-7 it yields positive number, resulting in calculated
> timezone to be GMT+7.
> Turns out that that some formats are not parsed properly, at least UTCXX:XX
> format used by UI is not processed correctly, and GMTXX:XX (without signs):
> {code:none}
> scala> java.util.TimeZone.getTimeZone("GMT6")
> res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("GMT+6")
> res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=2160,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC+6")
> res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224956533 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@ case class AccuracyExpr2DQSteps(context: DQContext, // 4. accuracy metric val accuracyTableName = ruleParam.getOutDfName() val matchedColName = details.getStringOrKey(_matched) + val matchedFractionColName = details.getStringOrKey(_matchedFraction) --- End diff -- @bhlx3lyx7 @chemikadze has this broken Apache Griffin UI side? Not sure how UI consume from ES. ---
[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224956565
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala
---
@@ -125,14 +126,20 @@ case class AccuracyExpr2DQSteps(context: DQContext,
// 4. accuracy metric
val accuracyTableName = ruleParam.getOutDfName()
val matchedColName = details.getStringOrKey(_matched)
+ val matchedFractionColName = details.getStringOrKey(_matchedFraction)
val accuracyMetricSql = procType match {
case BatchProcessType =>
s"""
- |SELECT `${totalCountTableName}`.`${totalColName}` AS
`${totalColName}`,
- |coalesce(`${missCountTableName}`.`${missColName}`, 0) AS
`${missColName}`,
- |(`${totalCountTableName}`.`${totalColName}` -
coalesce(`${missCountTableName}`.`${missColName}`, 0)) AS `${matchedColName}`
- |FROM `${totalCountTableName}` LEFT JOIN
`${missCountTableName}`
- """.stripMargin
+ SELECT A.total AS `${totalColName}`,
+A.miss AS `${missColName}`,
+(A.total - A.miss) AS `${matchedColName}`,
+coalesce( (A.total - A.miss) / A.total, 1.0) AS
`${matchedFractionColName}`
--- End diff --
add one more metrics, ok.
---
[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
[
https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648864#comment-16648864
]
ASF GitHub Bot commented on GRIFFIN-206:
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224948342
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
-let time = new Date().getTimezoneOffset() / 60;
-let timezone = "GMT" + time + ":00";
+let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
I have little concern about this.
1. if we want to get the timezone based on current time in browser, we need
to extract and rename the function as gettimezoneBasedonTime
2. why client want to control the schedule timezone, the timezone should be
owned by cluster, client should only need to control schedule time, right?
> Wrong sign of time zone offset when created from UI
> ---
>
> Key: GRIFFIN-206
> URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> Project: Griffin (Incubating)
> Issue Type: Bug
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Major
>
> When job is created from UI, time zone offset is created by this piece of
> code:
> {code:none}
> let time = new Date().getTimezoneOffset() / 60;
> let timezone = "GMT" + time + ":00";
> {code}
> Problem is, that for GMT-7 it yields positive number, resulting in calculated
> timezone to be GMT+7.
> Turns out that that some formats are not parsed properly, at least UTCXX:XX
> format used by UI is not processed correctly, and GMTXX:XX (without signs):
> {code:none}
> scala> java.util.TimeZone.getTimeZone("GMT6")
> res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("GMT+6")
> res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=2160,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC+6")
> res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224955984
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str)
{
return str.replaceAll(escapeHashTagPattern, hashTag);
}
+public static TimeZone getTimeZone(String timezone) {
+if (StringUtils.isEmpty(timezone)) {
+return TimeZone.getDefault();
+}
+return TimeZone.getTimeZone(timezone);
+}
+
}
--- End diff --
yes, it is utility function.
---
[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224948342
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
-let time = new Date().getTimezoneOffset() / 60;
-let timezone = "GMT" + time + ":00";
+let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
I have little concern about this.
1. if we want to get the timezone based on current time in browser, we need
to extract and rename the function as gettimezoneBasedonTime
2. why client want to control the schedule timezone, the timezone should be
owned by cluster, client should only need to control schedule time, right?
---
[jira] [Commented] (GRIFFIN-205) Accuracy measure check should provide matchedFraction to store
[
https://issues.apache.org/jira/browse/GRIFFIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648874#comment-16648874
]
ASF GitHub Bot commented on GRIFFIN-205:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-griffin/pull/434
> Accuracy measure check should provide matchedFraction to store
> --
>
> Key: GRIFFIN-205
> URL: https://issues.apache.org/jira/browse/GRIFFIN-205
> Project: Griffin (Incubating)
> Issue Type: Improvement
> Components: accuracy-batch, accuracy-real-time
>Affects Versions: 1.0.0-incubating
>Reporter: Artem Shutak
>Assignee: Artem Shutak
>Priority: Major
>
> Currently, {{accuracy}} measure results contains "total", "miss" and
> "matched" counts.
> As a result, It's hard to analyze accuracy fraction based on results stored
> in ElasticSearch, because ElasticSearch does not provide straight forward
> capability to get "field divided by field" query results.
> {{Accuracy}} measure results should also contain {{matchedFraction}} field.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP
+1 On Sat, 13 Oct 2018 at 13:49, He Wang wrote: > +1 > > On Fri, Oct 12, 2018 at 5:39 PM William Guo wrote: > > > hi all, > > > > Please vote on the proposal for Apache Griffin graduation to TLP to > submit > > to > > the Incubator PMC. > > > > Vote: > > [ ] +1 - Recommend Graduation of Apache Griffin as a TLP > > [ ] -1 - Do not recommend graduation of Apache Griffin because …. > > > > This vote will stay open for at least 72 hours. > > > > > > At the mentors request they did a maturity model analysis [1] and wrote > > contribution guidelines. [2] > > > > The Graduation Proposal was written and discussed on the dev list. [3] > > > > [1] > > > https://cwiki.apache.org/confluence/display/GRIFFIN/ASF+Maturity+Evaluation > > > > [2] http://griffin.incubator.apache.org/docs/contribute.html > > > > [3] > > > > > https://lists.apache.org/thread.html/ba389dd1f7a9e8c82912d4dbf06abceda5461429806f5f7b112fc05d@%3Cdev.griffin.apache.org%3E > > > > > > > > Establish the Apache Griffin Project > > > > WHEREAS, the Board of Directors deems it to be in the best interests of > > the Foundation and consistent with the Foundation's purpose to establish > > a Project Management Committee charged with the creation and maintenance > > of open-source software, for distribution at no charge to the public, > > related to a data quality solution for big data, including both streaming > > and batch mode. > > It offers an unified process to measure data quality from different > > perspectives. > > > > NOW, THEREFORE, BE IT RESOLVED, that a Project Management Committee > > (PMC), to be known as the "Apache Griffin Project", be and hereby is > > established pursuant to Bylaws of the Foundation; and be it further > > > > RESOLVED, that the Apache Griffin Project be and hereby is responsible > > for the creation and maintenance of software related to a data quality > > solution for big data, > > including both streaming and batch mode. > > It offers an unified process to measure data quality from different > > perspectives; and be it further > > > > > > RESOLVED, that the office of "Vice President, Apache Griffin" be and > > hereby is created, the person holding such office to serve at the > > direction of the Board of Directors as the chair of the Apache Griffin > > Project, and to have primary responsibility for management of the > > projects within the scope of responsibility of the Apache Griffin > > Project; and be it further > > > > RESOLVED, that the persons listed immediately below be and hereby are > > appointed to serve as the initial members of the Apache Griffin Project: > > > > * Alex Lv > > * Deyi Yao > > * Eugene Liu > > * Grant Guo > > * He Wang > > * Henry Saputra > > * Jason Liao > > * John Liu > > * Juan Li > > * Liang Shao > > * Lionel Liu > > * Luciano Resende > > * Nick Sokolov > > * Shawn Sha > > * Vincent Zhao > > * William Guo > > * Yuqin Xuan > > > > > > NOW, THEREFORE, BE IT FURTHER RESOLVED, that William Guo be appointed > > to the office of Vice President, Apache Griffin, to serve in accordance > > with and subject to the direction of the Board of Directors and the > > Bylaws of the Foundation until death, resignation, retirement, removal > > or disqualification, or until a successor is appointed; and be it > > further > > > > RESOLVED, that the initial Apache Griffin PMC be and hereby is tasked > > with the creation of a set of bylaws intended to encourage open > > development and increased participation in the Apache Griffin Project; > > and be it further > > > > RESOLVED, that the Apache Griffin Project be and hereby is tasked with > > the migration and rationalization of the Apache Incubator Griffin > > podling; and be it further > > > > RESOLVED, that all responsibilities pertaining to the Apache Incubator > > Griffin podling encumbered upon the Apache Incubator PMC are hereafter > > discharged. > > > > > > Thanks, > > William Guo > > >
[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction
Github user bhlx3lyx7 commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224957455 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@ case class AccuracyExpr2DQSteps(context: DQContext, // 4. accuracy metric val accuracyTableName = ruleParam.getOutDfName() val matchedColName = details.getStringOrKey(_matched) + val matchedFractionColName = details.getStringOrKey(_matchedFraction) --- End diff -- As I know, UI calculates the matched fraction by total and matched count, in ES the metrics are just persisted in JSON format, it's OK to add a field here. ---
[GitHub] incubator-griffin pull request #432: Fix a little doc bug concerning measure...
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/432#discussion_r224948476 --- Diff: griffin-doc/measure/measure-streaming-sample.md --- @@ -18,7 +18,7 @@ under the License. --> # Measure Streaming Sample -Measures consists of batch measure and streaming measure. This document is for the streaming measure sample. +Griffin measures consist of batch measure and streaming measure, this document merely gives the streaming measure sample. --- End diff -- Please use Apache Griffin instead of Griffin. we must use Apache Griffin at the same time as trademark. ---
[GitHub] incubator-griffin pull request #432: Fix a little doc bug concerning measure...
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/432#discussion_r224948471 --- Diff: griffin-doc/measure/measure-batch-sample.md --- @@ -18,7 +18,7 @@ under the License. --> # Measure Batch Sample -Measures consists of batch measure and streaming measure. This document is for the batch measure sample. +Griffin measures consist of batch measure and streaming measure, this document merely gives the batch measure sample. --- End diff -- Please use Apache Griffin instead of Griffin. we must use Apache Griffin at the same time as trademark. ---
[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224956283
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
-let time = new Date().getTimezoneOffset() / 60;
-let timezone = "GMT" + time + ":00";
+let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
IC, this timezone is used for data partition. but can we tell user this
critical information in the page?
---
[jira] [Commented] (GRIFFIN-205) Accuracy measure check should provide matchedFraction to store
[
https://issues.apache.org/jira/browse/GRIFFIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648899#comment-16648899
]
Lionel Liu commented on GRIFFIN-205:
In my opinion, the "total", "miss" and "matched" counts in accuracy measure
results are raw metrics, they could be aggregated in later calculation. But the
"matchedFraction" field is a calculated metrics, which could not be used in
later aggregation. Combining these metrics in the same metric value might
mislead the users.
I think it's OK to add "matchedFraction" field in accuracy metrics, but we need
to clarify the difference between the count metric and fraction metric in
document.
BTW, if we add this field in batch mode, it would be better to keep the
consistency in streaming mode as well.
> Accuracy measure check should provide matchedFraction to store
> --
>
> Key: GRIFFIN-205
> URL: https://issues.apache.org/jira/browse/GRIFFIN-205
> Project: Griffin (Incubating)
> Issue Type: Improvement
> Components: accuracy-batch, accuracy-real-time
>Affects Versions: 0.3.1-incubating
>Reporter: Artem Shutak
>Assignee: Artem Shutak
>Priority: Major
>
> Currently, {{accuracy}} measure results contains "total", "miss" and
> "matched" counts.
> As a result, It's hard to analyze accuracy fraction based on results stored
> in ElasticSearch, because ElasticSearch does not provide straight forward
> capability to get "field divided by field" query results.
> {{Accuracy}} measure results should also contain {{matchedFraction}} field.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
[
https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649102#comment-16649102
]
ASF GitHub Bot commented on GRIFFIN-206:
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224970940
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
-let time = new Date().getTimezoneOffset() / 60;
-let timezone = "GMT" + time + ":00";
+let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
@guoyuepeng @ashutakGG Moved to utility function. Angular is not my
specialty, I was really surprised how much complexity Angular community has
about it.
> Wrong sign of time zone offset when created from UI
> ---
>
> Key: GRIFFIN-206
> URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> Project: Griffin (Incubating)
> Issue Type: Bug
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Major
>
> When job is created from UI, time zone offset is created by this piece of
> code:
> {code:none}
> let time = new Date().getTimezoneOffset() / 60;
> let timezone = "GMT" + time + ":00";
> {code}
> Problem is, that for GMT-7 it yields positive number, resulting in calculated
> timezone to be GMT+7.
> Turns out that that some formats are not parsed properly, at least UTCXX:XX
> format used by UI is not processed correctly, and GMTXX:XX (without signs):
> {code:none}
> scala> java.util.TimeZone.getTimeZone("GMT6")
> res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("GMT+6")
> res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=2160,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC+6")
> res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224970940
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
-let time = new Date().getTimezoneOffset() / 60;
-let timezone = "GMT" + time + ":00";
+let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
@guoyuepeng @ashutakGG Moved to utility function. Angular is not my
specialty, I was really surprised how much complexity Angular community has
about it.
---
Re: [jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
don't worry, we can do it in angular side.
On Sun, Oct 14, 2018 at 4:17 AM ASF GitHub Bot (JIRA)
wrote:
>
> [
> https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649102#comment-16649102
> ]
>
> ASF GitHub Bot commented on GRIFFIN-206:
>
>
> Github user chemikadze commented on a diff in the pull request:
>
>
> https://github.com/apache/incubator-griffin/pull/435#discussion_r224970940
>
> --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts
> ---
> @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
> AfterViewChecked {
>return false;
> }
> this.measureid = this.getMeasureId();
> -let time = new Date().getTimezoneOffset() / 60;
> -let timezone = "GMT" + time + ":00";
> +let time = -(new Date().getTimezoneOffset() / 60);
> --- End diff --
>
> @guoyuepeng @ashutakGG Moved to utility function. Angular is not my
> specialty, I was really surprised how much complexity Angular community has
> about it.
>
>
> > Wrong sign of time zone offset when created from UI
> > ---
> >
> > Key: GRIFFIN-206
> > URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> > Project: Griffin (Incubating)
> > Issue Type: Bug
> >Reporter: Nikolay Sokolov
> >Assignee: Nikolay Sokolov
> >Priority: Major
> >
> > When job is created from UI, time zone offset is created by this piece
> of code:
> > {code:none}
> > let time = new Date().getTimezoneOffset() / 60;
> > let timezone = "GMT" + time + ":00";
> > {code}
> > Problem is, that for GMT-7 it yields positive number, resulting in
> calculated timezone to be GMT+7.
> > Turns out that that some formats are not parsed properly, at least
> UTCXX:XX format used by UI is not processed correctly, and GMTXX:XX
> (without signs):
> > {code:none}
> > scala> java.util.TimeZone.getTimeZone("GMT6")
> > res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > scala> java.util.TimeZone.getTimeZone("GMT+6")
> > res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=2160,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > scala> java.util.TimeZone.getTimeZone("UTC+6")
> > res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> > res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > {code}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
