[GitHub] guacamole-server pull request #207: GUACAMOLE-673: Create automatically need...

2018-12-03 Thread dejan032
GitHub user dejan032 opened a pull request: https://github.com/apache/guacamole-server/pull/207 GUACAMOLE-673: Create automatically needed directory for file transfer. Automatically create transfer folder in guacd file system when user is logged in to rdp, so that the transfer netwo

[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-12-03 Thread andrin-jost
Github user andrin-jost commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/204#discussion_r238549377 --- Diff: src/protocols/rdp/keymaps/de_ch_qwertz.keymap --- @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238508851 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB], '$(

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507952 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB], '$(

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507999 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB], '$(

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507820 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB], '$(

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507693 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB], '$(

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507594 --- Diff: src/guacd/daemon.c --- @@ -275,6 +281,17 @@ int main(int argc, char* argv[]) { /* General */ int retval; +#ifdef P

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507556 --- Diff: src/guacd/daemon.c --- @@ -19,6 +19,12 @@ #include "config.h" +#ifdef PTHREAD_STACK_SIZE +#define _GNU_SOURCE 1 -

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238507157 --- Diff: src/guacd/daemon.c --- @@ -275,6 +281,17 @@ int main(int argc, char* argv[]) { /* General */ int retval; +#ifdef P

Re: Help with CAS Module Regression

2018-12-03 Thread Nick Couchman
On Mon, Dec 3, 2018 at 10:51 AM Nick Couchman wrote: > On Mon, Dec 3, 2018 at 10:49 AM Mike Jumper wrote: > >> Did this error occur in 0.9.14? >> >> If this is breaking things, and did not occur when CAS support was >> initially released, I'd suggest a git bisect to narrow down when it >> starte

Re: Help with CAS Module Regression

2018-12-03 Thread Nick Couchman
On Mon, Dec 3, 2018 at 3:57 PM Nick Couchman wrote: > On Mon, Dec 3, 2018 at 10:51 AM Nick Couchman wrote: > >> On Mon, Dec 3, 2018 at 10:49 AM Mike Jumper wrote: >> >>> Did this error occur in 0.9.14? >>> >>> If this is breaking things, and did not occur when CAS support was >>> initially rele

Re: Help with CAS Module Regression

2018-12-03 Thread Nick Couchman
On Mon, Dec 3, 2018 at 10:49 AM Mike Jumper wrote: > Did this error occur in 0.9.14? > > If this is breaking things, and did not occur when CAS support was > initially released, I'd suggest a git bisect to narrow down when it > started. > > I believe everything worked fine in 0.9.14, and that som

Re: Help with CAS Module Regression

2018-12-03 Thread Mike Jumper
On Sun, Dec 2, 2018 at 1:48 PM Nick Couchman wrote: > > Okay, banging my head against the wall here trying to figure out what's > going on with the CAS module. At this point the redirect doesn't work at > all - the CAS module just sits on the screen with the non-translated > message: > > {{ 'LOGI

[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/204#discussion_r238316700 --- Diff: src/protocols/rdp/keymaps/de_ch_qwertz.keymap --- @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] guacamole-client pull request #341: GUACAMOLE-670: Add slf4j logging to CAS ...

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-client/pull/341 ---

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238167956 --- Diff: src/guacd/daemon.c --- @@ -275,6 +281,17 @@ int main(int argc, char* argv[]) { /* General */ int retval; +

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238170624 --- Diff: src/guacd/daemon.c --- @@ -19,6 +19,12 @@ #include "config.h" +#ifdef PTHREAD_STACK_SIZE +#define _GNU_SOURCE

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238171069 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB]

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238171680 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB]

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238170864 --- Diff: src/guacd/daemon.c --- @@ -275,6 +281,17 @@ int main(int argc, char* argv[]) { /* General */ int retval; +

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238172953 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB]

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238168882 --- Diff: src/guacd/daemon.c --- @@ -275,6 +281,17 @@ int main(int argc, char* argv[]) { /* General */ int retval; +

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238172374 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB]

[GitHub] guacamole-server pull request #206: GUACAMOLE-663: guacd SEGVs intermittentl...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/206#discussion_r238171724 --- Diff: configure.ac --- @@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE], '-I$(top_srcdir)/src/common-ssh') AC_SUBST([TERMINAL_LTLIB]