chisatohasimoto opened a new pull request #413: Add Japanese language support
URL: https://github.com/apache/guacamole-client/pull/413
Added Japanese language support for guacamole-client.
This is an automated message from
mike-jumper commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r295077837
##
File path: src/common-ssh/common-ssh/ssh.h
##
@@ -25,6 +25,20 @@
Yes, fair comment!
This business of adding extensions is fraught with difficulty ;)
You're right about using inline-block. My preferred solution would be to
use flexbox, but that probably doesn't have quite high enough browser
support for the project (96%).
I can fix my extension by floating my
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r295047012
##
File path: src/common-ssh/common-ssh/ssh.h
##
@@ -25,6 +25,20 @@
mike-jumper commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294979656
##
File path: src/common-ssh/common-ssh/ssh.h
##
@@ -25,6 +25,20 @@
Probably don't need Jersey. Will have some time to investigate now. I just
knew that if I took that version, it would be compatible, rather than
having to hunt through and work out which version to use. ;)
M.
.
On Tue, 18 Jun 2019 at 19:57, Mike Jumper wrote:
> On Tue, Jun 18, 2019 at 10:30
Perfect!
I was actually quite happy with the interpolation binding (fixing the
identifier on each line) and had no idea it wasn't allowed!
Many thanks,
M.
.
On Tue, 18 Jun 2019 at 19:45, Mike Jumper wrote:
> On Tue, Jun 18, 2019 at 11:14 AM Mark Nolan wrote:
>
> > ...
> > The browser
On Tue, Jun 18, 2019 at 10:30 AM Mark Nolan wrote:
> There were no other errors at all!
>
> For a moment I was very excited that I might have forgotten to update that
> dependency, but I hadn't been that stupid (wouldn't have been the first
> time!). I didn't know whether to be relieved or
On Tue, Jun 18, 2019 at 11:14 AM Mark Nolan wrote:
> ...
> The browser console shows this:
>
> angular.js:14800 Error: [$parse:syntax]
>
> http://errors.angularjs.org/1.6.9/$parse/syntax?p0=%7B=invalid%20key=17=xxxAuthGcpStop(%7B%7Bitem.identifier%7D%7D)=%7Bitem.identifier%7D%7D
> )
> at
I am getting multiple parse errors from AngularJS. I know 1.0.0 upgraded
AngularJS and I'm off to look through the notes now, but if anyone knows
what causes this, you could save me a lot of time!
Everything I know about AngularJS I have learned by looking at what
Guacamole does or through
There were no other errors at all!
For a moment I was very excited that I might have forgotten to update that
dependency, but I hadn't been that stupid (wouldn't have been the first
time!). I didn't know whether to be relieved or frustrated!
Anyway, I created a minimal version and went through
necouchman commented on issue #201: GUACAMOLE-547: Add support for SSH NONE
authentication method
URL: https://github.com/apache/guacamole-server/pull/201#issuecomment-503072533
@mike-jumper Okay, fixed up the stuff you requested - let me know if
anything else needs work. Also rebased on
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294760735
##
File path: src/protocols/ssh/ssh.c
##
@@ -130,26 +130,36 @@ static
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294760441
##
File path: src/common-ssh/ssh.c
##
@@ -304,23 +304,30 @@ static int
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294759904
##
File path: src/common-ssh/ssh.c
##
@@ -416,7 +427,7 @@ static int
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294759585
##
File path: src/protocols/ssh/ssh.c
##
@@ -130,26 +130,36 @@ static
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294759105
##
File path: src/common-ssh/ssh.c
##
@@ -352,14 +359,18 @@ static int
necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294758881
##
File path: src/common-ssh/common-ssh/ssh.h
##
@@ -99,7 +109,7 @@ void
18 matches
Mail list logo
