[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182291437 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnection.java --- @@ -0,0 +1,87

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182292287 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/services/quickConnectService.js --- @@ -0,0 +1,66

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182293749 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,187

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182294077 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,187

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182293830 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,187

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182294534 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,187

[GitHub] guacamole-manual pull request #86: GUACAMOLE-42: Document GUACD_LOG_LEVEL va...

2018-03-31 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-manual/pull/86 GUACAMOLE-42: Document GUACD_LOG_LEVEL variable. Document the newly-added GUACD_LOG_LEVEL environment variable. You can merge this pull request into a Git repository by running

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-31 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178438303 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-03-31 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-manual/pull/87 GUACAMOLE-38: Add chapter for Quickconnect extension. Adds the chapter for the quickconnect extension. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] guacamole-server pull request #161: GUACAMOLE-42: Add support for specifying...

2018-03-29 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-server/pull/161 GUACAMOLE-42: Add support for specifying log level to guacd in docker Small changes to allow the guacd log level to be passed through as an environment variable. Not entirely sure

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178039519 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r176918401 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #155: GUACAMOLE-446: Allow redirected drive na...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/155#discussion_r176919439 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.h --- @@ -42,7 +42,7 @@ * Registers a new filesystem device within the RDPDR

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176921682 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectAuthenticationProvider.java

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176926889 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/styles/quickconnect.css --- @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176926882 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r176917434 --- Diff: src/protocols/ssh/ttymode.h --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r176918817 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +143,25 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176921492 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectConnectionGroup.java

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r176918408 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r176919230 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +143,25 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176924292 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176924286 --- Diff: extensions/guacamole-auth-quickconnect/pom.xml --- @@ -0,0 +1,209 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176924294 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176924407 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176926671 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/templates/quickconnectField.html --- @@ -0,0 +1,9

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178541081 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) { } +/* Set up

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178542688 --- Diff: src/protocols/ssh/ssh.c --- @@ -191,6 +192,10 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178542720 --- Diff: src/protocols/ssh/ssh.c --- @@ -191,6 +192,10 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178540964 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) { } +/* Set up

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178530634 --- Diff: src/terminal/terminal.c --- @@ -1594,7 +1598,13 @@ static int __guac_terminal_send_key(guac_terminal* term, int keysym, int pressed

[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/259#discussion_r178643938 --- Diff: guacamole/src/main/webapp/translations/en.json --- @@ -447,6 +448,9 @@ "FIELD_HEADER_TYPESCRIPT_NAME" : "

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178622107 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178622074 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +299,17 @@ void* ssh_client_thread(void* data) { } +/* Set up

[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/259#discussion_r178640795 --- Diff: guacamole/src/main/webapp/translations/en.json --- @@ -447,6 +448,9 @@ "FIELD_HEADER_TYPESCRIPT_NAME" : "

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178621626 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +299,17 @@ void* ssh_client_thread(void* data) { } +/* Set up

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r178643311 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +143,25 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r178701688 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +143,25 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178531096 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178533605 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178045959 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178045884 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178056624 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178052016 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178056419 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178081985 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178082252 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176950410 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176926472 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectAuthenticationProvider.java

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176950390 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176950360 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,169

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175180850 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175185303 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnection.java --- @@ -0,0 +1,181

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175181207 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnection.java --- @@ -0,0 +1,181

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175207725 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] +Description=Guacamole Server +Documentation=man:guacd(8

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175207766 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] --- End diff -- Probably so...will add it. ---

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175213905 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] --- End diff -- Added. ---

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175312540 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175312723 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java --- @@ -0,0

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175313519 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-03-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r172005983 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +142,23 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-03-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r172006140 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +142,23 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-02-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r170931914 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -273,3 +273,15 @@ void guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-02-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r170931972 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -273,3 +273,15 @@ void guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-02-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r170931887 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +141,20 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r170947545 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-client pull request #254: GUACAMOLE-103: Implement SAML Authentica...

2018-06-28 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/254#discussion_r198765764 --- Diff: extensions/guacamole-auth-saml/src/main/java/org/apache/guacamole/auth/saml/conf/ConfigurationService.java --- @@ -0,0 +1,223

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-30 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221438180 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-30 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221436490 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/RelatedObjectSet.java

[GitHub] guacamole-server pull request #196: GUACAMOLE-527: Correct order of SFTP par...

2018-10-16 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-server/pull/196 GUACAMOLE-527: Correct order of SFTP parameters in VNC. Corrects the order of parameters in the VNC settings that I believe was causing issues with VNC known host checking

[GitHub] guacamole-server pull request #198: GUACAMOLE-630: Allow color scheme of act...

2018-11-09 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/198#discussion_r232439189 --- Diff: src/protocols/ssh/argv.c --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #198: GUACAMOLE-630: Allow color scheme of act...

2018-11-09 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/198#discussion_r232438968 --- Diff: src/protocols/ssh/argv.c --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #200: GUACAMOLE-630: Allow font parameters of ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/200#discussion_r232485885 --- Diff: src/protocols/ssh/argv.c --- @@ -81,16 +110,51 @@ static int guac_ssh_argv_blob_handler(guac_user* user, static int

[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

2018-11-06 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/199#discussion_r231131516 --- Diff: src/protocols/ssh/ssh.c --- @@ -320,6 +320,17 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232737279 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232737390 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232507335 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1281,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232507326 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp

[GitHub] guacamole-server pull request #201: GUACAMOLE-547: Add support for SSH NONE ...

2018-11-11 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-server/pull/201 GUACAMOLE-547: Add support for SSH NONE authentication method I'm not 100% certain that this is all that's needed, because I don't have a SSH server to test this against

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504348 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504386 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -356,6 +357,11 @@ enum RDP_ARGS_IDX { */ IDX_PRECONNECTION_BLOB

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504354 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,10 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504364 --- Diff: src/protocols/ssh/settings.h --- @@ -253,6 +253,10 @@ typedef struct guac_ssh_settings { * environment variable

[GitHub] guacamole-server pull request #201: GUACAMOLE-547: Add support for SSH NONE ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/201#discussion_r232504438 --- Diff: src/common-ssh/ssh.c --- @@ -321,6 +321,10 @@ static int guac_common_ssh_authenticate(guac_common_ssh_session* common_session

[GitHub] guacamole-server pull request #201: GUACAMOLE-547: Add support for SSH NONE ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/201#discussion_r232504541 --- Diff: src/common-ssh/ssh.c --- @@ -321,6 +321,10 @@ static int guac_common_ssh_authenticate(guac_common_ssh_session* common_session

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232741345 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,17 @@ void* ssh_client_thread(void* data) { return NULL

[GitHub] guacamole-client pull request #328: GUACAMOLE-232: Address regressions in ha...

2018-10-03 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/328#discussion_r222318256 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -953,37 +1006,58 @@ Guacamole.Keyboard = function Keyboard(element

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-28 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221253121 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-10-01 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r221599026 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission

[GitHub] guacamole-client pull request #320: Guacamole-626 - Add support for Docker s...

2018-09-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/320#discussion_r219650390 --- Diff: guacamole-docker/README.md --- @@ -28,14 +28,25 @@ Once the Guacamole image is running, Guacamole will be accessible at `-p 8080

[GitHub] guacamole-client pull request #320: Guacamole-626 - Add support for Docker s...

2018-09-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/320#discussion_r219652878 --- Diff: guacamole-docker/README.md --- @@ -90,6 +107,9 @@ the image will stop: 1. `MYSQL_DATABASE` - The name of the database to use

[GitHub] guacamole-client pull request #320: Guacamole-626 - Add support for Docker s...

2018-09-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/320#discussion_r219652862 --- Diff: guacamole-docker/README.md --- @@ -90,6 +107,9 @@ the image will stop: 1. `MYSQL_DATABASE` - The name of the database to use

[GitHub] guacamole-client pull request #320: Guacamole-626 - Add support for Docker s...

2018-09-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/320#discussion_r219652808 --- Diff: guacamole-docker/README.md --- @@ -45,6 +56,9 @@ the image will stop: 1. `POSTGRES_DATABASE` - The name of the database to use

[GitHub] guacamole-client pull request #320: Guacamole-626 - Add support for Docker s...

2018-09-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/320#discussion_r219652842 --- Diff: guacamole-docker/README.md --- @@ -45,6 +56,9 @@ the image will stop: 1. `POSTGRES_DATABASE` - The name of the database to use

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-26 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220506258 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/org/apache/guacamole/auth/jdbc/connection

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-26 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220513791 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml --- @@ -109,33 +109,33

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220395046 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220397742 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/org/apache/guacamole/auth/jdbc/connection

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220396450 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/upgrade/upgrade-pre-1.0.0.sql --- @@ -17,6 +17,319

[GitHub] guacamole-client pull request #319: GUACAMOLE-220: Add database support for ...

2018-09-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/319#discussion_r220395193 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup

<    1   2   3   4   5   >