ok2c merged PR #374:
URL: https://github.com/apache/httpcomponents-core/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apac
dependabot[bot] opened a new pull request, #393:
URL: https://github.com/apache/httpcomponents-client/pull/393
Bumps [ehcache-api](https://github.com/ehcache/ehcache3) from 3.10.2 to
3.10.3.
Commits
https://github.com/ehcache/ehcache3/commit/03b2e8754ff2d3450fd18a3f74c35c3c006d
davewichers commented on PR #387:
URL:
https://github.com/apache/httpcomponents-client/pull/387#issuecomment-1312248721
@ok2c - Why are you ignoring the suggestion to upgrade to the 2.x version of
this library? This is causing Dependency Convergence conflicts with other
libraries that are
ok2c commented on PR #387:
URL:
https://github.com/apache/httpcomponents-client/pull/387#issuecomment-1312423027
@davewichers Are you suggesting I should do a major upgrade of a dependency
in the middle of the development cycle?
--
This is an automated message from the Apache Git Service
michael-o opened a new pull request, #375:
URL: https://github.com/apache/httpcomponents-core/pull/375
Previously, text-based content was many times encoded with ISO-8859-1. This
has gradually fallen out of use in the past 10 to 15 years. Use US-ASCII where
a 7-bit encoding scheme is requir
michael-o commented on PR #375:
URL:
https://github.com/apache/httpcomponents-core/pull/375#issuecomment-1312561783
As discussed in
[HTTPCLIENT-2244](https://issues.apache.org/jira/browse/HTTPCLIENT-2244).
--
This is an automated message from the Apache Git Service.
To respond to the mes
rschmitt commented on PR #387:
URL:
https://github.com/apache/httpcomponents-client/pull/387#issuecomment-1312646873
My understanding is that the _API_ of Slf4j 2 is backwards compatible with
that of 1.7, but the _bytecode_ is not because Slf4j 2 requires JDK8. What I
don't understand is w
davewichers commented on PR #387:
URL:
https://github.com/apache/httpcomponents-client/pull/387#issuecomment-1313874158
@rschmitt - In general, with a pom file you specify the specific version. I
believe pom's allow you to specify a minimum, but the risk is that if the
library releases a n
carterkozak commented on PR #387:
URL:
https://github.com/apache/httpcomponents-client/pull/387#issuecomment-1313887796
The biggest problem is that slf4j 2.x requires a different mechanism to bind
the api to a logging implementation. Forcing services to upgrade the API will
potentially cau
bryanck opened a new pull request, #394:
URL: https://github.com/apache/httpcomponents-client/pull/394
This PR addresses an issue when interrupting a thread when using an
`HttpClient` with the `PoolingHttpClientConnectionManager`. If the pool reaches
the max size, and the client is waiting
michael-o commented on PR #394:
URL:
https://github.com/apache/httpcomponents-client/pull/394#issuecomment-1314042710
Interesting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ok2c commented on PR #394:
URL:
https://github.com/apache/httpcomponents-client/pull/394#issuecomment-1314389422
@bryanck Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ok2c merged PR #394:
URL: https://github.com/apache/httpcomponents-client/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
dependabot[bot] opened a new pull request, #395:
URL: https://github.com/apache/httpcomponents-client/pull/395
Bumps
[actions/dependency-review-action](https://github.com/actions/dependency-review-action)
from 2 to 3.
Release notes
Sourced from https://github.com/actions/dependenc
dependabot[bot] opened a new pull request, #396:
URL: https://github.com/apache/httpcomponents-client/pull/396
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to 4.9.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
relea
dependabot[bot] opened a new pull request, #397:
URL: https://github.com/apache/httpcomponents-client/pull/397
Bumps [ehcache-api](https://github.com/ehcache/ehcache3) from 3.10.2 to
3.10.6.
Commits
https://github.com/ehcache/ehcache3/commit/9b9a03b95f159667c9dca1f521614b331a14
dependabot[bot] commented on PR #393:
URL:
https://github.com/apache/httpcomponents-client/pull/393#issuecomment-1319967111
Superseded by #397.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] closed pull request #393: Bump ehcache-api from 3.10.2 to 3.10.3
URL: https://github.com/apache/httpcomponents-client/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dependabot[bot] opened a new pull request, #376:
URL: https://github.com/apache/httpcomponents-core/pull/376
Bumps
[actions/dependency-review-action](https://github.com/actions/dependency-review-action)
from 2 to 3.
Release notes
Sourced from https://github.com/actions/dependency-
dependabot[bot] opened a new pull request, #377:
URL: https://github.com/apache/httpcomponents-core/pull/377
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to 4.9.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
release
ok2c merged PR #376:
URL: https://github.com/apache/httpcomponents-core/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apac
ok2c closed pull request #307: Refactor duplicate patterns with new methods in
TimeValue
URL: https://github.com/apache/httpcomponents-core/pull/307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dependabot[bot] opened a new pull request, #398:
URL: https://github.com/apache/httpcomponents-client/pull/398
Bumps [ehcache-api](https://github.com/ehcache/ehcache3) from 3.10.2 to
3.10.8.
Commits
https://github.com/ehcache/ehcache3/commit/ac1bb6b5e384cb49a9b7eaefefa5db1cf254
dependabot[bot] commented on PR #397:
URL:
https://github.com/apache/httpcomponents-client/pull/397#issuecomment-1327447390
Superseded by #398.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] closed pull request #397: Bump ehcache-api from 3.10.2 to 3.10.6
URL: https://github.com/apache/httpcomponents-client/pull/397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
ok2c merged PR #395:
URL: https://github.com/apache/httpcomponents-client/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
ok2c merged PR #398:
URL: https://github.com/apache/httpcomponents-client/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
ok2c commented on PR #396:
URL:
https://github.com/apache/httpcomponents-client/pull/396#issuecomment-1328017013
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
ok2c opened a new pull request, #399:
URL: https://github.com/apache/httpcomponents-client/pull/399
@michael-o Please do another pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1340029979
Will take a look and test this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045580875
##
httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/TokenBearerAuthenticationHandler.java:
##
@@ -0,0 +1,44 @@
+/*
+ * ==
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045590335
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346274196
> Don't add runtime exceptions to method signatures. They belong into
Javadoc. See Effective Java from Joshua Bloch.
@ok2c I must say I disagree with Joshua Bloch in this
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045684393
##
httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/Authenticator.java:
##
@@ -31,6 +31,13 @@
public interface Authenticator {
+/
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045689705
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045722003
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346334453
> > Don't add runtime exceptions to method signatures. They belong into
Javadoc. See Effective Java from Joshua Bloch.
>
> @michael-o I must say I disagree with Joshu
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045738039
##
httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/BasicAuthenticationHandler.java:
##
@@ -27,13 +27,27 @@
package org.apache.hc.
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045756872
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045763985
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045775614
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045786273
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346436026
Two more questions left, I will try this in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045816086
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045817334
##
httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/BasicAuthenticationHandler.java:
##
@@ -27,13 +27,27 @@
package org.apache.hc.clien
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045824851
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045837033
##
httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/BasicAuthenticationHandler.java:
##
@@ -27,13 +27,27 @@
package org.apache.hc.
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347056473
@michael-o I have a feeling we are talking blondes vs brunettes here, but
have it the way you like it. Please review
--
This is an automated message from the Apache Git Servic
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046257968
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046260885
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347116449
> @michael-o I have a feeling we are talking blondes vs brunettes here, but
have it the way you like it. Please review
I like both, I am not picky :-D
--
This is a
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046267743
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046267743
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046269591
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046270523
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046272608
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/UsernamePasswordCredentials.java:
##
@@ -45,22 +45,36 @@ public class UsernamePasswordCreden
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347141146
@ok2c Can you explain why you use the `realm` parameter actively with Bearer
altough rfc6749 does not mention it once? I only see these:
https://datatracker.ietf.org/doc/ht
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347162852
> @ok2c Can you explain why you use the `realm` parameter actively with
Bearer altough rfc6749 does not mention it once? I only see these:
https://datatracker.ietf.org/doc/html/
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347170203
> > @ok2c Can you explain why you use the `realm` parameter actively with
Bearer altough rfc6749 does not mention it once? I only see these:
https://datatracker.ietf.org/do
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046296139
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046302493
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046339102
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * =
michael-o commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046341201
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,95 @@
+/*
+ * ==
ok2c commented on code in PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046343685
##
httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java:
##
@@ -0,0 +1,120 @@
+/*
+ * ==
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347258295
@michael-o what is it exactly that you want me to change now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347326058
> @michael-o what is it exactly that you want me to change now?
Only the `toString()` is questionable, the rest is fine. Let me give it a
shot tomorrow.
--
This is
ok2c merged PR #400:
URL: https://github.com/apache/httpcomponents-client/pull/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
Pluto-Whong closed pull request #401: Avoid being closed by the Evictor when
the connection is used.
URL: https://github.com/apache/httpcomponents-client/pull/401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] opened a new pull request, #402:
URL: https://github.com/apache/httpcomponents-client/pull/402
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to
4.10.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
rel
dependabot[bot] commented on PR #396:
URL:
https://github.com/apache/httpcomponents-client/pull/396#issuecomment-1354735219
Superseded by #402.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] closed pull request #396: Bump mockito-core from 4.8.1 to 4.9.0
URL: https://github.com/apache/httpcomponents-client/pull/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
dependabot[bot] opened a new pull request, #378:
URL: https://github.com/apache/httpcomponents-core/pull/378
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to
4.10.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
relea
dependabot[bot] commented on PR #377:
URL:
https://github.com/apache/httpcomponents-core/pull/377#issuecomment-1354866207
Superseded by #378.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #377: Bump mockito-core from 4.8.1 to 4.9.0
URL: https://github.com/apache/httpcomponents-core/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1355099174
OK, I gave it a shot. OIDC provider is Ping Identity and the target host
uses Spring Security. The good news, it works with no, invalid and valid
tokens. The following need
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1355338254
> The client has no chance to access response params from
https://datatracker.ietf.org/doc/html/rfc6750#section-3
@michael-o What do you mean exactly? Do you mean the clie
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1355593033
> > The client has no chance to access response params from
https://datatracker.ietf.org/doc/html/rfc6750#section-3
>
> @michael-o What do you mean exactly? Do you me
dependabot[bot] opened a new pull request, #379:
URL: https://github.com/apache/httpcomponents-core/pull/379
Bumps
[docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin) from
0.31.0 to 0.40.3.
Release notes
Sourced from https://github.com/fabric8io/docker-maven-pl
dependabot[bot] opened a new pull request, #403:
URL: https://github.com/apache/httpcomponents-client/pull/403
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to
4.11.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
rel
dependabot[bot] commented on PR #402:
URL:
https://github.com/apache/httpcomponents-client/pull/402#issuecomment-1367907720
Superseded by #403.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] closed pull request #402: Bump mockito-core from 4.8.1 to 4.10.0
URL: https://github.com/apache/httpcomponents-client/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dependabot[bot] commented on PR #378:
URL:
https://github.com/apache/httpcomponents-core/pull/378#issuecomment-1367934975
Superseded by #380.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #380:
URL: https://github.com/apache/httpcomponents-core/pull/380
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to
4.11.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
relea
dependabot[bot] closed pull request #378: Bump mockito-core from 4.8.1 to 4.10.0
URL: https://github.com/apache/httpcomponents-core/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
alturkovic opened a new pull request, #404:
URL: https://github.com/apache/httpcomponents-client/pull/404
Some implementations might depend on a variable present in the `HttpContext`
which is available in most other methods.
--
This is an automated message from the Apache Git Service.
To
ok2c commented on PR #404:
URL:
https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370957675
@alturkovic The change-set breaks backward compatibility with 5.0 APIs.
By the way, one may be better off writing a custom
`SSLConnectionSocketFactory` instead of trying
alturkovic commented on PR #404:
URL:
https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370959011
@ok2c Oops, added the method back. I understand, I just thought that having
`HttpContext` available by default made sense.
--
This is an automated message from the Apach
ok2c commented on PR #404:
URL:
https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370961882
@alturkovic Please deprecate the old method in favor of the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ok2c commented on PR #404:
URL:
https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370975027
@alturkovic Great. But please do it nicely and suppress deprecation warnings
in the new method.
--
This is an automated message from the Apache Git Service.
To respond to the
alturkovic commented on PR #404:
URL:
https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370980479
Sorry, I do not know what you mean by that, I took a look how other methods
are deprecated (i.e.:
`org.apache.hc.client5.http.ssl.ClientTlsStrategyBuilder#setTlsDetailsFac
ok2c commented on PR #404:
URL:
https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370987346
@alturkovic Please add `@SuppressWarnings("deprecation")` annotation to the
new method.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ok2c merged PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
ok2c merged PR #380:
URL: https://github.com/apache/httpcomponents-core/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apac
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374431955
@michael-o Out of curiosity, how long do you intend to block this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374432854
> @michael-o Out of curiosity, how long do you intend to block this PR?
??? There are still unresolved issues:
* `toString()` unnecessarily exposes the token
* `
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374436754
> > @michael-o Out of curiosity, how long do you intend to block this PR?
>
> ??? There are still unresolved issues:
>
Issues?
> * `toString()` unnece
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374437550
> > > @michael-o Out of curiosity, how long do you intend to block this PR?
> >
> >
> > ??? There are still unresolved issues:
>
> Issues?
>
> > ```
ok2c commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-137876
> > Why is this an issue, let alone a blocker?
>
> I bet there will be clowns complaining about this. I never wrote that this
is a blocker.
>
OK. This I can unde
michael-o commented on PR #399:
URL:
https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374477027
> > > Why is this an issue, let alone a blocker?
> >
> >
> > I bet there will be clowns complaining about this. I never wrote that
this is a blocker.
>
> O
MartinWitt opened a new pull request, #405:
URL: https://github.com/apache/httpcomponents-client/pull/405
# Repairing Code Style Issues
## InnerClassMayBeStatic
Inner classes that do not reference their enclosing instances can be made
static.
This prevents a common cause of memo
1 - 100 of 3506 matches
Mail list logo
