RE: Exceptions in Helix

Hi Sandeep, Yes, and I definitely appreciate you starting this thread. It's something that Helix doesn't really have right now and it's absolutely necessary for intuitive APIs. For reference, here are how some other projects tackle this (not necessarily Helix-related): Cassandra: https://gith

Re: Exceptions in Helix

Hi Kanak, Like I said the first stab was to start a conversation. So what you are pointing at is defining an exception based on the API invoked. So a NodeAlreadyExistsException can be thrown on an addNode API but that exception should specialization of the ConfigException to clearly indicate that

RE: Exceptions in Helix

My concern with this hierarchy is that it does a good job of describing what fails, but doesn't really hint at why. For instance, when trying to create a cluster that already exists, we would get something like a ClusterConfigException, and need to read javadocs to understand how it could be th

Exceptions in Helix

Hi guys, I sent out a mail last night (on the users maillist) that currently Instance configuration retrieval from HelixAdmin throws HelixException which is a runtime exception. I did not want to create a whole exception hierarchy for every API given my narrow scope of understanding but wanted to

[jira] [Commented] (HELIX-381) ClusterStateVerifier should support verifying a subset of resources

[ https://issues.apache.org/jira/browse/HELIX-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906484#comment-13906484 ] Hudson commented on HELIX-381: -- SUCCESS: Integrated in helix #1229 (See [https://builds.apach

helix - Build # 1229 - Fixed

The Apache Jenkins build system has built helix (build #1229) Status: Fixed Check console output at https://builds.apache.org/job/helix/1229/ to view the results.

[jira] [Commented] (HELIX-378) Add instance gauges to ClusterStatusMonitor

[ https://issues.apache.org/jira/browse/HELIX-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906192#comment-13906192 ] Hudson commented on HELIX-378: -- UNSTABLE: Integrated in helix #1228 (See [https://builds.apac

helix - Build # 1228 - Still Unstable

The Apache Jenkins build system has built helix (build #1228) Status: Still Unstable Check console output at https://builds.apache.org/job/helix/1228/ to view the results.

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/ --- (Updated Feb. 19, 2014, 1:41 p.m.) Review request for helix, Zhen Zhang and Kis

[jira] [Commented] (HELIX-378) Add instance gauges to ClusterStatusMonitor

[ https://issues.apache.org/jira/browse/HELIX-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906089#comment-13906089 ] Hudson commented on HELIX-378: -- UNSTABLE: Integrated in helix #1227 (See [https://builds.apac

helix - Build # 1227 - Still Unstable

The Apache Jenkins build system has built helix (build #1227) Status: Still Unstable Check console output at https://builds.apache.org/job/helix/1227/ to view the results.

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

> On Feb. 19, 2014, 6:39 p.m., Sandeep Nayak wrote: > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java, > > line 68 > > > > > > Why track the clusterId here if we are passing it i

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

> On Feb. 19, 2014, 10:39 a.m., Sandeep Nayak wrote: > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java, > > line 68 > > > > > > Why track the clusterId here if we are passing it

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/ --- (Updated Feb. 19, 2014, 11:43 a.m.) Review request for helix, Zhen Zhang and Ki

[jira] [Created] (HELIX-387) Create consistent failure behavior on the accessor classes

Kanak Biscuitwala created HELIX-387: --- Summary: Create consistent failure behavior on the accessor classes Key: HELIX-387 URL: https://issues.apache.org/jira/browse/HELIX-387 Project: Apache Helix

helix - Build # 1226 - Still Unstable

The Apache Jenkins build system has built helix (build #1226) Status: Still Unstable Check console output at https://builds.apache.org/job/helix/1226/ to view the results.

[jira] [Commented] (HELIX-360) ClusterAccessor#initClusterStructure uses (incorrect) duplicated code

[ https://issues.apache.org/jira/browse/HELIX-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905925#comment-13905925 ] Hudson commented on HELIX-360: -- UNSTABLE: Integrated in helix #1226 (See [https://builds.apac

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/#review34893 --- helix-core/src/main/java/org/apache/helix/api/accessor/AtomicPartic

Re: Review Request 16402: [HELIX-345] Speed up the controller pipelines for 0.7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16402/#review34896 --- Ship it! Ship It! - Zhen Zhang On Feb. 3, 2014, 6:47 p.m., Kanak

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

> On Feb. 19, 2014, 10:28 a.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java, > > line 60 > > > > > > Are we sacrificing the ability to plugin state store

Re: Review Request 18251: [HELIX-381] ClusterStateVerifier can now work with a subset of resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18251/#review34894 --- Ship it! can we add a test case for it? - Zhen Zhang On Feb. 19,

Re: Review Request 17961: [HELIX-378] Add instance gauges to ClusterStatusMonitor

> On Feb. 19, 2014, 10:26 a.m., Zhen Zhang wrote: > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java, > > line 345 > > > > > > why do we change the sensorName? This is by Todd's

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/#review34891 --- helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAcces

Re: Review Request 17961: [HELIX-378] Add instance gauges to ClusterStatusMonitor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17961/#review34889 --- helix-core/src/main/java/org/apache/helix/monitoring/mbeans/Cluster

Re: Review Request 17961: [HELIX-378] Add instance gauges to ClusterStatusMonitor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17961/#review34890 --- Ship it! Ship It! - Zhen Zhang On Feb. 11, 2014, 11:18 p.m., Kan

Re: Review Request 17670: [HELIX-360] Remove code duplication for list of required paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/#review34884 --- Ship it! Ship It! - Zhen Zhang On Feb. 3, 2014, 7:25 p.m., Kanak