Re: [Announce] New committer : David Mollitor

2019-09-12 Thread Andrew Sherman
Congratulations David, you deserve this! On Thu, Sep 12, 2019 at 2:19 AM Peter Vary wrote: > Congratulations David! > > Ashutosh Chauhan ezt írta (időpont: 2019. szept. > 12., Csü 1:24): > > > Hi, > > > > Apache Hive's Project Management Committee (PMC) has invited David > Mollitor > > to

Re: Review Request 70524: Break up DDLTask - extract Workload Management related operations

2019-04-23 Thread Andrew Sherman via Review Board
/AlterWMMappingOperation.java Lines 28 (patched) <https://reviews.apache.org/r/70524/#comment301065> This is a nit, but if you spell out "workload management" rather than "wm" in the javadoc then the classes will be easier for the naive reader to understand. - Andrew S

Re: [ANNOUNCE] New committer: Bharathkrishna Guruvayoor Murali

2018-12-02 Thread Andrew Sherman
Congratulations Bharath! On Sat, Dec 1, 2018 at 10:26 AM Ashutosh Chauhan wrote: > Apache Hive's Project Management Committee (PMC) has invited > Bharathkrishna > Guruvayoor Murali to become a committer, and we are pleased to announce > that > he has accepted. > > Bharath, welcome, thank you

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-27 Thread Andrew Sherman via Review Board
che.org/r/69054/#comment295705> nit: delete - Andrew Sherman On Nov. 27, 2018, 7:18 a.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread Andrew Sherman via Review Board
/hadoop/hive/metastore/utils/MetaStoreServerUtils.java Lines 1176 (patched) <https://reviews.apache.org/r/69167/#comment294688> Nit: all the trendy kids use StringBuilder now - Andrew Sherman On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-22 Thread Andrew Sherman via Review Board
> On Oct. 16, 2018, 8:59 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 291 (patched) > > <https://reviews.apache.org/r/69054/diff/1/?file=2098724#file2098724line291> >

Re: [ANNOUNCE] New committer: Nishant Bangarwa

2018-10-19 Thread Andrew Sherman
Congratulations Nishant! On Fri, Oct 19, 2018 at 4:29 AM Peter Vary wrote: > Congratulations Nishant! > > > On Oct 19, 2018, at 07:42, Sankar Hariappan > wrote: > > > > Congrats Nishant! > > > > Best regards > > Sankar > > > > > > > > > > > > > > > > > > > > On 15/10/18, 12:45 PM, "Ashutosh

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Andrew Sherman via Review Board
t; nit: add a timeout to get then you will kow the test can never hang - Andrew Sherman On Oct. 16, 2018, 8:36 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 68969: HIVE-20307 : Add support for filterspec to the getPartitions with projection API

2018-10-09 Thread Andrew Sherman via Review Board
/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java Lines 718 (patched) <https://reviews.apache.org/r/68969/#comment293780> This is so much nicer - Andrew Sherman On Oct. 9, 2018, 9:23 p.m., Vihang Karajgaonkar

Re: Review Request 68969: HIVE-20307 : Add support for filterspec to the getPartitions with projection API

2018-10-09 Thread Andrew Sherman via Review Board
peated, should be put in a method? In fact the whole methid could use a load of helper methods to make it more readable. - Andrew Sherman On Oct. 9, 2018, 7:47 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatica

Re: [ANNOUNCE] New committer: Janaki Lahorani

2018-10-09 Thread Andrew Sherman
Congratulations Janaki! On Mon, Oct 8, 2018 at 10:05 PM Ashutosh Chauhan wrote: > Apache Hive's Project Management Committee (PMC) has invited Janaki > Lahorani to become a committer, and we are pleased to announce that she has > accepted. > Janaki, welcome, thank you for your contributions,

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

2018-10-02 Thread Andrew Sherman via Review Board
say "providing different ways of filtering and controlling output" - Andrew Sherman On Oct. 3, 2018, 12:07 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

2018-10-02 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68889/#review209165 --- Ship it! Ship It! - Andrew Sherman On Oct. 2, 2018, 9:55

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

2018-10-01 Thread Andrew Sherman via Review Board
ncy is ugly too. IMHO You should teach Intellij to do your formatting and then let it decide this stuff - Andrew Sherman On Oct. 1, 2018, 7:09 a.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatic

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Andrew Sherman via Review Board
/hadoop/hive/metastore/conf/MetastoreConf.java Lines 517 (patched) <https://reviews.apache.org/r/68827/#comment293362> typo: th - Andrew Sherman On Sept. 28, 2018, 4:59 p.m., Bharathkrishna Guruvayoor Murali

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Andrew Sherman via Review Board
> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 917 (patched) > > <https://reviews.apache.org/r/68827/diff/1/?file=2091788#file2091788l

Re: Review Request 68827: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-26 Thread Andrew Sherman via Review Board
t;https://reviews.apache.org/r/68827/#comment293301> add test with the default param map from MetastoreConf - Andrew Sherman On Sept. 24, 2018, 8:37 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

2018-09-25 Thread Andrew Sherman via Review Board
rs can see that somethign funny is happening - Andrew Sherman On Sept. 24, 2018, 2:01 p.m., Karen Coppage wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-24 Thread Andrew Sherman via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > <https://reviews.apache.org/r/68767/diff/1/?file=2090314#file2090314line

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

2018-09-21 Thread Andrew Sherman via Review Board
ps://reviews.apache.org/r/68664/#comment293135> nit: I'm on line 560 and I still am not used to this assrtThat/is stuff. You should not change this as there is so much code but I have not found this a useful addition to the usual style. standalone-

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

2018-09-21 Thread Andrew Sherman via Review Board
/rpc/thrift/TOpenSessionReq.java Line 546 (original), 546 (patched) <https://reviews.apache.org/r/68710/#comment293099> why give a clue about password length? Maybe just always print or something? - Andrew Sherman On Sept. 21, 2018, 3:31 p.m., Karen Coppage

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Andrew Sherman via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > <https://reviews.apache.org/r/68767/diff/1/?file=2090314#file2090314line

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Andrew Sherman via Review Board
> On Sept. 21, 2018, 12:04 a.m., denys kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Line 311 (original), 311 (patched) > > > > > >

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-20 Thread Andrew Sherman via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > This all looks good, I haver questions... - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#rev

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-20 Thread Andrew Sherman via Review Board
che.org/r/68767/#comment293034> I note the tracing will be less intersting now. Do we now need to insert the paramters as well? - Andrew Sherman On Sept. 19, 2018, 9:46 a.m., Laszlo Pinter wrote: > > --- > This is an aut

Happy 10th Birthday Apache Hive!

2018-09-02 Thread Andrew Sherman
*Today is the tenth anniversary of the first Hive commit that is visible in our repository:https://github.com/apache/hive/commit/65da10218eaac25c47a69f6965002a1ac4bfcac3 Author: Owen O'Malley >Date: Tue Sep 2

[jira] [Created] (HIVE-20479) Update content/people.mdtext in cms

2018-08-28 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-20479: - Summary: Update content/people.mdtext in cms Key: HIVE-20479 URL: https://issues.apache.org/jira/browse/HIVE-20479 Project: Hive Issue Type: Task

Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68365/#review207383 --- Ship it! Ship It! - Andrew Sherman On Aug. 15, 2018, 11:13

Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Andrew Sherman via Review Board
params(EXTERNAL=false),TableType.MANAGED_TABLE params(EXTERNAL=true),TableType.EXTERNAL_TABLE as well? - Andrew Sherman On Aug. 15, 2018, 8:18 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

2018-07-30 Thread Andrew Sherman
Congratulations Sahil! On Mon, Jul 30, 2018 at 7:29 AM Sahil Takiar wrote: > Thanks! > > On Mon, Jul 30, 2018 at 2:44 AM, Peter Vary > wrote: > > > Congratulations Sahil! > > > > > On Jul 29, 2018, at 22:32, Vineet Garg wrote: > > > > > > Congratulations Sahil! > > > > > >> On Jul 26, 2018,

Re: [ANNOUNCE] New PMC Member : Vineet Garg

2018-07-30 Thread Andrew Sherman
Congratulations Vineet! On Mon, Jul 30, 2018 at 12:52 AM Deepak Jaiswal wrote: > Congratulations Vineet! > > On 7/30/18, 12:45 AM, "Peter Vary" wrote: > > Congratulations Vineet! > > > On Jul 30, 2018, at 01:59, Ashutosh Chauhan > wrote: > > > > On behalf of the Hive PMC I am

Re: [ANNOUNCE] New PMC Member : Peter Vary

2018-07-30 Thread Andrew Sherman
Congratulations Peter! On Sun, Jul 29, 2018 at 1:32 PM Vineet Garg wrote: > Congratulations Peter! > > > On Jul 26, 2018, at 11:25 AM, Ashutosh Chauhan > wrote: > > > > On behalf of the Hive PMC I am delighted to announce Peter Vary is > joining > > Hive PMC. > > Thanks Peter for all your

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

2018-07-30 Thread Andrew Sherman
Congratulations Vihang! On Mon, Jul 30, 2018 at 12:44 AM Peter Vary wrote: > Congratulations Vihang! > > > On Jul 29, 2018, at 22:32, Vineet Garg wrote: > > > > Congratulations Vihang! > > > >> On Jul 26, 2018, at 11:27 AM, Ashutosh Chauhan > wrote: > >> > >> On behalf of the Hive PMC I am

Re: [ANNOUNCE] New committer: Slim Bouguerra

2018-07-30 Thread Andrew Sherman
Congratulations Slim! On Mon, Jul 30, 2018 at 12:46 AM Peter Vary wrote: > Congratulations Slim! > > > On Jul 30, 2018, at 02:00, Ashutosh Chauhan > wrote: > > > > Apache Hive's Project Management Committee (PMC) has invited Slim > Bouguerra > > to become a committer, and we are pleased to

Re: Review Request 68027: HIVE-19986: Add logging of runtime statistics indicating when Hdfs Erasure Coding is used by MR. These stats are not avalable until the unreleased Hadoop 3.2 so the shim is u

2018-07-24 Thread Andrew Sherman via Review Board
test added to TestJdbcWithMiniHS2ErasureCoding.java. I also ran this code against a hadoop 3.2 snapshot to ensure the new stat works Thanks, Andrew Sherman

[jira] [Created] (HIVE-20030) Fix Java compile errors that show up in IntelliJ from ConvertJoinMapJoin.java and AnnotateRunTimeStatsOptimizer.java

2018-06-28 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-20030: - Summary: Fix Java compile errors that show up in IntelliJ from ConvertJoinMapJoin.java and AnnotateRunTimeStatsOptimizer.java Key: HIVE-20030 URL: https://issues.apache.org

Re: HiveQA is broken

2018-06-26 Thread Andrew Sherman
Thanks Vihang (and others who helped) -Andrew On Tue, Jun 26, 2018 at 1:16 PM Vihang Karajgaonkar wrote: > After updating to jdk-8 on the jenkins side and making some change on the > server side, it looks like its chugging along again. Will keep an eye. > > On Tue, Jun 26, 2018 at 11:56 AM,

[jira] [Created] (HIVE-19987) Add logging of runtime statistics indicating when Hdfs Erasure Coding is used by Spark

2018-06-25 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-19987: - Summary: Add logging of runtime statistics indicating when Hdfs Erasure Coding is used by Spark Key: HIVE-19987 URL: https://issues.apache.org/jira/browse/HIVE-19987

[jira] [Created] (HIVE-19986) Add logging of runtime statistics indicating when Hdfs Erasure Coding is used by MR

2018-06-25 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-19986: - Summary: Add logging of runtime statistics indicating when Hdfs Erasure Coding is used by MR Key: HIVE-19986 URL: https://issues.apache.org/jira/browse/HIVE-19986

[jira] [Created] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky

2018-06-22 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-19971: - Summary: TestRuntimeStats.testCleanup() is flaky Key: HIVE-19971 URL: https://issues.apache.org/jira/browse/HIVE-19971 Project: Hive Issue Type: Task

Re: [ANNOUNCE] New committer: Adam Szita

2018-06-21 Thread Andrew Sherman
Yay Adam! On Thu, Jun 21, 2018 at 7:27 AM Sahil Takiar wrote: > Congrats Adam! > > On Thu, Jun 21, 2018 at 2:52 AM, Peter Vary > wrote: > > > Well done Adam! > > Congratulations! > > > > > On Jun 20, 2018, at 21:02, Ashutosh Chauhan > > wrote: > > > > > > Apache Hive's Project Management

Re: New committer announcement : Marta Kuczora

2018-06-21 Thread Andrew Sherman
yay Marta! On Thu, Jun 21, 2018 at 7:27 AM Sahil Takiar wrote: > Congrats Marta! > > On Thu, Jun 21, 2018 at 2:52 AM, Peter Vary > wrote: > > > Well done Marta! > > Congratulations! > > > > > On Jun 20, 2018, at 21:06, Ashutosh Chauhan > > wrote: > > > > > > Apache Hive's Project Management

Re: Review Request 67468: HIVE-18118: provide supportability support for Erasure Coding Update number of Erasure Coded Files in a directory as part of Basic (aka Quick) Stats This information is then

2018-06-21 Thread Andrew Sherman via Review Board
jdbc test Thanks, Andrew Sherman

Re: Review Request 67468: FIXES TO MAKE INTELLIJ HAPPY DO NOT PUSH

2018-06-20 Thread Andrew Sherman via Review Board
/ Changes: https://reviews.apache.org/r/67468/diff/1-2/ Testing --- Ran driver tests and new jdbc test Thanks, Andrew Sherman

Re: Review Request 67468: HIVE-18118: provide supportability support for Erasure Coding Update number of Erasure Coded Files in a directory as part of Basic (aka Quick) Stats This information is then

2018-06-15 Thread Andrew Sherman via Review Board
36 ------- On June 6, 2018, 12:46 a.m., Andrew Sherman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67468/ > -

Review Request 67468: HIVE-18118: provide supportability support for Erasure Coding Update number of Erasure Coded Files in a directory as part of Basic (aka Quick) Stats This information is then (mos

2018-06-05 Thread Andrew Sherman via Review Board
9b36d09eb9fb332e913d442bb476628eca334b6e standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreUtils.java 55ff1502d415dea52095cfdd523d01f1e49ce084 Diff: https://reviews.apache.org/r/67468/diff/1/ Testing --- Ran driver tests and new jdbc test Thanks, Andrew Sherman

[jira] [Created] (HIVE-19758) Set hadoop.version=3.1.0 in standalone-metastore

2018-05-31 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-19758: - Summary: Set hadoop.version=3.1.0 in standalone-metastore Key: HIVE-19758 URL: https://issues.apache.org/jira/browse/HIVE-19758 Project: Hive Issue Type

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-22 Thread Andrew Sherman via Review Board
loyed these changes to the ptest server? this file > > is just a copy of whats already been deployed, so its just for reference > > > > also, why skip batching? > > Andrew Sherman wrote: > OK I have no idea what ut.itests.qtest.skipBatching means I just copi

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-15 Thread Andrew Sherman via Review Board
ecessary since you set the cluster type to mr above? > > Andrew Sherman wrote: > Ha good question. Yes it is necessary as setClusterType() does not always > set the cluster type :-( - it allows the cluster type to overridden with > -Dclustermode=xxx > > Sahil Takiar wrote:

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-15 Thread Andrew Sherman via Review Board
we want the ec commands to work outside the > > `TestErasureCodingHDFSCliDriver`? > > Andrew Sherman wrote: > So you could run an ec test in TestCliDriver (sorry reviewboard lost my > ealrier reply) > > Sahil Takiar wrote: > why would you want to do that

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-15 Thread Andrew Sherman via Review Board
ecessary since you set the cluster type to mr above? > > Andrew Sherman wrote: > Ha good question. Yes it is necessary as setClusterType() does not always > set the cluster type :-( - it allows the cluster type to overridden with > -Dclustermode=xxx > > Sahil Takiar wrote:

Re: [VOTE] Stricter commit guidelines

2018-05-15 Thread Andrew Sherman
+1 On Tue, May 15, 2018 at 2:34 AM Rui Li wrote: > +1 > > On Tue, May 15, 2018 at 2:24 PM, Prasanth Jayachandran < > pjayachand...@hortonworks.com> wrote: > > > +1 > > > > > > > > Thanks > > Prasanth > > > > > > > > On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-14 Thread Andrew Sherman via Review Board
0196bb94bb0b54f7184f testutils/ptest2/conf/deployed/master-mr2.properties 7edc307f85744d60d322ad8087164625677fc230 Diff: https://reviews.apache.org/r/67023/diff/3/ Changes: https://reviews.apache.org/r/67023/diff/2-3/ Testing --- Thanks, Andrew Sherman

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-14 Thread Andrew Sherman via Review Board
tCliDriver without changing it (sorry reviewboard lost my ealrier reply) - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67023/#review203040 -----------

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-14 Thread Andrew Sherman via Review Board
ecessary since you set the cluster type to mr above? > > Andrew Sherman wrote: > Ha good question. Yes it is necessary as setClusterType() does not always > set the cluster type :-( - it allows the cluster type to overridden with > -Dclustermode=xxx > > Sahil Takiar wrote:

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-11 Thread Andrew Sherman via Review Board
(patched) <https://reviews.apache.org/r/67023/#comment285041> should be 'select key, value from src;' - Andrew Sherman On May 11, 2018, 11:38 p.m., Andrew Sherman wrote: > > --- > This is an automatically generated e

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

2018-05-11 Thread Andrew Sherman via Review Board
0196bb94bb0b54f7184f testutils/ptest2/conf/deployed/master-mr2.properties 7edc307f85744d60d322ad8087164625677fc230 Diff: https://reviews.apache.org/r/67023/diff/2/ Changes: https://reviews.apache.org/r/67023/diff/1-2/ Testing --- Thanks, Andrew Sherman

[jira] [Created] (HIVE-19062) Update constraint_partition_columns.q.out

2018-03-27 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-19062: - Summary: Update constraint_partition_columns.q.out Key: HIVE-19062 URL: https://issues.apache.org/jira/browse/HIVE-19062 Project: Hive Issue Type: Bug

Re: Hive 3.0 release

2018-03-21 Thread Andrew Sherman
+1 -Andrew On Wed, Mar 21, 2018 at 11:33 AM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > +1 > > -Jesús > > On 3/21/18, 10:44 AM, "Prasanth Jayachandran" < > pjayachand...@hortonworks.com> wrote: > > +1 > > Thanks > Prasanth > > > > On Wed, Mar 21, 2018 at 9:59 AM

[jira] [Created] (HIVE-18877) HiveSchemaTool.validateSchemaTables() should wrap a SQLException when rethrowing

2018-03-06 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18877: - Summary: HiveSchemaTool.validateSchemaTables() should wrap a SQLException when rethrowing Key: HIVE-18877 URL: https://issues.apache.org/jira/browse/HIVE-18877

Re: Review Request 65745: HIVE-18743: CREATE TABLE on S3 data can be extremely slow. DO_NOT_UPDATE_STATS workaround is buggy.

2018-03-02 Thread Andrew Sherman via Review Board
/metastore/utils/MetaStoreUtils.java Line 657 (original), 652 (patched) <https://reviews.apache.org/r/65745/#comment278759> The log message says 'updating table stats fast', as we changed the method name perhaps this is now misleading? - Andrew Sherman On Feb. 22, 2018, 3:44 a.m., Ale

[jira] [Created] (HIVE-18791) Fix TestJdbcWithMiniHS2#testHttpHeaderSize

2018-02-23 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18791: - Summary: Fix TestJdbcWithMiniHS2#testHttpHeaderSize Key: HIVE-18791 URL: https://issues.apache.org/jira/browse/HIVE-18791 Project: Hive Issue Type: Bug

Re: Intellij + Checkstyle setup

2018-02-05 Thread Andrew Sherman
I will try to make things clearer... When debugging checkstyle it can be useful to have the IDE run the checks. Checkstyle uses a file usually called checkstyle.xml for its configuration. The version of checkstyle in Intellij (or in the checkstyle plugin, IDK) does not like the checkstyle.xml

[jira] [Created] (HIVE-18456) Add some tests for HIVE-18367 to check that the table information contains the query correctly

2018-01-16 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18456: - Summary: Add some tests for HIVE-18367 to check that the table information contains the query correctly Key: HIVE-18456 URL: https://issues.apache.org/jira/browse/HIVE-18456

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-12 Thread Andrew Sherman via Review Board
> On Jan. 11, 2018, 9:51 p.m., Andrew Sherman wrote: > > common/src/java/org/apache/hadoop/hive/common/LogUtils.java > > Lines 259 (patched) > > <https://reviews.apache.org/r/65075/diff/1/?file=1938298#file1938298line259> > > > > Does deleteAppender()

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-11 Thread Andrew Sherman via Review Board
208636 I think this is no longer tested. Is that OK? - Andrew Sherman On Jan. 11, 2018, 2:11 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: [Announce] New committer: Deepak Jaiswal

2018-01-08 Thread Andrew Sherman
Congratulations! On Mon, Jan 8, 2018 at 2:08 AM, Peter Vary wrote: > Congratulation Deepak! > > > On Jan 5, 2018, at 11:18 PM, Ashutosh Chauhan > wrote: > > > > The Project Management Committee (PMC) for Apache Hive has invited Deepak > > Jaiswal to

[jira] [Created] (HIVE-18367) Describe Extended output is truncated on a table with an explicit row format containing tabs or newlines.

2018-01-03 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18367: - Summary: Describe Extended output is truncated on a table with an explicit row format containing tabs or newlines. Key: HIVE-18367 URL: https://issues.apache.org/jira/browse

[jira] [Created] (HIVE-18310) Test 'vector_reduce_groupby_duplicate_cols.q' is misspelled in testconfiguration.properties

2017-12-19 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18310: - Summary: Test 'vector_reduce_groupby_duplicate_cols.q' is misspelled in testconfiguration.properties Key: HIVE-18310 URL: https://issues.apache.org/jira/browse/HIVE-18310

Re: Adding Hive Metastore functions to add and alter partitions for multiple tables

2017-12-15 Thread Andrew Sherman
the operation. > We are doing performance test on our system to see how long it takes for > multiple scenarios but after all, this should not be a blocker. > > Thanks, > Kaijie > > 秦凯捷 > Tel: +86-13810485829 > E-mail: daniel...@gmail.com > > > > On Thu, Dec 14, 20

Re: Adding Hive Metastore functions to add and alter partitions for multiple tables

2017-12-13 Thread Andrew Sherman
Hi Kaijie, I think this is an area that other the Hive community is interested in. So please do go ahead and describe your functionality. I think that it is important to describe - what happens in the case of a failure when part way through the operations. - what impact on the system there will

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-08 Thread Andrew Sherman via Review Board
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64193/#review193155 --- On Dec. 7, 2017, 7:12 p.m., Andrew Sherman wrote: > > -

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-07 Thread Andrew Sherman via Review Board
2c28c398ca49ba661df460c9f3e6d578c785d3ce Diff: https://reviews.apache.org/r/64193/diff/2/ Changes: https://reviews.apache.org/r/64193/diff/1-2/ Testing --- Thanks, Andrew Sherman

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-06 Thread Andrew Sherman via Review Board
are no > > existing ones, correct me if I am wrong). > > > > If you have time, it would be great to run some of the lineage tests for > > HoS too, but since thats a bit orthogonal to this JIRA, it can be done in a > > follow up JIRA. > > Andrew Sherman wr

[jira] [Created] (HIVE-18228) Azure credential properties should be added to the HiveConf hidden list

2017-12-05 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18228: - Summary: Azure credential properties should be added to the HiveConf hidden list Key: HIVE-18228 URL: https://issues.apache.org/jira/browse/HIVE-18228 Project

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-04 Thread Andrew Sherman via Review Board
tate`? Good catch, I will fix - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64193/#review192601 --- On Nov. 30, 2017, 1:22

Re: Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-12-01 Thread Andrew Sherman via Review Board
est-specific class. At one point I needed to have the hook in the HS2 classpath, that is no longer true so I moved it to test, thanks. . - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Review Request 64193: HIVE-18054: Make Lineage work with concurrent queries on a Session

2017-11-29 Thread Andrew Sherman via Review Board
://reviews.apache.org/r/64193/diff/1/ Testing --- Thanks, Andrew Sherman

Re: Integrating Yetus with Precommit job

2017-11-27 Thread Andrew Sherman
Thanks, this is going to be useful On Wed, Nov 22, 2017 at 11:28 AM, Vineet Garg wrote: > Thanks Adam! > > > On Nov 22, 2017, at 5:46 AM, Adam Szita wrote: > > > > This is now done. Patch is committed and we deployed the new war file to > > the ptest

[jira] [Created] (HIVE-18136) WorkloadManagerMxBean is missing the Apache license header

2017-11-22 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18136: - Summary: WorkloadManagerMxBean is missing the Apache license header Key: HIVE-18136 URL: https://issues.apache.org/jira/browse/HIVE-18136 Project: Hive

[jira] [Created] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver

2017-11-21 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18127: - Summary: Do not strip '--' comments from shell commands issued from CliDriver Key: HIVE-18127 URL: https://issues.apache.org/jira/browse/HIVE-18127 Project: Hive

[jira] [Created] (HIVE-18054) Make Lineage work with concurrent queries on a Session

2017-11-13 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-18054: - Summary: Make Lineage work with concurrent queries on a Session Key: HIVE-18054 URL: https://issues.apache.org/jira/browse/HIVE-18054 Project: Hive Issue

Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler

2017-11-08 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/#review190483 --- Ship it! Ship It! - Andrew Sherman On Nov. 8, 2017, 7:17

Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler

2017-11-08 Thread Andrew Sherman via Review Board
enever possible. - Andrew Sherman On Nov. 7, 2017, 9:19 p.m., Janaki Lahorani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Created] (HIVE-17935) Turn on hive.optimize.sort.dynamic.partition by default

2017-10-30 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17935: - Summary: Turn on hive.optimize.sort.dynamic.partition by default Key: HIVE-17935 URL: https://issues.apache.org/jira/browse/HIVE-17935 Project: Hive Issue

[jira] [Created] (HIVE-17868) Make queries in spark_local_queries.q have deterministic output

2017-10-20 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17868: - Summary: Make queries in spark_local_queries.q have deterministic output Key: HIVE-17868 URL: https://issues.apache.org/jira/browse/HIVE-17868 Project: Hive

[jira] [Created] (HIVE-17826) Error writing to RandomAccessFile after operation log is closed

2017-10-17 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17826: - Summary: Error writing to RandomAccessFile after operation log is closed Key: HIVE-17826 URL: https://issues.apache.org/jira/browse/HIVE-17826 Project: Hive

Re: Review Request 62995: HIVE-17806 Create directory for metrics file if it doesn't exist

2017-10-16 Thread Andrew Sherman via Review Board
be "temporary" not yemporary standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java Line 164 (original), 179 (patched) <https://reviews.apache.org/r/62995/#comment265243> should be"temporary" - Andrew Sherman

Re: Review Request 62693: HIVE-17635: Add unit tests to CompactionTxnHandler and use PreparedStatements for queries

2017-10-13 Thread Andrew Sherman via Review Board
To reply, visit: https://reviews.apache.org/r/62693/#review187818 --- On Sept. 29, 2017, 4:51 p.m., Andrew Sherman wrote: > > --- > This is an automatically generate

[jira] [Created] (HIVE-17789) Flaky test: TestSessionManagerMetrics.testAbandonedSessionMetrics has timing related problems

2017-10-12 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17789: - Summary: Flaky test: TestSessionManagerMetrics.testAbandonedSessionMetrics has timing related problems Key: HIVE-17789 URL: https://issues.apache.org/jira/browse/HIVE-17789

[jira] [Created] (HIVE-17760) Create a unit test which validates HIVE-9423 does not regress

2017-10-10 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17760: - Summary: Create a unit test which validates HIVE-9423 does not regress Key: HIVE-17760 URL: https://issues.apache.org/jira/browse/HIVE-17760 Project: Hive

[jira] [Created] (HIVE-17677) Investigate using hive statistics information to optimize HoS parallel order by

2017-10-02 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17677: - Summary: Investigate using hive statistics information to optimize HoS parallel order by Key: HIVE-17677 URL: https://issues.apache.org/jira/browse/HIVE-17677

Review Request 62693: HIVE-17635: Add unit tests to CompactionTxnHandler and use PreparedStatements for queries

2017-09-29 Thread Andrew Sherman
/apache/hadoop/hive/metastore/txn/TestTxnUtils.java 1497c00e5dc77c02e53767b014a23e5fd8cb5b29 ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java f8ae86bea3fe78374c0e0487d66c661f4f0d78ff Diff: https://reviews.apache.org/r/62693/diff/1/ Testing --- Thanks, Andrew

[jira] [Created] (HIVE-17635) Add unit tests to CompactionTxnHandler and use PreparedStatements for queries

2017-09-28 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17635: - Summary: Add unit tests to CompactionTxnHandler and use PreparedStatements for queries Key: HIVE-17635 URL: https://issues.apache.org/jira/browse/HIVE-17635

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-24 Thread Andrew Sherman
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181196 ------- On July 22, 2017, 12:16 a.m., Andrew Sherman wrote: > > ---

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Andrew Sherman
n. > > Peter Vary wrote: > Nice catch Andrew! > > One more thing. Could you please do this for the LogDivertAppenderForTest > too? It is only used for tests, but it would be good to clean up it too. > > Thanks, > Peter > > Andrew Sherman wrote

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Andrew Sherman
Diff: https://reviews.apache.org/r/61010/diff/2/ Changes: https://reviews.apache.org/r/61010/diff/1-2/ Testing --- Hand testing to show leak has gone. The test in TestOperationLoggingLayout is extended to check that the Appender is closed. Thanks, Andrew Sherman

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Andrew Sherman
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181083 --- On July 20, 2017, 10:45 p.m., Andrew Sherman wrote: > > --

Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-20 Thread Andrew Sherman
is extended to check that the Appender is closed. Thanks, Andrew Sherman

[jira] [Created] (HIVE-17128) Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-19 Thread Andrew Sherman (JIRA)
Andrew Sherman created HIVE-17128: - Summary: Operation Logging leaks file descriptors as the log4j Appender is never closed Key: HIVE-17128 URL: https://issues.apache.org/jira/browse/HIVE-17128

  1   2   >