Re: Review Request 61009: Extend object store to store bit vectors

2017-07-21 Thread Ashutosh Chauhan
al) <https://reviews.apache.org/r/61009/#comment256611> Seems like we are going to loose this extrapolation logic. metastore/src/model/package.jdo Lines 883 (patched) <https://reviews.apache.org/r/61009/#comment256612> may

Re: Review Request 57614: Auto-gather column stats - phase 2

2017-07-18 Thread Ashutosh Chauhan
r/57614/#comment256096> set autogather=false to restore original test ql/src/test/results/clientpositive/llap/vector_varchar_simple.q.out Line 355 (original), 355 (patched) <https://reviews.apache.org/r/57614/#comment256097&

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 1

2017-07-17 Thread Ashutosh Chauhan
+1 Built from sources. Ran some tests. Its been almost a year since we last released. Excited to see a new release coming forth. Thanks, Pengcheng for putting this together! Thanks, Ashutosh On Sat, Jul 15, 2017 at 8:41 PM, Pengcheng Xiong wrote: > I believe Owen and I checked every one of the

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-14 Thread Ashutosh Chauhan
> On July 14, 2017, 12:55 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/common/ndv/NumDistinctValueEstimatorFactory.java > > Lines 30-34 (patched) > > <https://reviews.apache.org/r/60753/diff/2/?file=1775584#file1775584line30> &g

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread Ashutosh Chauhan
apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java Lines 1414 (patched) <https://reviews.apache.org/r/60753/#comment255727> Does this method work for hll as well? - Ashutosh Chauhan On July 14, 2017, 12:08 a.m

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread Ashutosh Chauhan
ce (ws) ql/src/java/org/apache/hadoop/hive/ql/udf/generic/DecimalNumDistinctValueEstimator.java Lines 46 (patched) <https://reviews.apache.org/r/60753/#comment255710> whitespace (ws) - Ashutosh Chauhan On July 14, 2017, 12:08 a.m., pengcheng xiong wrote: > > --

Re: [VOTE] storage-release-2.4.0rc1

2017-07-12 Thread Ashutosh Chauhan
+1 Did a build and some basic testing. On Tue, Jul 11, 2017 at 1:36 PM, Alan Gates wrote: > +1. Checked the signatures, did a build with a fresh maven repo, ran rat. > > On Mon, Jul 10, 2017 at 11:58 PM, Pengcheng Xiong > wrote: > > > Hi all, > > > >Here is a new release candidate for hive

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-11 Thread Ashutosh Chauhan
in object store. > > Prasanth_J wrote: > I don't think it will be useful for user to tune this. > IMHO, most users won't care a lot about this. This can be used as > fallback but this will only add more checks. > > Ashutosh Chauhan wrote: > I a

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-11 Thread Ashutosh Chauhan
w180119 --- On July 10, 2017, 9:29 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60753/ > --

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

2017-07-11 Thread Ashutosh Chauhan
/StatsRulesProcFactory.java Line 1965 (original) <https://reviews.apache.org/r/60757/#comment255329> Did you intend to remove break; from here? - Ashutosh Chauhan On July 11, 2017, 10:07 p.m., Vineet Garg wrote: > > ---

Re: Review Request 60468: HIVE-16888

2017-07-11 Thread Ashutosh Chauhan
> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/druid_basic2.q.out > > Line 837 (original), 837 (patched) > > <https://reviews.apache.org/r/60468/diff/2/?file=1766002#file1766002line837> > > > > Is this c

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

2017-07-11 Thread Ashutosh Chauhan
me: computeRowCountAssumingInnerJoin() - Ashutosh Chauhan On July 11, 2017, 12:50 a.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 60468: HIVE-16888

2017-07-10 Thread Ashutosh Chauhan
nd (dt1 > 1970-01-01) and (dt1 >= 1970-01-01) and (1970-01-01 < dt1) and (1970-01-01 <= dt1)) simplifed to true, but should have been simplified to false. - Ashutosh Chauhan On June 28, 2017, 7:56 a.m., Jesús Camacho Rodríguez wrote: > >

Re: Review Request 60349: Scalar sub-query: sq_count_check not required if gby keys are constant

2017-07-07 Thread Ashutosh Chauhan
a/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 1533-1536 (patched) <https://reviews.apache.org/r/60349/#comment254955> Rule will fire only when flag is on. - Ashutosh Chauhan On June 26, 2017, 9:06 p.m., Vineet Garg wrote: > >

[ANNOUNCE] New PMC Member : Matt McCline

2017-07-06 Thread Ashutosh Chauhan
On behalf of the Hive PMC I am delighted to announce Matt McCline is joining Hive PMC. Matt is a long time contributor in Hive and is focusing on vectorization these days. Welcome, Matt! Thanks, Ashutosh

[Announce] New committer: Teddy Choi

2017-07-05 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Teddy Choi to become a committer and we are pleased to announce that he has accepted. Welcome, Teddy! Thanks, Ashutosh

[Announce] New committer: Peter Vary

2017-07-05 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Peter Vary to become a committer and we are pleased to announce that he has accepted. Welcome, Peter! Thanks, Ashutosh

[Announce] New committer: Vihang Karajgaonkar

2017-07-05 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Vihang Karajgaonkar to become a committer and we are pleased to announce that he has accepted. Welcome, Vihang! Thanks, Ashutosh

[Announce] New committer: Sahil Takiar

2017-07-05 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Sahil Takiar to become a committer and we are pleased to announce that he has accepted. Welcome, Sahil! Thanks, Ashutosh

[Announce] New committer: Deepesh Khandelwal

2017-07-05 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Deepesh Khandelwal to become a committer and we are pleased to announce that he has accepted. Welcome, Deepesh! Thanks, Ashutosh

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Ashutosh Chauhan
imizer/calcite/rules/HiveRelDecorrelator.java Lines 3145-3147 (original), 3128-3130 (patched) <https://reviews.apache.org/r/59984/#comment253459> Logic seems to be doing opposite of comment, that is dont use valueGen when grouping sets are present. - Ashutosh Chauhan On June 26, 20

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Ashutosh Chauhan
5531-5540 (patched) <https://reviews.apache.org/r/59984/#comment253456> Change in resultset. Either earlier results were wrong or new one. - Ashutosh Chauhan On June 26, 2017, 8:41 p.m., Vineet Garg wrote: > > ---

Re: Review Request 57614: Auto-gather column stats - phase 2

2017-06-26 Thread Ashutosh Chauhan
nsert.q.out Line 165 (original), 198 (patched) <https://reviews.apache.org/r/57614/#comment253347> vectorization turned off. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wrote: > > --- > This is an autom

Re: Review Request 57614: Auto-gather column stats - phase 2

2017-06-26 Thread Ashutosh Chauhan
#comment253325> Join order changed. ql/src/test/results/clientpositive/stats3.q.out Lines 58 (patched) <https://reviews.apache.org/r/57614/#comment253326> This should say invalidating stats. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wrote: >

Re: Review Request 57614: Auto-gather column stats - phase 2

2017-06-24 Thread Ashutosh Chauhan
ed) <https://reviews.apache.org/r/57614/#comment253110> No ColumnStatsDesc in explain. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wrote: > > --- > This is an automatically ge

Re: Review Request 57614: Auto-gather column stats - phase 2

2017-06-24 Thread Ashutosh Chauhan
> On June 22, 2017, 7:08 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/smb_join_partition_key.q > > Lines 1 (patched) > > <https://reviews.apache.org/r/57614/diff/2/?file=1754754#file1754754line1> > > > > decimals should b

Re: Review Request 57614: Auto-gather column stats - phase 2

2017-06-22 Thread Ashutosh Chauhan
Partial. ql/src/test/results/clientpositive/columnstats_tbllvl.q.out Line 109 (original), 110-111 (patched) <https://reviews.apache.org/r/57614/#comment252887> Another one: HIVE-15903 should have made this happen. - Ashutosh Chauhan On June 20, 2017, 10 p.m., pengcheng xiong wr

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Ashutosh Chauhan
> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > <https://reviews.apache.org/r/59984/diff/1/?file=1747770#file1747770line137> > >

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Ashutosh Chauhan
> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > <https://reviews.apache.org/r/59984/diff/1/?file=1747770#file1747770line137> > >

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Ashutosh Chauhan
and Filter, since lot of repeated code in two branches. - Ashutosh Chauhan On June 21, 2017, 3:44 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Ashutosh Chauhan
> On June 21, 2017, 2:03 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/except_distinct.q.out > > Lines 421-425 (original), 413-417 (patched) > > <https://reviews.apache.org/r/59998/diff/1/?file=1747966#file1747966line421> > > >

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Ashutosh Chauhan
seems to be undoing recently introduced hive.optimize.countdistinct optimization, which is surprising since that optimization runs before this. Is this expected? This may result in loss of performance. - Ashutosh Chauhan On June 21, 2017, 9:06 a.m., Jesús Camacho Rod

Re: Review Request 59998: HIVE-16867

2017-06-20 Thread Ashutosh Chauhan
ults/clientpositive/llap/subquery_scalar.q.out Lines 2491-2509 (original), 2482-2495 (patched) <https://reviews.apache.org/r/59998/#comment252440> Gbys doing diff aggregations but on same key can be further zipped. - Ashutosh Chauhan On June 12, 2017, 10:42 a.m.,

[jira] [Created] (HIVE-16924) Support distinct in presence Gby

2017-06-20 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16924: --- Summary: Support distinct in presence Gby Key: HIVE-16924 URL: https://issues.apache.org/jira/browse/HIVE-16924 Project: Hive Issue Type: New Feature

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-19 Thread Ashutosh Chauhan
Might be better to initialize this variable to true. Since, value being false is known and limited set. - Ashutosh Chauhan On June 11, 2017, 7:17 p.m., Vineet Garg wrote: > > --- > This is an automatically generated

Re: Review Request 60116: HIVE-16885

2017-06-19 Thread Ashutosh Chauhan
https://reviews.apache.org/r/60116/ > ------- > > (Updated June 15, 2017, 10:49 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16885 > https://issues.apache.org/jira/browse/HIVE-1

Re: Review Request 60116: HIVE-16885

2017-06-19 Thread Ashutosh Chauhan
;t generate unnecessary rows. - Ashutosh Chauhan On June 15, 2017, 10:49 a.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 59808: Enhance HiveFilterSetOpTransposeRule to remove union branches

2017-06-18 Thread Ashutosh Chauhan
-43 (patched) <https://reviews.apache.org/r/59808/#comment252021> Metadataonly optimizer should have kicked in and turned this to null scan. Seems like it didn't. Can you confirm with explain extended? - Ashutosh Chauhan On June 10, 2017, 9:57 p.m., pengcheng

[jira] [Created] (HIVE-16909) Improve ndv estimates when ndvs are aggregated across partitions

2017-06-15 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16909: --- Summary: Improve ndv estimates when ndvs are aggregated across partitions Key: HIVE-16909 URL: https://issues.apache.org/jira/browse/HIVE-16909 Project: Hive

Re: Review Request 59808: Enhance HiveFilterSetOpTransposeRule to remove union branches

2017-06-12 Thread Ashutosh Chauhan
6> Also, add hive.optimize.metadataonly=true; That should quick in some of these queries. ql/src/test/results/clientpositive/perf/query4.q.out Lines 240-275 (original) <https://reviews.apache.org/r/59808/#comment251377> Pretty cool ! - Ashutosh Chauhan

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-03 Thread Ashutosh Chauhan
-- On June 1, 2017, 7:46 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59697/ > ------- > > (Upda

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread Ashutosh Chauhan
ply, visit: > https://reviews.apache.org/r/59697/ > --- > > (Updated June 1, 2017, 7:46 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > hive-167

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread Ashutosh Chauhan
optimizer is not kicking in for tpcds queries. Is that expected? - Ashutosh Chauhan On June 1, 2017, 7:46 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

2017-05-31 Thread Ashutosh Chauhan
(original), 3-5 (patched) <https://reviews.apache.org/r/59468/#comment249839> yes.. you are correct. My bad. - Ashutosh Chauhan On May 27, 2017, 2:20 a.m., pengcheng xiong wrote: > > --- > This is an automatically gener

Re: Review Request 59610: Support numeric as same as decimal

2017-05-30 Thread Ashutosh Chauhan
(original), 137 (patched) <https://reviews.apache.org/r/59610/#comment249748> This will make Numeric reserved keyword, which is ok, but we need to note that in Release Notes field of jira and mark incompatible change flag in jira. - Ashutosh Chauhan On May 26, 2017, 5:43 p.m., pen

Re: Review Request 59624: HIVE-16757 remove use of deperecated RelNode.getRows()

2017-05-30 Thread Ashutosh Chauhan
izer/calcite/stats/HiveRelMdRowCount.java Line 75 (original), 75 (patched) <https://reviews.apache.org/r/59624/#comment249736> Should this instead be mq.getRowCount(join); That is waht javadoc of RelNode::estimateRowCount() is suggesting? - Ashutosh Chauhan On May 29, 2017, 7:54

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

2017-05-27 Thread Ashutosh Chauhan
iginal), 1 (patched) <https://reviews.apache.org/r/59468/#comment249605> Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. - Ashutosh Chauhan On May 27, 2017, 2:20 a.m., pengcheng xiong wrote: > > ---

[Announce] New PMC member: Yongzhi Chen

2017-05-25 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Yongzhi Chen to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Yongzhi! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Chaoyu Tang

2017-05-25 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Chaoyu Tang to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Chaoyu! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Aihua Xu

2017-05-25 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Aihua to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Aihua! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Sergio Pena

2017-05-25 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Sergio Pena to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Sergio! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member: Vaibhav Gumashta

2017-05-25 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Vaibhav Gumashta to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Vaibhav! Thanks, Ashutosh on behalf of Hive PMC

[Announce] New PMC member : Daniel Dai

2017-05-25 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Daniel Dai to become a PMC member and we are pleased to announce that he has accepted. Please join me in congratulating Daniel! Thanks, Ashutosh on behalf of Hive PMC

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

2017-05-25 Thread Ashutosh Chauhan
tched) <https://reviews.apache.org/r/59468/#comment249420> No mGby2 in plan. Probably removed by ReduceSinkDedup since keys are same for 2 Gbys. As I suggested earlier second Gby should have constant key and then it should show up here. - Ashutosh Chauhan On May

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

2017-05-23 Thread Ashutosh Chauhan
468/#comment249138> This change may not be needed if we run Count distinct optimization after this has alreday run. ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java Lines 75 (patched) <https://reviews.apache.org/r/59468/#comment249141> Also, le

Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc

2017-05-22 Thread Ashutosh Chauhan
avg(key) from src group by value; ql/src/test/results/clientpositive/llap/metadataonly1.q.out Line 256 (original), 256-257 (patched) <https://reviews.apache.org/r/59468/#comment249095> Earlier plan was better. When metadataonly optimizer can kick in that should. - Ashutosh Chauhan

Re: Review Request 56140: Can't order by an unselected column

2017-05-18 Thread Ashutosh Chauhan
e currently rewritten to avoid this missing feature. - Ashutosh Chauhan On May 1, 2017, 5:30 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 56140: Can't order by an unselected column

2017-05-17 Thread Ashutosh Chauhan
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 1619 (patched) <https://reviews.apache.org/r/56140/#comment248751> Comment : If there are aggregations in order by, we need to remember them in qb. - Ashutosh Chauhan On May 1, 2017, 5:30 p.m., pengcheng xio

Re: Review Request 58935: Set column stats default as true when creating new tables/partitions

2017-05-17 Thread Ashutosh Chauhan
/StatsSetupConst.java Line 286 (original), 289 (patched) <https://reviews.apache.org/r/58935/#comment248749> Need to update function name? Not limited to basic stats, nor to table (called for partitions as well.) - Ashutosh Chauhan On May 2, 2017, 10:04 p.m., pengcheng xiong

Re: Review Request 56140: Can't order by an unselected column

2017-05-16 Thread Ashutosh Chauhan
> On May 3, 2017, 4:24 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/cp_sel.q.out > > Line 46 (original), 50 (patched) > > <https://reviews.apache.org/r/56140/diff/8/?file=1704004#file1704004line50> > > > > Is this expected? >

Re: Review Request 59137: HIVE-16602: Implement shared scans with Tez

2017-05-11 Thread Ashutosh Chauhan
ct that they faithfully apply the filter, since they dont do per row filter evaluation, only at stripe level. - Ashutosh Chauhan On May 10, 2017, 10:20 a.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically gener

Re: Review Request 59137: HIVE-16602: Implement shared scans with Tez

2017-05-10 Thread Ashutosh Chauhan
109 (patched) <https://reviews.apache.org/r/59137/#comment247750> Comment about this represents. - Ashutosh Chauhan On May 10, 2017, 10:20 a.m., Jesús Camacho Rodríguez wrote: > > --

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-09 Thread Ashutosh Chauhan
ng exception, return null ? serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java Lines 1154 (patched) <https://reviews.apache.org/r/50787/#comment247525> Instead of throwing exception, return null ? - Ashutosh Chauhan On May 8, 2017, 3:17 p.m., Rui Li w

[Announce] New committer: Vineet Garg

2017-05-09 Thread Ashutosh Chauhan
The Project Management Committee (PMC) for Apache Hive has invited Vineet Garg to become a committer and we are pleased to announce that he has accepted. Welcome, Vineet! Thanks, Ashutosh

Re: Review Request 56140: Can't order by an unselected column

2017-05-02 Thread Ashutosh Chauhan
t. For an order by there should necessarily be a RS in plan, otherwise we can get sorting in map only plan. ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out Lines 580-588 (original) <https://reviews.apache.org/r/56140/#comment246734> Order by must have RS. - Ashutosh

Re: [VOTE] Should we release hive-storage 2.4.0rc0?

2017-05-01 Thread Ashutosh Chauhan
Downloaded tar ball. Shasum matches. Build from src. All looks good. +1 On Fri, Apr 28, 2017 at 11:39 AM, Pengcheng Xiong wrote: > I downloaded the tarball, extracted, installed it. It works well with Hive > 2.3 (candidate). Thus, +1 on this. Thanks a lot for your work! > > On Fri, Apr 28, 2017

[jira] [Created] (HIVE-16536) Various improvements in TestPerfCliDriver

2017-04-25 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16536: --- Summary: Various improvements in TestPerfCliDriver Key: HIVE-16536 URL: https://issues.apache.org/jira/browse/HIVE-16536 Project: Hive Issue Type

[jira] [Created] (HIVE-16512) Join fails on operator return path on CBO

2017-04-22 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16512: --- Summary: Join fails on operator return path on CBO Key: HIVE-16512 URL: https://issues.apache.org/jira/browse/HIVE-16512 Project: Hive Issue Type: Sub

[jira] [Created] (HIVE-16511) CBO looses inner casts on constants of complex type

2017-04-22 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16511: --- Summary: CBO looses inner casts on constants of complex type Key: HIVE-16511 URL: https://issues.apache.org/jira/browse/HIVE-16511 Project: Hive Issue

[jira] [Created] (HIVE-16494) udaf percentile_approx() may fail on CBO

2017-04-20 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16494: --- Summary: udaf percentile_approx() may fail on CBO Key: HIVE-16494 URL: https://issues.apache.org/jira/browse/HIVE-16494 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-16492) Create view doesn't work with Calcite Return path

2017-04-20 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16492: --- Summary: Create view doesn't work with Calcite Return path Key: HIVE-16492 URL: https://issues.apache.org/jira/browse/HIVE-16492 Project: Hive

[jira] [Created] (HIVE-16491) CBO cant handle join involving complex types in on condition

2017-04-20 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16491: --- Summary: CBO cant handle join involving complex types in on condition Key: HIVE-16491 URL: https://issues.apache.org/jira/browse/HIVE-16491 Project: Hive

[jira] [Created] (HIVE-16474) Upgrade Druid version to 0.10

2017-04-18 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16474: --- Summary: Upgrade Druid version to 0.10 Key: HIVE-16474 URL: https://issues.apache.org/jira/browse/HIVE-16474 Project: Hive Issue Type: Task

[jira] [Created] (HIVE-16434) Add support for parsing additional timestamp formats

2017-04-12 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16434: --- Summary: Add support for parsing additional timestamp formats Key: HIVE-16434 URL: https://issues.apache.org/jira/browse/HIVE-16434 Project: Hive

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-12 Thread Ashutosh Chauhan
g/r/58181/#comment244772> Won't we have this when user directly uses not <=> in query. How is that handled without this special map? - Ashutosh Chauhan On April 12, 2017, 12:14 a.m., Vineet Garg wrote: > > --- > This

Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

2017-04-11 Thread Ashutosh Chauhan
s.apache.org/r/57944/#comment244588> Can delete. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 1787 (patched) <https://reviews.apache.org/r/57944/#comment244589> Worth a comment on why basePlan.getCluster().getPlanner() != planner. - Ashutosh Chauhan

Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

2017-04-11 Thread Ashutosh Chauhan
che.org/r/57944/#comment244526> This is not expected. - Ashutosh Chauhan On April 11, 2017, 3:17 p.m., Remus Rusanu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[jira] [Created] (HIVE-16411) Revert HIVE-15199

2017-04-09 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16411: --- Summary: Revert HIVE-15199 Key: HIVE-16411 URL: https://issues.apache.org/jira/browse/HIVE-16411 Project: Hive Issue Type: Task Reporter

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-05 Thread Ashutosh Chauhan
gt; ^(KW_NOT EQUAL_NS) - Ashutosh Chauhan On April 4, 2017, 11:05 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[jira] [Created] (HIVE-16374) Remove serializer & deserializer interfaces

2017-04-04 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16374: --- Summary: Remove serializer & deserializer interfaces Key: HIVE-16374 URL: https://issues.apache.org/jira/browse/HIVE-16374 Project: Hive Issue

Re: [VOTE] Apache Hive 1.2.2 Release Candidate 0

2017-04-04 Thread Ashutosh Chauhan
search=gumashta&op=index. > > I think it will take a day or so for the KEYS file to be updated (it is > auto generated), but if you want to test the release in the meantime, > please use the above link to access the signing key. > > Thanks, > ‹Vaibhav > > On 4/3/17, 2:53 P

[jira] [Created] (HIVE-16365) Merge interface HiveStorageHandler in DefaultStorageHandler

2017-04-03 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16365: --- Summary: Merge interface HiveStorageHandler in DefaultStorageHandler Key: HIVE-16365 URL: https://issues.apache.org/jira/browse/HIVE-16365 Project: Hive

[jira] [Created] (HIVE-16364) Merge interface HiveMetaHook in DefaultHiveMetaHook

2017-04-03 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16364: --- Summary: Merge interface HiveMetaHook in DefaultHiveMetaHook Key: HIVE-16364 URL: https://issues.apache.org/jira/browse/HIVE-16364 Project: Hive Issue

Re: [VOTE] Apache Hive 1.2.2 Release Candidate 0

2017-04-03 Thread Ashutosh Chauhan
Hi Vaibhav, Can't locate your key at any of standard location. Can you point out which key you used to sign the release? Thanks, Ashutosh On Mon, Apr 3, 2017 at 12:51 AM, Vaibhav Gumashta wrote: > Hi everyone, > > Apache Hive 1.2.2 Release Candidate 0 is available here: > > https://dist.apache

[jira] [Created] (HIVE-16359) Update golden file for subquery_select.q

2017-04-03 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16359: --- Summary: Update golden file for subquery_select.q Key: HIVE-16359 URL: https://issues.apache.org/jira/browse/HIVE-16359 Project: Hive Issue Type: Test

Re: Review Request 57094: HIVE-15996

2017-04-03 Thread Ashutosh Chauhan
> On March 29, 2017, 11:19 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Line 3091 (original), 3096 (patched) > > <https://reviews.apache.org/r/57094/diff/1/?file=1650285#file1650285line3099> > > &g

Re: Review Request 57094: HIVE-15996

2017-03-29 Thread Ashutosh Chauhan
ement. ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out Lines 1070-1085 (patched) <https://reviews.apache.org/r/57094/#comment243339> Needs updating, now that undelying bug is fixed. - Ashutosh Chauhan On Feb. 27, 2017, 2:37 p.m., Jesús Camac

Re: Review Request 58004: HIVE-16228: Support for subqueries in complex expressions in SELECT

2017-03-29 Thread Ashutosh Chauhan
l), 78 (patched) <https://reviews.apache.org/r/58004/#comment243326> This change seems unnecessary. Having rule which does narrow matching is better. - Ashutosh Chauhan On March 28, 2017, 9:41 p.m., Vineet Garg wrote: > > --

Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

2017-03-27 Thread Ashutosh Chauhan
test/results/clientpositive/pointlookup3.q.out Line 1054 (original), 1054 (patched) <https://reviews.apache.org/r/57944/#comment242998> PointLookupOptimizer.java - Ashutosh Chauhan On March 27, 2017, 7:54 a.m., Remus Rusanu wrote: > > --

Re: Backward incompatible changes

2017-03-24 Thread Ashutosh Chauhan
> up Pengcheng's branch as branch-2.3. We should also consider the packaging > changes (shrouding protobuf, guava, and kyro) that would make integration > with Spark easier in branch-2.3. > > Thanks, >Owen > > > On Thu, Mar 23, 2017 at 11:15 PM, Ashutosh Chauhan >

Re: Backward incompatible changes

2017-03-23 Thread Ashutosh Chauhan
So, I just pushed branch-2 from current tip. Now, lets get 2.2 release out as soon as possible. Thanks, Ashutosh On Thu, Mar 23, 2017 at 9:46 PM, Ashutosh Chauhan wrote: > Cutting a branch should not slow down a 2.2 release. If any thing, this > should help in achieving stabilization

Re: Backward incompatible changes

2017-03-23 Thread Ashutosh Chauhan
t; points > >out, he is working on 2.2 and I will work on 2.3. Thanks. > > > >On Wed, Mar 22, 2017 at 1:32 PM, Ashutosh Chauhan < > hashut...@apache.org> > >wrote: > > > >> Unless there is more feedback, I plan to cut branch-2 in

Re: Backward incompatible changes

2017-03-22 Thread Ashutosh Chauhan
:23 PM, Ashutosh Chauhan wrote: > I hear what you are saying. Lets begin with 3 concerns: > > - How will we keep the community motivated on fixing both master and > branch-2? > Until we do a stable release from master, stable releases can come only > from branch-2. If a contributo

Review Request 57738: Enable cbo in presence of hints

2017-03-19 Thread Ashutosh Chauhan
923441a Diff: https://reviews.apache.org/r/57738/diff/1/ Testing --- Existing regression tests. Thanks, Ashutosh Chauhan

[jira] [Created] (HIVE-16244) Flaky test : dynamic_semijoin_reduction_3.q

2017-03-17 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16244: --- Summary: Flaky test : dynamic_semijoin_reduction_3.q Key: HIVE-16244 URL: https://issues.apache.org/jira/browse/HIVE-16244 Project: Hive Issue Type

[jira] [Created] (HIVE-16230) Enable CBO in presence of hints

2017-03-16 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-16230: --- Summary: Enable CBO in presence of hints Key: HIVE-16230 URL: https://issues.apache.org/jira/browse/HIVE-16230 Project: Hive Issue Type: Improvement

[ANNOUNCE] New PMC Member : Eugene Koifman

2017-03-14 Thread Ashutosh Chauhan
On behalf of the Hive PMC I am delighted to announce Eugene Koifman is joining Hive PMC. Eugene is a long time contributor in Hive and is focusing on ACID support areas these days. Welcome, Eugene! Thanks, Ashutosh

Re: Review Request 57620: Support the named columns join

2017-03-14 Thread Ashutosh Chauhan
positive/named_column_join.q Lines 29 (patched) <https://reviews.apache.org/r/57620/#comment241301> Test for 3-way join: select * from (select t1.b b from t t1 inner join t t2 using (b)) t3 join t t4 using(b); select * from (select t2.a a from t t1 inner join t t2 using (b)) t3 join t t4

Re: Review Request 57568: HIVE-15978 Support regr_* functions

2017-03-14 Thread Ashutosh Chauhan
c/test/results/clientpositive/udaf_binarysetfunctions.q.out Lines 399 (patched) <https://reviews.apache.org/r/57568/#comment241272> Testing on postgres, got NULL for covar_samp() instead of 0.0 - Ashutosh Chauhan On March 13, 2017

Re: Backward incompatible changes

2017-03-10 Thread Ashutosh Chauhan
ho just upgraded to > 2.x won't have any more features and improvements > because they will be developed on 3.0. > > - Sergio > > > > On Mon, Mar 6, 2017 at 1:24 PM, Ashutosh Chauhan < > ashutosh.chau...@gmail.com > > wrote: > > > The way it helps

<    1   2   3   4   5   6   7   8   9   10   >