Re: [ANNOUNCE] New PMC Member : Vineet Garg

2018-08-01 Thread Chaoyu Tang
Congratulations Vineet! On Tue, Jul 31, 2018 at 7:39 AM, Rajesh Balamohan < rajesh.balamo...@gmail.com> wrote: > Congratulations Vineet! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:34 PM Marta Kuczora > > wrote: > > > Congratulations Vineet! > > > > On Mon, Jul 30, 2018 at 9:45 AM Peter Vary

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

2018-08-01 Thread Chaoyu Tang
Congratulations Vihang. On Tue, Jul 31, 2018 at 7:39 AM, Rajesh Balamohan wrote: > Congratulations Vihang! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:35 PM Marta Kuczora > > wrote: > > > Congratulations Vihang! > > > > On Mon, Jul 30, 2018 at 9:44 AM Peter Vary > > wrote: > > > > >

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

2018-08-01 Thread Chaoyu Tang
Congratulations Sahil! On Tue, Jul 31, 2018 at 7:40 AM, Rajesh Balamohan wrote: > Congratulations Sahil! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:57 PM Marta Kuczora > > wrote: > > > Congratulations Sahil! > > > > On Mon, Jul 30, 2018 at 9:44 AM Peter Vary > > wrote: > > > > >

Re: [ANNOUNCE] New PMC Member : Peter Vary

2018-08-01 Thread Chaoyu Tang
Congratulations, Peter. On Wed, Aug 1, 2018 at 2:08 PM, Peter Vary wrote: > Thanks everyone! > > Rajesh Balamohan ezt írta (időpont: 2018. júl. > 31., > Ke 13:41): > > > Congratulations Peter! > > > > ~Rajesh.B > > > > > > On Tue, Jul 31, 2018 at 3:58 PM Marta Kuczora > > > > wrote: > > > > >

Re: adding the column to hive partition

2017-08-11 Thread Chaoyu Tang
Is not it right that the values for the new column of existing partition should be null? On Thu, Aug 10, 2017 at 9:53 PM, mallik new wrote: > Hello All, > > how to add the column to already partitioned table in hive, after i have > added the column using cascade, the new

Re: [Announce] New committer: Vihang Karajgaonkar

2017-07-07 Thread Chaoyu Tang
Congratulations Vihang !!!. On Fri, Jul 7, 2017 at 2:38 PM, Sergio Pena wrote: > Congratulations Vihang !!!. > > - Sergio > > On Fri, Jul 7, 2017 at 12:50 PM, Vaibhav Gumashta < > vgumas...@hortonworks.com > > wrote: > > > Congratulations Vihang! > > > > On 7/7/17,

Re: [ANNOUNCE] New PMC Member : Matt McCline

2017-07-07 Thread Chaoyu Tang
Congratulations Matt! On Fri, Jul 7, 2017 at 12:27 PM, Xuefu Zhang wrote: > Congratulations! > > On Fri, Jul 7, 2017 at 8:27 AM, Eugene Koifman > wrote: > > > Congratulations! > > > > On 7/7/17, 1:04 AM, "Zoltan Haindrich"

Re: [Announce] New committer: Teddy Choi

2017-07-07 Thread Chaoyu Tang
Congratulations Teddy! On Fri, Jul 7, 2017 at 4:07 PM, Peter Vary wrote: > Congratulatins Teddy! > > > On Jul 7, 2017, at 9:28 PM, Jimmy Xiang wrote: > > > > Congrats!! > > > > On Fri, Jul 7, 2017 at 11:37 AM, Sergio Pena >

Re: [Announce] New committer: Sahil Takiar

2017-07-07 Thread Chaoyu Tang
Congratulations Sahil !!! On Fri, Jul 7, 2017 at 2:38 PM, Sergio Pena wrote: > Congratulations Sahil !!! > > On Wed, Jul 5, 2017 at 7:49 PM, Ashutosh Chauhan > wrote: > > > The Project Management Committee (PMC) for Apache Hive has invited Sahil

Re: [Announce] New committer: Deepesh Khandelwal

2017-07-07 Thread Chaoyu Tang
Congratulations Deepesh! On Fri, Jul 7, 2017 at 4:07 PM, Peter Vary wrote: > Congratulations Deepesh! > > > On Jul 7, 2017, at 8:38 PM, Sergio Pena > wrote: > > > > Congratulations Deepesh !!! > > > > On Wed, Jul 5, 2017 at 7:48 PM, Ashutosh

Re: [Announce] New committer: Peter Vary

2017-07-07 Thread Chaoyu Tang
Congratulations Peter! On Fri, Jul 7, 2017 at 3:29 PM, Jimmy Xiang wrote: > Congrats!! > > On Fri, Jul 7, 2017 at 11:38 AM, Sergio Pena > wrote: > > Congrats Peter !! > > > > On Fri, Jul 7, 2017 at 12:51 PM, Vaibhav Gumashta < >

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-01 Thread Chaoyu Tang
+1. A nice move which might help HMS to be more easily adopted by more other components. On Sat, Jul 1, 2017 at 12:41 AM, Sushanth Sowmyan wrote: > +1 > > On Jun 30, 2017 17:05, "Owen O'Malley" wrote: > > > On Fri, Jun 30, 2017 at 3:26 PM, Chao Sun

[jira] [Created] (HIVE-16803) Alter table change column comment should not try to get column stats for update

2017-06-01 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16803: -- Summary: Alter table change column comment should not try to get column stats for update Key: HIVE-16803 URL: https://issues.apache.org/jira/browse/HIVE-16803 Project

Re: [Announce] New committer: Vineet Garg

2017-05-09 Thread Chaoyu Tang
Congratulations Vineet! On Tue, May 9, 2017 at 6:34 PM, Vaibhav Gumashta wrote: > Congrats Vineet. > > ‹Vaibhav > > On 5/9/17, 1:54 PM, "Deepak Jaiswal" wrote: > > >Congratulations Vineet! > > > >On 5/9/17, 1:51 PM, "Jimmy Xiang"

Re: Review Request 58992: HIVE-16572: Rename a partition should not drop its column stats

2017-05-08 Thread Chaoyu Tang
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58992/#review174165 ------- On May 4, 2017, 2:19 p.m., Chaoyu Tang wrote: > > --

Re: Welcome new Hive committer, Zhihai Xu

2017-05-07 Thread Chaoyu Tang
Congrats Zhihai!! Chaoyu On Sun, May 7, 2017 at 8:58 AM, Rui Li wrote: > Congrats Zhihai :) > > On Sun, May 7, 2017 at 3:41 PM, Lefty Leverenz > wrote: > > > Congratulations Zhihai! > > > > -- Lefty > > > > > > On Sat, May 6, 2017 at 2:06 AM,

Review Request 58992: HIVE-16572: Rename a partition should not drop its column stats

2017-05-04 Thread Chaoyu Tang
/ Testing --- Manual tests new qtests Thanks, Chaoyu Tang

[jira] [Created] (HIVE-16572) Rename a partition should not drop its column stats

2017-05-02 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16572: -- Summary: Rename a partition should not drop its column stats Key: HIVE-16572 URL: https://issues.apache.org/jira/browse/HIVE-16572 Project: Hive Issue Type: Bug

Re: Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats

2017-04-28 Thread Chaoyu Tang
visit: https://reviews.apache.org/r/58686/#review173359 ------- On April 28, 2017, 6:19 p.m., Chaoyu Tang wrote: > > --- > This is an automatically generat

Re: Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats

2017-04-28 Thread Chaoyu Tang
, Chaoyu Tang

Re: ptest not running?

2017-04-26 Thread Chaoyu Tang
It looks the ptest is still having the problem. Either submitting patch in JIRA or manual build could not trigger the tests. On Tue, Apr 25, 2017 at 11:31 PM, Eugene Koifman wrote: > I see HIVE-16445 in it – it was picked up automatically > > On 4/25/17, 5:44 PM,

Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats

2017-04-24 Thread Chaoyu Tang
/src/test/results/clientpositive/alter_table_column_stats.q.out PRE-CREATION ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out 85d7dc4 Diff: https://reviews.apache.org/r/58686/diff/1/ Testing --- manual tests qtests Thanks, Chaoyu Tang

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-19 Thread Chaoyu Tang
- > > (Updated April 14, 2017, 1:14 p.m.) > > > Review request for hive, Aihua Xu, Chaoyu Tang, and Sergio Pena. > > > Bugs: HIVE-16426 > https://issues.apache.org/jira/browse/HIVE-16426 > > > Repository: hive-git > > > Description

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-06 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58086/#review171222 --- Ship it! Ship It! - Chaoyu Tang On April 6, 2017, 4:12 p.m

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-06 Thread Chaoyu Tang
nstead of Integer.MAX_VALUE? - Chaoyu Tang On April 6, 2017, 6:04 a.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Created] (HIVE-16394) HoS does not support queue name change in middle of session

2017-04-05 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16394: -- Summary: HoS does not support queue name change in middle of session Key: HIVE-16394 URL: https://issues.apache.org/jira/browse/HIVE-16394 Project: Hive Issue

Re: Review Request 55498: HIVE-15538: Test HIVE-13884 with more complex query predicates

2017-04-01 Thread Chaoyu Tang
> On Jan. 27, 2017, 4:22 p.m., Chaoyu Tang wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java > > Lines 193 (patched) > > <https://reviews.apache.org/r/55498/diff/2/?file=1604754#file1604754line193> > >

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-15 Thread Chaoyu Tang
ation to an existing one, its column and table > > stats disappeared. This is expected as we are now using the new location. > > Could u be talk more about how to reproduce the problem? Thanks. > > Chaoyu Tang wrote: > Hi, PengCheng, thanks for reviewing the patch. The current logi

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-15 Thread Chaoyu Tang
ts or rolls back, and the 2nd transaction to revert the DB changes is no more needed. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57566/#review169037 ---

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

2017-03-15 Thread Chaoyu Tang
Congratulations Eugene! On Wed, Mar 15, 2017 at 11:52 AM, Jimmy Xiang wrote: > Congrats!! > > On Wed, Mar 15, 2017 at 7:31 AM, Sergio Pena > wrote: > > Congratulations Eugene !! > > > > On Wed, Mar 15, 2017 at 5:41 AM, Prasanth Jayachandran < > >

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-14 Thread Chaoyu Tang
://reviews.apache.org/r/57566/diff/3-4/ Testing --- Thanks, Chaoyu Tang

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/57566/diff/3/ Changes: https://reviews.apache.org/r/57566/diff/2-3/ Testing --- Thanks, Chaoyu Tang

Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/57566/diff/2/ Changes: https://reviews.apache.org/r/57566/diff/1-2/ Testing --- Thanks, Chaoyu Tang

Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang
/1/ Testing --- Thanks, Chaoyu Tang

[jira] [Created] (HIVE-16189) Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16189: -- Summary: Table column stats might be invalidated in a failed table rename Key: HIVE-16189 URL: https://issues.apache.org/jira/browse/HIVE-16189 Project: Hive

[jira] [Created] (HIVE-16147) Rename a partitioned table should not drop its partition columns stats

2017-03-08 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16147: -- Summary: Rename a partitioned table should not drop its partition columns stats Key: HIVE-16147 URL: https://issues.apache.org/jira/browse/HIVE-16147 Project: Hive

[jira] [Created] (HIVE-16071) Spark remote driver misuses the timeout in RPC handshake

2017-02-28 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16071: -- Summary: Spark remote driver misuses the timeout in RPC handshake Key: HIVE-16071 URL: https://issues.apache.org/jira/browse/HIVE-16071 Project: Hive Issue Type

Review Request 56970: HIVE-16019: Query fails when group by/order by on same column with uppercase name

2017-02-22 Thread Chaoyu Tang
/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2430811 ql/src/test/queries/clientpositive/order3.q PRE-CREATION ql/src/test/results/clientpositive/order3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/56970/diff/ Testing --- new qtests. Thanks, Chaoyu Tang

[jira] [Created] (HIVE-16019) Query fails when group by/order by on same column with uppercase name

2017-02-22 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16019: -- Summary: Query fails when group by/order by on same column with uppercase name Key: HIVE-16019 URL: https://issues.apache.org/jira/browse/HIVE-16019 Project: Hive

[jira] [Created] (HIVE-15966) Query column alias fails in order by

2017-02-17 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15966: -- Summary: Query column alias fails in order by Key: HIVE-15966 URL: https://issues.apache.org/jira/browse/HIVE-15966 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-15815) Allow to pass some Oozie properties to Spark in HoS

2017-02-04 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15815: -- Summary: Allow to pass some Oozie properties to Spark in HoS Key: HIVE-15815 URL: https://issues.apache.org/jira/browse/HIVE-15815 Project: Hive Issue Type

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-31 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/#review163784 --- Ship it! LGTM, +1 - Chaoyu Tang On Jan. 30, 2017, 8:48 p.m

Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section

2017-01-27 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55932/#review163284 --- Ship it! LGTM. +1 - Chaoyu Tang On Jan. 25, 2017, 3:03 p.m

Re: Review Request 55498: HIVE-15538: Test HIVE-13884 with more complex query predicates

2017-01-27 Thread Chaoyu Tang
doop/hive/ql/TestMetaStoreLimitPartitionRequest.java (line 230) <https://reviews.apache.org/r/55498/#comment234716> HMS filter might support the IN clause, but not the LIKE in query predicate. - Chaoyu Tang On Jan. 13, 2017, 3:26 p.m., M

[jira] [Created] (HIVE-15742) Column stats should be preserved when it is renamed

2017-01-26 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15742: -- Summary: Column stats should be preserved when it is renamed Key: HIVE-15742 URL: https://issues.apache.org/jira/browse/HIVE-15742 Project: Hive Issue Type

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-24 Thread Chaoyu Tang
Diff: https://reviews.apache.org/r/55731/diff/ Testing --- 1. Manual tests 2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-24 Thread Chaoyu Tang
unt and raw_data_size? If so, is there any use of numFiles/totalSize? - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55731/#review162771 -------

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-23 Thread Chaoyu Tang
2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-23 Thread Chaoyu Tang
://reviews.apache.org/r/55731/diff/ Testing --- 1. Manual tests 2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-23 Thread Chaoyu Tang
it is not necessary to have/call hasStatsInParameters function. > > Chaoyu Tang wrote: > Thanks PengCheng for reviewing the patch. I looked through the code > related to this STATS status and feel a little confusing, here are some > questions I need help from you. To my underst

Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-20 Thread Chaoyu Tang
atch after testing. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55731/#review162357 --- On Jan. 19, 2017, 10:29 p.m., Chaoyu Tan

Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats

2017-01-19 Thread Chaoyu Tang
-CREATION Diff: https://reviews.apache.org/r/55731/diff/ Testing --- 1. Manual tests 2. new unit tests Thanks, Chaoyu Tang

Re: Review Request 55479: Improve canceling response time for acquiring locks

2017-01-13 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55479/#review161552 --- Ship it! Ship It! - Chaoyu Tang On Jan. 13, 2017, 5:14 p.m

Re: Review Request 55479: Improve canceling response time for acquiring locks

2017-01-12 Thread Chaoyu Tang
9/#comment232768> as I commented before, the DriverState class might provide this method for inspecting this state, which looks better. - Chaoyu Tang On Jan. 12, 2017, 11:21 p.m., Yongzhi Chen wrote: > > --- > This is a

[jira] [Created] (HIVE-15485) Investigate the DoAs failure in HoS

2016-12-21 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15485: -- Summary: Investigate the DoAs failure in HoS Key: HIVE-15485 URL: https://issues.apache.org/jira/browse/HIVE-15485 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-15446) Hive fails in recursive debug

2016-12-16 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15446: -- Summary: Hive fails in recursive debug Key: HIVE-15446 URL: https://issues.apache.org/jira/browse/HIVE-15446 Project: Hive Issue Type: Bug Components

Re: Invitation for Hive committers to become ORC committers

2016-12-15 Thread Chaoyu Tang
I am interested in. Thanks Chaoyu On Thu, Dec 15, 2016 at 5:13 PM, Rajesh Balamohan wrote: > I would be interested. Thanks. > > ~Rajesh.B > > On Fri, Dec 16, 2016 at 3:31 AM, Mithun Radhakrishnan < > mithun.radhakrish...@yahoo.com.invalid> wrote: > > > I'd be keen. > >

[jira] [Created] (HIVE-15410) WebHCat supports get/set table property with its name containing period and hyphen

2016-12-09 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15410: -- Summary: WebHCat supports get/set table property with its name containing period and hyphen Key: HIVE-15410 URL: https://issues.apache.org/jira/browse/HIVE-15410 Project

[jira] [Created] (HIVE-15341) Get work path instead of attempted task path in HiveHFileOutputFormat

2016-12-02 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15341: -- Summary: Get work path instead of attempted task path in HiveHFileOutputFormat Key: HIVE-15341 URL: https://issues.apache.org/jira/browse/HIVE-15341 Project: Hive

Re: Review Request 53838: HIVE-15232: Add notification events for functions and indexes

2016-11-17 Thread Chaoyu Tang
/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java (line 296) <https://reviews.apache.org/r/53838/#comment226426> Nit: remove empty spaces - Chaoyu Tang On Nov. 17, 2016, 8:48 p.m., Mohit Sabharwal

Re: Review Request 52800: HIVE-13966: DbNotificationListener: can loose DDL operation notifications

2016-11-10 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52800/#review155616 --- Ship it! Ship It! - Chaoyu Tang On Nov. 10, 2016, 5:40 p.m

Re: Review Request 52800: HIVE-13966: DbNotificationListener: can loose DDL operation notifications

2016-11-10 Thread Chaoyu Tang
> On Nov. 8, 2016, 4:13 p.m., Chaoyu Tang wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java, line > > 86 > > <https://reviews.apache.org/r/52800/diff/1/?file=1556283#file1556283line86> > > > > I wonder if the API changes

Re: Review Request 53570: HIVE-12891 : Hive fails when java.io.tmpdir is set to a relative location

2016-11-08 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53570/#review155315 --- Ship it! Ship It! - Chaoyu Tang On Nov. 8, 2016, 9:22 a.m

Re: Review Request 52800: HIVE-13966: DbNotificationListener: can loose DDL operation notifications

2016-11-08 Thread Chaoyu Tang
/hadoop/hive/metastore/AlterHandler.java (line 86) <https://reviews.apache.org/r/52800/#comment225118> I wonder if the API changes will cause some backward compatibility issue, if the HiveMetaStore is currently the only consumer of the AlterHandler, it should be fine. - Chaoyu Tang On N

[jira] [Created] (HIVE-15109) Set MaxPermSize to 256M for maven tests

2016-11-01 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15109: -- Summary: Set MaxPermSize to 256M for maven tests Key: HIVE-15109 URL: https://issues.apache.org/jira/browse/HIVE-15109 Project: Hive Issue Type: Test

[jira] [Created] (HIVE-15091) Master: Update errata.txt for the missing JIRA number in HIVE-14909 commit msg

2016-10-28 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15091: -- Summary: Master: Update errata.txt for the missing JIRA number in HIVE-14909 commit msg Key: HIVE-15091 URL: https://issues.apache.org/jira/browse/HIVE-15091 Project

Re: Review Request 53110: HIVE-14909: Preserve the "parent location" of the table when an "alter table rename to " is submitted (the case when the db location is not specified and the

2016-10-26 Thread Chaoyu Tang
the old code works in this way, and I think it reasonable so did not change that. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53110/#review153924 -----

Re: Review Request 53110: HIVE-14909: Preserve the "parent location" of the table when an "alter table rename to " is submitted (the case when the db location is not specified and the

2016-10-25 Thread Chaoyu Tang
://reviews.apache.org/r/53110/diff/ Testing --- Unit tests Manaual tests Thanks, Chaoyu Tang

[jira] [Created] (HIVE-15059) Flaky test: TestSemanticAnalysis#testAlterTableRename

2016-10-25 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15059: -- Summary: Flaky test: TestSemanticAnalysis#testAlterTableRename Key: HIVE-15059 URL: https://issues.apache.org/jira/browse/HIVE-15059 Project: Hive Issue Type

Re: Review Request 53148: HIVE-15025: Secure-Socket-Layer (SSL) support for HMS

2016-10-25 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53148/#review153796 --- Ship it! Ship It! - Chaoyu Tang On Oct. 24, 2016, 8:51 p.m

[jira] [Created] (HIVE-15043) HMS supports Oracle 12c as its backend database

2016-10-24 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-15043: -- Summary: HMS supports Oracle 12c as its backend database Key: HIVE-15043 URL: https://issues.apache.org/jira/browse/HIVE-15043 Project: Hive Issue Type

Re: Review Request 53110: HIVE-14909: Preserve the "parent location" of the table when an "alter table rename to " is submitted (the case when the db location is not specified and the

2016-10-22 Thread Chaoyu Tang
/metastore/HiveAlterHandler.java 7b84595 ql/src/test/queries/clientpositive/encryption_move_tbl.q a25d955 ql/src/test/results/clientpositive/encrypted/encryption_move_tbl.q.out 910ce25 Diff: https://reviews.apache.org/r/53110/diff/ Testing --- Unit tests Manaual tests Thanks, Chaoyu

Review Request 53110: HIVE-14909: Preserve the "parent location" of the table when an "alter table rename to " is submitted (the case when the db location is not specified and the Hiv

2016-10-21 Thread Chaoyu Tang
, Chaoyu Tang

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Chaoyu Tang
might not work as expected. - Chaoyu Tang On Oct. 13, 2016, 8:43 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-13 Thread Chaoyu Tang
://reviews.apache.org/r/52559/diff/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

Re: Review Request 52743: HIVE-14927 Remove code duplication from tests in TestLdapAtnProviderWithMiniDS

2016-10-13 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52743/#review152498 --- Ship it! Ship It! - Chaoyu Tang On Oct. 11, 2016, 5:18 p.m

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-11 Thread Chaoyu Tang
://reviews.apache.org/r/52559/diff/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-11 Thread Chaoyu Tang
rves a follow-up JIRA. - Chaoyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52559/#review152246 --- On Oct. 11, 20

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-11 Thread Chaoyu Tang
), this state is explicitly checked. If the destroy is called, the driver will do the final cleaning up and after that, driver could no more be useful. - Chaoyu --- This is an automatically generated e-mail. To re

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-11 Thread Chaoyu Tang
: https://reviews.apache.org/r/52559/diff/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

[jira] [Created] (HIVE-14930) RuntimeException was seen in explainanalyze_3.q test log

2016-10-11 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14930: -- Summary: RuntimeException was seen in explainanalyze_3.q test log Key: HIVE-14930 URL: https://issues.apache.org/jira/browse/HIVE-14930 Project: Hive Issue Type

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-09 Thread Chaoyu Tang
--- Manually tests Precommit tests Thanks, Chaoyu Tang

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-09 Thread Chaoyu Tang
://reviews.apache.org/r/52559/diff/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-09 Thread Chaoyu Tang
: https://reviews.apache.org/r/52559/diff/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-05 Thread Chaoyu Tang
ql/src/java/org/apache/hadoop/hive/ql/Driver.java dd55434 Diff: https://reviews.apache.org/r/52559/diff/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-05 Thread Chaoyu Tang
sting method like releasePlan(plan) is already the synchronized method. We do not the locks for ctx access since it has been gurantteed to be accessed by one thread since the close thread is halt in waiting when the query process is accesing this variable. - Chaoyu ------

Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

2016-10-05 Thread Chaoyu Tang
/ Testing --- Manually tests Precommit tests Thanks, Chaoyu Tang

[jira] [Created] (HIVE-14874) Master: Update errata.txt for missing JIRA nubmer in HIVE-9423 commit msg

2016-10-01 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14874: -- Summary: Master: Update errata.txt for missing JIRA nubmer in HIVE-9423 commit msg Key: HIVE-14874 URL: https://issues.apache.org/jira/browse/HIVE-14874 Project: Hive

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-22 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51694/#review150064 --- Ship it! LGTM. Thanks Illya!. - Chaoyu Tang On Sept. 22

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Chaoyu Tang
> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote: > > service/src/java/org/apache/hive/service/auth/ldap/Query.java, line 122 > > <https://reviews.apache.org/r/51694/diff/1/?file=1492949#file1492949line122> > > > > Will it improve the performance to se

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Chaoyu Tang
> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote: > > service/src/java/org/apache/hive/service/auth/ldap/LdapUtils.java, line 105 > > <https://reviews.apache.org/r/51694/diff/1/?file=1492948#file1492948line105> > > > > This method might throw

[jira] [Created] (HIVE-14799) Query operation are not thread safe during its cancellation

2016-09-20 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14799: -- Summary: Query operation are not thread safe during its cancellation Key: HIVE-14799 URL: https://issues.apache.org/jira/browse/HIVE-14799 Project: Hive Issue

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-16 Thread Chaoyu Tang
nge. service/src/java/org/apache/hive/service/auth/ldap/Query.java (line 122) <https://reviews.apache.org/r/51694/#comment216868> Will it improve the performance to set the search limit? I did not see it is used. - Chaoyu T

[jira] [Created] (HIVE-14774) Canceling query using Ctrl-C in beeline might lead to stale locks

2016-09-16 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14774: -- Summary: Canceling query using Ctrl-C in beeline might lead to stale locks Key: HIVE-14774 URL: https://issues.apache.org/jira/browse/HIVE-14774 Project: Hive

Review Request 51699: HIVE-12812: Enable mapred.input.dir.recursive by default to support union with aggregate function

2016-09-07 Thread Chaoyu Tang
Precommit tests Thanks, Chaoyu Tang

Re: Review Request 51395: HIVE-14626: Support Trash in Truncate Table

2016-09-07 Thread Chaoyu Tang
tests New ptests precommit tests Thanks, Chaoyu Tang

[jira] [Created] (HIVE-14697) Can not access kerberized HS2 Web UI

2016-09-02 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14697: -- Summary: Can not access kerberized HS2 Web UI Key: HIVE-14697 URL: https://issues.apache.org/jira/browse/HIVE-14697 Project: Hive Issue Type: Bug

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-31 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review147447 --- Ship it! LGTM - Chaoyu Tang On Aug. 31, 2016, 3:32 p.m

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-31 Thread Chaoyu Tang
> On Aug. 31, 2016, 1:48 a.m., Chaoyu Tang wrote: > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java, > > line 488 > > <https://reviews.apache.org/r/51435/diff/3/?file=1488428#file1488428line488> > > >

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-31 Thread Chaoyu Tang
> On Aug. 27, 2016, 3:20 a.m., Chaoyu Tang wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java, line 72 > > <https://reviews.apache.org/r/51435/diff/2/?file=1486030#file1486030line72> > > > > hive.conf.hidden.list is usually not default

  1   2   3   4   5   >