Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149832 --- Ship it! Thanks, LGTM. - Gabor Szadovszky On Sept. 21, 2016

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

/LegacyMetrics.java (line 244) <https://reviews.apache.org/r/52084/#comment217536> throws clause is not required here - Gabor Szadovszky On Sept. 21, 2016, 9:24 a.m., Barna Zsombor Klara wrote: > > --- > This is an automatica

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review149643 --- Ship it! Thanks for the patch. LGTM. - Gabor Szadovszky On

Re: Review Request 51895: HIVE-14714 - Finishing Hive on Spark causes "java.io.IOException: Stream closed"

rector timeout - The submit process ends properly after the RemoteDriver stopped Expected behavior: After ending the actual session the client exits immediately (beeline). All the stdout/stderr of the RemoteDriver are captured properly in the hive.log until the redirector timeout. Thanks, Gabor Szadovszky

Re: Review Request 51895: HIVE-14714 - Finishing Hive on Spark causes "java.io.IOException: Stream closed"

meout > - Generating output for more time than the actual redirector timeout > - The submit process ends properly after the RemoteDriver stopped > > Expected behavior: After ending the actual session the client exits > immediately (beeline). All the stdout/stderr of the RemoteDriver are captured > properly in the hive.log until the redirector timeout. > > > Thanks, > > Gabor Szadovszky > >

Review Request 51895: HIVE-14714 - Finishing Hive on Spark causes "java.io.IOException: Stream closed"

er ending the actual session the client exits immediately (beeline). All the stdout/stderr of the RemoteDriver are captured properly in the hive.log until the redirector timeout. Thanks, Gabor Szadovszky

[jira] [Created] (HIVE-14714) Finishing Hive on Spark causes "java.io.IOException: Stream closed"

Gabor Szadovszky created HIVE-14714: --- Summary: Finishing Hive on Spark causes "java.io.IOException: Stream closed" Key: HIVE-14714 URL: https://issues.apache.org/jira/browse/HIVE-14714

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148013 --- Ship it! LGTM - Gabor Szadovszky On Sept. 6, 2016, 11:53

Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters - second version

> On Sept. 6, 2016, 1:21 p.m., Gabor Szadovszky wrote: > > LGTM > > Marta Kuczora wrote: > Thanks a lot for the review by the way. I forgot to write it earlier. :) You're very welcome. :) - Gabor --- T

Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters - second version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51334/#review147822 --- Ship it! LGTM - Gabor Szadovszky On Sept. 6, 2016, 1:10 p.m

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

BeelineWithHS2ConnectionFile.java (line 219) <https://reviews.apache.org/r/51593/#comment214912> I guess, it was a debug output only... - Gabor Szadovszky On Sept. 2, 2016, 6:30 a.m., Vihang Karajgaonkar wrote: > > --- >

Re: Review Request 51568: HIVE-13555 add nullif

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51568/#review147602 --- Ship it! Thanks for the patch. LGTM. - Gabor Szadovszky On

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487193#file1487193line195> > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Ha

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487193#file1487193line195> > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Ha

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java (line 36) <https://reviews.apache.org/r/51468/#comment214041> I agree that it looks better however, I cannot see the point of this refactor. It seems that the original implementation was good enough. Do I miss something? - Gabor Sza

Re: Review Request 51046: Support explain analyze in Hive

ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java (line 151) <https://reviews.apache.org/r/51046/#comment214028> nit: Trailing whitespaces should be removed. ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java (line 504) <https://reviews.apache.org/r/51046/#comment

Re: Review Request 51193: HIVE-14358: Add metrics for number of queries executed for each execution engine (mr, spark, tez)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51193/#review147030 --- LGTM. Thanks for the patch. - Gabor Szadovszky On Aug. 18

Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters - second version

> On Aug. 26, 2016, 5:39 p.m., Gabor Szadovszky wrote: > > Some minor findings/questions. LGTM, otherwise. Thanks for the patch. :) - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters - second version

<https://reviews.apache.org/r/51334/#comment213939> From performance point of view it might be a good idea to use something like appendEscapedValue(StringBuilder, String) instead to avoid creating several StringBuilder and String objects. - Gabor Szadovszky On Aug. 23, 2016, 2:45 p.m., Marta K

Re: Review Request 51381: HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns

Not sure what would be the maximum number of rows. Is int enough? metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java (line 501) <https://reviews.apache.org/r/51381/#comment213669> Is there a missing string to be added? I don't think it make

Re: Review Request 51395: HIVE-14626: Support Trash in Truncate Table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51395/#review146881 --- LGTM. Thanks for the patch. - Gabor Szadovszky On Aug. 24

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review146879 --- LGTM, thanks for the patch. - Gabor Szadovszky On Aug. 25

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

ive/cli/control/CliConfig.java (line 248) <https://reviews.apache.org/r/51397/#comment213642> The spec of runDisabled says to include ".q.disabled" AS WELL. By implementation it seems it will include ONLY ".q.diabled" files. - Gabor Szadovszky On A

Re: Review Request 51251: HIVE-14588: Add S3 credentials to the hidden configuration variable supported on HIVE-14207

/51251/diff/ Testing --- Manual testing. (Using an already existing and unit tested solution, no additional unit test is required.) Thanks, Gabor Szadovszky

Re: Review Request 51251: HIVE-14588: Add S3 credentials to the hidden configuration variable supported on HIVE-14207

/diff/ Testing (updated) --- Manual testing. (Using an already existing and unit tested solution, no additional unit test is required.) Thanks, Gabor Szadovszky

Review Request 51251: HIVE-14588: Add S3 credentials to the hidden configuration variable supported on HIVE-14207

--- HIVE-14588: Add S3 credentials to the hidden configuration variable supported on HIVE-14207 Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c89d72ec16ec5b1563f56797102ac2c9ad9db8ee Diff: https://reviews.apache.org/r/51251/diff/ Testing --- Thanks, Gabor

[jira] [Created] (HIVE-14588) Add S3 credentials to the hidden configuration variable supported on HIVE-14207

Gabor Szadovszky created HIVE-14588: --- Summary: Add S3 credentials to the hidden configuration variable supported on HIVE-14207 Key: HIVE-14588 URL: https://issues.apache.org/jira/browse/HIVE-14588

contributor role request

Hi, Could you please grant me contributor access to the JIRA for Hive so that I can resolve issues? My username is gszadovszky. Thanks a lot in advance. Regards, Gabor

Review Request 50502: HIVE-14294: HiveSchemaConverter for Parquet doesn't translate TINYINT and SMALLINT into proper Parquet types

anual tests Thanks, Gabor Szadovszky