Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > Overall looks good. Thanks for taking this up. I suggested some small > > improvements to the tests below. Thanks Adam and Vihang for the review! > On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 12, 2018, 11:58 a.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 350 (patched) > > > > > > I think we should catch

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 350 (patched) > > > > > > I think we should catch

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 11, 2018, 12:54 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 52 (patched) > > > > > > Parameterized tests don't

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195158 --- Fix it, then Ship it! Overall looks good. Thanks for taking

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > Thanks for the review Vihang! > On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 52 (patched) > >

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 10, 2018, 3:44 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195114 ---

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 8, 2018, 3:15 p.m., Marta Kuczora wrote: > > Thanks a lot for creating this testing infra for HMS testing!!! > > Overall it looks great to me, I would have only a few suggestions regarding > > the database tests. Please see my notes in the file. Thanks for the review Marta! > On

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 9, 2018, 2:50 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review194948 --- Thanks a lot for creating this testing infra for HMS testing!!!