Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

> On Nov. 2, 2017, 10:40 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 265 (patched) > > > > > > Shouldn't we use > > parts =

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

> On Nov. 2, 2017, 10:40 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 265 (patched) > > > > > > Shouldn't we use > > parts =

Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63528/ --- Review request for hive, Peter Vary and Barna Zsombor Klara. Bugs: HIVE-17969

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

> On Nov. 6, 2017, 6:51 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 263-264 (original), 275-278 (patched) > > > > > >

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63528/ --- (Updated Nov. 7, 2017, 10:22 a.m.) Review request for hive, Peter Vary and

Review Request 63144: HIVE-16748: Integreate YETUS to Pre-Commit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63144/ --- Review request for hive, Peter Vary and Barna Zsombor Klara. Bugs: HIVE-16748

Re: Review Request 63144: HIVE-16748: Integreate YETUS to Pre-Commit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63144/ --- (Updated Oct. 26, 2017, 7:04 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 350 (patched) > > > > > > I think we should catch

Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18468

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

> On Jan. 19, 2018, 11:41 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 122 (patched) > > > > > > nit: Why static? I like

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195796 --- Overall looks good, I just have small observations. One more

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 19, 2018, 2:29 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195825 --- Looks good! I added small issues to fix, similarly with the

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/#review195891 --- This change looks good! I only spotted some small

Review Request 65284: Create tests to cover listPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18484

Review Request 65285: Create tests to cover getPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18483

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 23, 2018, 1:38 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 223 (patched) > > > > > > When altering a

Review Request 65353: Create tests to cover getTableMeta method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65353/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18542

Re: Review Request 65285: Create tests to cover getPartition(s) methods

> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 200 (patched) > > > > > > Maybe test for case

Re: Review Request 65285: Create tests to cover getPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/ --- (Updated Jan. 24, 2018, 2:02 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65284: Create tests to cover listPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- (Updated Jan. 25, 2018, 1:47 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65285: Create tests to cover getPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/ --- (Updated Jan. 25, 2018, 1:51 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 25, 2018, 1:52 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65284: Create tests to cover listPartition(s) methods

> On Jan. 25, 2018, 11:37 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > > Lines 762-765 (patched) > > > > > > Is this the same

Re: Review Request 65353: Create tests to cover getTableMeta method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65353/ --- (Updated Jan. 30, 2018, 4:53 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196418 --- Thanks for the patch Marta, it looks very thourough! I've added

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196428 --- Ship it! Ship It! - Adam Szita On Jan. 29, 2018, 12:49

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196517 --- Ship it! Ship It! - Adam Szita On Jan. 30, 2018, 8:15 a.m.,

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196430 --- Nice patch with well covered cases. Since this is a lot of test

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196979 --- Fix it, then Ship it! Thanks for the patch Marta, this is

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

> On Feb. 21, 2018, 1:37 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 3370 (patched) > > > > > > How "expensive" is this call? Is this

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198106 --- Ship it! Ship It! - Adam Szita On Feb. 21, 2018, 11:37

Re: Review Request 68656: HIVE-20505: upgrade org.openjdk.jmh:jmh-core to 1.21

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68656/#review208448 --- Ship it! Ship It! - Adam Szita On Sept. 6, 2018, 10:07

Re: Review Request 67895: Improve HiveMetaStoreClient.dropDatabase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67895/ --- (Updated July 13, 2018, 9:22 a.m.) Review request for hive. Changes ---

Review Request 67895: Improve HiveMetaStoreClient.dropDatabase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67895/ --- Review request for hive. Bugs: HIVE-18705

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195900 --- Thanks for this patch Marta, it looks good! I've made a few

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review196012 --- Fix it, then Ship it! Looking good, thanks Peter!

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196031 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 4:47 p.m.,

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196003 --- Fix it, then Ship it! Looks good Peter, thanks for the patch!

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review196029 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 11:18

Re: Review Request 65284: Create tests to cover listPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- (Updated Jan. 24, 2018, 11:22 a.m.) Review request for hive, Marta Kuczora and

Re: Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/#review211278 --- Ship it! Ship It! - Adam Szita On Dec. 12, 2018, 3:13 p.m.,

Re: Review Request 69410: HIVE-20330: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

> On Nov. 22, 2018, 1:25 p.m., Peter Vary wrote: > > My only concen is that some other components might use HCAT_KEY_JOB_INFO > > property values as well? Was this a public property key? > > > > Otherwise nicely done! Thanks for looking into this change, AFAIK HCAT_KEY_JOB_INFO is only used

Review Request 69410: HIVE-20330: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69410/ --- Review request for hive, Nandor Kollar and Peter Vary. Bugs: HIVE-20330

Re: Review Request 70453: HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70453/#review214635 ---

Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71575/ --- Review request for hive. Bugs: HIVE-22284

Re: Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71575/ --- (Updated Oct. 7, 2019, 2:26 p.m.) Review request for hive. Changes ---

Re: Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71575/ --- (Updated Oct. 8, 2019, 7:53 a.m.) Review request for hive. Bugs: HIVE-22284

Re: Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71575/ --- (Updated Oct. 3, 2019, 3:20 p.m.) Review request for hive. Changes ---

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220266 --- Ship it! Ship It! - Adam Szita On April 6, 2020, 10:04

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

> On April 9, 2020, 9:09 a.m., Adam Szita wrote: > > Ship It! Committed. This can be closed. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220266

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220102 --- Looking pretty good overall, I just have a few