Re: Review Request 15855: Check DATABASES/TABLE privilege for metastore authorizer

2014-05-23 Thread Ashutosh Chauhan
/security/authorization/AuthorizationPreEventListener.java https://reviews.apache.org/r/15855/#comment78171 Same comment as previous. - Ashutosh Chauhan On Nov. 26, 2013, 8:49 a.m., Navis Ryu wrote: --- This is an automatically

Re: Review Request 16034: Add explain authorize for checking privileges

2014-05-24 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16034/#review43899 --- Ship it! Ship It! - Ashutosh Chauhan On May 24, 2014, 8:45 a.m

Re: Review Request 21970: HIVE-7062: Support Streaming mode in Windowing

2014-05-28 Thread Ashutosh Chauhan
https://reviews.apache.org/r/21970/#comment78511 Better name : funcArgs? - Ashutosh Chauhan On May 28, 2014, 5:40 a.m., Harish Butani wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Review Request 22170: analyze table T compute statistics for columns; will now compute stats for all columns.

2014-06-02 Thread Ashutosh Chauhan
/columnstats_tbllvl.q.out 3d3d0e2 Diff: https://reviews.apache.org/r/22170/diff/ Testing --- Added new tests. Thanks, Ashutosh Chauhan

Re: [VOTE] Apache Hive 0.13.1 Release Candidate 3

2014-06-05 Thread Ashutosh Chauhan
+1 On Thu, Jun 5, 2014 at 5:32 AM, Yu Azuryy azur...@outlook.com wrote: +1 now. Sorry, It's my fault. I hacked Hadoop major version in my test cluster as 1.3.0, actually it was 2.4.0. But ShimLoader parse major version as 1, so get HDFSv1 FileSystem. then I get this error. Date:

Re: Review Request 22170: analyze table T compute statistics for columns; will now compute stats for all columns.

2014-06-05 Thread Ashutosh Chauhan
/ Testing --- Added new tests. Thanks, Ashutosh Chauhan

Re: Review Request 22170: analyze table T compute statistics for columns; will now compute stats for all columns.

2014-06-06 Thread Ashutosh Chauhan
://reviews.apache.org/r/22170/diff/ Testing --- Added new tests. Thanks, Ashutosh Chauhan

Review Request 22328: Make hive use one jetty version.

2014-06-06 Thread Ashutosh Chauhan
/pom.xml 1600966 trunk/shims/0.20S/pom.xml 1600966 trunk/shims/0.23/pom.xml 1600966 Diff: https://reviews.apache.org/r/22328/diff/ Testing --- Manually built and ran few tests. Thanks, Ashutosh Chauhan

Review Request 22404: Optimize limit 0

2014-06-09 Thread Ashutosh Chauhan
: https://reviews.apache.org/r/22404/diff/ Testing --- Added new test. Thanks, Ashutosh Chauhan

Re: Review Request 22404: Optimize limit 0

2014-06-10 Thread Ashutosh Chauhan
/limit_pushdown.q.out 055b17f ql/src/test/results/clientpositive/vectorization_limit.q.out 9bc95ac Diff: https://reviews.apache.org/r/22404/diff/ Testing --- Added new test. Thanks, Ashutosh Chauhan

Review Request 22770: Allow partial partition spec in analyze command

2014-06-18 Thread Ashutosh Chauhan
/clientpositive/columnstats_partlvl_incorrect_num_keys.q.out PRE-CREATION Diff: https://reviews.apache.org/r/22770/diff/ Testing --- Moved -ve tests to +ve. Thanks, Ashutosh Chauhan

Review Request 22782: Display partition level column stats

2014-06-19 Thread Ashutosh Chauhan
/clientpositive/columnstats_partlvl.q.out a4c4677 Diff: https://reviews.apache.org/r/22782/diff/ Testing --- Added new tests Thanks, Ashutosh Chauhan

Re: Review Request 22770: Allow partial partition spec in analyze command

2014-06-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22770/#review46179 --- On June 19, 2014, 2:35 a.m., Ashutosh Chauhan wrote

branch for cbo work

2014-06-19 Thread Ashutosh Chauhan
Hi all, Some of you may have noticed that cost based optimizer work is going on at HIVE-5775 John has put up an initial patch there as well. But there is a lot more work that needs to be done. Following our tradition of large feature work in branch, I propose that we create a branch and commit

Re: branch for cbo work

2014-06-24 Thread Ashutosh Chauhan
Seems like folks are in agreement. I will go ahead and create a branch. On Mon, Jun 23, 2014 at 11:40 AM, John Pullokkaran jpullokka...@hortonworks.com wrote: I see that design doc doesn't talk about plug and play aspect of cost model; and it also doesn't make it clear that cost model

Re: branch for cbo work

2014-06-24 Thread Ashutosh Chauhan
Created a branch at https://svn.apache.org/repos/asf/hive/branches/cbo Folks interested to contribute feel free to create jiras and provide patches for branch. Lets advance Hive's optimizer by teaching it how to cost different plans! Thanks, Ashutosh On Mon, Jun 23, 2014 at 11:13 PM, Ashutosh

Re: Review Request 22752: HIVE-7063: Optimize for the Top N within a Group use case

2014-06-27 Thread Ashutosh Chauhan
whether rank got pushed or not will be useful in future for perf debugging. - Ashutosh Chauhan On June 18, 2014, 8:40 p.m., Harish Butani wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 22770: Allow partial partition spec in analyze command

2014-06-29 Thread Ashutosh Chauhan
/clientpositive/columnstats_partlvl_dp.q.out PRE-CREATION Diff: https://reviews.apache.org/r/22770/diff/ Testing --- Moved -ve tests to +ve. Thanks, Ashutosh Chauhan

Review Request 23325: Table level stats collection fail for partitioned tables

2014-07-07 Thread Ashutosh Chauhan
1608624 trunk/ql/src/test/queries/clientpositive/columnstats_partlvl.q 1608624 trunk/ql/src/test/results/clientpositive/columnstats_partlvl.q.out 1608624 Diff: https://reviews.apache.org/r/23325/diff/ Testing --- Added new test. Thanks, Ashutosh Chauhan

Review Request 23404: Optimize for empty relation scans

2014-07-10 Thread Ashutosh Chauhan
/ Testing --- added new tests. Thanks, Ashutosh Chauhan

Review Request 23421: invalidate stats when table is truncated

2014-07-11 Thread Ashutosh Chauhan
/truncate_table.q.out 718895c Diff: https://reviews.apache.org/r/23421/diff/ Testing --- added new tests Thanks, Ashutosh Chauhan

Re: Review Request 23421: invalidate stats when table is truncated

2014-07-12 Thread Ashutosh Chauhan
those stats, but setting this flag to false is done in line with how we are invalidating column stats in case of other alter statements. In a separate jira we should drop column statistics in case of alter statements (including truncate). - Ashutosh Chauhan On July 11, 2014, 9:55 p.m

Re: Case problem in complex type

2014-07-12 Thread Ashutosh Chauhan
Following POLA[1] I would suggest that ORC should follow conventions as rest of Hive. If all other Struct OI are case-insensitive, than ORC should be as well. 1: http://en.wikipedia.org/wiki/Principle_of_least_astonishment On Thu, Jul 10, 2014 at 10:21 PM, Navis류승우 navis@nexr.com wrote:

Review Request 23509: column stats collection throws exception if all values for a column is null

2014-07-15 Thread Ashutosh Chauhan
/colstats_all_nulls.q PRE-CREATION ql/src/test/results/clientpositive/colstats_all_nulls.q.out PRE-CREATION Diff: https://reviews.apache.org/r/23509/diff/ Testing --- added new test Thanks, Ashutosh Chauhan

Re: Review Request 23404: Optimize for empty relation scans

2014-07-18 Thread Ashutosh Chauhan
/optimize_nullscan.q PRE-CREATION ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION Diff: https://reviews.apache.org/r/23404/diff/ Testing --- added new tests. Thanks, Ashutosh Chauhan

Review Request 23967: Enable auto conversion of SMBjoin in presence of constant propagate optimization

2014-07-27 Thread Ashutosh Chauhan
ql/src/test/results/clientpositive/smb_mapjoin_25.q.out bd289c3 Diff: https://reviews.apache.org/r/23967/diff/ Testing --- smb_mapjoin_25.q used to fail to convert joins to SMBJoins, now it does. Thanks, Ashutosh Chauhan

Re: Review Request 23967: Enable auto conversion of SMBjoin in presence of constant propagate optimization

2014-07-27 Thread Ashutosh Chauhan
/23967/diff/ Testing --- smb_mapjoin_25.q used to fail to convert joins to SMBJoins, now it does. Thanks, Ashutosh Chauhan

Re: Would like to contribute

2014-07-31 Thread Ashutosh Chauhan
Done. You can assign jiras to yourself now. Welcome to Hive! On Thu, Jul 31, 2014 at 1:45 PM, Mostafa Mokhtar mmokh...@hortonworks.com wrote: I would like to assign this work item to myself and start working on it but I don't have JIRA assign permissions.

Review Request 24176: Fetch aggregated stats from MetaStore

2014-07-31 Thread Ashutosh Chauhan
* tests. Thanks, Ashutosh Chauhan

Re: Review Request 24176: Fetch aggregated stats from MetaStore

2014-08-01 Thread Ashutosh Chauhan
Existing tests annotate_stats* exercises this code path. Let me know, if you think there are other ways to test this. - Ashutosh Chauhan On Aug. 1, 2014, 5:49 a.m., Ashutosh Chauhan wrote: --- This is an automatically generated e

Re: Review Request 24176: Fetch aggregated stats from MetaStore

2014-08-01 Thread Ashutosh Chauhan
Diff: https://reviews.apache.org/r/24176/diff/ Testing --- Existing annotate_stats* tests. Thanks, Ashutosh Chauhan

hive 0.10 release

2012-11-07 Thread Ashutosh Chauhan
Hi, Its been a while since we released 0.10 more than six months ago. All this while, lot of action has happened with various cool features landing in trunk. Additionally, I am looking forward to HiveServer2 landing in trunk. So, I propose that we cut the branch for 0.10 soon afterwards and than

Review Request: DB based token store

2012-11-07 Thread Ashutosh Chauhan
--- Includes unit test Thanks, Ashutosh Chauhan

Re: [jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0

2012-11-08 Thread Ashutosh Chauhan
Chauhan (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.pl ugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Resolution: Fixed Fix Version/s: 0.10.0

Re: Review Request: DB based token store

2012-11-12 Thread Ashutosh Chauhan
trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1408480 Diff: https://reviews.apache.org/r/7941/diff/ Testing --- Includes unit test Thanks, Ashutosh Chauhan

Re: Review Request: DB based token store

2012-11-13 Thread Ashutosh Chauhan
generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/#review13387 --- On Nov. 12, 2012, 10:54 p.m., Ashutosh Chauhan wrote: --- This is an automatically generated e

Re: Review Request: DB based token store

2012-11-13 Thread Ashutosh Chauhan
/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1408480 Diff: https://reviews.apache.org/r/7941/diff/ Testing --- Includes unit test Thanks, Ashutosh Chauhan

Re: Review Request: DB based token store

2012-11-15 Thread Ashutosh Chauhan
/ObjectStore.java https://reviews.apache.org/r/7941/#comment28882 Yeah.. will refactor that. - Ashutosh Chauhan On Nov. 13, 2012, 8:45 a.m., Ashutosh Chauhan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request: DB based token store

2012-11-15 Thread Ashutosh Chauhan
, visit: https://reviews.apache.org/r/7941/#review13461 --- On Nov. 13, 2012, 8:45 a.m., Ashutosh Chauhan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request: DB based token store

2012-11-15 Thread Ashutosh Chauhan
/apache/hadoop/hive/thrift/TestDBTokenStore.java PRE-CREATION trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1409909 Diff: https://reviews.apache.org/r/7941/diff/ Testing --- Includes unit test Thanks, Ashutosh Chauhan

Re: hive 0.10 release

2012-11-15 Thread Ashutosh Chauhan
wrote: That sounds good. I think this issue needs to be solved as well as anything else that produces a bugus query result. https://issues.apache.org/jira/browse/HIVE-3083 Edward On Wed, Nov 7, 2012 at 7:50 PM, Ashutosh Chauhan hashut...@apache.org wrote

Re: hive 0.10 release

2012-11-19 Thread Ashutosh Chauhan
, Ashutosh On Thu, Nov 15, 2012 at 2:29 PM, Ashutosh Chauhan hashut...@apache.orgwrote: Good progress. Looks like folks are on board. I propose to cut the branch in next couple of days. There are few jiras which are patch ready which I want to get into the hive-0.10 release, including HIVE-3255

Re: JIRA permissions for Hive

2012-11-21 Thread Ashutosh Chauhan
Hey Mikhail, Added you to the list of contributor. You should be able to perform those actions now. Ashutosh On Wed, Nov 21, 2012 at 10:06 AM, Mikhail Bautin bautin.mailing.li...@gmail.com wrote: Hello, For some reason I don't seem to have permissions to assign issues, change issue

Re: Review request: JIRAs useful for the Shark project

2012-11-27 Thread Ashutosh Chauhan
Hi Mikhail, I will take a look into those jiras. Thanks, Ashutosh On Tue, Nov 27, 2012 at 11:43 AM, Mikhail Bautin bautin.mailing.li...@gmail.com wrote: Hello, There are the following review requests pending that are very useful for the Shark project (http://shark.cs.berkeley.edu/). It

Re: [VOTE] Apache Hive 0.10.0 Release Candidate 0

2012-12-26 Thread Ashutosh Chauhan
%40mail.gmail.com%3E I think this can be solved later and need not block this release. Alan. On Dec 18, 2012, at 10:23 PM, Ashutosh Chauhan wrote: Apache Hive 0.10.0 Release Candidate 0 is available here: http://people.apache.org/~hashutosh/hive-0.10.0-rc0/ Maven artifacts are available

Re: running apache jenkins build on hadoop 23

2013-01-08 Thread Ashutosh Chauhan
I have re-enabled hive on hadoop2 build at https://builds.apache.org/job/Hive-trunk-hadoop2/ I also created hive on hadoop1 build at https://builds.apache.org/job/hive-trunk-hadoop1/ Enjoy, Ashutosh On Sun, Jan 6, 2013 at 10:56 PM, Namit Jain nj...@fb.com wrote: I forgot who had setup apache

Re: ASF HiveServer2 release plan !!

2013-01-08 Thread Ashutosh Chauhan
Hi Manish, Currently the blocker for HiveServer2 in ASF is https://issues.apache.org/jira/browse/HIVE-3785 Patch there outlines changes HS2 requires in existing hive codebase. That patch is currently under review. Once thats reviewed and checked-in than remaining of HS2 patch will made it in

Re: running apache jenkins build on hadoop 23

2013-01-08 Thread Ashutosh Chauhan
Yes, all tests which has INCLUDE 23 will be executed. Ashutosh On Tue, Jan 8, 2013 at 7:47 PM, Namit Jain nj...@fb.com wrote: Ashutosh, Is hadoop2 using hadoop 23 ? I mean, will tests with INCLUDE 23 be executed ? On 1/9/13 9:15 AM, Ashutosh Chauhan hashut...@apache.org wrote: I have

Re: Review Request: HIVE-2206: add a new optimizer for query correlation discovery and optimization

2013-01-09 Thread Ashutosh Chauhan
worked, no ? Having this working will be very useful for debugging. - Ashutosh Chauhan On Nov. 19, 2012, 7:51 p.m., Yin Huai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7126

Re: [VOTE] Apache Hive 0.10.0 Release Candidate 0

2013-01-10 Thread Ashutosh Chauhan
Thanks for driving this, Alex On Jan 9, 2013, at 6:19 AM, Namit Jain nj...@fb.com wrote: +1 Build from src. Ran some sanity tests both from bin and compiled src - they looked good On 12/27/12 3:08 AM, Ashutosh Chauhan ashutosh.chau...@gmail.com wrote: +1

[ANNOUNCE] Apache Hive 0.10.0 Released

2013-01-11 Thread Ashutosh Chauhan
The Apache Hive team is proud to announce the the release of Apache Hive version 0.10.0. The Apache Hive (TM) data warehouse software facilitates querying and managing large datasets residing in distributed storage. Built on top of Apache Hadoop (TM), it provides: * Tools to enable easy data

Re: Review Request: HIVE-2206: add a new optimizer for query correlation discovery and optimization

2013-01-12 Thread Ashutosh Chauhan
On Jan. 10, 2013, 2:24 a.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/CorrelationLocalSimulativeReduceSinkOperator.java, line 275 https://reviews.apache.org/r/7126/diff/11/?file=221827#file221827line275 Does this imply CLSRSOperator cannot have more than

Re: [ANNOUNCE] Apache Hive 0.10.0 Released

2013-01-16 Thread Ashutosh Chauhan
! On Fri, Jan 11, 2013 at 12:37 AM, Lefty Leverenz le...@hortonworks.com wrote: Congratulations! – Lefty On Thu, Jan 10, 2013 at 11:59 PM, Ashutosh Chauhan hashut...@apache.org wrote: The Apache Hive team is proud to announce the the release of Apache Hive version 0.10.0

Review Request 25679: Let CBO handle field expression in join condition

2014-09-15 Thread Ashutosh Chauhan
/TypeCheckCtx.java 11bd103 ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1e60f7b Diff: https://reviews.apache.org/r/25679/diff/ Testing --- mapjoin1.q Thanks, Ashutosh Chauhan

Review Request 25716: Type coercion for union queries.

2014-09-16 Thread Ashutosh Chauhan
, Ashutosh Chauhan

Review Request 25739: CBO: bail from Optiq planning if a Select list contains multiple references to the same name

2014-09-17 Thread Ashutosh Chauhan
/25739/diff/ Testing --- timestamp_udf.q Thanks, Ashutosh Chauhan

Review Request 25744: [CBO] Partition pruner doesnt handle unpartitioned table in non-strict mode correctly

2014-09-17 Thread Ashutosh Chauhan
://reviews.apache.org/r/25744/diff/ Testing --- create_view_partitioned.q Thanks, Ashutosh Chauhan

Review Request 25792: Stats based compute query replies fail to do simple column transforms

2014-09-18 Thread Ashutosh Chauhan
09f4bff ql/src/test/results/clientpositive/metadata_only_queries_with_filters.q.out f556c97 Diff: https://reviews.apache.org/r/25792/diff/ Testing --- Added new test Thanks, Ashutosh Chauhan

Re: Review Request 25716: Type coercion for union queries.

2014-09-18 Thread Ashutosh Chauhan
for union queries. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 607e6d9 Diff: https://reviews.apache.org/r/25716/diff/ Testing --- union32.q Thanks, Ashutosh Chauhan

Re: Review Request 25716: Type coercion for union queries.

2014-09-19 Thread Ashutosh Chauhan
: https://reviews.apache.org/r/25716/diff/ Testing --- union32.q Thanks, Ashutosh Chauhan

Review Request 25856: [CBO] Handle case where top level schema contains repeated alias

2014-09-19 Thread Ashutosh Chauhan
/r/25856/diff/ Testing --- limit_pushdown.q Thanks, Ashutosh Chauhan

Review Request 25956: [CBO] Preserve subquery alias while generating ast

2014-09-23 Thread Ashutosh Chauhan
/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 943cc5c Diff: https://reviews.apache.org/r/25956/diff/ Testing --- authorization_view_sqlstd.q Thanks, Ashutosh Chauhan

Review Request 25997: Collect table read entities at same time as view read entities

2014-09-24 Thread Ashutosh Chauhan
/SemanticAnalyzer.java c4dacf9 Diff: https://reviews.apache.org/r/25997/diff/ Testing --- Unit tests Thanks, Ashutosh Chauhan

Re: Review Request 25997: Collect table read entities at same time as view read entities

2014-09-25 Thread Ashutosh Chauhan
tests Thanks, Ashutosh Chauhan

Review Request 26162: Incorrect results for n-way join when join expressions are not in same order across joins

2014-09-29 Thread Ashutosh Chauhan
/join_merge_multi_expressions.q PRE-CREATION ql/src/test/results/clientpositive/join_merge_multi_expressions.q.out PRE-CREATION Diff: https://reviews.apache.org/r/26162/diff/ Testing --- Added new test. Thanks, Ashutosh Chauhan

Review Request 26178: Truncating table doesnt invalidate stats

2014-09-30 Thread Ashutosh Chauhan
/results/clientpositive/alter_numbuckets_partitioned_table_h23.q.out 5047b23 Diff: https://reviews.apache.org/r/26178/diff/ Testing --- Thanks, Ashutosh Chauhan

Review Request 26259: Null Scan optimizer throws exception when no partitions are selected

2014-10-01 Thread Ashutosh Chauhan
/clientpositive/optimize_nullscan.q d06b89b ql/src/test/results/clientpositive/optimize_nullscan.q.out ed81cd6 ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out 66c62ef Diff: https://reviews.apache.org/r/26259/diff/ Testing --- Added new test. Thanks, Ashutosh Chauhan

Review Request 26261: hive stats issue when insert query is appending data into table

2014-10-01 Thread Ashutosh Chauhan
/vectorized_timestamp_funcs.q.out 1628879 Diff: https://reviews.apache.org/r/26261/diff/ Testing --- Added new tests and existing unit tests. Thanks, Ashutosh Chauhan

Review Request 26345: Constant folding should happen before group-by optimization

2014-10-04 Thread Ashutosh Chauhan
/GroupByOptimizer.java d06522f ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 0a58200 Diff: https://reviews.apache.org/r/26345/diff/ Testing --- groupby_sort_* tests Thanks, Ashutosh Chauhan

Re: Review Request 26345: Constant folding should happen before group-by optimization

2014-10-05 Thread Ashutosh Chauhan
, Ashutosh Chauhan

Review Request 26379: Disable cbo for tablesample

2014-10-06 Thread Ashutosh Chauhan
, Ashutosh Chauhan

Review Request 26454: Column Pruner dont prune columns from limit operator.

2014-10-08 Thread Ashutosh Chauhan
/ColumnPrunerProcFactory.java 0a9c6d2 Diff: https://reviews.apache.org/r/26454/diff/ Testing --- limit tests on top of HIVE-8358 Thanks, Ashutosh Chauhan

Review Request 26461: [CBO] Handle filters with non-boolean return type

2014-10-08 Thread Ashutosh Chauhan
--- annotate_stats_filter.q Thanks, Ashutosh Chauhan

Review Request 26483: Correctly handle invalid distinct queries.

2014-10-08 Thread Ashutosh Chauhan
--- NegativeCliDriver::invalid_distinct1.q,invalid_distinct3.q Thanks, Ashutosh Chauhan

Re: Review Request 26483: Correctly handle invalid distinct queries.

2014-10-09 Thread Ashutosh Chauhan
/SemanticAnalyzer.java 19110ce Diff: https://reviews.apache.org/r/26483/diff/ Testing (updated) --- NegativeCliDriver::invalid_distinct1.q,invalid_distinct3.q,having1.q Thanks, Ashutosh Chauhan

Review Request 26528: Use OptiqSemanticException in error condition

2014-10-09 Thread Ashutosh Chauhan
--- TestNegativeCliDriver Thanks, Ashutosh Chauhan

Review Request 26573: PCR doesnt remove filters involving casts

2014-10-10 Thread Ashutosh Chauhan
1630984 trunk/ql/src/test/queries/clientpositive/pcr.q 1630984 trunk/ql/src/test/results/clientpositive/pcr.q.out 1630984 Diff: https://reviews.apache.org/r/26573/diff/ Testing --- New tests in pcr.q Thanks, Ashutosh Chauhan

Review Request 26631: Add identity project remover optimization

2014-10-12 Thread Ashutosh Chauhan
. Thanks, Ashutosh Chauhan

Re: Review Request 26573: PCR doesnt remove filters involving casts

2014-10-13 Thread Ashutosh Chauhan
in pcr.q Thanks, Ashutosh Chauhan

Review Request 26649: Constant folding should happen before predicate pushdown

2014-10-13 Thread Ashutosh Chauhan
/sample1.q.xml 1631285 Diff: https://reviews.apache.org/r/26649/diff/ Testing --- Existing test cases. Thanks, Ashutosh Chauhan

Re: Review Request 26649: Constant folding should happen before predicate pushdown

2014-10-13 Thread Ashutosh Chauhan
/ql/src/test/results/compiler/plan/sample1.q.xml 1631285 Diff: https://reviews.apache.org/r/26649/diff/ Testing --- Existing test cases. Thanks, Ashutosh Chauhan

Review Request 26892: Enhance Constant Folding to propagate constants for simple expressions

2014-10-17 Thread Ashutosh Chauhan
/constprog2.q 72ce5a3 ql/src/test/results/clientpositive/constprog2.q.out 148d95b Diff: https://reviews.apache.org/r/26892/diff/ Testing --- Added new test Thanks, Ashutosh Chauhan

Re: Review Request 26892: Enhance Constant Folding to propagate constants for simple expressions

2014-10-18 Thread Ashutosh Chauhan
/diff/ Testing --- Added new test Thanks, Ashutosh Chauhan

Review Request 26983: Fold is not null expr.

2014-10-21 Thread Ashutosh Chauhan
/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan

Review Request 27152: Push constant filters through joins

2014-10-24 Thread Ashutosh Chauhan
/clientpositive/optimize_nullscan.q.out fd77ad2 Diff: https://reviews.apache.org/r/27152/diff/ Testing --- Added new test. Thanks, Ashutosh Chauhan

Review Request 27167: Constant folding should happen early

2014-10-24 Thread Ashutosh Chauhan
.q.out 1634137 Diff: https://reviews.apache.org/r/27167/diff/ Testing --- Existing tests Thanks, Ashutosh Chauhan

Re: Review Request 27318: HIVE-8625: Some union queries result in plans with many unions with CBO on

2014-10-29 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27318/#review58992 --- Ship it! Ship It! - Ashutosh Chauhan On Oct. 29, 2014, 4:06 a.m

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-10-30 Thread Ashutosh Chauhan
/#comment100552 you can just say analyze table cbo_t1 compute statistics; data/scripts/q_test_init.sql https://reviews.apache.org/r/27401/#comment100553 similarly here analyze table cbo_t1 compute statistics for columns; - Ashutosh Chauhan On Oct. 30, 2014, 11:18 p.m., Sergey

Re: New Hive contributor request : mladenkov

2014-11-03 Thread Ashutosh Chauhan
Hi Mladen, Welcome aboard! I have added you as a contributor on Hive jira. Looking forward to your proposals and patches to improve Hive. Thanks, Ashutosh On Mon, Nov 3, 2014 at 7:55 AM, Mladen Kovacevic mla...@ca.ibm.com wrote: Hi, I'd like to be included as a Hive contributor, please. My

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

2014-11-04 Thread Ashutosh Chauhan
/#comment101169 Please leave this here. We want stats collection to happen via fs. Not by default jdbc:derby - Ashutosh Chauhan On Nov. 4, 2014, 9:07 p.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail

Review Request 27646: delete HS1

2014-11-05 Thread Ashutosh Chauhan
/hadoop/hive/jdbc/JdbcTable.java 1636981 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java 1636981 Diff: https://reviews.apache.org/r/27646/diff/ Testing --- removed test cases for HS1 Thanks, Ashutosh Chauhan

Review Request 27647: add commons-logging to uber jar

2014-11-05 Thread Ashutosh Chauhan
/browse/HIVE-8748 Repository: hive Description --- add commons-logging to uber jar Diffs - trunk/jdbc/pom.xml 1637002 Diff: https://reviews.apache.org/r/27647/diff/ Testing --- Thanks, Ashutosh Chauhan

Re: Review Request 27646: delete HS1

2014-11-05 Thread Ashutosh Chauhan
--- removed test cases for HS1 Thanks, Ashutosh Chauhan

Re: Review Request 27847: HIVE-8295 : Add batch retrieve partition objects for metastore direct sql

2014-11-10 Thread Ashutosh Chauhan
/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java https://reviews.apache.org/r/27847/#comment102131 Do we need query.close(sqlResult2); - Ashutosh Chauhan On Nov. 11, 2014, 12:23 a.m., Sergey Shelukhin wrote

Re: Review Request 27847: HIVE-8295 : Add batch retrieve partition objects for metastore direct sql

2014-11-11 Thread Ashutosh Chauhan
/MetaStoreDirectSql.java https://reviews.apache.org/r/27847/#comment102260 Wondering if there is any value in doing ensureDbInit() ? Seems like runTestQuery() is sufficient. If ensureDbInit() is indeed needed, can you please add comment why is it needed? - Ashutosh Chauhan On Nov. 11, 2014, 7:34 p.m

Re: [VOTE] officially stop supporting hadoop 0.20.x in hive 0.14 ?

2014-11-11 Thread Ashutosh Chauhan
Created : https://issues.apache.org/jira/browse/HIVE-8828 On Wed, Oct 8, 2014 at 7:14 AM, Alan Gates ga...@hortonworks.com wrote: +1. Alan. Thejas Nair the...@hortonworks.com October 7, 2014 at 15:53 I think it is time to revisit the support for hive support for hadoop 0.20. Trying to

Review Request 27895: Remove Hadoop 20 shims

2014-11-11 Thread Ashutosh Chauhan
. Thanks, Ashutosh Chauhan

Re: Review Request 27900: HIVE-8739

2014-11-11 Thread Ashutosh Chauhan
/MetaStoreDirectSql.java https://reviews.apache.org/r/27900/#comment102350 Are we sure about Oracle? Till now this worked on Oracle. Do we have evidence for otherwise? - Ashutosh Chauhan On Nov. 12, 2014, 2:02 a.m., Sergey Shelukhin wrote

Re: Review Request 27900: HIVE-8739

2014-11-13 Thread Ashutosh Chauhan
in a follow-up jira. But, it will be good to leave a TODO here. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java https://reviews.apache.org/r/27900/#comment102895 Better name since its not limited to Derby: stopDBFromPushingCastAboveJoin? - Ashutosh Chauhan

Re: Review Request 14890: Index creation on a skew table fails

2014-11-13 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14890/#review61395 --- Ship it! Ship It! - Ashutosh Chauhan On Nov. 14, 2014, 12:03

<    1   2   3   4   5   6   7   8   9   10   >