Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_db_uuid

2017-05-11 Thread Vihang Karajgaonkar
any inadvertent changes/corruption to the schema. - Vihang ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59070/#review174698 ---

Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_db_uuid

2017-05-11 Thread Vihang Karajgaonkar
t/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 91d8c2af67ae1e49f8d41f16d8eee361b3b2abf9 Diff: https://reviews.apache.org/r/59070/diff/4/ Changes: https://reviews.apache.org/r/59070/diff/3-4/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Vihang Karajgaonkar
ba99024163a1f2c59d59e9ed7ea276c154c99d24 ql/src/test/results/clientpositive/repair.q.out c1834640a35500c521a904a115a718c94546df10 Diff: https://reviews.apache.org/r/58936/diff/4/ Changes: https://reviews.apache.org/r/58936/diff/3-4/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Vihang Karajgaonkar
. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/#review174792 --- On May 12, 2017, 9:35 p.m., Vihang Karajgaonkar wrote: &g

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Vihang Karajgaonkar
- "which ever" should be "whichever" > > - a comma before "whichever" might be good > > - please end the description with a period Thanks for the review. Added the suggested changes. - Vihang -------

Review Request 59429: HIVE-16723 : Enable configurable MetaStoreSchemaInfo

2017-05-20 Thread Vihang Karajgaonkar
/org/apache/hadoop/hive/metastore/TestMetaStoreSchemaInfo.java 71420012756ca26bf399228efdf011597eb70b17 Diff: https://reviews.apache.org/r/59429/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59429: HIVE-16723 : Enable configurable MetaStoreSchemaInfo

2017-05-22 Thread Vihang Karajgaonkar
/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59429: HIVE-16723 : Enable configurable MetaStoreSchemaInfo

2017-05-22 Thread Vihang Karajgaonkar
/ Testing --- Thanks, Vihang Karajgaonkar

Re: Jimmy Xiang now a Hive PMC member

2017-05-25 Thread Vihang Karajgaonkar
Congratulations Jimmy! On Thu, May 25, 2017 at 8:27 AM, Sergio Pena wrote: > Congratulations Jimmy !!! > > On Thu, May 25, 2017 at 2:30 AM, Peter Vary wrote: > > > Congratulations Jimmy! > > > > > On May 25, 2017, at 6:16 AM, Xuefu Zhang wrote: > > > > > > Hi all, > > > > > > It's an honer to

Re: Welcome Rui Li to Hive PMC

2017-05-25 Thread Vihang Karajgaonkar
Congratulations Rui! On Thu, May 25, 2017 at 8:29 AM, Anshuman Dwivedi wrote: > Congrats ! > > Regards, > Anshuman Dwivedi > > -Sergio Pena wrote: - > To: dev > From: Sergio Pena > Date: 05/25/2017 08:57PM > Subject: Re: Welcome Rui Li to Hive PMC > > Congratulations Rui !!! > > On Th

Re: [Announce] New PMC members

2017-05-26 Thread Vihang Karajgaonkar
Congratulations to all the new PMC members! On Fri, May 26, 2017 at 7:50 AM, Xuefu Zhang wrote: > Many congratulations to Yongzhi, Daniel, Vaibhav, Sergio, Aihua, Chaoyu! > Well-deserved! > > Thanks, > Xuefu > > On Fri, May 26, 2017 at 7:19 AM, Jimmy Xiang wrote: > > > Congrats!! > > > > On Fri

Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Vihang Karajgaonkar
/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Vihang Karajgaonkar
/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java 6bddb8e864d26a6cb7e2fe9b8b8becf427779944 Diff: https://reviews.apache.org/r/59654/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

2017-05-30 Thread Vihang Karajgaonkar
/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java 6bddb8e864d26a6cb7e2fe9b8b8becf427779944 Diff: https://reviews.apache.org/r/59654/diff/2/ Changes: https://reviews.apache.org/r/59654/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 60589: HIVE-17001: Insert overwrite table doesn't clean partition directory on HDFS if partition is missing from HMS

2017-07-05 Thread Vihang Karajgaonkar
rite should also fail on a external table. The behavior of external table is inconsistent in my opinion. We allow it to be overwritten but not truncated. When the table is a managed table, the test works as expected since Hive cleans up the directory after drop partition command. - Vih

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-06 Thread Vihang Karajgaonkar
I can understand the concerns from Edward and Xuefu and I think they are valid as well. I think having a regular cadence of release will help alleviate the concerns related to features making into releases to a certain extent. Having quarterly or semi-annual releases would be a good thing in genera

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-07-06 Thread Vihang Karajgaonkar
common/src/test/org/apache/hive/common/util/TestHiveStringUtils.java Lines 112 (patched) <https://reviews.apache.org/r/60445/#comment254672> nit, spellcheck comments - Vihang Karajgaonkar On July 5, 2017, 6:09 p.m., Andrew Sherman wrote: > >

Re: [ANNOUNCE] New PMC Member : Matt McCline

2017-07-07 Thread Vihang Karajgaonkar
Congratulations Matt! On Fri, Jul 7, 2017 at 9:27 AM, Xuefu Zhang wrote: > Congratulations! > > On Fri, Jul 7, 2017 at 8:27 AM, Eugene Koifman > wrote: > > > Congratulations! > > > > On 7/7/17, 1:04 AM, "Zoltan Haindrich" > wrote: > > > > Congrats Matt! > > > > On 7 Jul 2017 09:46, Pet

Re: [Announce] New committer: Vihang Karajgaonkar

2017-07-08 Thread Vihang Karajgaonkar
2017 at 12:50 PM, Vaibhav Gumashta < > > > > > vgumas...@hortonworks.com > > > > > > wrote: > > > > > > > > > > > Congratulations Vihang! > > > > > > > > > > > > On 7/7/17, 10:47 AM, "Vineet Gar

Re: how to use vectorizedparquetrecordreader

2017-07-17 Thread Vihang Karajgaonkar
Parquet vectorization support was added in 2.2.0. In order to enable it you should set hive.vectorized.execution.enabled=true. Following other configs are also relevant for vectorization and you should have them enabled as well. hive.vectorized.use.vector.serde.deserialize=true; hive.vectorized.ex

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Vihang Karajgaonkar
Before we see a flood of name suggestions :) Why not just keep it Metastore? Its already well-known in the community and easy to relate to. On Mon, Jul 24, 2017 at 2:13 PM, Alan Gates wrote: > In the same vein Carter and Gunther suggested Omegastore. Pick your > alphabet and whether it’s a cata

Re: Review Request 61041: HIVE-17150: CREATE INDEX execute HMS out-of-transaction listener calls inside a transaction

2017-07-24 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61041/#review181268 --- Ship it! Ship It! - Vihang Karajgaonkar On July 21, 2017, 5

Re: ptest not running

2017-08-04 Thread Vihang Karajgaonkar
The pre-commit admin didn't seem to be running every 10 min it is supposed to run. I just triggered a run manually to see if it picks up any pending patches. Will update here. On Fri, Aug 4, 2017 at 3:57 PM, Eugene Koifman wrote: > Hi, > I looks like it’s not picking up new patches > https://bui

Re: ptest not running

2017-08-04 Thread Vihang Karajgaonkar
projects must be facing the same problem too. On Fri, Aug 4, 2017 at 4:10 PM, Vihang Karajgaonkar wrote: > The pre-commit admin didn't seem to be running every 10 min it is supposed > to run. I just triggered a run manually to see if it picks up any pending > patches. Will update he

Review Request 62092: HIVE-17368 : DBTokenStore fails to connect in Kerberos enabled remote HMS environment

2017-09-05 Thread Vihang Karajgaonkar
5299e18743aa45c539287b335f95e8ce8df0fc35 shims/common/src/main/java/org/apache/hadoop/hive/thrift/HiveDelegationTokenManager.java b3e4a7608282be603e79d1d101679e239a5219b0 Diff: https://reviews.apache.org/r/62092/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 62092: HIVE-17368 : DBTokenStore fails to connect in Kerberos enabled remote HMS environment

2017-09-05 Thread Vihang Karajgaonkar
ber as well. Please > > feel to free to trim it to what you think is appropriate. I will update the comment to reflect some of thoughts you mentioned above. - Vihang --- This is an automatically generated e-mail.

Re: Review Request 62092: HIVE-17368 : DBTokenStore fails to connect in Kerberos enabled remote HMS environment

2017-09-05 Thread Vihang Karajgaonkar
/diff/2/ Changes: https://reviews.apache.org/r/62092/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: New committer : Barna Zsombor Klara

2017-09-18 Thread Vihang Karajgaonkar
Congratulations Zsombor! On Mon, Sep 18, 2017 at 8:15 AM, Zoltan Haindrich < zhaindr...@hortonworks.com> wrote: > Congratulations!! > > On 16 Sep 2017 00:52, Ashutosh Chauhan wrote: > The Project Management Committee (PMC) for Apache Hive has invited Barna > Zsombor Klara to become a committer a

Becoming a contributor

2016-05-18 Thread Vihang Karajgaonkar
Hello Everyone, I would like to start working on issues reported on Hive in JIRA. I followed the steps mentioned in https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-BecomingaContributor

Re: Becoming a contributor

2016-05-18 Thread Vihang Karajgaonkar
yourself yet, but if you reply to this > email with your JIRA id I’ll make it so you can. > > Alan. > >> On May 18, 2016, at 11:42, Vihang Karajgaonkar wrote: >> >> Hello Everyone, >> >> I would like to start working on issues reported on Hive in JI

Re: Becoming a contributor

2016-05-19 Thread Vihang Karajgaonkar
Thanks Alan. On Wed, May 18, 2016 at 5:07 PM, Alan Gates wrote: > You’ve been added, so you should now be able to assign JIRAs to yourself. > > Alan. > > > On May 18, 2016, at 13:38, Vihang Karajgaonkar > wrote: > > > > Thanks Alan! My JIRA id is vihangk1 &

Review Request 49215: HIVE-14085 : Allow type widening primitive conversion on hive/parquet tables

2016-06-24 Thread Vihang Karajgaonkar
ql/src/test/results/clientpositive/parquet_columnar.q.out fd28f5ce241d0661a10c18430522ccbb6f0fc88f ql/src/test/results/clientpositive/parquet_type_promotion.q.out 91c3fff57de418db975af18b779bc46e95a15501 Diff: https://reviews.apache.org/r/49215/diff/ Testing --- Thanks, Vihang

Re: [Announce] New Hive Committer - Mohit Sabharwal

2016-07-01 Thread Vihang Karajgaonkar
Congratulations Mohit! > On Jul 1, 2016, at 10:05 AM, Chao Sun wrote: > > Congratulations Mohit! Good job! > > Best, > Chao > > On Fri, Jul 1, 2016 at 9:57 AM, Szehon Ho > wrote: > On behalf of the Apache Hive PMC, I'm pleased to announce that Mohit > Sabharwa

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-01 Thread Vihang Karajgaonkar
eeline/BeeLineOpts.java (line 69) <https://reviews.apache.org/r/49498/#comment205783> nit, add a space after = - Vihang Karajgaonkar On July 1, 2016, 3:08 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-

Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-11 Thread Vihang Karajgaonkar
5aaa38527734d46de037352ff51e54e0ae1cede0 beeline/src/java/org/apache/hive/beeline/BufferedRows.java 962c5319bb7e6e448979e1cef80a086cadd2ecc6 beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java PRE-CREATION Diff: https://reviews.apache.org/r/49919/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-12 Thread Vihang Karajgaonkar
https://reviews.apache.org/r/49919/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Vihang Karajgaonkar
n the loop. btw, If we have to add it in the loop it should be Math.min(Math.max(max[j], row.sizes[j] + 1), maxColumnWidth); Did you mean the same? - Vihang Karajgaonkar On July 12, 2016, 5:51 p.m., Vihang Karajgaonkar

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Vihang Karajgaonkar
https://reviews.apache.org/r/49919/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-15 Thread Vihang Karajgaonkar
> On July 1, 2016, 9:58 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes. Can you please test your code by setting > > USE_DEPRECATED_CLI=false. > > Peter Vary wrote: > Ok. Maybe something is not yet clear for me :) > Could you please explain? &g

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-15 Thread Vihang Karajgaonkar
hive/beeline/ClientCommandHookFactory.java (line 64) <https://reviews.apache.org/r/49498/#comment207964> I agree that in case of go command you would probably need to query the db, but I think in the common case of use and connect commands it would be still beneficial to save that extra query call. - Vihang Kara

Re: Review Request 49782: HIVE-14170: Beeline IncrementalRows should buffer rows and incrementally re-calculate width if TableOutputFormat is used

2016-07-15 Thread Vihang Karajgaonkar
o max column width - Vihang Karajgaonkar On July 11, 2016, 5:29 p.m., Sahil Takiar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: [ANNOUNCE] New PMC Member : Jesus

2016-07-18 Thread Vihang Karajgaonkar
Congratulations Jesus! > On Jul 18, 2016, at 8:30 AM, Sergio Pena wrote: > > Congrats Jesus !!! > > On Mon, Jul 18, 2016 at 7:28 AM, Peter Vary wrote: > >> Congratulations Jesus! >> >>> On Jul 18, 2016, at 6:55 AM, Wei Zheng wrote: >>> >>> Congrats Jesus! >>> >>> Thanks, >>> >>> Wei >>>

Re: [ANNOUNCE] New PMC Member : Pengcheng

2016-07-18 Thread Vihang Karajgaonkar
Congratulations! > On Jul 18, 2016, at 5:28 AM, Peter Vary wrote: > > Congratulations Pengcheng! > > >> On Jul 18, 2016, at 6:55 AM, Wei Zheng wrote: >> >> Congrats Pengcheng! >> >> Thanks, >> >> Wei >> >> >> >> >> >> >> On 7/17/16, 16:01, "Xuefu Zhang" wrote: >> >>> Congrats, Peng

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-18 Thread Vihang Karajgaonkar
the previous two tests to be executed before it? If yes, it might make sense to make it self-contained since I believe the order in which tests are executed is not deterministic. - Vihang Karajgaonkar On July 18, 2016, 12:37 p.m.

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-07-27 Thread Vihang Karajgaonkar
setHiveConf while the Reflector is looking for setConf. Did you try renaming the method from setHiveConf to setConf? - Vihang Karajgaonkar On July 27, 2016, 4:26 p.m., Peter Vary wrote: > > --- > This is an automatically genera

Re: Review Request 50982: HIVE-14345:Beeline result table has erroneous characters

2016-08-12 Thread Vihang Karajgaonkar
test might fail. I think it will be more robust to determine this string programatically using the values in mockResultData and value of maxColumnWidth. - Vihang Karajgaonkar On Aug. 12, 2016, 3:16 p.m., Miklos Csanady wrote: > > ---

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-08-25 Thread Vihang Karajgaonkar
> On July 28, 2016, 4:37 a.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 627 > > <https://reviews.apache.org/r/50510/diff/1/?file=1455259#file1455259line627> > > > > Adding @Ignore may not be the ri

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-08-25 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50510/#review146862 --- Ship it! LGTM. Thanks for the change. - Vihang Karajgaonkar

Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-01 Thread Vihang Karajgaonkar
itests/hive-unit/src/test/java/org/apache/hive/beeline/hs2connectionfile/TestBeelineWithUserHs2ConnectionFile.java PRE-CREATION Diff: https://reviews.apache.org/r/51593/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
--- Thanks, Vihang Karajgaonkar

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
#review147678 --- On Sept. 6, 2016, 11:53 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.o

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
gt; It this is public, do we need the VisibleForTesting annotation? fixed - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review147700 ---

Re: Error when running the test TestBeeLineWithArgs

2016-09-07 Thread Vihang Karajgaonkar
Yes, you are right. I have created a JIRA for the same. https://issues.apache.org/jira/browse/HIVE-14717 > On Sep 6, 2016, at 7:02 AM, Marta Kuczora wrote: > > Hi, > > I have noticed recently that I cannot run the TestBeeLineWithArgs test on >

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Vihang Karajgaonkar
------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148007 --- On Sept. 7, 2016, 6:22 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Vihang Karajgaonkar
--- Thanks, Vihang Karajgaonkar

Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-12 Thread Vihang Karajgaonkar
ug messages in the output file. - Vihang Karajgaonkar On Sept. 13, 2016, 2:36 a.m., Jianguo Tian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-09-27 Thread Vihang Karajgaonkar
credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-09-29 Thread Vihang Karajgaonkar
: https://reviews.apache.org/r/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-09-30 Thread Vihang Karajgaonkar
credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-30 Thread Vihang Karajgaonkar
/java/org/apache/hive/beeline/hs2connection/TestBeelineWithUserHs2ConnectionFile.java PRE-CREATION Diff: https://reviews.apache.org/r/51593/diff/ Testing --- Thanks, Vihang Karajgaonkar

Review Request 52493: HIVE-13589 : beeline - support prompt for password with '-u' option

2016-10-03 Thread Vihang Karajgaonkar
a83f925df25be5801f885f4570fb8aaf5ab18c88 beeline/src/test/resources/hive-site.xml 5f310d68245275ac9dc24df45579784019eea332 itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION Diff: https://reviews.apache.org/r/52493/diff/ Testing --- Thanks, Vihang

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-05 Thread Vihang Karajgaonkar
-mail. To reply, visit: https://reviews.apache.org/r/52283/#review151382 ------- On Oct. 5, 2016, 9:58 p.m., Vihang Karajgaonkar wrote: > > --- > This is an auto

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-05 Thread Vihang Karajgaonkar
hanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-12 Thread Vihang Karajgaonkar
.java 936fdafdb37c461a7a5deb97cba72d4db54a49e1 Diff: https://reviews.apache.org/r/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-12 Thread Vihang Karajgaonkar
ck to original implementation of this method. > On Oct. 6, 2016, 8:56 p.m., Mohit Sabharwal wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java, > > line 103 > > <https://reviews.apache.org/r/52283/diff/4/?file=1523426#file1523426l

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-12 Thread Vihang Karajgaonkar
/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-14 Thread Vihang Karajgaonkar
936fdafdb37c461a7a5deb97cba72d4db54a49e1 Diff: https://reviews.apache.org/r/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-14 Thread Vihang Karajgaonkar
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review152521 --- On Oct. 14, 2016, 6:32 p.m., Vihang Karajgaonkar wrote: > > ---

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-20 Thread Vihang Karajgaonkar
eeline/Commands.java 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330 itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION Diff: https://reviews.apache.org/r/52493/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-20 Thread Vihang Karajgaonkar
> fdbe0a2c6c37688ab511710bd43517908996f158 > beeline/src/java/org/apache/hive/beeline/Commands.java > 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52493/diff/ > > > Testing > --- > > > Thanks, > > Vihang Karajgaonkar > >

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-21 Thread Vihang Karajgaonkar
ache.org/r/52493/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-21 Thread Vihang Karajgaonkar
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52493/#review153482 --- On Oct. 21, 2016, 5:31 p.m., Vihang Karajgaonkar wrote: > >

[jira] [Created] (HIVE-25796) Allow metastore clients to fetch remaining events if some of the events are cleaned up

2021-12-10 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-25796: -- Summary: Allow metastore clients to fetch remaining events if some of the events are cleaned up Key: HIVE-25796 URL: https://issues.apache.org/jira/browse/HIVE-25796

[jira] [Created] (HIVE-26948) Backport HIVE-21456 to branch-3

2023-01-16 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-26948: -- Summary: Backport HIVE-21456 to branch-3 Key: HIVE-26948 URL: https://issues.apache.org/jira/browse/HIVE-26948 Project: Hive Issue Type

[jira] [Created] (HIVE-26949) Backport HIVE-26071 to branch-3

2023-01-16 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-26949: -- Summary: Backport HIVE-26071 to branch-3 Key: HIVE-26949 URL: https://issues.apache.org/jira/browse/HIVE-26949 Project: Hive Issue Type

[jira] [Created] (HIVE-27001) Backport HIVE-26633 to branch-3

2023-01-30 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27001: -- Summary: Backport HIVE-26633 to branch-3 Key: HIVE-27001 URL: https://issues.apache.org/jira/browse/HIVE-27001 Project: Hive Issue Type

[jira] [Created] (HIVE-27009) Support pluggable user token provider HiveMetastoreClient

2023-01-31 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27009: -- Summary: Support pluggable user token provider HiveMetastoreClient Key: HIVE-27009 URL: https://issues.apache.org/jira/browse/HIVE-27009 Project: Hive

[jira] [Created] (HIVE-27062) Disable flaky test TestRpc#testClientTimeout

2023-02-09 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27062: -- Summary: Disable flaky test TestRpc#testClientTimeout Key: HIVE-27062 URL: https://issues.apache.org/jira/browse/HIVE-27062 Project: Hive Issue

[jira] [Created] (HIVE-27087) Fix TestMiniSparkOnYarnCliDriver test failures on branch-3

2023-02-16 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27087: -- Summary: Fix TestMiniSparkOnYarnCliDriver test failures on branch-3 Key: HIVE-27087 URL: https://issues.apache.org/jira/browse/HIVE-27087 Project: Hive

[jira] [Created] (HIVE-27092) Reenable flaky test TestRpc

2023-02-17 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27092: -- Summary: Reenable flaky test TestRpc Key: HIVE-27092 URL: https://issues.apache.org/jira/browse/HIVE-27092 Project: Hive Issue Type: Test

[jira] [Created] (HIVE-27146) Re-enable orc_merge*.q tests for TestMiniSparkOnYarnCliDriver

2023-03-16 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27146: -- Summary: Re-enable orc_merge*.q tests for TestMiniSparkOnYarnCliDriver Key: HIVE-27146 URL: https://issues.apache.org/jira/browse/HIVE-27146 Project

[jira] [Created] (HIVE-27148) Disable TestJdbcGenericUDTFGetSplits

2023-03-16 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27148: -- Summary: Disable TestJdbcGenericUDTFGetSplits Key: HIVE-27148 URL: https://issues.apache.org/jira/browse/HIVE-27148 Project: Hive Issue Type

[jira] [Created] (HIVE-27154) Fix testBootstrapReplLoadRetryAfterFailureForPartitions

2023-03-19 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27154: -- Summary: Fix testBootstrapReplLoadRetryAfterFailureForPartitions Key: HIVE-27154 URL: https://issues.apache.org/jira/browse/HIVE-27154 Project: Hive

[jira] [Created] (HIVE-27171) Backport HIVE-20680 to branch-3

2023-03-24 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27171: -- Summary: Backport HIVE-20680 to branch-3 Key: HIVE-27171 URL: https://issues.apache.org/jira/browse/HIVE-27171 Project: Hive Issue Type: Sub

[jira] [Created] (HIVE-27175) Fix TestJdbcDriver2#testSelectExecAsync2

2023-03-25 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27175: -- Summary: Fix TestJdbcDriver2#testSelectExecAsync2 Key: HIVE-27175 URL: https://issues.apache.org/jira/browse/HIVE-27175 Project: Hive Issue Type

[jira] [Created] (HIVE-27202) Disable flaky test TestJdbcWithMiniLlapRow#testComplexQuery

2023-03-31 Thread Vihang Karajgaonkar (Jira)
Vihang Karajgaonkar created HIVE-27202: -- Summary: Disable flaky test TestJdbcWithMiniLlapRow#testComplexQuery Key: HIVE-27202 URL: https://issues.apache.org/jira/browse/HIVE-27202 Project: Hive

[jira] [Created] (HIVE-19757) hive.version.shortname should be 4.0

2018-05-31 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19757: -- Summary: hive.version.shortname should be 4.0 Key: HIVE-19757 URL: https://issues.apache.org/jira/browse/HIVE-19757 Project: Hive Issue Type

[jira] [Created] (HIVE-19804) msck repair should hold locks

2018-06-05 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19804: -- Summary: msck repair should hold locks Key: HIVE-19804 URL: https://issues.apache.org/jira/browse/HIVE-19804 Project: Hive Issue Type

[jira] [Created] (HIVE-19966) Compile error when using open-jdk

2018-06-21 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19966: -- Summary: Compile error when using open-jdk Key: HIVE-19966 URL: https://issues.apache.org/jira/browse/HIVE-19966 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-19988) Precommit jobs erroring out

2018-06-25 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19988: -- Summary: Precommit jobs erroring out Key: HIVE-19988 URL: https://issues.apache.org/jira/browse/HIVE-19988 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-19998) Changing batch sizes and test driver specific configuration should be open to everyone

2018-06-26 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-19998: -- Summary: Changing batch sizes and test driver specific configuration should be open to everyone Key: HIVE-19998 URL: https://issues.apache.org/jira/browse/HIVE-19998

[jira] [Created] (HIVE-19999) Move precommit jobs to jdk 8

2018-06-26 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-1: -- Summary: Move precommit jobs to jdk 8 Key: HIVE-1 URL: https://issues.apache.org/jira/browse/HIVE-1 Project: Hive Issue Type

[jira] [Created] (HIVE-20122) Deploy and test standalone metastore for Hive 3.1

2018-07-09 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20122: -- Summary: Deploy and test standalone metastore for Hive 3.1 Key: HIVE-20122 URL: https://issues.apache.org/jira/browse/HIVE-20122 Project: Hive

[jira] [Created] (HIVE-20306) Add the thrift API to get partially filled Partition

2018-08-03 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20306: -- Summary: Add the thrift API to get partially filled Partition Key: HIVE-20306 URL: https://issues.apache.org/jira/browse/HIVE-20306 Project: Hive

[jira] [Created] (HIVE-20308) Add support for pagination

2018-08-03 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20308: -- Summary: Add support for pagination Key: HIVE-20308 URL: https://issues.apache.org/jira/browse/HIVE-20308 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-20307) Add support for filterspec

2018-08-03 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20307: -- Summary: Add support for filterspec Key: HIVE-20307 URL: https://issues.apache.org/jira/browse/HIVE-20307 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-20365) Fix warnings when regenerating thrift code

2018-08-10 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20365: -- Summary: Fix warnings when regenerating thrift code Key: HIVE-20365 URL: https://issues.apache.org/jira/browse/HIVE-20365 Project: Hive Issue

[jira] [Created] (HIVE-20461) Metastore unit tests do not run with directSQL enabled

2018-08-24 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20461: -- Summary: Metastore unit tests do not run with directSQL enabled Key: HIVE-20461 URL: https://issues.apache.org/jira/browse/HIVE-20461 Project: Hive

[jira] [Created] (HIVE-20472) mvn test failing for metastore-tool module

2018-08-27 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20472: -- Summary: mvn test failing for metastore-tool module Key: HIVE-20472 URL: https://issues.apache.org/jira/browse/HIVE-20472 Project: Hive Issue

[jira] [Created] (HIVE-20697) Some replication tests are super slow and cause batch timeouts

2018-10-05 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-20697: -- Summary: Some replication tests are super slow and cause batch timeouts Key: HIVE-20697 URL: https://issues.apache.org/jira/browse/HIVE-20697 Project

<    1   2   3   4   5   6   >