Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 4:04 PM, Yann Ylavic wrote: > On Tue, Sep 7, 2021 at 3:05 PM Ruediger Pluem wrote: >> >> On 9/7/21 2:18 PM, Yann Ylavic wrote: >>> Index: server/protocol.c >>> === >>> --- server/protocol.c (revision 1893001) >>> +++

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 3:05 PM Ruediger Pluem wrote: > > On 9/7/21 2:18 PM, Yann Ylavic wrote: > > Index: server/protocol.c > > === > > --- server/protocol.c (revision 1893001) > > +++ server/protocol.c (working copy) > > @@ -716,6

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 3:05 PM Ruediger Pluem wrote: > > On 9/7/21 2:00 PM, Yann Ylavic wrote: > > On Mon, May 25, 2020 at 7:50 AM wrote: > >> > >> Modified: httpd/httpd/trunk/server/scoreboard.c > >> URL: > >>

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 4:16 PM, Yann Ylavic wrote: > On Tue, Sep 7, 2021 at 3:05 PM Ruediger Pluem wrote: >> >> On 9/7/21 2:00 PM, Yann Ylavic wrote: >>> On Mon, May 25, 2020 at 7:50 AM wrote: Modified: httpd/httpd/trunk/server/scoreboard.c URL:

Re: svn commit: r1893014 - in /httpd/httpd/trunk: changes-entries/event_maintenance_spawn_limit.txt server/mpm/event/event.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 11:34 AM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Sep 7 09:34:09 2021 > New Revision: 1893014 > > URL: http://svn.apache.org/viewvc?rev=1893014=rev > Log: > mpm_event: Fix children processes possibly not stopped on graceful restart. > > The number of children spawned

release scripts

2021-09-07 Thread ste...@eissing.org
After some learning experience (*cough*) I committed a new version of the scripts, now in $DEV_TOOLS/release that go so far as staging local changes to all repositories after a successful vote. I will test some more tomorrow and add the announce mailing part. The real test will then come when

Re: svn commit: r1892997 - /httpd/httpd/branches/2.4.x/STATUS

2021-09-07 Thread Ruediger Pluem
On 9/7/21 10:51 AM, ste...@eissing.org wrote: > Updated the PR by merging current 2.4.x, updated the documentation and > answered the comments. Sorry for missing this so long! No worries. I forgot about it as well. Regards Rüdiger

Re: svn commit: r1892842 [9/24] - in /httpd/httpd/branches/2.4.x/docs/manual: ./ developer/ faq/ howto/ misc/ mod/ programs/ vhosts/

2021-09-07 Thread Christophe JAILLET
Le 03/09/2021 à 10:14, nil...@apache.org a écrit : Modified: httpd/httpd/branches/2.4.x/docs/manual/install.html.de URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/docs/manual/install.html.de?rev=1892842=1892841=1892842=diff

Re: svn commit: r1893014 - in /httpd/httpd/trunk: changes-entries/event_maintenance_spawn_limit.txt server/mpm/event/event.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 8:29 PM Christophe JAILLET wrote: > > maybe completely off-topic, but we have the same kind of code in worker.c. This may happen with mpm_worker too (with specific MPM tunings), but we have no report so far and mainly no active_daemons accounting there. This means more

Re: svn commit: r1893014 - in /httpd/httpd/trunk: changes-entries/event_maintenance_spawn_limit.txt server/mpm/event/event.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 9:28 PM Ruediger Pluem wrote: > > On 9/7/21 6:41 PM, Yann Ylavic wrote: > > On Tue, Sep 7, 2021 at 6:08 PM Ruediger Pluem wrote: > >> > >> On 9/7/21 11:34 AM, yla...@apache.org wrote: > >>> Author: ylavic > >>> Date: Tue Sep 7 09:34:09 2021 > >>> New Revision: 1893014 >

Re: svn commit: r1893014 - in /httpd/httpd/trunk: changes-entries/event_maintenance_spawn_limit.txt server/mpm/event/event.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 6:08 PM Ruediger Pluem wrote: > > On 9/7/21 11:34 AM, yla...@apache.org wrote: > > Author: ylavic > > Date: Tue Sep 7 09:34:09 2021 > > New Revision: 1893014 > > > > URL: http://svn.apache.org/viewvc?rev=1893014=rev > > Log: > > mpm_event: Fix children processes possibly

Re: svn commit: r1893014 - in /httpd/httpd/trunk: changes-entries/event_maintenance_spawn_limit.txt server/mpm/event/event.c

2021-09-07 Thread Christophe JAILLET
Hi, maybe completely off-topic, but we have the same kind of code in worker.c. Just my 2c, CJ Le 07/09/2021 à 11:34, yla...@apache.org a écrit : Author: ylavic Date: Tue Sep 7 09:34:09 2021 New Revision: 1893014 URL: http://svn.apache.org/viewvc?rev=1893014=rev Log: mpm_event: Fix children

Re: svn commit: r1893014 - in /httpd/httpd/trunk: changes-entries/event_maintenance_spawn_limit.txt server/mpm/event/event.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 6:41 PM, Yann Ylavic wrote: > On Tue, Sep 7, 2021 at 6:08 PM Ruediger Pluem wrote: >> >> On 9/7/21 11:34 AM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Tue Sep 7 09:34:09 2021 >>> New Revision: 1893014 >>> >>> URL: http://svn.apache.org/viewvc?rev=1893014=rev >>> Log: >>>

Re: svn commit: r1893011 - /httpd/httpd/trunk/test/time-sem.c

2021-09-07 Thread Christophe JAILLET
Le 07/09/2021 à 10:52, yla...@apache.org a écrit : Author: ylavic Date: Tue Sep 7 08:52:23 2021 New Revision: 1893011 URL: http://svn.apache.org/viewvc?rev=1893011=rev Log: test/time-sem.c: unlock the accept mutex before exiting (error conditions). Modified:

Re: svn commit: r1893004 - /httpd/httpd/trunk/modules/metadata/mod_unique_id.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 3:52 AM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Sep 7 01:52:48 2021 > New Revision: 1893004 > > URL: http://svn.apache.org/viewvc?rev=1893004=rev > Log: > mod_unique_id: Follow up to r1892915 and r1893002: Atomic counter. > > *

Re: svn commit: r1893004 - /httpd/httpd/trunk/modules/metadata/mod_unique_id.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 8:07 AM Ruediger Pluem wrote: > > On 9/7/21 3:52 AM, yla...@apache.org wrote: > > > > -/* Set counter in network byte order for the uuencoded unique id. */ > > -new_unique_id.counter = htons(new_unique_id.counter); > > +/* The counter is two bytes for the

Re: svn commit: r1892988 - in /httpd/dev-tools/v2: README common-lib.sh make-candidate.sh update-branch.sh

2021-09-07 Thread ste...@eissing.org
> Am 06.09.2021 um 17:55 schrieb Ruediger Pluem : > > > > On 9/6/21 1:35 PM, ic...@apache.org wrote: >> Author: icing >> Date: Mon Sep 6 11:35:41 2021 >> New Revision: 1892988 >> >> URL: http://svn.apache.org/viewvc?rev=1892988=rev >> Log: >> * added 'update-branch.sh' to increase the

unused function

2021-09-07 Thread ste...@eissing.org
proxy_util.c:4447:23: error: unused function 'ap_filter_input_pending' [-Werror,-Wunused-function] in branches/2.4.x on a maintainer build. Can we remove this backport fragment?

Re: svn commit: r1892997 - /httpd/httpd/branches/2.4.x/STATUS

2021-09-07 Thread ste...@eissing.org
Updated the PR by merging current 2.4.x, updated the documentation and answered the comments. Sorry for missing this so long! > Am 06.09.2021 um 21:43 schrieb rpl...@apache.org: > > Author: rpluem > Date: Mon Sep 6 19:43:39 2021 > New Revision: 1892997 > > URL:

Re: unused function

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 10:47 AM ste...@eissing.org wrote: > > proxy_util.c:4447:23: error: unused function 'ap_filter_input_pending' > [-Werror,-Wunused-function] > > in branches/2.4.x on a maintainer build. Can we remove this backport fragment? Oh yeah sorry, the removal was missing from

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Yann Ylavic
On Tue, Sep 7, 2021 at 2:00 PM Yann Ylavic wrote: > > On Mon, May 25, 2020 at 7:50 AM wrote: > > > > Author: rpluem > > Date: Mon May 25 05:50:12 2020 > > New Revision: 1878092 > > > > URL: http://svn.apache.org/viewvc?rev=1878092=rev > > Log: > > Fix a NULL pointer dereference > > > > *

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Eric Covener
On Tue, Sep 7, 2021 at 8:18 AM Yann Ylavic wrote: > > On Tue, Sep 7, 2021 at 2:00 PM Yann Ylavic wrote: > > > > On Mon, May 25, 2020 at 7:50 AM wrote: > > > > > > Author: rpluem > > > Date: Mon May 25 05:50:12 2020 > > > New Revision: 1878092 > > > > > > URL:

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Yann Ylavic
On Mon, May 25, 2020 at 7:50 AM wrote: > > Author: rpluem > Date: Mon May 25 05:50:12 2020 > New Revision: 1878092 > > URL: http://svn.apache.org/viewvc?rev=1878092=rev > Log: > Fix a NULL pointer dereference > > * server/scoreboard.c (ap_increment_counts): In certain cases like certain >

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 2:00 PM, Yann Ylavic wrote: > On Mon, May 25, 2020 at 7:50 AM wrote: >> >> Author: rpluem >> Date: Mon May 25 05:50:12 2020 >> New Revision: 1878092 >> >> URL: http://svn.apache.org/viewvc?rev=1878092=rev >> Log: >> Fix a NULL pointer dereference >> >> * server/scoreboard.c

Re: svn commit: r1878092 - /httpd/httpd/trunk/server/scoreboard.c

2021-09-07 Thread Ruediger Pluem
On 9/7/21 2:18 PM, Yann Ylavic wrote: > Index: server/protocol.c > === > --- server/protocol.c (revision 1893001) > +++ server/protocol.c (working copy) > @@ -716,6 +716,13 @@ static int read_request_line(request_rec *r, apr_b >