Re: intent to rip out mod_tls

2024-09-13 Thread Ruediger Pluem
On 9/13/24 3:26 PM, Stefan Eissing via dev wrote: > Folks, > > the 'rustls-ffi' project keeps on > changing their API and consider themselves "pre-1.0". The recent 0.14.0 > release does not work with mod_tls, again. While one of their devs is willing >

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-09-11 Thread Ruediger Pluem
On 9/11/24 5:59 PM, Yann Ylavic wrote: > On Mon, Sep 9, 2024 at 12:20 PM Ruediger Pluem wrote: >> >> Looks like there is no further feedback on the below. >> @Yann: Care to commit https://bz.apache.org/bugzilla/attachment.cgi?id=39832 >> ? >> I would then

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-09-09 Thread Ruediger Pluem
Looks like there is no further feedback on the below. @Yann: Care to commit https://bz.apache.org/bugzilla/attachment.cgi?id=39832 ? I would then commit my stuff below. Regards Rüdiger On 8/20/24 5:20 PM, Ruediger Pluem wrote: > > > On 8/20/24 2:32 PM, Eric Covener wrote: >>

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-08-20 Thread Ruediger Pluem
On 8/20/24 2:32 PM, Eric Covener wrote: > On Tue, Aug 20, 2024 at 8:12 AM Ruediger Pluem wrote: >> >> >> >> On 8/20/24 1:44 PM, Eric Covener wrote: >>> On Tue, Aug 20, 2024 at 4:41 AM Ruediger Pluem wrote: >>>> >>>> >>&

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-08-20 Thread Ruediger Pluem
On 8/20/24 1:44 PM, Eric Covener wrote: > On Tue, Aug 20, 2024 at 4:41 AM Ruediger Pluem wrote: >> >> >> >> On 8/19/24 2:14 PM, Eric Covener wrote: >>>> >>>> Maybe reverting r757427 >>>> (https://svn.apache.org/viewvc?vie

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-08-20 Thread Ruediger Pluem
On 8/19/24 2:14 PM, Eric Covener wrote: >> >> Maybe reverting r757427 >> (https://svn.apache.org/viewvc?view=revision&revision=757427) fixes this. >> My new patch sofar: >> >> Index: modules/mappers/mod_rewrite.c >> === >> --- modu

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2024-08-20 Thread Ruediger Pluem
On 8/20/24 9:01 AM, Vladimir Chlup wrote: > Hello, > > It's not necessarily related, but some time ago, I created a PR > (https://github.com/apache/httpd/pull/437) that adds git commands > for apr checkout to INSTALL. Given that everything is also on git, svn is not > needed. Especially if th

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2024-08-20 Thread Ruediger Pluem
On 8/19/24 7:44 PM, Roy T. Fielding wrote: >> On Aug 19, 2024, at 8:22 AM, Eric Covener wrote: >> >> To bring the convo back here out of cwiki -- in a world where we moved >> to read/write git, with reviews happening in the context of a pull >> request, does anyone else have any feelings about

Re: linux.yml: missing libsasl2-dev dependency

2024-08-19 Thread Ruediger Pluem
On 8/19/24 1:06 PM, Graham Leggett via dev wrote: > Hi all, > > Tests are failing on Ubuntu because of this bug: > > https://bugs.launchpad.net/ubuntu/+source/openldap2/+bug/2077320 > > libldap2-dev is missing a dependency on libsasl2-dev, and as a result the > moment you try use ldap_sasl_i

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-08-19 Thread Ruediger Pluem
On 8/19/24 11:24 AM, Ruediger Pluem wrote: > > > On 8/7/24 2:09 PM, Ruediger Pluem wrote: >> >> >> On 7/31/24 7:03 PM, Yann Ylavic wrote: >>> On Wed, Jul 31, 2024 at 6:57 PM wrote: >>>> >>>> https://bz.apache.org/bugzilla/sho

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-08-19 Thread Ruediger Pluem
On 8/7/24 2:09 PM, Ruediger Pluem wrote: > > > On 7/31/24 7:03 PM, Yann Ylavic wrote: >> On Wed, Jul 31, 2024 at 6:57 PM wrote: >>> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=69235 >>> >>> --- Comment #2 from Yann Ylavi

Re: 2.4.62 and UNCList config errors

2024-08-14 Thread Ruediger Pluem
On 8/14/24 7:19 AM, Steffen wrote: > > >> Op 13 aug 2024 om 10:26 heeft Steffen het volgende >> geschreven: >> >>  >> >> >>> Op 13 aug 2024 om 10:00 heeft Ruediger Pluem het >>> volgende geschreven: >>> >>> 

Re: 2.4.62 and UNCList config errors

2024-08-13 Thread Ruediger Pluem
On 8/13/24 9:56 AM, SteffenAL wrote: >   >   > On Tuesday 13/08/2024 at 08:54, Ruediger Pluem wrote: >> >> >> On 8/12/24 5:44 PM, Eric Covener wrote: >>> On Mon, Aug 12, 2024 at 5:18 AM Ruediger Pluem wrote: >>>> >>>> >>>>

Re: 2.4.62 and UNCList config errors

2024-08-12 Thread Ruediger Pluem
On 8/12/24 5:44 PM, Eric Covener wrote: > On Mon, Aug 12, 2024 at 5:18 AM Ruediger Pluem wrote: >> >> >> >> On 8/7/24 2:37 PM, Ruediger Pluem wrote: >>> >>> >>> On 7/30/24 9:52 AM, SteffenAL wrote: >>>> >>>> P

Re: 2.4.62 and UNCList config errors

2024-08-12 Thread Ruediger Pluem
On 8/7/24 2:37 PM, Ruediger Pluem wrote: > > > On 7/30/24 9:52 AM, SteffenAL wrote: >> >> Please have a look >> >> https://www.apachelounge.com/viewtopic.php?p=42911 > > Can we have the full LogLevel trace8 error_log posted here or in the forum &g

Re: svn commit: r1919547 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

2024-08-08 Thread Ruediger Pluem
On 7/27/24 3:54 PM, yla...@apache.org wrote: > Author: ylavic > Date: Sat Jul 27 13:54:08 2024 > New Revision: 1919547 > > URL: http://svn.apache.org/viewvc?rev=1919547&view=rev > Log: > mod_proxy_fcgi: Use r->uri rather than r->filename for directory walk. > > r->filename is a "proxy:" one fo

Re: svn commit: r1919325 - in /httpd/httpd/trunk: changes-entries/pr69197.txt modules/mappers/mod_rewrite.c

2024-08-08 Thread Ruediger Pluem
On 7/17/24 10:50 PM, yla...@apache.org wrote: > Author: ylavic > Date: Wed Jul 17 20:50:12 2024 > New Revision: 1919325 > > URL: http://svn.apache.org/viewvc?rev=1919325&view=rev > Log: > mod_rewrite: Better question mark tracking to avoid UnsafeAllow3F. PR 69197. > > Track in do_expand() whe

Re: 2.4.62 and UNCList config errors

2024-08-07 Thread Ruediger Pluem
On 7/30/24 9:52 AM, SteffenAL wrote: > > Please have a look > > https://www.apachelounge.com/viewtopic.php?p=42911 Can we have the full LogLevel trace8 error_log posted here or in the forum (the link above only contains a snipped). Regards Rüdiger

Re: svn commit: r1916784 - /httpd/dev-tools/release/README

2024-08-07 Thread Ruediger Pluem
On 2024/08/07 10:48:26 Eric Covener wrote: > On Wed, Aug 7, 2024 at 2:28 AM Ruediger Pluem wrote: > > > > > > > > On 4/3/24 3:55 PM, cove...@apache.org wrote: > > > Author: covener > > > Date: Wed Apr 3 13:55:56 2024 > > > New Revision:

Re: [Bug 69235] unable to connect to backend with existing rewrite rules.

2024-08-07 Thread Ruediger Pluem
On 7/31/24 7:03 PM, Yann Ylavic wrote: > On Wed, Jul 31, 2024 at 6:57 PM wrote: >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=69235 >> >> --- Comment #2 from Yann Ylavic --- >> Created attachment 39832 >> --> https://bz.apache.org/bugzilla/attachment.cgi?id=39832&action=edit >> mod_pr

Re: svn commit: r1919628 - in /httpd/httpd/trunk: changes-entries/bz69203.txt modules/proxy/mod_proxy.c modules/proxy/mod_proxy_fcgi.c

2024-08-07 Thread Ruediger Pluem
On 8/2/24 2:53 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Aug 2 00:53:53 2024 > New Revision: 1919628 > > URL: http://svn.apache.org/viewvc?rev=1919628&view=rev > Log: > Follow up to r1919620: Restore r->filename re-encoding for ProxyPass URLs. > > > Modified: > httpd/http

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2024-08-07 Thread Ruediger Pluem
On 7/16/24 5:02 PM, Eric Covener wrote: > On Thu, May 11, 2023 at 11:34 AM Ruediger Pluem wrote: >> >> >> >> On 5/11/23 12:27 PM, Ruediger Pluem wrote: >>> >>> >>> On 5/4/23 10:34 AM, Ruediger Pluem wrote: >>>> This is

Re: svn commit: r1916784 - /httpd/dev-tools/release/README

2024-08-06 Thread Ruediger Pluem
On 4/3/24 3:55 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Apr 3 13:55:56 2024 > New Revision: 1916784 > > URL: http://svn.apache.org/viewvc?rev=1916784&view=rev > Log: > amend log message > > Modified: > httpd/dev-tools/release/README > > Modified: httpd/dev-tools/releas

Re: [RFC/PATCH] Avoid redefining apr_filepath_merge() for UNC path checks

2024-07-12 Thread Ruediger Pluem
On 7/12/24 1:05 PM, Eric Covener wrote: > Any concerns on this? @Ruediger Pluem ? I agree with all the arguments, but how do we protect 3rd party modules? They would need to switch to ap_filepath_merge as well. Regards Rüdiger

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 4:09 PM, Stefan Eissing via dev wrote: > > >> Am 05.07.2024 um 15:44 schrieb Ruediger Pluem : >> >> >> >> On 7/5/24 3:40 PM, Yann Ylavic wrote: >>> On Fri, Jul 5, 2024 at 3:35 PM Yann Ylavic wrote: >>>>

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 3:40 PM, Yann Ylavic wrote: > On Fri, Jul 5, 2024 at 3:35 PM Yann Ylavic wrote: >> >> On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem wrote: >>> >>>>>>> md_crypt.c: In function 'md_cert_get_ct_scts': >>>>>>> m

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 3:26 PM, Yann Ylavic wrote: > On Fri, Jul 5, 2024 at 3:16 PM Yann Ylavic wrote: >> >> On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem wrote: >>> >>> >>> >>> On 7/5/24 2:14 PM, Ruediger Pluem wrote: >>>> >>>>

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 3:16 PM, Yann Ylavic wrote: > On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem wrote: >> >> >> >> On 7/5/24 2:14 PM, Ruediger Pluem wrote: >>> >>> >>> On 7/5/24 2:11 PM, Ruediger Pluem wrote: >>>> >>>&g

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 2:14 PM, Ruediger Pluem wrote: > > > On 7/5/24 2:11 PM, Ruediger Pluem wrote: >> >> >> On 7/5/24 2:04 PM, Stefan Eissing via dev wrote: >>> >>> >>>> Am 05.07.2024 um 13:51 schrieb Ruediger Pluem : >>>> &g

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 2:11 PM, Ruediger Pluem wrote: > > > On 7/5/24 2:04 PM, Stefan Eissing via dev wrote: >> >> >>> Am 05.07.2024 um 13:51 schrieb Ruediger Pluem : >>> >>> I just noticed that mod_md in 2.4.61 fails to compile with openssl < 1.1.1

Re: mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
On 7/5/24 2:04 PM, Stefan Eissing via dev wrote: > > >> Am 05.07.2024 um 13:51 schrieb Ruediger Pluem : >> >> I just noticed that mod_md in 2.4.61 fails to compile with openssl < 1.1.1. >> Below is the output against openssl 1.0.2 on RedHat

mod_md in 2.4.61 fails to compile with openssl < 1.1.1

2024-07-05 Thread Ruediger Pluem
I just noticed that mod_md in 2.4.61 fails to compile with openssl < 1.1.1. Below is the output against openssl 1.0.2 on RedHat 7: md_crypt.c: In function 'md_pkey_get_rsa_e64': md_crypt.c:982:5: warning: implicit declaration of function 'EVP_PKEY_get0_RSA' [-Wimplicit-function-declaration]

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-07-03 Thread Ruediger Pluem
On 7/3/24 3:23 PM, Yann Ylavic wrote: > On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote: >> >> Thanks for the intense review. I hope I captured all stuff in the below. > > Thanks for working on this. Committed in r1918880 considering your comments. Feel free

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-07-03 Thread Ruediger Pluem
On 7/3/24 11:09 AM, Yann Ylavic wrote: > On Wed, Jul 3, 2024 at 11:01 AM Yann Ylavic wrote: >> >> On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote: >>> >>> On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote: >>>> >>>> On 7/3/24 2:

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-07-03 Thread Ruediger Pluem
On 7/3/24 11:01 AM, Yann Ylavic wrote: > On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote: >> >> On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote: >>> >>> On 7/3/24 2:59 AM, Yann Ylavic wrote: >>>> On Tue, Jul 2, 2024 at 10:57 AM Rue

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-07-02 Thread Ruediger Pluem
On 7/3/24 2:59 AM, Yann Ylavic wrote: > On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote: >> >> On 7/1/24 3:01 PM, Ruediger Pluem wrote: >>> >>> >>> On 6/27/24 3:48 PM, Ruediger Pluem wrote: >>>> >>>> >>>> On 6/

Re: svn commit: r1918798 - /httpd/httpd/branches/2.4.x/STATUS

2024-07-02 Thread Ruediger Pluem
I would be fine if we add: 1918814 1918815 1918823 Unfortunately they cause some conflicts: modules/dav/main/ms_wdv.c modules/filters/mod_crypto.c are not present in 2.4.x an can just be ignored. The patch to modules/http/byterange_filter.c needs to be slightly modified to: Index: modules/http

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-07-02 Thread Ruediger Pluem
On 7/1/24 3:01 PM, Ruediger Pluem wrote: > > > On 6/27/24 3:48 PM, Ruediger Pluem wrote: >> >> >> On 6/27/24 12:47 PM, Yann Ylavic wrote: >>> On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote: >>>> >>>> On Thu, Jun 27, 2024 at 12:

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-07-01 Thread Ruediger Pluem
On 6/27/24 3:48 PM, Ruediger Pluem wrote: > > > On 6/27/24 12:47 PM, Yann Ylavic wrote: >> On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote: >>> >>> On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote: >>>> >>>> How about t

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-07-01 Thread Ruediger Pluem
Crossposting to dev@apr. Maybe some Windows folks want to feedback. Regards Rüdiger On 6/20/24 12:12 PM, Ruediger Pluem wrote: > > > On 6/19/24 2:52 PM, Joe Orton wrote: >> On Wed, Jun 19, 2024 at 02:04:20PM +0200, Yann Ylavic wrote: >>> On Wed, Jun 19, 2024 at 1:00 

Re: [VOTE] Release httpd-2.4.60-rc4 as httpd-2.4.60

2024-06-28 Thread Ruediger Pluem
On 6/27/24 10:54 PM, Helmut K. C. Tessarek wrote: > On 2024-06-26 17:20, Eric Covener wrote: >> Thanks for testing and re-testing. I just extended an existing FCGI >> test to cover the scenario as well. > > You are welcome. Thanks for doing the release work and for adding a test that > will ca

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-06-27 Thread Ruediger Pluem
On 6/27/24 12:47 PM, Yann Ylavic wrote: > On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote: >> >> On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote: >>> >>> How about the below? I am yet undecided if I should follow the below >>> approach to

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-06-27 Thread Ruediger Pluem
On 6/26/24 11:33 AM, Yann Ylavic wrote: > On Wed, Jun 26, 2024 at 10:28 AM Ruediger Pluem wrote: >> >> On 3/19/23 10:30 PM, yla...@apache.org wrote: >>> >>> --- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c (original) >>> +++ httpd/httpd/trunk/modul

Re: svn commit: r1918664 - /httpd/httpd/branches/2.4.x/STATUS

2024-06-26 Thread Ruediger Pluem
On 6/26/24 3:56 PM, Eric Covener wrote: > On Wed, Jun 26, 2024 at 9:54 AM Ruediger Pluem wrote: >> >> >> >> On 6/26/24 3:40 PM, cove...@apache.org wrote: >>> Author: covener >>> Date: Wed Jun 26 13:40:42 2024 >>> New Revision: 1918664 >

Re: svn commit: r1918664 - /httpd/httpd/branches/2.4.x/STATUS

2024-06-26 Thread Ruediger Pluem
On 6/26/24 3:40 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 26 13:40:42 2024 > New Revision: 1918664 > > URL: http://svn.apache.org/viewvc?rev=1918664&view=rev > Log: > update, leave vote > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branc

Re: svn commit: r1918651 - in /httpd/httpd/trunk: include/ap_mmn.h include/httpd.h modules/mappers/mod_rewrite.c server/util.c

2024-06-26 Thread Ruediger Pluem
On 6/26/24 12:09 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 26 10:09:29 2024 > New Revision: 1918651 > > URL: http://svn.apache.org/viewvc?rev=1918651&view=rev > Log: > factor out IS_SLASH, perdir fix > > in per-dir, the filename will be internally redirected, so / is OK t

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2024-06-26 Thread Ruediger Pluem
On 3/19/23 10:30 PM, yla...@apache.org wrote: > Author: ylavic > Date: Sun Mar 19 21:30:47 2023 > New Revision: 1908537 > > URL: http://svn.apache.org/viewvc?rev=1908537&view=rev > Log: > mod_ssl: Fix deprecation warnings with openssl-3. > > * mod_ssl_openssl.h: > Make it the first openssl t

Re: svn commit: r1918626 - in /httpd/httpd/trunk: include/ap_mmn.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/proxy_util.c

2024-06-26 Thread Ruediger Pluem
On 6/26/24 1:49 AM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Jun 25 23:49:09 2024 > New Revision: 1918626 > > URL: http://svn.apache.org/viewvc?rev=1918626&view=rev > Log: > mod_proxy: Fixup UDS filename for mod_proxy called through r->handler. > > * modules/proxy/proxy_util.c: >

Re: svn commit: r1918623 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2024-06-25 Thread Ruediger Pluem
On 6/25/24 9:43 PM, cove...@apache.org wrote: > Author: covener > Date: Tue Jun 25 19:43:15 2024 > New Revision: 1918623 > > URL: http://svn.apache.org/viewvc?rev=1918623&view=rev > Log: > fix comparison of local path on Windows > > Submitted By: Yann Ylavic > > Modified: > httpd/httpd/tr

Re: [VOTE] Release httpd-2.4.60-rc1 as httpd-2.4.60

2024-06-25 Thread Ruediger Pluem
On 6/25/24 3:30 PM, Yann Ylavic wrote: > On Tue, Jun 25, 2024 at 2:50 PM Eric Covener wrote: >> >> - whether backing out >> https://github.com/apache/httpd/commit/9494aa8d52e3c263bc0413b77ac8a73b0d524388.diff >> from the candidate helps? > > I'm not sure r1918553 made it to rc1, did it? > I

Re: [VOTE] Release httpd-2.4.60-rc1 as httpd-2.4.60

2024-06-24 Thread Ruediger Pluem
On 6/25/24 8:30 AM, Helmut K. C. Tessarek wrote: > Hello, > > On 2024-06-24 14:28, Eric Covener wrote: >> Hi all, >> >> Please find below the proposed release tarball and signatures: >> >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to

Re: httpd-2.4.60-rc1: pytest http2 failures w.r.t. assets

2024-06-24 Thread Ruediger Pluem
On 6/25/24 1:12 AM, Rainer Jung wrote: > I am getting some pytest failures when checking for assets (leading "/" > missing): > > === FAILURES > === > __ TestAssets.test_h2_006_03 > ___

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-20 Thread Ruediger Pluem
On 6/19/24 2:52 PM, Joe Orton wrote: > On Wed, Jun 19, 2024 at 02:04:20PM +0200, Yann Ylavic wrote: >> On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: >>> As far as I read the code it does not. >>> >>> https://github.com/apache/apr/blob/b0a08c76ceacc23

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Ruediger Pluem
On 6/19/24 2:04 PM, Yann Ylavic wrote: > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: >> >> On 6/19/24 12:00 PM, Yann Ylavic wrote: >>> On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote: >>>> >>>> On 6/18/24 4:20 PM, yla...@apache.or

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Ruediger Pluem
On 6/19/24 12:00 PM, Yann Ylavic wrote: > On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote: >> >> On 6/18/24 4:20 PM, yla...@apache.org wrote: >>> >>> +/* Release the old conn address */ >>> +if (conn->address) { >>

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Ruediger Pluem
On 6/18/24 4:20 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Jun 18 14:20:06 2024 > New Revision: 1918412 > > URL: http://svn.apache.org/viewvc?rev=1918412&view=rev > Log: > mod_proxy: Keep connection alive on addressTTL expiry if the DNS didn't > change. > > * modules/proxy/prox

Re: Json support for httpd log

2024-06-12 Thread Ruediger Pluem
Thanks for your patience Thomas. You mails are not lost. It is just that with the somewhat limited resources we have in this project no-one had time so far to look through your proposal. You are doing it exactly right by giving us a reminder from time to time to get it back on our list. Regards

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Ruediger Pluem
On 4/18/24 10:40 AM, Graham Leggett via dev wrote: > Hi all, > > The attached patch is a current work in progress patch for httpd-trunk to use > the new apr_ldap API that just landing in APR. > > The highlights: > > - Complete replacement of the previous API. > - Will work against apr-2 (jus

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Ruediger Pluem
On 4/18/24 3:21 PM, Joe Orton wrote: > On Thu, Apr 18, 2024 at 09:40:21AM +0100, Graham Leggett via dev wrote: >> Hi all, >> >> The attached patch is a current work in progress patch for httpd-trunk to >> use the new apr_ldap API that just landing in APR. >> >> The highlights: >> >> - Complete

Re: svn commit: r1916926 - in /httpd/httpd/trunk: changes-entries/worker_exit.txt server/mpm/worker/worker.c

2024-04-12 Thread Ruediger Pluem
On 4/12/24 1:02 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 12 11:02:31 2024 > New Revision: 1916926 > > URL: http://svn.apache.org/viewvc?rev=1916926&view=rev > Log: > mpm_worker: Fix AH00045 about children processes not terminating timely. > > * server/mpm/worker/worker.c(s

Re: svn commit: r1916925 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-04-12 Thread Ruediger Pluem
On 4/12/24 12:35 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 12 10:35:10 2024 > New Revision: 1916925 > > URL: http://svn.apache.org/viewvc?rev=1916925&view=rev > Log: > mpm_event: Simplify pollset "good methods" vs APR_POLLSET_WAKEABLE. > > * server/mpm/event/event.c(setup_t

Re: Fwd: [Bug 68872] New: xmlhttprequest.onprogress behavior changed after updated to 2.4.59

2024-04-08 Thread Ruediger Pluem
On 4/8/24 1:47 PM, Eric Covener wrote: > Any concerns with documenting the ap_trust_cgilike_cl variable in e.g. > https://httpd.apache.org/docs/2.4/env.html ? Not from my side. Regards Rüdiger

Re: pytest results for 2.4.59

2024-04-04 Thread Ruediger Pluem
On 4/5/24 12:59 AM, Rainer Jung wrote: > I think I fixed all test failures, hopefully in the correct way. More eyes > welcome. > > I have a few additional sporadic ERRORS: > > A] ERROR during teardown check for log file errors or warnings (twice): > > 04.04.2024 21:14:42.205465 _

Re: [VOTE] Release httpd-2.4.59-rc1 as httpd-2.4.59

2024-04-04 Thread Ruediger Pluem
Are you sure that you did not use outdated headers somehow? DAV_WALKTYPE_TOLERANT is defined in modules/dav/main/mod_dav.h Regards Rüdiger On 4/4/24 12:49 PM, Steffen Land wrote: > -1 > Get an error: > > Error C2065 'DAV_WALKTYPE_TOLERANT': undeclared identifier mod_dav_fs > C:\VS17\

Re: mod_systemd: refactor to get rid of libsystemd dependency?

2024-04-04 Thread Ruediger Pluem
On 4/3/24 4:32 PM, Joe Orton wrote: > On Tue, Apr 02, 2024 at 12:25:40PM +0200, Rainer Jung wrote: >> Hi there, >> >> in the light of the recent xz attack I was wondering, whether we should also >> reduce our library dependencies by no longer using sd_notify() in >> mod_systemd (thus loading lib

Re: libapreq subproject roll call

2024-02-16 Thread Ruediger Pluem
On 2/16/24 2:10 PM, Eric Covener wrote: >> Will apreq 2.18 still be released? > > I think we should, but we need someone to do the release work and 3 > active PMC members to approve it. Prior to the recent activity, the > subproject was essentially unchanged and unreleased for 10 years (with >

Re: reset in proxy_balancer_method

2024-02-15 Thread Ruediger Pluem
On 2/15/24 9:28 AM, jean-frederic clere wrote: > On 2/14/24 20:54, Ruediger Pluem wrote: >> >> >> On 2/14/24 3:45 PM, jean-frederic clere wrote: >>> On 2/14/24 08:19, Ruediger Pluem wrote: >>>> >>>> >>>> On 2/9/24 11:59 AM, je

Re: reset in proxy_balancer_method

2024-02-14 Thread Ruediger Pluem
On 2/14/24 3:45 PM, jean-frederic clere wrote: > On 2/14/24 08:19, Ruediger Pluem wrote: >> >> >> On 2/9/24 11:59 AM, jean-frederic clere wrote: >>> Hi, >>> >>> I have noted to the reset() clean up too much in the balancers: >>> mod_lbm

Re: using changes-entries or write in CHANGES directly

2024-02-14 Thread Ruediger Pluem
On 2/14/24 10:53 AM, jean-frederic clere wrote: > Hi, > > Are there any rules to use changes-entries or write directly in CHANGES? > IMHO change-entries is preferred. See http://svn.apache.org/viewvc/httpd/httpd/trunk/README.CHANGES?view=markup I just noticed that we probably need a better

Re: reset in proxy_balancer_method

2024-02-13 Thread Ruediger Pluem
On 2/9/24 11:59 AM, jean-frederic clere wrote: > Hi, > > I have noted to the reset() clean up too much in the balancers: > mod_lbmethod_bybusyness.c for example does: > +++ >     for (i = 0; i < balancer->workers->nelts; i++, worker++) { >     (*worker)->s->lbstatus = 0; >     ap_proxy_

Re: svn commit: r1915534 - in /httpd/httpd/branches/2.4.x: ./ modules/cache/mod_socache_shmcb.c modules/proxy/balancers/mod_lbmethod_heartbeat.c os/unix/unixd.c server/buildmark.c server/scoreboard.c

2024-02-02 Thread Ruediger Pluem
On 2/2/24 12:50 PM, jor...@apache.org wrote: > Author: jorton > Date: Fri Feb 2 11:50:07 2024 > New Revision: 1915534 > > URL: http://svn.apache.org/viewvc?rev=1915534&view=rev > Log: > Merge r1909450 from trunk: > > Make sources build with latest clang version > > Submitted by: icing > Revi

Re: svn commit: r1915516 - in /httpd/httpd/branches/2.4.x: ./ CHANGES configure.in docs/man/htpasswd.1 support/htpasswd.c support/passwd_common.c support/passwd_common.h

2024-02-01 Thread Ruediger Pluem
On 2/1/24 5:54 PM, jor...@apache.org wrote: > Author: jorton > Date: Thu Feb 1 16:54:40 2024 > New Revision: 1915516 > > URL: http://svn.apache.org/viewvc?rev=1915516&view=rev > Log: > Merge r1861793, r1862612, r1862724, r1877251, r1907672 from trunk: > > Add support for SHA-2 crypt() algorit

Re: svn commit: r1915411 - /httpd/httpd/trunk/CMakeLists.txt

2024-01-26 Thread Ruediger Pluem
On 1/26/24 4:07 PM, jean-frederic clere wrote: > On 1/26/24 15:57, Ruediger Pluem wrote: >> There seem to be unrelated changes to mod_proxy_hcheck in the below. Is this >> intended? > > Well mod_proxy_hchech was missing... I was planning another commit. > > Sh

Re: svn commit: r1915411 - /httpd/httpd/trunk/CMakeLists.txt

2024-01-26 Thread Ruediger Pluem
There seem to be unrelated changes to mod_proxy_hcheck in the below. Is this intended? Regards Rüdiger On 1/26/24 3:25 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Fri Jan 26 14:25:15 2024 > New Revision: 1915411 > > URL: http://svn.apache.org/viewvc?rev=1915411&view=rev > Log: > ab

Re: PR #363

2024-01-24 Thread Ruediger Pluem
On 1/25/24 8:04 AM, Ruediger Pluem wrote: > > > On 1/24/24 11:31 PM, Rich Bowen wrote: >> Well, it turns out that in order for this to actually work, we would need to >> rename README to README.md, so I'm inclined to revert >> this change unless someone th

Re: PR #363

2024-01-24 Thread Ruediger Pluem
On 1/24/24 11:31 PM, Rich Bowen wrote: > Well, it turns out that in order for this to actually work, we would need to > rename README to README.md, so I'm inclined to revert > this change unless someone thinks differently. How about using a symlink? Keep README and create a README.md symlink t

Re: New type of spam bugzilla entries

2024-01-15 Thread Ruediger Pluem
On 1/12/24 1:22 PM, Eric Covener wrote: > On Fri, Jan 12, 2024 at 3:22 AM Ruediger Pluem wrote: >> >> Recently we seem to have new types of SPAM entries in Bugzilla. Instead of >> adding the SPAM message directly they look >> more like real bug reports / comments w

New type of spam bugzilla entries

2024-01-12 Thread Ruediger Pluem
Recently we seem to have new types of SPAM entries in Bugzilla. Instead of adding the SPAM message directly they look more like real bug reports / comments with some context / relation to httpd or even the specific bug (maybe AI generated) but then contain SPAM links. Examples: https://bz.apach

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2024-01-11 Thread Ruediger Pluem
On 11/28/23 10:29 PM, Yann Ylavic wrote: > > Tried something in https://github.com/apache/httpd/pull/396 > WDYT? Looks good. Thanks. Regards Rüdiger

Re: process_regexp bug, infinite recursion

2024-01-08 Thread Ruediger Pluem
On 1/8/24 1:37 PM, Yann Ylavic wrote: > On Mon, Jan 8, 2024 at 10:49 AM Ruediger Pluem wrote: >> >> On 1/5/24 3:08 PM, Yann Ylavic wrote: >>> >>> process_regexp.diff >>>

Re: Module file access problem

2024-01-08 Thread Ruediger Pluem
On 12/25/23 9:55 AM, MIIM via dev wrote: > > I apologize in advance for posting this question to the development > forum, but unfortunately the modules-development list is dead > according to the list server. > > > I have a module attempting to write a log file -- > not one of the Apache log

Re: process_regexp bug, infinite recursion

2024-01-08 Thread Ruediger Pluem
On 1/5/24 3:08 PM, Yann Ylavic wrote: > On Fri, Jan 5, 2024 at 3:11 AM Eric Covener wrote: >> On Thu, Jan 4, 2024 at 9:04 PM Jason Pyeron wrote: >>> I am having some issue searching Bugzilla for any issue involving >>> process_regexp in mod_headers.c . >>> >>> It finds nothing, so I am assumi

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Ruediger Pluem
On 12/20/23 4:08 PM, Yann Ylavic wrote: > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote: >> >> I was surprised this made a difference to the behaviour on the wire. It >> seems like the chunk filter has suboptimal behaviour here. If you take >> an output brigade like either: >> >> a) [HEAP FLU

Re: svn commit: r1914045 - in /httpd/httpd/trunk: changes-entries/ab-source-address.txt docs/man/ab.1 support/ab.c

2023-12-19 Thread Ruediger Pluem
On 12/19/23 4:44 PM, Joe Orton wrote: > On Wed, Nov 22, 2023 at 05:19:50PM -, minf...@apache.org wrote: >> Author: minfrin >> Date: Wed Nov 22 17:19:49 2023 >> New Revision: 1914045 >> >> URL: http://svn.apache.org/viewvc?rev=1914045&view=rev >> Log: >> Add an option to specify a source addr

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-24 Thread Ruediger Pluem
On 11/24/23 5:41 PM, Graham Leggett via dev wrote: > On 24 Nov 2023, at 14:25, Ruediger Pluem wrote: > >>> +            req->dn = dn; >> >> Don't we need to save the vals as well? > > We do - and we also need to apr_pstrdup() the dn to be consist

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-24 Thread Ruediger Pluem
On 11/24/23 10:59 AM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 5:47 PM Ruediger Pluem wrote: >> >> On 11/23/23 5:05 PM, Yann Ylavic wrote: >>> On Thu, Nov 23, 2023 at 4:46 PM Yann Ylavic wrote: >>>> >>>> On Thu, Nov 23, 2023 at 4:17 PM Rue

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-24 Thread Ruediger Pluem
On 11/24/23 10:45 AM, Graham Leggett via dev wrote: > >   > >          /* Make sure that the filtered search returned a single dn */ > >          if (result == LDAP_SUCCESS && dn) { > > +            req->dn = dn; Don't we need to save the vals as well? Index: modules/aaa/mod_authnz_ldap.c

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-23 Thread Ruediger Pluem
On 11/23/23 5:05 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 4:46 PM Yann Ylavic wrote: >> >> On Thu, Nov 23, 2023 at 4:17 PM Ruediger Pluem wrote: >>> >>> On 11/23/23 3:53 PM, Yann Ylavic wrote: >>> I am asking because I guess I am hit now

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-23 Thread Ruediger Pluem
On 11/23/23 3:53 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 12:11 PM Ruediger Pluem wrote: >> >> On 9/11/23 3:50 PM, jfcl...@apache.org wrote: >>> Author: jfclere >>> Date: Mon Sep 11 13:50:21 2023 >>> New Revision: 1912245 >>> >>

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 2:28 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 1:33 PM Ruediger Pluem wrote: >> >> >> >> On 11/23/23 12:52 PM, Graham Leggett via dev wrote: >>> On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: >>> >>>>> -if (

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 12:52 PM, Graham Leggett via dev wrote: > On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: > >>> -    if (req->dn == NULL || !*req->dn) { >>> -    ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02636) >>> -  &q

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 11:22 AM, minf...@apache.org wrote: > Author: minfrin > Date: Thu Nov 23 10:22:58 2023 > New Revision: 1914067 > > URL: http://svn.apache.org/viewvc?rev=1914067&view=rev > Log: > Optimise handling LDAP authorization where LDAP was not used > previously for LDAP authentication. > >

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-23 Thread Ruediger Pluem
On 9/11/23 3:50 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Mon Sep 11 13:50:21 2023 > New Revision: 1912245 > > URL: http://svn.apache.org/viewvc?rev=1912245&view=rev > Log: > Arrange the bybusyness logic and prevent bad busy values > this closes #383 > > Modified: > httpd/htt

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 4:19 PM, Graham Leggett via dev wrote: > On 20 Nov 2023, at 15:10, Ruediger Pluem wrote: > >> Revisiting this again. I guess the below patch should fix it. >> I assume that only the checking on req != NULL is relevant. >> r->user and req->dn do not

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 4:05 PM, Yann Ylavic wrote: > On Mon, Nov 20, 2023 at 3:46 PM Yann Ylavic wrote: >> >> On Mon, Nov 20, 2023 at 2:33 PM Yann Ylavic wrote: >>> >>> On Mon, Nov 20, 2023 at 1:57 PM Graham Leggett via dev >>> wrote: >>>>

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 3:46 PM, Yann Ylavic wrote: > On Mon, Nov 20, 2023 at 2:33 PM Yann Ylavic wrote: >> >> On Mon, Nov 20, 2023 at 1:57 PM Graham Leggett via dev >> wrote: >>> >>> On 20 Nov 2023, at 12:26, Ruediger Pluem wrote: >>> >>> Or we

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 1:07 PM, yla...@apache.org wrote: > Author: ylavic > Date: Mon Nov 20 12:07:11 2023 > New Revision: 1913977 > > URL: http://svn.apache.org/viewvc?rev=1913977&view=rev > Log: > mod_authnz_ldap: Follow up to r1913962: r->user not used in > ldapsearch_check_authorization(). > > > Mo

Re: svn commit: r1913962 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/19/23 11:45 AM, minf...@apache.org wrote: > Author: minfrin > Date: Sun Nov 19 10:45:05 2023 > New Revision: 1913962 > > URL: http://svn.apache.org/viewvc?rev=1913962&view=rev > Log: > Apply earlier fix to the ldapsearch case: > > Arrange for backend LDAP connections to be returned > to

Re: svn commit: r1912459 - in /httpd/httpd/trunk: include/ modules/proxy/

2023-11-02 Thread Ruediger Pluem
On 11/2/23 1:47 PM, Yann Ylavic wrote: > On Sat, Sep 30, 2023 at 7:19 PM Ruediger Pluem wrote: >> >> On 9/21/23 3:15 PM, yla...@apache.org wrote: >> >>> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original) >>> +++ httpd/httpd/trunk/modules/prox

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x:./modules/http2/h2.h

2023-10-16 Thread Ruediger Pluem
If you revert r1913027, r1913024, r1913006, hence --- modules/http2/h2.h (revision 1913024) +++ modules/http2/h2.h (revision 1913006) @@ -20,8 +20,6 @@ #include #include -#include - struct h2_session; struct h2_stream; @@ -41,9 +39,7 @@ #define H2_USE_POLLFD_FROM_CONN 0 #endif +#if H

  1   2   3   4   5   6   7   8   9   10   >