Re: svn commit: r1733537 - /httpd/httpd/trunk/support/ab.c

2016-05-27 Thread Yann Ylavic
On Tue, May 24, 2016 at 9:01 PM, William A Rowe Jr wrote: >> >> +/* >> + * Similar to standard strstr() but we ignore case in this version. >> + * Copied from ap_strcasestr(). >> + */ >> +static char *xstrcasestr(const char *s1, const char *s2) >> +{ [] >> +} > > Two

Re: svn commit: r1745582 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-27 Thread Yann Ylavic
On Thu, May 26, 2016 at 3:37 PM, William A Rowe Jr wrote: > On Thu, May 26, 2016 at 8:24 AM, William A Rowe Jr > wrote: >> >> >>> Excellent, but one big issue, namespace collision. >>> >>> [...] >> >> would be the proper doxygen, to dissuade users from

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Yann Ylavic
Ok, I'll start from there, thanks. On Fri, Jan 8, 2016 at 4:50 PM, Jim Jagielski <j...@jagunet.com> wrote: > I went ahead and committed what was there and ran tests > to make sure it runs clean before doing so. > >> On Jan 8, 2016, at 10:48 AM, Yann Ylavic <yla

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 5:30 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Fri, Jan 8, 2016 at 3:17 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: >> >> Agreed it is configuration, but cant we simply tweak our recommended >> conf/magic >> file??? >

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 3:34 PM, Paul Spangler wrote: > On 1/8/2016 6:49 AM, Jim Jagielski wrote: >> >> Just noticed that the test framework reports issues w/ sessions on trunk: >> >> t/modules/session.t . 1/105 # Failed test 8 in >> t/modules/session.t at

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 1:43 PM, Jim Jagielski wrote: > -0.9... > > This seems a very heavy solution to a specific one-off problem. Not sure this is the patch which is heavy here... Anytime mod_mime_magic recognizes the type of a gzip file (by the magic bytes), it

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 3:17 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Fri, Jan 8, 2016 at 3:27 AM, Yann Ylavic <ylavic@gmail.com> wrote: >> >> >> On Fri, Jan 8, 2016 at 8:49 AM, Jan Kaluža <jkal...@redhat.com> wrote: >> > >> &

Re: [Bug 55808] File integrity verification using MD5 and SHA1

2016-01-14 Thread Yann Ylavic
[cross posting @docs => @dev, full thread http://www.gossamer-threads.com/lists/apache/docs/453401] On Thu, Jan 14, 2016 at 1:50 AM, Tom Fredrik Blenning Klaussen <b...@blenning.no> wrote: > > On 14/01/16 01:19, Yann Ylavic wrote: >> >> as I said earlier, the wa

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 3:17 PM, Jim Jagielski wrote: > Doesn't this depend on: > > trunk patch: http://svn.apache.org/r1656259 > http://svn.apache.org/r1656359 (CHANGES entry) > > which, in STATUS, is tagged as still being worked? I don't think so,

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Tue, Jun 28, 2016 at 12:11 AM, Yann Ylavic <ylavic@gmail.com> wrote: > On Mon, Jun 27, 2016 at 11:26 PM, Yann Ylavic <ylavic@gmail.com> wrote: >> On Mon, Jun 27, 2016 at 10:48 AM, Stefan Eissing >> <stefan.eiss...@greenbytes.de> wrote: >>> >&

Re: MinSpareThreads lower bound calculation and docs

2016-06-25 Thread Yann Ylavic
On Sat, Jun 18, 2016 at 11:53 AM, Luca Toscano wrote: > Hi Apache devs! > > I have a question for you about the following users@ email thread: > > - >

Re: Hung 2.2.x STATUS entries...

2016-06-25 Thread Yann Ylavic
On Fri, Jun 17, 2016 at 8:53 PM, Ruediger Pluem wrote: > > > On 06/17/2016 05:55 PM, William A Rowe Jr wrote: >> A couple of branches/2.2.x STATUS questions are outstanding... >> >> *) mod_mem_cache: Don't cache incomplete responses when the client aborts >> the connection.

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 6:00 PM, Yann Ylavic <ylavic@gmail.com> wrote: > > PR 57832 does not depend on this (race) condition, hence this change > (r1750301, or actually its successor since I'll revert it for a less > intrusive version) could be applied to 2.4.x without r16

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-28 Thread Yann Ylavic
On Tue, Jun 28, 2016 at 12:23 AM, Yann Ylavic <ylavic@gmail.com> wrote: >> >> The possible issue if r1750414 were backported, is that without >> r1750392 mod_proxy_http2 may not detect a TLS close notify before >> reusing a backend connection. >>

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-28 Thread Yann Ylavic
I can, but is mod_proxy_h2 CTR (Commit Then Review) like mod_h2 ? On Tue, Jun 28, 2016 at 12:15 PM, Stefan Eissing <stefan.eiss...@greenbytes.de> wrote: > Looks good to me. Can you commit this, then I quickly run my tests with it... > >> Am 28.06.2016 um 09:50 schrieb Y

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-28 Thread Yann Ylavic
? > >> Am 28.06.2016 um 13:42 schrieb Yann Ylavic <ylavic@gmail.com>: >> >> I don't think trunk needs it because ap_proxy_connect_backend() is >> already doing this work (via ap_proxy_check_backend). >> >> That's why I proposed a 2.4.x only patch, but

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-28 Thread Yann Ylavic
Patch as a file attached. On Tue, Jun 28, 2016 at 1:48 PM, Yann Ylavic <ylavic@gmail.com> wrote: > Maybe if you can test current 2.4.x with this patch and it works as > expected it could be backported... > > On Tue, Jun 28, 2016 at 1:46 PM, Yann Ylavic <ylavic@gmail

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-28 Thread Yann Ylavic
Maybe if you can test current 2.4.x with this patch and it works as expected it could be backported... On Tue, Jun 28, 2016 at 1:46 PM, Yann Ylavic <ylavic@gmail.com> wrote: > Dunno, the issue is that reused TLS connections where data are > immediately available from the

Re: svn commit: r1750392 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_fcgi.c modu

2016-06-28 Thread Yann Ylavic
On Tue, Jun 28, 2016 at 1:52 PM, Jim Jagielski <j...@jagunet.com> wrote: > >> On Jun 27, 2016, at 4:25 PM, Yann Ylavic <ylavic@gmail.com> wrote: >> >> On Mon, Jun 27, 2016 at 9:05 PM, Jim Jagielski <j...@jagunet.com> wrote: >>> >>&

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-28 Thread Yann Ylavic
<stefan.eiss...@greenbytes.de> wrote: > We are talking about adding this to trunk first, right? ^^ > >> Am 28.06.2016 um 12:34 schrieb Stefan Eissing <stefan.eiss...@greenbytes.de>: >> >> I believe so. Highly experimental and all such... >> >>>

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 10:48 AM, Stefan Eissing <stefan.eiss...@greenbytes.de> wrote: > >> Am 27.06.2016 um 10:41 schrieb Yann Ylavic <ylavic@gmail.com>: >> >> On Mon, Jun 27, 2016 at 10:23 AM, Stefan Eissing <ste...@eissing.org> wrote: >>> Th

Re: svn commit: r1750392 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_fcgi.c modu

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 10:25 PM, Yann Ylavic <ylavic@gmail.com> wrote: > I thought we could later follow up on this change and optimize these > by using the new tmp_bb field (cleanup is faster than > create/destroy)... Something like the attached patch. Index: modules/proxy/m

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 11:26 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Mon, Jun 27, 2016 at 10:48 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >>> Am 27.06.2016 um 10:41 schrieb Yann Ylavic <ylavic@gmail.com>: >>> >

Re: Mergine of Multiple Cookie Headers

2016-06-29 Thread Yann Ylavic
On Wed, Jun 29, 2016 at 9:33 AM, Plüm, Rüdiger, Vodafone Group wrote: > > >> -Original Message- >> From: Rainer Canavan [mailto:rainer.cana...@sevenval.com] >> Sent: Dienstag, 28. Juni 2016 16:30 >> To: dev@httpd.apache.org >> Subject: Mergine of Multiple

Re: svn commit: r1729507 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy.h proxy/mod_proxy_ajp.c proxy/mod_proxy_http.c proxy/mod_proxy_wstunnel.c

2016-02-10 Thread Yann Ylavic
On Wed, Feb 10, 2016 at 9:19 PM, Ruediger Pluem wrote: > > On 02/10/2016 09:15 PM, Jim Jagielski wrote: >> It looks like the whole retry was removed :( > > If you look at the old code before r1729507 there wasn't any retry in the > mod_proxy_wstunnel case. > The loop had just

Re: HTTPS connections lock-up with 2.4.18

2016-02-04 Thread Yann Ylavic
On Thu, Feb 4, 2016 at 11:53 PM, Joachim Achtzehnter <joac...@kraut.ca> wrote: > On 2016-02-04 0:54, Yann Ylavic wrote: > >> On Thu, Feb 4, 2016 at 9:41 AM, Yann Ylavic <ylavic@gmail.com> wrote: >>> >>> Doesn't the socket_bucket_read() call (frame

Re: collaboration request - apache server automation testing with swat tool

2016-02-06 Thread Yann Ylavic
Hi Alexey, On Sat, Feb 6, 2016 at 5:03 PM, Alexey Melezhik wrote: > Sure, then it's probably won't be big deal to port existed test code base. > > Here I want to highlight some swat features which make it more then > just engine to make http requests and verify an output.

Re: svn commit: r1726233 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c

2016-02-09 Thread Yann Ylavic
On Fri, Jan 22, 2016 at 4:30 PM, wrote: > Author: covener > Date: Fri Jan 22 15:30:19 2016 > New Revision: 1726233 > > URL: http://svn.apache.org/viewvc?rev=1726233=rev > Log: > from feedback, assume all parameters to SetHandler are expressions. > > Modified: >

Re: mod_proxy_http2

2016-02-09 Thread Yann Ylavic
On Mon, Feb 8, 2016 at 6:07 PM, Stefan Eissing wrote: > > One thing: the ssl_hostname that is used for SNI by the generic proxy utils > seems to get lost when the socket needs to reset and is then not available on > the next connect. That should affect

Re: mod_proxy_http2

2016-02-09 Thread Yann Ylavic
On Mon, Feb 8, 2016 at 6:07 PM, Stefan Eissing wrote: > FYI: I just checked in a very experimental mod_proxy_http2 that registers on > h2:// and h2c:// proxy URLs. I did this naming to have the module totally > separate from mod_proxy_http, not wanting to make a

Negative mod_proxy ping_timeout..

2016-02-09 Thread Yann Ylavic
.. is meant to do a simple TCP readability check on the connection, using ap_proxy_is_socket_connected(). This is trunk only AFAICT. However all our proxy modules handle this just after calling ap_proxy_connect_backend() which already calls ap_proxy_is_socket_connected() for the same purpose.

Re: Negative mod_proxy ping_timeout..

2016-02-09 Thread Yann Ylavic
On Tue, Feb 9, 2016 at 5:42 PM, Jim Jagielski wrote: > Why the change to modules/proxy/mod_proxy_hcheck.c? The call to ap_proxy_connect_backend() just above already calls ap_proxy_is_socket_connected() for any reused connection, so why check it twice? If the connection is not

Re: HTTPS connections lock-up with 2.4.18 [SOLVED]

2016-02-05 Thread Yann Ylavic
On Fri, Feb 5, 2016 at 5:42 AM, Joachim Achtzehnter wrote: > >> Are you sure the earlier sononblock() call succeeded (ie. my patch on >> socket_bucket_read() does not help)? > > It did not get called. The reason was that it assumed the socket was already > in non-blocking mode.

Re: svn commit: r1729929 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h include/httpd.h server/core.c

2016-02-12 Thread Yann Ylavic
On Fri, Feb 12, 2016 at 2:04 AM, wrote: > Author: wrowe > Date: Fri Feb 12 01:04:58 2016 > New Revision: 1729929 > [] > Modified: httpd/httpd/trunk/include/httpd.h > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/include/httpd.h?rev=1729929=1729928=1729929=diff >

Re: svn commit: r1729826 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2016-02-11 Thread Yann Ylavic
On Thu, Feb 11, 2016 at 3:14 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Thu, Feb 11, 2016 at 3:10 PM, Ruediger Pluem <rpl...@apache.org> wrote: >> >> conn->ssl_hostname might be allocated from conn->scpool. >> So the pointer might be invalid

Re: [users@httpd] Block access to "OPTIONS *"

2016-02-12 Thread Yann Ylavic
Following up below users@ discussion on dev@... On Fri, Feb 12, 2016 at 12:47 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Fri, Feb 12, 2016 at 10:47 AM, Daniel <dferra...@gmail.com> wrote: >> The typical way to block OPTIONS in 2.2 does not need mod_rewrite at all

Re: [users@httpd] Block access to "OPTIONS *"

2016-02-12 Thread Yann Ylavic
On Fri, Feb 12, 2016 at 1:28 PM, Jim Jagielski wrote: > Blocking OPTIONS has a long and illustrious history... > I am -0 on doing anything more related to it ;) OK, I see, let's users@ play with the workaround then :)

Re: svn commit: r1729929 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h include/httpd.h server/core.c

2016-02-12 Thread Yann Ylavic
On Fri, Feb 12, 2016 at 10:49 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Feb 12, 2016 2:24 AM, "Yann Ylavic" <ylavic@gmail.com> wrote: >> >> I see this TODO about bitfield, but never seen it done in your >> commits, so I wonder where Rai

Re: [users@httpd] Block access to "OPTIONS *"

2016-02-12 Thread Yann Ylavic
On Fri, Feb 12, 2016 at 1:29 PM, Daniel Gruno wrote: > On 02/12/2016 01:28 PM, Jim Jagielski wrote: >> Blocking OPTIONS has a long and illustrious history... >> I am -0 on doing anything more related to it ;) >> > > Isn't that why we have the optional mod_allowmethods these

Re: Thoughts on using HW for httpd?

2016-02-12 Thread Yann Ylavic
+1! On Fri, Feb 12, 2016 at 1:27 PM, Jim Jagielski wrote: > /me like > >> On Feb 12, 2016, at 7:20 AM, Daniel Gruno wrote: >> >> Hi folks, >> as some may know, ComDev is trialling a new thing called 'Help Wanted!' >> at https://helpwanted.apache.org/ >>

Re: FYI: Backport of mod_proxy_hcheck

2016-02-12 Thread Yann Ylavic
On Fri, Feb 12, 2016 at 2:50 PM, Jim Jagielski wrote: > The patchfile, minus docs, can be found at: > > http://home.apache.org/~jim/patches/hcheck-2.4.patch How about the changes to struct proxy_worker_shared w.r.t. backportability?

Re: svn commit: r1729826 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2016-02-11 Thread Yann Ylavic
On Thu, Feb 11, 2016 at 3:10 PM, Ruediger Pluem wrote: > > conn->ssl_hostname might be allocated from conn->scpool. > So the pointer might be invalid after socket_cleanup(conn). So you need to > apr_pstrdup it first. > No real good idea which pool to use here. Oh, correct! >

Re: svn commit: r1729826 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2016-02-11 Thread Yann Ylavic
On Thu, Feb 11, 2016 at 3:12 PM, Stefan Eissing wrote: > >> Am 11.02.2016 um 15:10 schrieb Ruediger Pluem : >> >> >> conn->ssl_hostname might be allocated from conn->scpool. >> So the pointer might be invalid after socket_cleanup(conn). So you need

Re: mod_proxy_http2

2016-02-11 Thread Yann Ylavic
On Tue, Feb 9, 2016 at 3:42 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Mon, Feb 8, 2016 at 6:07 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >> One thing: the ssl_hostname that is used for SNI by the generic proxy utils >> seems to get

Re: svn commit: r1728656 - in /httpd/httpd/trunk: build/make_nw_export.awk modules/proxy/mod_proxy.h

2016-02-05 Thread Yann Ylavic
On Fri, Feb 5, 2016 at 1:31 PM, wrote: > Author: rjung > Date: Fri Feb 5 12:31:33 2016 > New Revision: 1728656 > [] > > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.h > URL: >

Re: rotatelogs and SIGTERM?

2016-02-12 Thread Yann Ylavic
ove...@gmail.com> wrote: > I lost a sentence somewhere. On one platform I use, the default for > SIGTERM writes a message to stderr. > > On Fri, Feb 12, 2016 at 4:37 PM, Yann Ylavic <ylavic@gmail.com> wrote: >> On Fri, Feb 12, 2016 at 8:25 PM, Eric Covener <cov

Re: rotatelogs and SIGTERM?

2016-02-12 Thread Yann Ylavic
On Fri, Feb 12, 2016 at 8:25 PM, Eric Covener wrote: > Recall that 2.2 ran piped loggers under a shell until somewhat late in > life, and 2.4 runs them directly [by default]. > > rotatelogs currently doesn't do anything to block sigterm. The > default ahndler for sigterm

Re: svn commit: r1726787 - /httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c

2016-01-27 Thread Yann Ylavic
On Tue, Jan 26, 2016 at 1:57 PM, wrote: > Author: rpluem > Date: Tue Jan 26 12:57:18 2016 > New Revision: 1726787 > > URL: http://svn.apache.org/viewvc?rev=1726787=rev > Log: > * Transform the buckets to the correct lifetime of the brigade, connection > and filter stack that

Re: [Bug 55808] File integrity verification using MD5 and SHA1

2016-02-02 Thread Yann Ylavic
Thanks, I'll read this! On Tue, Feb 2, 2016 at 6:58 PM, Luca Toscano <toscano.l...@gmail.com> wrote: > Hi Yann, > > 2016-02-02 18:41 GMT+01:00 Yann Ylavic <ylavic@gmail.com>: >> >> >> How do you do the "publish" part? >> > > I use t

Re: HTTPS connections lock-up with 2.4.18

2016-02-01 Thread Yann Ylavic
On Mon, Feb 1, 2016 at 3:41 AM, Joachim Achtzehnter wrote: > After upgrading from 2.4.12 to 2.4.18 we find that some requests for files > cause a lock-up when HTTPS is used, but not with plain HTTP. After some > debugging it seems the problem is that the mod_ssl no longer

Re: HTTPS connections lock-up with 2.4.18

2016-02-01 Thread Yann Ylavic
A little precision: On Mon, Feb 1, 2016 at 1:19 PM, Yann Ylavic <ylavic@gmail.com> wrote: > > Could you provide some network capture (tcpdump, wireshark...) when > the lock-up occurs? I mean a pcap format here, the goal is correlating with the SSL handshake (or renegotiatio

Re: HTTPS connections lock-up with 2.4.18

2016-02-01 Thread Yann Ylavic
On Mon, Feb 1, 2016 at 10:10 AM, Joachim Achtzehnter wrote: > The problem was first discovered with Apache 2.4.18 compiled against > OpenSSL/1.0.1m. The running system, which is an i686 Linux system, used the > same versions. > > We then installed our old mod_ssl.so from Apache

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 11:38 AM, Stefan Eissing wrote: > Interesting. I have an issue on github from someone who observes, sometimes, > a hanging > HTTP/2 connection, where mod_http2 calls ap_pass_brigade() with ~120KB which > never > returns. Client, after a

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 6:31 AM, Joachim Achtzehnter wrote: > > Attached is file "ssl_log-v3.txt" with the log messages seen when using your > v3 patch. The other two files are the corresponding Wireshark traces, > collected on the client-side where Firefox was trying to retrieve

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 10:14 AM, Joachim Achtzehnter <joac...@kraut.ca> wrote: > Late at night here and I'm not at work, but see the embedded responses to > clarify some things... > > On 2016-02-03 12:43 AM, Yann Ylavic wrote: >> >> I can't tell about the underlying

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 11:29 AM, Plüm, Rüdiger, Vodafone Group wrote: > Which MPM is used? Event or something different? > There a differences on how c->data_in_input_filters is handled by different > MPM's. > On sync MPM's like worker there is an explicit flush if

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 9:43 AM, Yann Ylavic <ylavic@gmail.com> wrote: > > I can't tell about the underlying HTTP data here, but I suspect there > is more than a single HTTP request sent by the client, which makes > httpd believe requests are pipelined, and hence never flush

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 3:01 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Wed, Feb 3, 2016 at 12:34 PM, Yann Ylavic <ylavic@gmail.com> wrote: >> >> So I don't see why the response is not flushed on the network before >> entering READ_REQUEST_LINE or C

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 12:34 PM, Yann Ylavic <ylavic@gmail.com> wrote: > > So I don't see why the response is not flushed on the network before > entering READ_REQUEST_LINE or CHECK_REQUEST_LINE_READABLE states. OK, I can now reproduce with mpm_event. Joachim, looking into t

Re: Worker states for balancer members

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 3:21 PM, Jim Jagielski wrote: > > Sooo > > STOPPED: Never sent proxy traffic. Never health-checked. Never > re-tried. Never automatically re-enabled. > > DISABLED: Never sent proxy traffic. Is health-checked. Retried. > Could be

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 4:01 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Wed, Feb 3, 2016 at 3:01 PM, Yann Ylavic <ylavic@gmail.com> wrote: >> >> Joachim, looking into this from my own environment (no need to apply >> patches yourself now ;

Re: HTTPS connections lock-up with 2.4.18

2016-02-04 Thread Yann Ylavic
56.652444 2016] [core:notice] [pid 1663] [client >>>> >>>> 205.159.216.185:55962] core_output_filter: sent 1998 on 1998 bytes >>>>> >>>>> [Wed Feb 03 18:09:56.652510 2016] [ssl:info] [pid 1663] (70014)End of >>>> >>>>

Re: HTTPS connections lock-up with 2.4.18

2016-02-04 Thread Yann Ylavic
On Thu, Feb 4, 2016 at 9:41 AM, Yann Ylavic <ylavic@gmail.com> wrote: > Doesn't the socket_bucket_read() call (frame #3) enter > apr_socket_timeout_set(p, 0), and hence sononblock() which puts the > socket in O_NONBLOCK? and resets APR_INCOMPLETE_READ. > > Maybe "s

Re: HTTPS connections lock-up with 2.4.18

2016-02-04 Thread Yann Ylavic
On Thu, Feb 4, 2016 at 9:54 AM, Yann Ylavic <ylavic@gmail.com> wrote: > On Thu, Feb 4, 2016 at 9:41 AM, Yann Ylavic <ylavic@gmail.com> wrote: >> Doesn't the socket_bucket_read() call (frame #3) enter >> apr_socket_timeout_set(p, 0), and hence sononblock

Re: HTTPS connections lock-up with 2.4.18

2016-02-02 Thread Yann Ylavic
On Mon, Feb 1, 2016 at 11:50 PM, Joachim Achtzehnter wrote: > The Wireshark trace confirms what one may have predicted from the > observed symptoms. There is no response from the server to the GET > request on the wire. There are some missing TLS records from the server during

Re: [Bug 55808] File integrity verification using MD5 and SHA1

2016-02-02 Thread Yann Ylavic
On Wed, Jan 20, 2016 at 11:24 PM, Yann Ylavic <ylavic@gmail.com> wrote: > > Would attached patch be appropriate, so that MD5/SHA1/ASC/KEYS files > are under https://*.apache.org's certification? Assuming lazy consensus, committed in r1728066. Thanks Tom Fredrik. Regards, Yann.

Re: [Bug 55808] File integrity verification using MD5 and SHA1

2016-02-02 Thread Yann Ylavic
Hi Luca, On Tue, Feb 2, 2016 at 6:27 PM, Luca Toscano wrote: > > sorry for the lack of response but I didn't notice the patch. No problem. > I checked the > links in staging and published the patch to > https://httpd.apache.org/download.cgi (hope that it is ok for you).

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 11:53 AM, Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com> wrote: > >> -Original Message- >> From: Yann Ylavic [mailto:ylavic@gmail.com] >> Sent: Mittwoch, 3. Februar 2016 11:41 >> To: httpd-dev >> Subject: Re

Re: Worker states for balancer members

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 1:25 PM, Jim Jagielski wrote: > > I WAS thinking about basically "making" HC_FAIL STOPPED because > that mode can only be set/cleared during configuration (the > balancer-manager doesn't provide for changing that bit) and so > for the life of me I can't

Re: HTTPS connections lock-up with 2.4.18

2016-02-03 Thread Yann Ylavic
On Wed, Feb 3, 2016 at 4:53 PM, Yann Ylavic <ylavic@gmail.com> wrote: > > I suggest you use the attached patch instead (replacing any previous > one), so that we log the output path taken when mod_ssl is in the > place. Forgot about the casting issue (SSL_get_app_data)

Re: svn commit: r1726787 - /httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c

2016-02-01 Thread Yann Ylavic
On Mon, Feb 1, 2016 at 3:32 PM, Ruediger Pluem wrote: >> >> I am fine with flushing at the end of the loop. If no one opposes I can do >> this. >> > > Looking into this in more detail the following thoughts came up: > > What do we think how much iterations do we do in this

Re: Bug 57227 - Patch still not in main stream

2016-02-29 Thread Yann Ylavic
Hi, On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult wrote: > > I did find a bug in mod_autoindex more than one year ago, about missing CSS > class, and proposed a patch at same time > (https://bz.apache.org/bugzilla/show_bug.cgi?id=57227). > It appears that this patch is still

Re: Bug 57227 - Patch still not in main stream

2016-02-29 Thread Yann Ylavic
On Mon, Feb 29, 2016 at 5:01 PM, Jim Jagielski <j...@jagunet.com> wrote: > >> On Feb 29, 2016, at 7:43 AM, Yann Ylavic <ylavic@gmail.com> wrote: >> >> Hi, >> >> On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult <brao...@gmail.com> wrote: >>&

Re: Bug 57227 - Patch still not in main stream

2016-02-29 Thread Yann Ylavic
[CCing the original bugs@ list and dev@ which I somehow added from my first response. Not sure bugs@ is to be addressed directly though, it is normally CCed for bugzilla reports only...] On Mon, Feb 29, 2016 at 2:52 PM, Bruno Raoult wrote: > >> On Mon, Feb 29, 2016 at 1:31 PM,

Re: Thinking about a T of 2.4.19 soonish

2016-02-29 Thread Yann Ylavic
On Mon, Feb 29, 2016 at 3:22 PM, Jim Jagielski wrote: > Is this 2.4 specific... Looking in trunk for > https://bz.apache.org/bugzilla/attachment.cgi?id=33611 This patch is proposed on bz only for now, waiting for the OP to test... > >> On Feb 29, 2016, at 8:19 AM, Lenk, Micha

Re: Bug 57227 - Patch still not in main stream

2016-02-29 Thread Yann Ylavic
On Mon, Feb 29, 2016 at 3:55 PM, Yann Ylavic <ylavic@gmail.com> wrote: > > On Mon, Feb 29, 2016 at 2:52 PM, Bruno Raoult <brao...@gmail.com> wrote: >> >> In order to find out by myself next time, how did you jump from r1648201 >> (which I >> f

Re: svn commit: r1725551 - /httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci

2016-01-21 Thread Yann Ylavic
On Thu, Jan 21, 2016 at 5:36 AM, Rainer Jung <rainer.j...@kippdata.de> wrote: > Am 21.01.2016 um 01:33 schrieb Yann Ylavic: >> >> "^ssl_log_(|r|c)xerror$" => "^ssl_log_(r|c)?xerror$"? >> Or is it some special coccinelle regex syntax? > &g

Re: socket timeouts

2016-01-21 Thread Yann Ylavic
On Thu, Jan 21, 2016 at 11:52 AM, Stefan Eissing wrote: > However seems to do it. Anyone for/against applying it? Looks good to me, APR_TIMEUP is recoverable after all (other httpd callsites would fail as usual). This will raise an INFO log line per timeup though

Re: svn commit: r1725949 - /httpd/httpd/trunk/docs/manual/expr.xml

2016-01-21 Thread Yann Ylavic
e simply > copy the buckets from the response from the backend that comprises the > body to r->kept_body. That way, ap_expr can now apply expressions > against it to check if the backend is healthy or not. > > It's totally self-contained. > > >> On Jan 21, 2016, at 10:29

Re: svn commit: r1725949 - /httpd/httpd/trunk/docs/manual/expr.xml

2016-01-21 Thread Yann Ylavic
Is r->kept_body ever initiallized on the backend side, wouldn't mod_proxy need to somehow add mod_request's filters? On Thu, Jan 21, 2016 at 4:25 PM, Jim Jagielski wrote: > Sounds good to me!! > > thx! > >> On Jan 21, 2016, at 10:23 AM, Rainer Jung

Re: Bus error for proxy_hcheck on Solaris

2016-01-21 Thread Yann Ylavic
On Thu, Jan 21, 2016 at 9:53 PM, Rainer Jung wrote: > > Am 21.01.2016 um 21:28 schrieb Jim Jagielski: >> >> Based on your stack, then that was the section you hit. But I >> have no idea how you hit it. The test is: >> >> if (hc->s->method != worker->s->method) > > >

Re: socket timeouts

2016-01-20 Thread Yann Ylavic
On Tue, Jan 19, 2016 at 4:52 PM, Stefan Eissing wrote: > > I experimented with setting socket timeouts to 1 second during > HTTP/2's keepalive reading and closing the connection after n such > TIMEUP returns. That works nicely on cleartext connections, but > https://

Re: svn commit: r1725551 - /httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci

2016-01-20 Thread Yann Ylavic
On Tue, Jan 19, 2016 at 4:45 PM, wrote: > Author: rjung > Date: Tue Jan 19 15:45:44 2016 > New Revision: 1725551 > > URL: http://svn.apache.org/viewvc?rev=1725551=rev > Log: > Improve spatch for APLOGNO a bit. > > Modified: >

Re: [Bug 55808] File integrity verification using MD5 and SHA1

2016-01-20 Thread Yann Ylavic
On Thu, Jan 14, 2016 at 9:25 AM, Yann Ylavic <ylavic@gmail.com> wrote: > [cross posting @docs => @dev, full thread > http://www.gossamer-threads.com/lists/apache/docs/453401] > > On Thu, Jan 14, 2016 at 1:50 AM, Tom Fredrik Blenning Klaussen > <b...@blenning.no>

Re: ap_expr

2016-01-20 Thread Yann Ylavic
On Wed, Jan 20, 2016 at 5:36 PM, Jim Jagielski wrote: > Ugg... it seems that updating ap_expr results in bison stepping > in and redoing stuff... Thing is, I have Bison 3.0.4 and the old > files seems to have been based on 2.7: Last time I changed util_expr_parse.y, I had to

Re: svn commit: r1725551 - /httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci

2016-01-20 Thread Yann Ylavic
On Thu, Jan 21, 2016 at 12:35 AM, Rainer Jung <rainer.j...@kippdata.de> wrote: > Am 21.01.2016 um 00:17 schrieb Yann Ylavic: >> >> On Tue, Jan 19, 2016 at 4:45 PM, <rj...@apache.org> wrote: >>> >>> Author: rjung >>> Date: Tue Jan 19 15:

Re: svn commit: r1726787 - /httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c

2016-01-27 Thread Yann Ylavic
On Wed, Jan 27, 2016 at 10:02 AM, Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com> wrote: > >> -Original Message- >> From: Yann Ylavic [mailto:ylavic@gmail.com] >> Sent: Mittwoch, 27. Januar 2016 09:15 >> To: httpd-dev >> Subject: Re:

Re: Work in progress: mod_proxy Health Check module

2016-01-22 Thread Yann Ylavic
On Fri, Jan 22, 2016 at 6:29 PM, Jim Jagielski wrote: > At this point GET is now implemented as well as checking > the response via ap_expr... Thanks Jim, this is great!

Re: HTTPS connections lock-up with 2.4.18

2016-02-02 Thread Yann Ylavic
Back to the list... (Attaching the logs provided privately by Joachim, with the client IP - the only possible sensitive informatition - replaced with XXX.XXX.XXX.XXX). On Tue, Feb 2, 2016 at 11:08 AM, Joachim Achtzehnter wrote: > > Applied you patch, built, installed, and then

Re: HTTPS connections lock-up with 2.4.18

2016-02-02 Thread Yann Ylavic
On Tue, Feb 2, 2016 at 1:46 PM, Yann Ylavic <ylavic@gmail.com> wrote: > Back to the list... > (Attaching the logs provided privately by Joachim, with the client IP > - the only possible sensitive informatition - replaced with > XXX.XXX.XXX.XXX). Oups, here there are.

Re: svn commit: r1729847 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2016-02-29 Thread Yann Ylavic
On Thu, Feb 11, 2016 at 4:42 PM, Ruediger Pluem wrote: > > In general this looks fine. We only run in trouble if something provided in > the Host header is longer then > PROXY_WORKER_MAX_HOSTNAME_SIZE (in case of ProxyPreserveHost on). Then we > loose the SNI hostname on

Re: conn_rec needs a context

2016-03-01 Thread Yann Ylavic
On Wed, Mar 2, 2016 at 1:23 AM, Yann Ylavic <ylavic@gmail.com> wrote: > Hi, > > On Wed, Mar 2, 2016 at 1:09 AM, Graham Leggett <minf...@sharp.fm> wrote: >> >> Would it make sense to add a vector of contexts that same way we have a >> vector of c

Re: conn_rec needs a context

2016-03-01 Thread Yann Ylavic
Hi, On Wed, Mar 2, 2016 at 1:09 AM, Graham Leggett wrote: > > Would it make sense to add a vector of contexts that same way we have a > vector of configs, one slot for each module, which will allow any module to > add a context of it’s own to conn_rec without having to extend

Re: svn commit: r1727603 - in /httpd/httpd/trunk: CHANGES server/mpm/event/event.c

2016-03-01 Thread Yann Ylavic
On Wed, Mar 2, 2016 at 12:59 AM, Yann Ylavic <ylavic@gmail.com> wrote: > On Fri, Jan 29, 2016 at 4:51 PM, <ic...@apache.org> wrote: >> >> +static void setup_slave_conn(conn_rec *c, void *csd) >> +{ >> +event_conn_state_t *mcs; >>

Re: svn commit: r1727603 - in /httpd/httpd/trunk: CHANGES server/mpm/event/event.c

2016-03-01 Thread Yann Ylavic
On Fri, Jan 29, 2016 at 4:51 PM, wrote: > Author: icing > Date: Fri Jan 29 15:51:25 2016 > New Revision: 1727603 > > URL: http://svn.apache.org/viewvc?rev=1727603=rev > Log: > event: slave connection init, vhost early config > > Modified: >

Re: [VOTE] access control for dynamic hosts

2016-03-09 Thread Yann Ylavic
Hi Fabien, On Wed, Mar 9, 2016 at 5:44 PM, <fab...@apache.org> wrote: > > Currently 2 votes: > > +1: Mario Brandt, Yann Ylavic I think you can go ahead, trunk is in CTR (Commit Then Review) mode. You may have more feedbacks when done... Regards, Yann.

Re: mod_proxy_http2 questions (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-10 Thread Yann Ylavic
On Thu, Mar 10, 2016 at 5:38 PM, Stefan Eissing wrote: > > Iterative, the Common Case > -- [] > > As to the input/output handling for that request_rec, that is basic mod_http2 > stuff. The core filters have been replaced with ones that shuffle

mod_proxy_http2 questions (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-10 Thread Yann Ylavic
Hi Stefan, sorry I didn't look closely enough in mod_proxy_http2's code yet to answer the following questions by myself, so I'm asking here... On Wed, Mar 9, 2016 at 1:53 PM, Stefan Eissing wrote: > > When called inside a HTTP/1.1 connection, it will open/reuse >

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

2016-03-15 Thread Yann Ylavic
On Tue, Mar 15, 2016 at 8:28 PM, Graham Leggett wrote: > > The trouble with the above is that because of the pool cleanup we now have, > pfds[3] needs to live as long as pool p. In your example it does, but there > is nothing stopping someone trying to allocate pfds[3] on the

Re: svn commit: r1734396 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/ssl/mod_ssl.c

2016-03-18 Thread Yann Ylavic
On Fri, Mar 18, 2016 at 5:06 PM, Jeff Trawick wrote: > On Thu, Mar 10, 2016 at 7:31 AM, wrote: >> >> Author: ylavic >> Date: Thu Mar 10 12:31:13 2016 >> New Revision: 1734396 >> >> URL: http://svn.apache.org/viewvc?rev=1734396=rev >> Log: >> Merge r1734006

<    6   7   8   9   10   11   12   13   14   15   >