Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-22 Thread Nick Kew
On Mon, 19 Jul 2004, Joe Orton wrote: Nothing like that was posted to the list, at least. Patch below is still sufficient to fix the proxy+304 case; does it work for you too? Yes, mostly (it fixes the important bug that was previously a showstopper). And it's an improvement on my hack by

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-22 Thread Nick Kew
On Thu, 22 Jul 2004, Nick Kew wrote: On Mon, 19 Jul 2004, Joe Orton wrote: Nothing like that was posted to the list, at least. Patch below is still sufficient to fix the proxy+304 case; does it work for you too? Yes, mostly (it fixes the important bug that was previously a showstopper).

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-22 Thread Joe Orton
On Thu, Jul 22, 2004 at 12:20:33PM +0100, Nick Kew wrote: On Thu, 22 Jul 2004, Nick Kew wrote: On Mon, 19 Jul 2004, Joe Orton wrote: Nothing like that was posted to the list, at least. Patch below is still sufficient to fix the proxy+304 case; does it work for you too? Yes,

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-19 Thread Joe Orton
On Sat, Jul 17, 2004 at 03:22:35PM -, [EMAIL PROTECTED] wrote: niq 2004/07/17 08:22:35 Modified:modules/filters mod_deflate.c Log: Fix previous patch to deal correctly with multiple empty brigades before we know if there's any content, and not re-process the headers.

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-19 Thread Nick Kew
On Mon, 19 Jul 2004, Joe Orton wrote: On Sat, Jul 17, 2004 at 03:22:35PM -, [EMAIL PROTECTED] wrote: niq 2004/07/17 08:22:35 Modified:modules/filters mod_deflate.c Log: Fix previous patch to deal correctly with multiple empty brigades before we know if there's

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-19 Thread Joe Orton
On Mon, Jul 19, 2004 at 03:47:45PM +0100, Nick Kew wrote: On Mon, 19 Jul 2004, Joe Orton wrote: On Sat, Jul 17, 2004 at 03:22:35PM -, [EMAIL PROTECTED] wrote: niq 2004/07/17 08:22:35 Modified:modules/filters mod_deflate.c Log: Fix previous patch to deal

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-17 Thread Andr Malo
* [EMAIL PROTECTED] wrote: +f-ctx = ctx = (void*)-1; I personally consider defining arbitrary pointer values as bad style, though I'm not sure what the general opinion here is (if any). I'd suggest to use a static pointer, like a global static char foo_sentinel; /* choose a speaking

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2004-07-17 Thread Nick Kew
On Sat, 17 Jul 2004, [ISO-8859-15] André Malo wrote: * [EMAIL PROTECTED] wrote: +f-ctx = ctx = (void*)-1; I personally consider defining arbitrary pointer values as bad style, though I'm not sure what the general opinion here is (if any). I'd suggest to use a static pointer,

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2003-03-11 Thread William A. Rowe, Jr.
At 12:04 PM 3/11/2003, [EMAIL PROTECTED] wrote: ianh2003/03/11 10:04:37 Modified:.Tag: APACHE_2_0_BRANCH CHANGES STATUS docs/manual/mod Tag: APACHE_2_0_BRANCH mod_deflate.xml modules/filters Tag: APACHE_2_0_BRANCH mod_deflate.c Log: Backport

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2003-03-11 Thread Ian Holsman
William A. Rowe, Jr. wrote: At 12:04 PM 3/11/2003, [EMAIL PROTECTED] wrote: ianh2003/03/11 10:04:37 Modified:.Tag: APACHE_2_0_BRANCH CHANGES STATUS docs/manual/mod Tag: APACHE_2_0_BRANCH mod_deflate.xml modules/filters Tag: APACHE_2_0_BRANCH

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2003-03-11 Thread André Malo
* Ian Holsman wrote: [2.0.45] + *) mod_deflate: Extend the DeflateFilterNote directive to + allow accurate logging of the filter's in- and outstream. + [André Malo] ah, although it wasn't voted ... I'd give my late +1 on it. But please keep the changes consistent ;-) nd --

branching -- was (Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c)

2003-03-11 Thread Ian Holsman
ok.. can someone remind me what we are supposed to do in this situation? Although I dislike putting in 'unvoted' changes into the stable release, I hate having 2 seperate sets of code, with bits pieces of each other in them worse. André Malo wrote: * Ian Holsman wrote: [2.0.45] + *)

RE: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2003-01-02 Thread Bill Stoddard
IMHO, there should be an extremely high bar to creating a macro. -- justin I fricking hate macros but there are times they are useful. This isn't one of them IMHO. Bill

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2003-01-01 Thread Justin Erenkrantz
--On Wednesday, January 1, 2003 8:31 PM + [EMAIL PROTECTED] wrote: @@ -239,6 +256,11 @@ apr_bucket_brigade *bb, *proc_bb; } deflate_ctx; +#define LeaveNote(type, value) \ +if (c-note##type##Name) \ +apr_table_setn(r-notes, c-note##type##Name, \ +

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-11-09 Thread Justin Erenkrantz
--On Sunday, November 10, 2002 6:09 AM + [EMAIL PROTECTED] wrote: jerenkrantz2002/11/09 22:09:20 Modified:.CHANGES modules/filters mod_deflate.c Log: Always emit Vary header if mod_deflate is involved in the request. Submitted by: Andr?©Malo [EMAIL

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-11-09 Thread André Malo
* Rasmus Lerdorf wrote: Shouldn't you also Vary on User-Agent when a BrowserMatch no-gzip is present? Yes, but mod_deflate doesn't know anything about BrowserMatch. So one has to configure an explicit Header append Vary User-Agent in that case (no-gzip can be set in various ways, not only

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-11-09 Thread André Malo
* Justin Erenkrantz wrote: André, how do you want your name reflected in the CHANGES file? you may simply drop the eh... accent (?). (Sending a patch would probably be best so I don't screw it up anymore...) hehe, done. nd -- sub the($){+shift} sub answer (){ord q [* It is always

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-11-09 Thread Aaron Bannert
On Sat, Nov 09, 2002 at 10:17:58PM -0800, Justin Erenkrantz wrote: Oh, bah. I'm getting used to a certain SCM that supports UTF-8 (heck, I'm not even sure if that got inputed as UTF-8 either). My bad. Did you edit that file in your SCM? How did you input that anyway? What kind of encoding

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-05-20 Thread William A. Rowe, Jr.
At 08:06 PM 5/19/2002, Cliff wrote: Whoa, wait a minute. That doesn't strike me as the right solution. The encoding should be one-hop only. If it's encoded and we want to maintain that encoding, chances are we'll have to decode it and re-encode it later. Why you ask? Because leaving it

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-05-20 Thread Ian Holsman
Cliff Woolley wrote: On 20 May 2002 [EMAIL PROTECTED] wrote: ianh02/05/19 17:07:33 Modified:modules/filters mod_deflate.c Log: content with Content-Encoding header, content is encoded. But mod_deflate does not check it. It cause to encode content twice. This problem

Content Codings (was: Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c)

2002-05-20 Thread Greg Stein
On Mon, May 20, 2002 at 08:40:03AM -0700, Ian Holsman wrote: Cliff Woolley wrote: On 20 May 2002 [EMAIL PROTECTED] wrote: ianh02/05/19 17:07:33 Modified:modules/filters mod_deflate.c Log: content with Content-Encoding header, content is encoded. But mod_deflate

Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c

2002-05-19 Thread Cliff Woolley
On 20 May 2002 [EMAIL PROTECTED] wrote: ianh02/05/19 17:07:33 Modified:modules/filters mod_deflate.c Log: content with Content-Encoding header, content is encoded. But mod_deflate does not check it. It cause to encode content twice. This problem is reproducable by