On 8/3/2006 7:11 AM, jfcl...@apache.org wrote:
Author: jfclere
Date: Thu Aug 3 05:11:14 2006
New Revision: 428374
URL: http://svn.apache.org/viewvc?rev=428374view=rev
Log:
A presistence to the shared memory slotmem.
Yes, that's from the wayback machine but applies as a roadblock
to shipping
Jim Jagielski wrote:
I thought the whole idea was to abstract out the
scoreboard so that it was easier for people to add
and remove tables from the scoreboard... the so-called
generic scoreboard.
I donated the mod_slotmem code a few weeks ago that was a rather simple way to
do just that.
Hi,
I would like to return the httpd-proxy-scoreboard to its first goal: A
replacement of the scoreboard by normal shared memory.
To reach this the experiments of health_checker should be removed or
changed to a provider of bytraffic/byrequest for mod_proxy_balancer.
Any comments?
Cheers
Jean
Jean-Frederic Clere wrote:
Hi,
I would like to return the httpd-proxy-scoreboard to its first goal: A
replacement of the scoreboard by normal shared memory.
To reach this the experiments of health_checker should be removed or
changed to a provider of bytraffic/byrequest
the drive or motivation to rip out
the proxy stuff without the generic scoreboard effort
in parallel.
On Dec 11, 2006, at 7:57 AM, Jean-Frederic Clere wrote:
Hi,
I would like to return the httpd-proxy-scoreboard to its first goal: A
replacement of the scoreboard by normal shared memory.
To reach
Hi,
I would like to return the httpd-proxy-scoreboard to its first goal: A
replacement of the scoreboard by pieces normal shared memory.
To reach this the experiments of health_checker should be removed or
changed to a provider of bytraffic/byrequest for mod_proxy_balancer and
seen as an example
Brian Akins wrote:
Jean-frederic Clere wrote:
Do you mean the proxy back-end connections?
I am thinking of a more general purpose slotmem not particularly
tied to proxy. Maybe have some wrapper functions that create a
slotmem based on threads x procs and can be access using
[EMAIL PROTECTED] wrote:
Author: jfclere
Date: Fri Aug 4 04:44:01 2006
New Revision: 428700
URL: http://svn.apache.org/viewvc?rev=428700view=rev
Log:
Remove shared memory before creating it. (That only removes the file!).
Modified:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem
On 08/03/2006 06:01 PM, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Thu Aug 3 09:01:50 2006
New Revision: 428437
URL: http://svn.apache.org/viewvc?rev=428437view=rev
Log:
Use only one slotmem for status and checker.
Modified:
httpd/httpd/branches/httpd-proxy-scoreboard
-scoreboard/modules/proxy/mod_proxy_health_checker.c
Modified:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c?rev=428437r1=428436r2
-scoreboard/modules/proxy/mod_proxy_health_checker.c
Modified:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c?rev=428437r1=428436r2
Hi,
I am trying to get the slotmem persistent (because for the moment it
didn't persist even a graceful restart).
So I have a question:
- Is there a way to have a pool in a module that will only be cleaned up
when httpd stops?
Anyway I would like to have an option to have the slotmem
Jean-frederic Clere wrote:
Hi,
I am trying to get the slotmem persistent (because for the moment it
didn't persist even a graceful restart).
So I have a question:
- Is there a way to have a pool in a module that will only be cleaned up
when httpd stops?
I suppose you should do that like
Mladen Turk wrote:
Jean-frederic Clere wrote:
Hi,
I am trying to get the slotmem persistent (because for the moment it
didn't persist even a graceful restart).
So I have a question:
- Is there a way to have a pool in a module that will only be cleaned
up when httpd stops?
I suppose
Jim Jagielski wrote:
I thought that this was about abstracting out scoreboard
so that other modules could have scoreboard-like
access without mucking around with the real scoreboard...
+1. The proxy could just use this mechanism. We need to separate the
two issues. I am all in favor of a
Brian Akins wrote:
Jim Jagielski wrote:
I thought that this was about abstracting out scoreboard
so that other modules could have scoreboard-like
access without mucking around with the real scoreboard...
+1. The proxy could just use this mechanism. We need to separate the
two
Ruediger Pluem wrote:
On 07/28/2006 06:34 PM, [EMAIL PROTECTED] wrote:
Added:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c?rev=426604view
Jim Jagielski wrote:
Jean-frederic Clere wrote:
Jim Jagielski wrote:
A quick check shows that various worker stats are not shared...
doing a reload of the balancer-manager shows the I/O/Elected
values flopping all over the place. So they seem in this
impl process specific and not
Jim Jagielski wrote:
A quick check shows that various worker stats are not shared...
doing a reload of the balancer-manager shows the I/O/Elected
values flopping all over the place. So they seem in this
impl process specific and not shared at all. Did nothing
special to build modules/mem just
On 07/29/2006 09:59 AM, Ruediger Pluem wrote:
But it is not used in this implementation. Instead you use worker-id here.
Should it be used by other implementations where worker-id cannot /
shouldn't be used?
Never mind. Obsoleted by r426732.
Regards
Rüdiger
Jim Jagielski wrote:
A quick check shows that various worker stats are not shared...
doing a reload of the balancer-manager shows the I/O/Elected
values flopping all over the place. So they seem in this
impl process specific and not shared at all. Did nothing
special to build modules/mem just
Jean-frederic Clere wrote:
Jim Jagielski wrote:
A quick check shows that various worker stats are not shared...
doing a reload of the balancer-manager shows the I/O/Elected
values flopping all over the place. So they seem in this
impl process specific and not shared at all. Did nothing
On Jul 29, 2006, at 7:43 AM, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Sat Jul 29 04:43:25 2006
New Revision: 426781
Modified: httpd/httpd/branches/httpd-proxy-scoreboard/support/
proxymonitor.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-
scoreboard/support
I'm not sure I'm comfortable with the directory location (proxy)
and the names (checker|comarea) being hardcoded... And
creating the directory is also somewhat unsettling as well
since it's a normal directory that should exist. It would
be like Apache pre-creating the logs directory... :/
On 29.07.2006 16:46, Jim Jagielski wrote:
I'm not sure I'm comfortable with the directory location (proxy)
and the names (checker|comarea) being hardcoded... And
creating the directory is also somewhat unsettling as well
since it's a normal directory that should exist. It would
be like Apache
On Jul 29, 2006, at 7:43 AM, [EMAIL PROTECTED] wrote:
fname = ap_server_root_relative(pool, name);
+dir = apr_pstrdup(pool, name);
+sep = strrchr(dir, '/');
+if (sep != NULL) {
+*sep++ = '\0';
+dname = ap_server_root_relative(pool, dir);
+
Jim Jagielski wrote:
I'm not sure I'm comfortable with the directory location (proxy)
Ok Should it be moved in logs: The pid file is already there.
and the names (checker|comarea) being hardcoded...
Ok. That means I should not create the slot mem in the pre-config.
And
creating the
On 07/28/2006 06:34 PM, [EMAIL PROTECTED] wrote:
Added:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c?rev=426604view=auto
On 07/27/2006 02:37 PM, Jean-frederic Clere wrote:
Ruediger Pluem wrote:
You want to check all the connections of the pool corresponding to the
worker but not all the workers.
Not all at the same time, but only the one I actually leased.
If it is not that does not mean
necessarily
On Jul 26, 2006, at 12:11 PM, Jean-frederic Clere wrote:
Hi,
I have started to write a generic health-checker for mod_proxy. I
would like to change the macro PROXY_WORKER_IS_USABLE() to a
routine in proxy_util.c.
Why? We're simply checking bits... I can't see bothering
with the
=426604view=revLog:First try to put togother an external health checker for mod_proxy.Added:httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.chttpd/httpd/branches/httpd-proxy-scoreboard
an external health checker for mod_proxy.
Added:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/mod_proxy_health_checker.c
httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy
-scoreboard/modules/proxy/config.m4
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/config.m4?rev=426604r1=426603r2=426604view=diff
==
--- httpd/httpd/branches/httpd-proxy
On Jul 28, 2006, at 12:34 PM, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Fri Jul 28 09:33:58 2006
New Revision: 426604
URL: http://svn.apache.org/viewvc?rev=426604view=rev
Log:
First try to put togother an external health checker for mod_proxy.
Just coming back from OSCON, I haven't
On Jul 28, 2006, at 1:54 PM, jean-frederic clere wrote:
Hi,
I have committed the code to get comments on some points:
- Does it make sense to include from support objects from modules/
proxy?
- Does the mod_proxy_health_checker is the right way to go? - I
mean: one part is storing the
Em 28/07/2006, às 13:34, [EMAIL PROTECTED] escreveu:
Author: jfclere
Date: Fri Jul 28 09:33:58 2006
New Revision: 426604
...
+
+static const slotmem_storage_method *checkstorage = NULL;
+static ap_slotmem_t *myscore=NULL;
Indentation consistency ? myscore=NULL
+
+if (!port) {
+
Jim Jagielski wrote:
On Jul 28, 2006, at 1:54 PM, jean-frederic clere wrote:
Hi,
I have committed the code to get comments on some points:
- Does it make sense to include from support objects from modules/
proxy?
- Does the mod_proxy_health_checker is the right way to go? - I
mean: one
Jim Jagielski wrote:
On Jul 28, 2006, at 12:34 PM, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Fri Jul 28 09:33:58 2006
New Revision: 426604
URL: http://svn.apache.org/viewvc?rev=426604view=rev
Log:
First try to put togother an external health checker for mod_proxy.
Just coming back
On Jul 28, 2006, at 4:03 PM, Jean-frederic Clere wrote:
Jim Jagielski wrote:
On Jul 28, 2006, at 1:54 PM, jean-frederic clere wrote:
Hi,
I have committed the code to get comments on some points:
- Does it make sense to include from support objects from
modules/ proxy?
- Does the
Many compile warnings when compiling with maint-mode:
mod_proxy.c: In function 'add_pass':
mod_proxy.c:1176: warning: implicit declaration of function
'proxy_checkstorage_add_entry'
mod_proxy.c: In function 'proxy_post_config':
mod_proxy.c:1870: warning: implicit declaration of function
Jim Jagielski wrote:
Many compile warnings when compiling with maint-mode:
Fixed. Thanks,
Cheers
Jean-Frederic
mod_proxy.c: In function 'add_pass':
mod_proxy.c:1176: warning: implicit declaration of function
'proxy_checkstorage_add_entry'
mod_proxy.c: In function 'proxy_post_config':
Davi Arnaut wrote:
Em 28/07/2006, às 13:34, [EMAIL PROTECTED] escreveu:
Author: jfclere
Date: Fri Jul 28 09:33:58 2006
New Revision: 426604
...
+
+static const slotmem_storage_method *checkstorage = NULL;
+static ap_slotmem_t *myscore=NULL;
Indentation consistency ? myscore=NULL
/httpd/branches/httpd-proxy-scoreboard/modules/proxy/config.m4
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/config.m4?rev=426604r1=426603r2=426604view=diff
==
--- httpd/httpd
A quick check shows that various worker stats are not shared...
doing a reload of the balancer-manager shows the I/O/Elected
values flopping all over the place. So they seem in this
impl process specific and not shared at all. Did nothing
special to build modules/mem just allowed default config
Ruediger Pluem wrote:
On 07/26/2006 10:53 PM, Jean-frederic Clere wrote:
I already have a prototype of an external health checker process that
uses an AJP cping/cpong and a simple connect for http/https.
Basicaly mod_proxy uses the health_worker_method routine to write and
read from a
On 07/27/2006 11:31 AM, Jean-frederic Clere wrote:
Ruediger Pluem wrote:
On 07/26/2006 10:53 PM, Jean-frederic Clere wrote:
I already have a prototype of an external health checker process that
uses an AJP cping/cpong and a simple connect for http/https.
Basicaly mod_proxy uses the
Ruediger Pluem wrote:
On 07/27/2006 11:31 AM, Jean-frederic Clere wrote:
Ruediger Pluem wrote:
On 07/26/2006 10:53 PM, Jean-frederic Clere wrote:
I already have a prototype of an external health checker process that
uses an AJP cping/cpong and a simple connect for
outside httpd.
Modified:
httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem/mod_plainmem.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem/mod_plainmem.c?rev=425734r1=425733r2=425734view=diff
features could be
used outside httpd.
Modified: httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem/mod_plainmem.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem/mod_plainmem.c?rev=425734r1=425733r2=425734view=diff
On 26.07.2006 17:39, Jean-frederic Clere wrote:
Ruediger Pluem wrote:
Too much copy and paste? We already found it above and what we are
searching for
is in *new isn't it? (Maybe we should also set *new to NULL in the
beginning to
have a defined return value?)
No... There is a typo:
Hi,
I have started to write a generic health-checker for mod_proxy. I
would like to change the macro PROXY_WORKER_IS_USABLE() to a routine in
proxy_util.c.
Comments?
Another problem I have is to decide the max size of the slot mem for the
worker: proxy_lb_workers() only gives the right
On 26.07.2006 18:11, Jean-frederic Clere wrote:
Hi,
I have started to write a generic health-checker for mod_proxy. I
would like to change the macro PROXY_WORKER_IS_USABLE() to a routine in
proxy_util.c.
Comments?
From my current point of view we should keep this macro as a simple bit
Ruediger Pluem wrote:
On 26.07.2006 18:11, Jean-frederic Clere wrote:
Hi,
I have started to write a generic health-checker for mod_proxy. I
would like to change the macro PROXY_WORKER_IS_USABLE() to a routine in
proxy_util.c.
Comments?
From my current point of view we should keep
On 07/26/2006 10:53 PM, Jean-frederic Clere wrote:
I already have a prototype of an external health checker process that
uses an AJP cping/cpong and a simple connect for http/https.
Basicaly mod_proxy uses the health_worker_method routine to write and
read from a slot mem that contains the
Jean-frederic Clere wrote:
Do you mean the proxy back-end connections?
I am thinking of a more general purpose slotmem not particularly tied
to proxy. Maybe have some wrapper functions that create a slotmem
based on threads x procs and can be access using r-connection.
(internally slotmem
Brian Akins wrote:
Jean-frederic Clere wrote:
Do you mean the proxy back-end connections?
I am thinking of a more general purpose slotmem not particularly tied
to proxy.
++1. Making it proxy specific really doesn't allow for the
kind of abstraction and usage that would make it
Brian Akins wrote:
Jean-frederic Clere wrote:
Do you mean the proxy back-end connections?
I am thinking of a more general purpose slotmem not particularly
tied to proxy. Maybe have some wrapper functions that create a
slotmem based on threads x procs and can be access using
Some comments inline.
Regards
Rüdiger
On 19.07.2006 14:18, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Wed Jul 19 05:18:10 2006
New Revision: 423444
--- httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem/mod_plainmem.c
(added)
+++ httpd/httpd/branches/httpd-proxy-scoreboard
Ruediger Pluem wrote:
+static apr_status_t ap_slotmem_create(ap_slotmem_t **new, const char
*name, apr_size_t item_size, int item_num, apr_pool_t *pool)
In my thought of a slotmem or scoreboard item_num is max threads *
max procs just like the normal scoreboard. Or has this morphed into
Ruediger Pluem wrote:
Some comments inline.
Regards
Many thanks
Cheers
Jean-Frederic
Rüdiger
On 19.07.2006 14:18, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Wed Jul 19 05:18:10 2006
New Revision: 423444
--- httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem
60 matches
Mail list logo
