Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Yann Ylavic
On Fri, Mar 31, 2023 at 11:23 AM Ruediger Pluem wrote: > > On 3/31/23 10:25 AM, Yann Ylavic wrote: > > On Fri, Mar 31, 2023 at 10:15 AM Ruediger Pluem wrote: > >> > >> On 3/31/23 9:56 AM, Yann Ylavic wrote: > >>> On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: > > On 3/31/23

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Ruediger Pluem
On 3/31/23 10:25 AM, Yann Ylavic wrote: > On Fri, Mar 31, 2023 at 10:15 AM Ruediger Pluem wrote: >> >> On 3/31/23 9:56 AM, Yann Ylavic wrote: >>> On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: On 3/31/23 2:11 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Yann Ylavic
On Fri, Mar 31, 2023 at 10:15 AM Ruediger Pluem wrote: > > On 3/31/23 9:56 AM, Yann Ylavic wrote: > > On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: > >> > >> On 3/31/23 2:11 AM, yla...@apache.org wrote: > >>> Author: ylavic > >>> Date: Fri Mar 31 00:11:02 2023 > >>> New Revision: 1908827

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Ruediger Pluem
On 3/31/23 9:56 AM, Yann Ylavic wrote: > On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: >> >> On 3/31/23 2:11 AM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Fri Mar 31 00:11:02 2023 >>> New Revision: 1908827 >>> >>> URL: http://svn.apache.org/viewvc?rev=1908827=rev >>> Log:

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Yann Ylavic
On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: > > On 3/31/23 2:11 AM, yla...@apache.org wrote: > > Author: ylavic > > Date: Fri Mar 31 00:11:02 2023 > > New Revision: 1908827 > > > > URL: http://svn.apache.org/viewvc?rev=1908827=rev > > Log: > > mod_proxy: Check for space/ctrls in nocanon

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Ruediger Pluem
On 3/31/23 2:11 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Mar 31 00:11:02 2023 > New Revision: 1908827 > > URL: http://svn.apache.org/viewvc?rev=1908827=rev > Log: > mod_proxy: Check for space/ctrls in nocanon path/urls before forwarding. Can this really happen? Wouldn't this

Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy

2023-03-08 Thread Yann Ylavic
avoid decoding in ap_process_request_internal(). > > > > * proxy/mod_proxy_http.c, proxy/mod_proxy_ajp.c, proxy/mod_proxy_wstunnel.c, > > proxy/mod_proxy_fcgi.c, proxy/mod_proxy_ajp.c, http2/mod_proxy_http2.c: > > Don't process the url through ap_proxy_canonenc() in ca

Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy

2023-03-08 Thread Ruediger Pluem
mod_proxy.c(ap_proxy_trans_match): > Set "proxy-noencode" in r->notes for PROXYPASS_MAP_ENCODED, and return DONE > to avoid decoding in ap_process_request_internal(). > > * proxy/mod_proxy_http.c, proxy/mod_proxy_ajp.c, proxy/mod_proxy_wstunnel.c, > proxy/mod_proxy_fcgi.c,

Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c

2023-03-06 Thread Stefan Eissing via dev
> Am 06.03.2023 um 10:37 schrieb Yann Ylavic : > > On Mon, Mar 6, 2023 at 10:28 AM Ruediger Pluem wrote: >> >> Thanks. Should we roll a new rc with this being backported and included? > > I don't think so, the ci failure is caused by an explicit script/check > but the build works fine while

Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c

2023-03-06 Thread Yann Ylavic
On Mon, Mar 6, 2023 at 10:28 AM Ruediger Pluem wrote: > > Thanks. Should we roll a new rc with this being backported and included? I don't think so, the ci failure is caused by an explicit script/check but the build works fine while runtime will only log an empty "AH" number, not a show stopper

Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c

2023-03-06 Thread Ruediger Pluem
On 3/6/23 10:24 AM, jor...@apache.org wrote: > Author: jorton > Date: Mon Mar 6 09:24:44 2023 > New Revision: 1908116 > > URL: http://svn.apache.org/viewvc?rev=1908116=rev > Log: > * modules/http2/mod_proxy_http2.c: Fix missing APLOGNO. > > Modified: > http

Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy

2023-03-05 Thread Stefan Eissing via dev
> Am 05.03.2023 um 02:30 schrieb Eric Covener : > >> Modified: httpd/httpd/trunk/modules/http2/mod_proxy_http2.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_proxy_http2.c?rev=1907

Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy

2023-03-04 Thread Eric Covener
> Modified: httpd/httpd/trunk/modules/http2/mod_proxy_http2.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_proxy_http2.c?rev=1907972=1907971=1907972=diff > == > --- httpd/http

Re: mod_proxy_http2 setting Transfer-Encoding chunked for a GET request

2022-09-28 Thread Rainer Jung
Hi Stefan, the PR is: https://bz.apache.org/bugzilla/show_bug.cgi?id=66282 Let me know, in case you can not reproduce it, or I should test something! Best regards, Rainer

Re: mod_proxy_http2 setting Transfer-Encoding chunked for a GET request

2022-09-28 Thread Stefan Eissing via dev
I send a normal GET request, without body, no Transfer-Encoding and no > Content-Length, to httpd and proxy it via mod_proxy_http2 to the same server, > the proxied request gets "Transfer-Encoding: chunked" added by > mod_proxy_http2 and is then denied by mod_security on the

mod_proxy_http2 setting Transfer-Encoding chunked for a GET request

2022-09-28 Thread Rainer Jung
it via mod_proxy_http2 to the same server, the proxied request gets "Transfer-Encoding: chunked" added by mod_proxy_http2 and is then denied by mod_security on the receiving side. No such addition when using mod_proxy_http. It seems to me, that "Transfer-Encoding: chunked&

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-06-04 Thread Ruediger Pluem
On 6/3/20 4:09 PM, Stefan Eissing wrote: > Made some adjustments to have it work for all the "we wait for sth from > backend" and added as r1878433 in trunk. Looks very nice. Thank you very much. Regards Rüdiger

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-06-03 Thread Stefan Eissing
Made some adjustments to have it work for all the "we wait for sth from backend" and added as r1878433 in trunk. > Am 02.06.2020 um 09:37 schrieb Stefan Eissing : > > Looks good! > >> Am 29.05.2020 um 21:14 schrieb Ruediger Pluem : >> >> >> >> On 5/29/20 11:41 AM, Stefan Eissing wrote: >>>

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-06-02 Thread Stefan Eissing
Looks good! > Am 29.05.2020 um 21:14 schrieb Ruediger Pluem : > > > > On 5/29/20 11:41 AM, Stefan Eissing wrote: >> >> >>> Am 29.05.2020 um 11:23 schrieb Ruediger Pluem : >>> >>> >>> >>> On 5/29/20 10:09 AM, Stefan Eissing wrote: Looks good. Now I learned about the "ping"

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-29 Thread Ruediger Pluem
On 5/29/20 11:41 AM, Stefan Eissing wrote: > > >> Am 29.05.2020 um 11:23 schrieb Ruediger Pluem : >> >> >> >> On 5/29/20 10:09 AM, Stefan Eissing wrote: >>> Looks good. Now I learned about the "ping" parameter... >> >> Committed as r1878264 with a tweaked comment to make clear what I do.

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-29 Thread Stefan Eissing
> Am 29.05.2020 um 11:23 schrieb Ruediger Pluem : > > > > On 5/29/20 10:09 AM, Stefan Eissing wrote: >> Looks good. Now I learned about the "ping" parameter... > > Committed as r1878264 with a tweaked comment to make clear what I do. > > Getting me to the next possible enhancement. I

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-29 Thread Ruediger Pluem
On 5/29/20 10:09 AM, Stefan Eissing wrote: > Looks good. Now I learned about the "ping" parameter... Committed as r1878264 with a tweaked comment to make clear what I do. Getting me to the next possible enhancement. I already had a patch but when putting it to the mail I got doubts that it

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-29 Thread Stefan Eissing
Looks good. Now I learned about the "ping" parameter... > Am 28.05.2020 um 21:30 schrieb Ruediger Pluem : > > > > On 5/28/20 12:06 PM, Stefan Eissing wrote: >> >>> Am 28.05.2020 um 12:05 schrieb Ruediger Pluem : >>> >>> >>> >>> On 5/28/20 11:36 AM, Stefan Eissing wrote: >>> You

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-28 Thread Ruediger Pluem
On 5/28/20 12:06 PM, Stefan Eissing wrote: > >> Am 28.05.2020 um 12:05 schrieb Ruediger Pluem : >> >> >> >> On 5/28/20 11:36 AM, Stefan Eissing wrote: >> >>> >>> You are correct. I made a v2 of the patch: >> >> Thanks. This one looks good. > > Thanks for reviewing this. Thanks for commiting

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-28 Thread Stefan Eissing
> Am 28.05.2020 um 12:05 schrieb Ruediger Pluem : > > > > On 5/28/20 11:36 AM, Stefan Eissing wrote: > >> >> You are correct. I made a v2 of the patch: > > Thanks. This one looks good. Thanks for reviewing this. > > Regards > > Rüdiger

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-28 Thread Ruediger Pluem
On 5/28/20 11:36 AM, Stefan Eissing wrote: > > You are correct. I made a v2 of the patch: Thanks. This one looks good. Regards Rüdiger

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-28 Thread Stefan Eissing
> Am 27.05.2020 um 17:58 schrieb Ruediger Pluem : > > > > On 5/27/20 5:25 PM, Stefan Eissing wrote: >> Maybe this can work? It goes into blocking read with default timeout when >> there is definitely nothing to send from our end. >> >> >> h2-proxy-timeout.patch >> >> Index:

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Ruediger Pluem
On 5/27/20 5:25 PM, Stefan Eissing wrote: > Maybe this can work? It goes into blocking read with default timeout when > there is definitely nothing to send from our end. > > > h2-proxy-timeout.patch > > Index: modules/http2/h2_proxy_session.c >

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Stefan Eissing
2020 um 15:05 schrieb Ruediger Pluem : >>> >>> >>> >>> On 5/27/20 1:10 PM, Stefan Eissing wrote: >>>> The whole thing initially handled processing of several streams in >>>> parallel. That is why it has more states than currently nec

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Stefan Eissing
>>> h2_proxy_session_process() returns from H2_PROXYS_ST_WAIT state to the >>> caller in mod_proxy_http2.c#255. That one checks the aborted state of the >>> "master" connection. So, when our frontend connection goes away, >>> mod_proxy_http2 processing

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Stefan Eissing
why it has more states than currently necessary. >> >> h2_proxy_session_process() returns from H2_PROXYS_ST_WAIT state to the >> caller in mod_proxy_http2.c#255. That one checks the aborted state of the >> "master" connection. So, when our frontend connection

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Ruediger Pluem
On 5/27/20 1:10 PM, Stefan Eissing wrote: > The whole thing initially handled processing of several streams in parallel. > That is why it has more states than currently necessary. > > h2_proxy_session_process() returns from H2_PROXYS_ST_WAIT state to the caller > in mod_pr

Re: Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Stefan Eissing
The whole thing initially handled processing of several streams in parallel. That is why it has more states than currently necessary. h2_proxy_session_process() returns from H2_PROXYS_ST_WAIT state to the caller in mod_proxy_http2.c#255. That one checks the aborted state of the "m

Trying to understand the logic of mod_proxy_http2 with regards to timeouts

2020-05-27 Thread Ruediger Pluem
I try to understand the logic of mod_proxy_http2 with respect to timeouts. I am currently stuck at this piece of code in h2_proxy_session_process in h2_proxy_session.c case H2_PROXYS_ST_BUSY: case H2_PROXYS_ST_LOCAL_SHUTDOWN: case H2_PROXYS_ST_REMOTE_SHUTDOWN

Re: Questions with mod_proxy_http2

2019-05-14 Thread Ruediger Pluem
On 05/14/2019 09:38 AM, Stefan Eissing wrote: > > >> Am 14.05.2019 um 09:30 schrieb Ruediger Pluem : >> >> >> >> On 05/13/2019 03:30 PM, Stefan Eissing wrote: >>> >>> >>>> Am 13.05.2019 um 14:42 schrieb Plüm, Rüdiger, Vodafon

Re: Questions with mod_proxy_http2

2019-05-14 Thread Stefan Eissing
> Am 14.05.2019 um 09:30 schrieb Ruediger Pluem : > > > > On 05/13/2019 03:30 PM, Stefan Eissing wrote: >> >> >>> Am 13.05.2019 um 14:42 schrieb Plüm, Rüdiger, Vodafone Group >>> : >>> >>> I recently started using mod_proxy_

Re: Questions with mod_proxy_http2

2019-05-14 Thread Ruediger Pluem
On 05/13/2019 03:30 PM, Stefan Eissing wrote: > > >> Am 13.05.2019 um 14:42 schrieb Plüm, Rüdiger, Vodafone Group >> : >> >> I recently started using mod_proxy_http2 and some questions popped up for me: >> >> 1. Why do we retry 5 times har

Re: Questions with mod_proxy_http2

2019-05-13 Thread Stefan Eissing
> Am 13.05.2019 um 14:42 schrieb Plüm, Rüdiger, Vodafone Group > : > > I recently started using mod_proxy_http2 and some questions popped up for me: > > 1. Why do we retry 5 times hardcoded (leading to AH10023 in case we fail)? > The other protocols only try to r

Questions with mod_proxy_http2

2019-05-13 Thread Plüm , Rüdiger , Vodafone Group
I recently started using mod_proxy_http2 and some questions popped up for me: 1. Why do we retry 5 times hardcoded (leading to AH10023 in case we fail)? The other protocols only try to retry once if the ping failed (additional Expect 100 header in the HTTP case, PING packet in the AJP case

Re: svn commit: r1853407 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_http.c

2019-02-14 Thread Stefan Eissing
Yann, The new v3 patch runs without any problems in my test setups. Nice work! As to the errors you see: that seems to be the output parsing for nghttp in the test classes that needs some more work. On your systems, DATA packages arrive different than my MacOS had seen so far. That messed up the

Re: svn commit: r1853407 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_http.c

2019-02-13 Thread Yann Ylavic
Thanks Stefan, I think the "400" issue is fixed (r1853518, added to backport proposal), but two tests keep failing for in the test suite, namely test_004_post and test_500_proxy. They fail with or without my changes (trunk and 2.4.x), so I don't think it's related (mod_proxy does not seem to be

Re: svn commit: r1853407 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_http.c

2019-02-12 Thread Stefan Eissing
ad. >>> >>> We can then use it in stream_reqbody_{chunked,cl}() to flush client >>> forwarded >>> data only when necessary. This both allows "optimal" flushing and simplifies >>> code (note that spool_reqbody_cl() also makes use of the new

Re: svn commit: r1853407 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_http.c

2019-02-12 Thread Yann Ylavic
ation and common error handling). > > > > Also, since proxy_http_req_t::flushall/subprocess_env::proxy-flushall are > > now > > meaningless (and unused) on the backend side, they are renamed respectively > > to > > prefetch_nonblocking/proxy-prefetch-nonblocking,

Re: svn commit: r1853407 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_http.c

2019-02-12 Thread ste...@eissing.org
nv::proxy-flushall are now > meaningless (and unused) on the backend side, they are renamed respectively to > prefetch_nonblocking/proxy-prefetch-nonblocking, and solely determine whether > to prefetch in nonblocking mode or not. These flags were trunk only and may > not be really u

Re: mod_proxy_http2 sni ?

2017-02-23 Thread Steffen
n I add/change the front to: ProtocolsHonorOrder On Protocols h2 http/1.1 LoadModule http2_module modules/mod_http2.so LoadModule proxy_http2_module modules/mod_proxy_http2.so ProxyPass / h2c://127.0.0.1:80/ ProxyPassReverse / h2c://127.0.0.1:80/ This is not working as expected, all is going to the default/fi

Re: mod_proxy_http2 sni ?

2017-02-23 Thread Stefan Eissing
; >>>>> ProxyPass / http://127.0.0.1:80/ >>>>> ProxyPassReverse / http://127.0.0.1:80/ >>>>> >>>>> >>>>> In backend have: >>>>> >>>>> >>>>> ProtocolsHonorOrder On >>>>>

Re: mod_proxy_http2 sni ?

2017-02-22 Thread Steffen
ith all the vhosts. When I add/change the front to: ProtocolsHonorOrder On Protocols h2 http/1.1 LoadModule http2_module modules/mod_http2.so LoadModule proxy_http2_module modules/mod_proxy_http2.so ProxyPass / h2c://127.0.0.1:80/ ProxyPassReverse / h2c://127.0.0.1:80/ This is not w

Re: mod_proxy_http2 sni ?

2017-02-22 Thread Stefan Eissing
>> >>> >>> ProtocolsHonorOrder On >>> Protocols h2c http/1.1 >>> LoadModule http2_module modules/mod_http2.so >>> >>> This is working great and with all the vhosts. >>> >>> >>> When I add/change the front

Re: mod_proxy_http2 sni ?

2017-02-17 Thread Steffen
In backend have: >> >> >> ProtocolsHonorOrder On >> Protocols h2c http/1.1 >> LoadModule http2_module modules/mod_http2.so >> >> This is working great and with all the vhosts. >> >> >> When I add/change the front to: >>

Re: mod_proxy_http2 sni ?

2017-02-16 Thread Stefan Eissing
> > ProtocolsHonorOrder On > Protocols h2c http/1.1 > LoadModule http2_module modules/mod_http2.so > > This is working great and with all the vhosts. > > > When I add/change the front to: > > > ProtocolsHonorOrder On > Protocols h2 http/1.1

mod_proxy_http2 sni ?

2017-02-16 Thread Steffen
/mod_proxy_http2.so ProxyPass / h2c://127.0.0.1:80/ ProxyPassReverse / h2c://127.0.0.1:80/ This is not working as expected, all is going to the default/first vhost. a log line from the backend gives is all cases not found . default 127.0.0.1 - - [16/Feb/2017:10:22:00 +0100] &quo

Re: svn commit: r1779578 - /httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml

2017-01-20 Thread Stefan Eissing
> > > > > > URL: http://svn.apache.org/viewvc?rev=1779578=rev > > > Log: > > > Added more details to mod-proxy-http2's doc > > > > > > Modified: > > >httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml > > > > >

Re: svn commit: r1779578 - /httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml

2017-01-20 Thread Luca Toscano
t; > > > Am 20.01.2017 um 09:45 schrieb elu...@apache.org: > > > > > > Author: elukey > > > Date: Fri Jan 20 08:45:40 2017 > > > New Revision: 1779578 > > > > > > URL: http://svn.apache.org/viewvc?rev=1779578=rev > > > Log: >

Re: svn commit: r1779578 - /httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml

2017-01-20 Thread Stefan Eissing
te: Fri Jan 20 08:45:40 2017 > > New Revision: 1779578 > > > > URL: http://svn.apache.org/viewvc?rev=1779578=rev > > Log: > > Added more details to mod-proxy-http2's doc > > > > Modified: > >httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml >

Re: svn commit: r1779578 - /httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml

2017-01-20 Thread Luca Toscano
wvc?rev=1779578=rev > > Log: > > Added more details to mod-proxy-http2's doc > > > > Modified: > >httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml > > > > Modified: httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml > > URL: http://svn.apa

Re: svn commit: r1779578 - /httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml

2017-01-20 Thread ste...@eissing.org
httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml > > Modified: httpd/httpd/trunk/docs/manual/mod/mod_proxy_http2.xml > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_

Re: httpd-trunk - mod_proxy_http2 needs an export

2016-10-18 Thread NormW
G/M Thanks for the thanks! Norm On 18/10/2016 11:06 PM, Stefan Eissing wrote: Added in trunk and 2.4.x branch. Thanks! Am 18.10.2016 um 14:02 schrieb NormW : G\E If anyone is looking after NetWare issues: Index: modules/http2/NWGNUmod_http2

Re: httpd-trunk - mod_proxy_http2 needs an export

2016-10-18 Thread Stefan Eissing
Added in trunk and 2.4.x branch. Thanks! > Am 18.10.2016 um 14:02 schrieb NormW : > > G\E > If anyone is looking after NetWare issues: >> Index: modules/http2/NWGNUmod_http2 >> == >> --- modules/http2/NWGNUmod_http2

httpd-trunk - mod_proxy_http2 needs an export

2016-10-18 Thread NormW
G\E If anyone is looking after NetWare issues: Index: modules/http2/NWGNUmod_http2 == --- modules/http2/NWGNUmod_http2(revision 1765415) +++ modules/http2/NWGNUmod_http2(working copy) @@ -393,6 +393,7 @@

Re: svn commit: r1750771 - /httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy_http2.html.en

2016-06-30 Thread Stefan Eissing
Thanks, Jim! > Am 30.06.2016 um 13:14 schrieb j...@apache.org: > > Author: jim > Date: Thu Jun 30 11:14:31 2016 > New Revision: 1750771 > > URL: http://svn.apache.org/viewvc?rev=1750771=rev > Log: > xforms > > Modified: >httpd/httpd/branches/2.4.x/doc

Re: svn commit: r1750681 - in /httpd/httpd/branches/2.4.x: STATUS docs/manual/mod/mod_proxy_http2.html docs/manual/mod/mod_proxy_http2.html.en docs/manual/mod/mod_proxy_http2.xml.meta

2016-06-29 Thread André Malo
pd/branches/2.4.x/docs/manual/mod/mod_proxy_http2.html > httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy_http2.html.en > httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy_http2.xml.meta Huh? nd -- Das einzige, das einen Gebäudekollaps (oder auch einen thermonuklearen Krieg) unb

Re: [PATCH] mod_proxy_http2: fix proxying of 32K+ sized responses

2016-06-10 Thread Jim Jagielski
Thanks! > On Jun 10, 2016, at 10:58 AM, Evgeny Kotkov > wrote: > > Jim Jagielski writes: > >> Thanks for the patch... It came thru, at least for me, mangled. >> >> Could you resend? > > I think that's because gmail did base64 encoding for the

Re: [PATCH] mod_proxy_http2: fix proxying of 32K+ sized responses

2016-06-10 Thread Evgeny Kotkov
Jim Jagielski writes: > Thanks for the patch... It came thru, at least for me, mangled. > > Could you resend? I think that's because gmail did base64 encoding for the attachment. The unmangled patch is available here:

Re: [PATCH] mod_proxy_http2: fix proxying of 32K+ sized responses

2016-06-10 Thread Jim Jagielski
Thanks for the patch... It came thru, at least for me, mangled. Could you resend? > On Jun 10, 2016, at 10:21 AM, Evgeny Kotkov > wrote: > >

Re: mod_proxy_http2 windows build

2016-05-19 Thread Jan Ehrhardt
Stefan Eissing in gmane.comp.apache.devel (Wed, 18 May 2016 17:09:46 +0200): >Reaching out to the knowledgable and always helpful Windows people: do we >need a mod_proxy_http2.dsp in trunk/modules/http2 (and 2.4.x branch for >next release)? The project files for the 2.4.x branch I

Re: mod_proxy_http2 windows build

2016-05-19 Thread William A Rowe Jr
On May 18, 2016 6:08 PM, "Jan Ehrhardt" wrote: > > William A Rowe Jr in gmane.comp.apache.devel (Wed, 18 May 2016 14:54:41 > -0500): > >The .dsp files become irrelevant in this day and age, the legacy environment > >it maps to is entirely dead and beyond availability (snip)...

Re: mod_proxy_http2 windows build

2016-05-18 Thread Jan Ehrhardt
William A Rowe Jr in gmane.comp.apache.devel (Wed, 18 May 2016 14:54:41 -0500): >The .dsp files become irrelevant in this day and age, the legacy environment >it maps to is entirely dead and beyond availability (snip)... Yet they are still the preferred way of building Apache by the people at

Re: mod_proxy_http2 windows build

2016-05-18 Thread William A Rowe Jr
ng < >> stefan.eiss...@greenbytes.de <mailto:stefan.eiss...@greenbytes.de>> >> wrote: >> >> Reaching out to the knowledgable and always helpful Windows people: >> do we >> need a mod_proxy_http2.dsp in trunk/modules/http2 (and 2.4.x branch >> for &

Re: mod_proxy_http2 windows build

2016-05-18 Thread Stefan Eissing
, May 18, 2016 at 10:09 AM, Stefan Eissing >> <stefan.eiss...@greenbytes.de <mailto:stefan.eiss...@greenbytes.de>> wrote: >> >>Reaching out to the knowledgable and always helpful Windows people: do we >>need a mod_proxy_http2.dsp in trunk/modules/http2 (and

Re: mod_proxy_http2 windows build

2016-05-18 Thread Michal Karm
ways helpful Windows people: do we need a mod_proxy_http2.dsp in trunk/modules/http2 (and 2.4.x branch for next release)? -Stefan Or perhaps to seize the opportunity to purge .dep/.mak and have a proper CMakeLists.txt instead? :) Michal Karm Babacek -- Sent from my Hosaka Ono-Sendai Cyberspace 7

Re: mod_proxy_http2 windows build

2016-05-18 Thread William A Rowe Jr
... and .mak/.dep files in 2.4 branch, I'm on it today. On Wed, May 18, 2016 at 10:09 AM, Stefan Eissing < stefan.eiss...@greenbytes.de> wrote: > Reaching out to the knowledgable and always helpful Windows people: do we > need a mod_proxy_http2.dsp in trunk/modules/http2 (and

mod_proxy_http2 windows build

2016-05-18 Thread Stefan Eissing
Reaching out to the knowledgable and always helpful Windows people: do we need a mod_proxy_http2.dsp in trunk/modules/http2 (and 2.4.x branch for next release)? -Stefan

Re: [PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-17 Thread Stefan Eissing
Ok, thanks. Your patch was added to trunk in r1744206 and I will propose it for backporting. Cheers, Stefan > Am 13.05.2016 um 12:13 schrieb Evgeny Kotkov : > > Stefan Eissing writes: > >> Hmm, can someone with more brains than me

Re: [PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-13 Thread Evgeny Kotkov
Stefan Eissing writes: > Hmm, can someone with more brains than me on mod_rewrite look at the > first patch if we want to add handling for h2: and h2c: uri schemes > here or if there is a better way? Thanks. In case this will help the review, here are some of the

Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion & Christophe JAILLET
r1729208, r1735668, r1735668, r1735931, r1735935, r1735942 from trunk: let proxy handler forward ALPN protocol strings for ssl proxy connections Remove leftover comment Remove leftover comment APLOGNO update for mod_proxy_http2 fix APLOGNO at wrong place, me stupid h2_proxy_session: fill

Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion & Christophe JAILLET
Hi all, mod_proxy_http2 does not compile because of changes made in mod_hhtp2: - h2_ihash_is_empty vs h2_ihash_empty - h2_request_create vs h2_req_create - modified header files - ... If not fixed in the mean time, I'll give a look at it tonight. Do we need to go thru the formal

Re: [PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-12 Thread Stefan Eissing
ticed that it's currently impossible to use mod_proxy_http2 in > conjunction with mod_rewrite's [P] request proxying: > >RewriteEngine On >RewriteRule ^/foo h2c://hostname/bar [P] > > mod_proxy_http2 registers on h2:// and h2c:// proxy URLs [1], however, > m

Re: [PATCH] mod_proxy_http2: fix theoretically possible segfault when parsing URL

2016-05-12 Thread Stefan Eissing
Evgeny, both patches look fine. Thanks! Applied in r1743517. Cheers, Stefan > Am 12.05.2016 um 16:33 schrieb Evgeny Kotkov <evgeny.kot...@visualsvn.com>: > > This patch fixes a theoretically possible segfault in mod_proxy_http2. > > Please see the o

Re: [PATCH] mod_http2, mod_proxy_http2: fix CMake support

2016-05-12 Thread Stefan Eissing
Thanks Evgeny. Applied in trunk as r1743512. To Jacob: mod_http2 should not be necessary as only OPTIONAL functions are used from it. mod_proxy_http2 is designed to work without mod_http2 being loaded (although it makes more sense if it is). -Stefan > Am 12.05.2016 um 16:54 schrieb Ja

Re: [PATCH] mod_http2, mod_proxy_http2: fix CMake support

2016-05-12 Thread Jacob Champion
On 05/12/2016 07:31 AM, Evgeny Kotkov wrote: @@ -451,11 +452,11 @@ SET(mod_proxy_wstunnel_extra_libsmod_proxy) SET(mod_proxy_http2_requires NGHTTP2_FOUND) SET(mod_proxy_http2_extra_defines ssize_t=long) -SET(mod_proxy_http2_extra_libs

[PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-12 Thread Evgeny Kotkov
I noticed that it's currently impossible to use mod_proxy_http2 in conjunction with mod_rewrite's [P] request proxying: RewriteEngine On RewriteRule ^/foo h2c://hostname/bar [P] mod_proxy_http2 registers on h2:// and h2c:// proxy URLs [1], however, mod_rewrite needs an update

[PATCH] mod_proxy_http2: fix theoretically possible segfault when parsing URL

2016-05-12 Thread Evgeny Kotkov
This patch fixes a theoretically possible segfault in mod_proxy_http2. Please see the open_stream() function in h2_proxy_session.c:598. If the call to apr_uri_parse() fails, some of the apr_uri_t's fields may be set to NULL, and this would cause a segfault in the following lines: authority

[PATCH] mod_http2, mod_proxy_http2: fix CMake support

2016-05-12 Thread Evgeny Kotkov
I noticed a few issues in CMakeLists.txt that currently prevent building mod_http2 and mod_proxy_http2 — that is, missing includes and library references. The attached patch should fix them. Regards, Evgeny Kotkov Fix CMake support for mod_http2 and mod_proxy_http2. Index: CMakeLists.txt

Re: svn commit: r1734238 - in /httpd/httpd/trunk: docs/manual/mod/mod_proxy_http2.xml modules/http2/h2_proxy_session.c modules/http2/mod_proxy_http2.c

2016-05-03 Thread Stefan Eissing
Thanks, Eric. Fixed in r1742073. -Stefan > Am 02.05.2016 um 20:25 schrieb Eric Covener <cove...@gmail.com>: > > On Wed, Mar 9, 2016 at 8:41 AM, <ic...@apache.org> wrote: >> +mod_proxy_http2 works with incoming requests >> +over HTTP/1.1 and HT

Re: svn commit: r1734238 - in /httpd/httpd/trunk: docs/manual/mod/mod_proxy_http2.xml modules/http2/h2_proxy_session.c modules/http2/mod_proxy_http2.c

2016-05-02 Thread Eric Covener
On Wed, Mar 9, 2016 at 8:41 AM, <ic...@apache.org> wrote: > +mod_proxy_http2 works with incoming requests > +over HTTP/1.1 and HTTP/2 requests. If mod_proxy_http2 > +handles the frontend connection, requests against the same HTTP/2 > +backend are sent over a

Re: mod_proxy_http2 build change

2016-04-29 Thread Jan Ehrhardt
Stefan Eissing in gmane.comp.apache.devel (Fri, 29 Apr 2016 11:46:14 +0200): >Just a heads up for all people caring about "other" builds: with r1741596 >in trunk I remove h2_request.c from linking in mod_proxy_http2. This >should help resolve some issues that where observed o

mod_proxy_http2 build change

2016-04-29 Thread Stefan Eissing
Just a heads up for all people caring about "other" builds: with r1741596 in trunk I remove h2_request.c from linking in mod_proxy_http2. This should help resolve some issues that where observed on the Windows build. I tried to make all needed changes in cmake/netware/dsp, but a

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread William A Rowe Jr
I've had success with Jeff's minimalist nghttp build schema. A larger effort at a cmake for the full stack (lib+apps) has been in the works for a month or two now, haven't had a chance to try it. On Mar 22, 2016 6:27 PM, "Jan Ehrhardt" wrote: > Jeff Trawick in

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread Jan Ehrhardt
Jeff Trawick in gmane.comp.apache.devel (Tue, 22 Mar 2016 18:11:59 -0400): >What version of nghttp2 are you using? I always use git head of nghttp2. So that is > v1.8.0 ATM >Are you using the cmake build for httpd? No. I open the *.dsw / *.dsp in with VC9 / VC11, after applying these

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread Jeff Trawick
http2 functions that mod_http2 didn't use when I built >> > before. (not related to cmake) >> > >> > After resolving that I now see a bunch of unresolved symbols with >> > mod_proxy_http2. From the number of symbols and the type there seems to >> > be a co

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread Jeff Trawick
> After resolving that I now see a bunch of unresolved symbols with > > mod_proxy_http2. From the number of symbols and the type there seems to > > be a couple of issues in the httpd CMakeLists.txt file. I can hopefully > > look at that early tomorrow a.m. > > The CMake/mod_proxy_http2 stuff

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread Jacob Champion
0 on Windows to fix bad > linkage in nghttp2 functions that mod_http2 didn't use when I built > before. (not related to cmake) > > After resolving that I now see a bunch of unresolved symbols with > mod_proxy_http2. From the number of symbols and the type there seems to > be a

Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread Jeff Trawick
nch of unresolved symbols with mod_proxy_http2. From the number of symbols and the type there seems to be a couple of issues in the httpd CMakeLists.txt file. I can hopefully look at that early tomorrow a.m. -- Born in Roswell... married an alien... http://emptyhammock.com/

mod_proxy_http2 backport proposal w. patch

2016-03-19 Thread Stefan Eissing
I propose a backport of mod_proxy_http2 with a 2.4.x patch included in STATUS. Kind souls may have a look. Maybe we can get it in for 2.4.19. Particular attention would be welcome by people who know the differences between trunk and 2.4.x architecture. I had to rip out the "detach_ba

Re: mod_proxy_http2 questions (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-11 Thread Yann Ylavic
bout routing, it's also rewriting, caching, >> filtering, securing..., so who would do that actual work per request >> if not workers? > > If I understand you correctly, all this is still happening. The things > I describe above are only happening when the handler of mod_pro

Re: request SUSPENDED (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-11 Thread Stefan Eissing
Ok, tests show that on returning SUSPENDED, no EOS + EOR buckets are written, but a FLUSH is passed by ap_process_request() nevertheless. Maybe that should not be done on a suspended connection, not sure. -Stefan > Am 11.03.2016 um 12:02 schrieb Stefan Eissing : >

Re: request SUSPENDED (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-11 Thread Stefan Eissing
Comments to the later parts, re suspending requests. > Am 10.03.2016 um 22:24 schrieb Yann Ylavic : > [...] > On Thu, Mar 10, 2016 at 5:38 PM, Stefan Eissing > wrote: >> >> Backend Engines >> --- >> How can we do that? Let's

Re: mod_proxy_http2 questions (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-11 Thread Stefan Eissing
http2_engine (s1[r1],s2[r2],s3[r3]) <--> b1 When a new request comes in, slave s4 is created and started on a worker: mpm-worker: m1 h2-worker: |--- proxy_http2_engine (s1[r1],s2[r2],s3[r3]) <--> b1 h2-worker: |--- s4[r4] When that runs into the handler of mod_proxy_http2 and is about to

Re: Add ?? mod_proxy_http2 for NetWare build - All done!

2016-03-10 Thread NormW
G/M Stefan, All done. and many thanks for taking the time out to attend to it. Regards Norm

Re: mod_proxy_http2 questions (was: [VOTE] backport mod_proxy_http2 to 2.4.x as experimental)

2016-03-10 Thread Yann Ylavic
t else is done there... > > Also I have not had the time to look at the logging of such request. > There might be some more work done there. Yes, that's another story (and mod_logio would better count h2 connections/bytes if that's the underlying protocol after all...). > > I hope this give an explanation of how mod_proxy_http2 works > together with mod_http2. If not, please ask. Happy to explain and > get feedback. Thanks for explaining Stefan, same here :) Regards, Yann.

  1   2   >