Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-17 Thread Christophe JAILLET
Finally, won't have time tonight :( and this week and week-end will be already busy. CJ Le 17/06/2014 11:31, Marion et Christophe JAILLET a écrit : Hi, obviously, no problem for me for merging the 2 in the same proposal. I'll have a look at it tonight. CJ

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-17 Thread Yann Ylavic
4 10:02 >> De : "Yann Ylavic" >> A : jaillet...@apache.org, "httpd" >> Copie à : >> Objet : Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES >> modules/proxy/mod_proxy_fdpass.c &g

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-17 Thread Marion et Christophe JAILLET
Hi,   obviously, no problem for me for merging the 2 in the same proposal. I'll have a look at it tonight. CJ > Message du 17/06/14 10:02 > De : "Yann Ylavic" > A : jaillet...@apache.org, "httpd" > Copie à : > Objet : Re: svn commit: r1598946 - i

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-17 Thread Yann Ylavic
Christophe, do you agree if I modify the 2.4.x proposal with : Index: STATUS === --- STATUS (revision 1603074) +++ STATUS (working copy) @@ -224,12 +224,14 @@ 2.4.x patch: trunk works (modulo CHANGES) +1: ylavic

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-16 Thread Yann Ylavic
Applied in r1602989. On Fri, Jun 13, 2014 at 1:45 AM, Yann Ylavic wrote: > On Fri, Jun 13, 2014 at 1:20 AM, Yann Ylavic wrote: >> On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic wrote: >>> On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote: The most important imho is to not truncate the len

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-12 Thread Yann Ylavic
On Fri, Jun 13, 2014 at 1:20 AM, Yann Ylavic wrote: > On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic wrote: >> On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote: >>> The most important imho is to not truncate the length at sizeof(struct >>> sockaddr_un) when the real sun_path is beyond sizeof(su

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-12 Thread Yann Ylavic
On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic wrote: > On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote: >> The most important imho is to not truncate the length at sizeof(struct >> sockaddr_un) when the real sun_path is beyond sizeof(sun_path). >> The libc calls are probably bullet proof regar

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-12 Thread Yann Ylavic
On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic wrote: > The most important imho is to not truncate the length at sizeof(struct > sockaddr_un) when the real sun_path is beyond sizeof(sun_path). > The libc calls are probably bullet proof regarding NUL termination > (eg. force ((char*)sun)[addrlen] =

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-12 Thread Yann Ylavic
On Thu, Jun 12, 2014 at 10:30 PM, Christophe JAILLET wrote: > Le 10/06/2014 18:19, Yann Ylavic a écrit : > >> On Sun, Jun 1, 2014 at 8:54 AM, wrote: >>> /* TODO: In APR 2.x: Extend apr_sockaddr_t to possibly be a path !!! */ >>> +/* XXX: The same function exists in proxy_util.c */ >> >> Shouldn

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-12 Thread Christophe JAILLET
Le 10/06/2014 18:19, Yann Ylavic a écrit : On Sun, Jun 1, 2014 at 8:54 AM, wrote: Author: jailletc36 Date: Sun Jun 1 06:54:15 2014 New Revision: 1598946 URL: http://svn.apache.org/r1598946 Log: Fix computation of the size of 'struct sockaddr_un' when passed to 'connec()'. s/connec()/connect

Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c

2014-06-10 Thread Yann Ylavic
On Sun, Jun 1, 2014 at 8:54 AM, wrote: > Author: jailletc36 > Date: Sun Jun 1 06:54:15 2014 > New Revision: 1598946 > > URL: http://svn.apache.org/r1598946 > Log: > Fix computation of the size of 'struct sockaddr_un' when passed to 'connec()'. s/connec()/connect()/ > Use the same logic as the