Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c

2017-01-19 Thread Yann Ylavic
On Thu, Jan 19, 2017 at 10:58 PM, Yann Ylavic wrote: > On Thu, Jan 19, 2017 at 10:41 PM, Stefan Eissing > wrote: >>> >>> We really need to not destroy m->pool in its parent's cleanup. >> >> Hmm, why is that bad? > > If the parent pool cleanup

Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c

2017-01-19 Thread Stefan Eissing
Have to sleep over this. But I agree that this area needs some change. > Am 19.01.2017 um 23:31 schrieb Yann Ylavic : > > On Thu, Jan 19, 2017 at 10:58 PM, Yann Ylavic wrote: >> On Thu, Jan 19, 2017 at 10:41 PM, Stefan Eissing >>

Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c

2017-01-19 Thread Yann Ylavic
On Thu, Jan 19, 2017 at 10:58 PM, Yann Ylavic wrote: > On Thu, Jan 19, 2017 at 10:41 PM, Stefan Eissing > wrote: >> >> Would work. But then we could just never destroy this directly, >> because it will always disappear via the parent h2_session

Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c

2017-01-19 Thread Yann Ylavic
On Thu, Jan 19, 2017 at 10:41 PM, Stefan Eissing wrote: >> >> We really need to not destroy m->pool in its parent's cleanup. > > Hmm, why is that bad? If the parent pool cleanup is called, that pool is being destroyed, which also destroys all its children pools (for

Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c

2017-01-19 Thread Stefan Eissing
> Am 19.01.2017 um 22:38 schrieb Yann Ylavic : > > On Thu, Jan 19, 2017 at 10:09 PM, wrote: >> Author: icing >> Date: Thu Jan 19 21:09:18 2017 >> New Revision: 1779528 >> >> URL: http://svn.apache.org/viewvc?rev=1779528=rev >> Log: >> On the trunk: >>

Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c

2017-01-19 Thread Yann Ylavic
On Thu, Jan 19, 2017 at 10:09 PM, wrote: > Author: icing > Date: Thu Jan 19 21:09:18 2017 > New Revision: 1779528 > > URL: http://svn.apache.org/viewvc?rev=1779528=rev > Log: > On the trunk: > > reverting change 1779525. We really need to not destroy m->pool in its parent's