Re: [MTCGA]: new failures in builds [4973730] needs to be handled

2020-01-30 Thread Denis Garus
Hello! I've created the task [1]. 1. https://issues.apache.org/jira/browse/IGNITE-12611 чт, 30 янв. 2020 г. в 20:56, : > Hi Igniters, > > I've detected some new issue on TeamCity to be handled. You are more than > welcomed to help. > > If your changes can lead to this failure(s): We're

Re: Internal classes are exposed in public API

2020-01-30 Thread Pavel Tupitsyn
Agree with Andrey, let's remove deprecation for now and unblock the release. On Thu, Jan 30, 2020 at 10:23 PM Andrey Gura wrote: > I'll just repeat one thought with some changes. > > There are at least two groups of people in this discussion. One group > sure that new API is complete and

[jira] [Created] (IGNITE-12611) EntryProcessorPermissionCheckTest.test: Test looks flaky

2020-01-30 Thread Denis Garus (Jira)
Denis Garus created IGNITE-12611: Summary: EntryProcessorPermissionCheckTest.test: Test looks flaky Key: IGNITE-12611 URL: https://issues.apache.org/jira/browse/IGNITE-12611 Project: Ignite

[MTCGA]: new failures in builds [4972431] needs to be handled

2020-01-30 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to

[MTCGA]: new failures in builds [4972383] needs to be handled

2020-01-30 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to

Re: CompactFooter for ClientBinaryMarshaller

2020-01-30 Thread tschauenberg
Igor, can you have a look at https://issues.apache.org/jira/browse/IGNITE-12003 and link it to https://issues.apache.org/jira/browse/IGNITE-10960? Using Java 2.7.0 thin client, Java 2.7.0 thick client and Java 2.7.0 Ignite servers I first hit IGNITE-10960 and then reading your comments and the

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Alexey Goncharuk
Because originally the sole purpose of deactivation was resource deallocation. чт, 30 янв. 2020 г. в 22:13, Denis Magda : > Such a revelation for me that data is purged from RAM if someone > deactivates the cluster. Alex, do you remember why we decided to implement > it this way initially? > > -

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Gura
I'll just repeat one thought with some changes. There are at least two groups of people in this discussion. One group sure that new API is complete and production ready while other group disagree with it. Obviously we can't reach consensus about it right now. But we can do it in the future. At

Re: Native Persistence & JDBC

2020-01-30 Thread Denis Magda
Forwarding this thread to the dev list. Ignite SQL experts, could you check this thread and create a proper ticket for this minor usability improvement? Probably, the ticket is not even needed. Basically, our driver reports this error - *SQLException: Client is invalid. Probably cache name is

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Denis Magda
Such a revelation for me that data is purged from RAM if someone deactivates the cluster. Alex, do you remember why we decided to implement it this way initially? - Denis On Thu, Jan 30, 2020 at 2:09 AM Alexey Goncharuk wrote: > I agree on CLI and JMX because those interfaces can be used by a

[MTCGA]: new failures in builds [4973730] needs to be handled

2020-01-30 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to

Re: Internal classes are exposed in public API

2020-01-30 Thread Nikolay Izhikov
Alexey. I answered to your examples and issues you provide. But, it seems the discussion of the API and the Java code itself is not the goal of this thread anymore. > Should we provide a way to know the number of metrics and registries in > advance? No. If you think this is the real use-as

Re: Contribution

2020-01-30 Thread Denis Magda
Nikolay, Andrey, Would you be the best committers to help out here? You are already deeply involved in metrics development and can quickly suggest Lev how to proceed with this task. - Denis On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев wrote: > Hello everyone, I have question about following

Re: Internal classes are exposed in public API

2020-01-30 Thread Denis Magda
Folks, seriously, we should deprecate an existing API only after the new one is no longer considered experimental. There might be API and configuration changes in the experimental API before it's announced as GA. I would encourage us to do this properly - let's release the new APIs labeling them

Re: Internal classes are exposed in public API

2020-01-30 Thread Alexey Goncharuk
Nikita, Disagree here. I already gave an example in this thread of how you need to peek into configuration in order to obtain an instance of exporter SPI which may not necessarily be the type you need. That's why IGNITE-12553 was created in the first place.

Re: [IGNITE-12582] Configuration by property

2020-01-30 Thread Seliverstov Igor
Isn't a better way just to add a new annotation? Like RepositoryConfig but from v2 package for example. This case whose who already use it won't suffer. Also it's would be great to provide a way to escape constants which are similar to spel expressions. Regards, Igor чт, 30 янв. 2020 г.,

[jira] [Created] (IGNITE-12610) Disable H2 object cache reliably

2020-01-30 Thread Ivan Pavlukhin (Jira)
Ivan Pavlukhin created IGNITE-12610: --- Summary: Disable H2 object cache reliably Key: IGNITE-12610 URL: https://issues.apache.org/jira/browse/IGNITE-12610 Project: Ignite Issue Type: Bug

Re: Cache 6 suite is broken

2020-01-30 Thread Ivan Pavlukhin
Zhenya, Good news! Could you please tell what is the root cause and how did you fix it? вт, 28 янв. 2020 г. в 18:58, Zhenya Stanilovsky : > > > > Looks like i found problem root cause, first run completed on TC, hope it > would be ok with other builds. > > > > > > >--- Forwarded message

Re: Internal classes are exposed in public API

2020-01-30 Thread Nikita Amelchev
Folks, I have some experience using the new metrics API. The new format is easy to use from the user point and approved by the community. It provides a single metric format and one entry point. I believe that they are able to replace existing ones. I don't see any issues with the new metrics. The

[jira] [Created] (IGNITE-12609) SQL: GridReduceQueryExecutor refactoring.

2020-01-30 Thread Andrey Mashenkov (Jira)
Andrey Mashenkov created IGNITE-12609: - Summary: SQL: GridReduceQueryExecutor refactoring. Key: IGNITE-12609 URL: https://issues.apache.org/jira/browse/IGNITE-12609 Project: Ignite Issue

Re: Apache Ignite contribution

2020-01-30 Thread Ivan Pavlukhin
> I'll suggest to add this links with explanation for newcomers (not only "how > to contribute" but and "where to ask" and "who could help me with this task") "who could help me with this task" sounds very important to attract new contributors. Regardless having channels for all kind of

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Gura
> We doesn’t come to an agreement that API should be changed. > We should discuss the design of the Metric API and your proposals for it in > another thread. > Please, avoid arguments like «this API will be 100% changed» in this > discussion. I just explain why this item is acceptable to me. I

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Mashenkov
Hi Igniters, Let me share some thoughts. Abstractly. 1. @Experimental API. When user see API marked as experimental usually it is a red flag for using such API in prod and also he can't count the API stability: - API itself if not stable and one can have compilation issues with next versions at

Re: Internal classes are exposed in public API

2020-01-30 Thread Alexey Goncharuk
чт, 30 янв. 2020 г. в 15:18, Anton Vinogradov : > We should have all the options. > > Deprecated -> will be removed at major release (because this way is slow or > overcomplicated) but still be used now, > Not only does it mean that the API should be removed in a major release, but there is a

Re: Internal classes are exposed in public API

2020-01-30 Thread Anton Vinogradov
>> . Remove @Deprecated from old API (because it strange to have one >> deprecated API and second experimental API) >> 2. Add @IgniteExperimetnal to new API (because... see item. 1) -1 We should have all the options. Deprecated -> will be removed at major release (because this way is slow or

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-30 Thread Alexey Goncharuk
Sounds good, will do!

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-30 Thread Maxim Muzafarov
Alexey, Let's merge these issues [1] [2] to the master branch first and wait for a couple of days to collect test statistics. My fears based on the fact not getting new regression flaky failures for the release branch as we've got here [3] [4]. [1]

Re: [MTCGA]: new failures in builds [4939116] needs to be handled

2020-01-30 Thread Maxim Muzafarov
Igniters, It seems that the issue will be solved under [1] JIRA ticket. [1] https://issues.apache.org/jira/browse/IGNITE-12601 On Fri, 24 Jan 2020 at 15:06, Maxim Muzafarov wrote: > > Folks, > > > This test began to constantly fail in the master branch [2] and the > 2.8 [1] also. It seems

[jira] [Created] (IGNITE-12608) [ignite-extensions] Setup tests for ignite-client-spring-boot-autoconfigure, ignite-spring-boot-autoconfigure on TC

2020-01-30 Thread Nikolay Izhikov (Jira)
Nikolay Izhikov created IGNITE-12608: Summary: [ignite-extensions] Setup tests for ignite-client-spring-boot-autoconfigure, ignite-spring-boot-autoconfigure on TC Key: IGNITE-12608 URL:

Re: Internal classes are exposed in public API

2020-01-30 Thread Nikolay Izhikov
Hello. > 2. Add @IgniteExperimetnal to new API (because... see item. 1 +1 > 1. Remove @Deprecated from old API (because it strange to have one deprecated > API and second experimental API) -1 I propose to update deprecation message and provide metric name for each deprecated method. >

[jira] [Created] (IGNITE-12607) PartitionsExchangeAwareTest is flaky

2020-01-30 Thread Ivan Rakov (Jira)
Ivan Rakov created IGNITE-12607: --- Summary: PartitionsExchangeAwareTest is flaky Key: IGNITE-12607 URL: https://issues.apache.org/jira/browse/IGNITE-12607 Project: Ignite Issue Type: Bug

Re: Internal classes are exposed in public API

2020-01-30 Thread Andrey Gura
>From my point of view we still don't have consensus. I think we should do at least the following: 1. Remove @Deprecated from old API (because it strange to have one deprecated API and second experimental API) 2. Add @IgniteExperimetnal to new API (because... see item. 1) 3. Do not merge

Re: [DISCUSS] Merge PR via GitHub web UI

2020-01-30 Thread Ivan Pavlukhin
Great news! Thank you Pavel! чт, 30 янв. 2020 г. в 14:14, Pavel Tupitsyn : > > It's done, only Squash mode is enabled in GitHub UI. > > On Mon, Jan 27, 2020 at 5:05 PM Pavel Tupitsyn wrote: > > > INFRA ticket filed: > > https://issues.apache.org/jira/browse/INFRA-19778 > > > > On Mon, Jan 27,

Re: [DISCUSS] Merge PR via GitHub web UI

2020-01-30 Thread Pavel Tupitsyn
It's done, only Squash mode is enabled in GitHub UI. On Mon, Jan 27, 2020 at 5:05 PM Pavel Tupitsyn wrote: > INFRA ticket filed: > https://issues.apache.org/jira/browse/INFRA-19778 > > On Mon, Jan 27, 2020 at 4:38 PM Alexey Zinoviev > wrote: > >> I used squash for last two years, no problemo

Contribution

2020-01-30 Thread Лев Киселев
Hello everyone, I have question about following task: [https://issues.apache.org/jira/browse/IGNITE-10698] Solution proposed in task description is seem to be logical. So, I need to every replace @MXBeanParametersNames and @MXBeanParametersDescriptions (everywhere, for uniformity) with something

[IGNITE-12582] Configuration by property

2020-01-30 Thread Sergey Chernolyas
Hi igniters! Presently, Spring Data for Ignite can't be configured dynamically. I mean , than I defines repository by the code: @Repository @RepositoryConfig(cacheName = "Calendar") public interface CalendarRepository extends IgniteRepository { List findByName(String name); } But I need to

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Alexey Goncharuk
I agree on CLI and JMX because those interfaces can be used by a system administrator and can be invoked by mistake. As for the Java API, personally, I find it strange to add 'force' or 'confirm' flags to it because it is very unlikely that such an invocation is done by mistake. Such mistakes are

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Nikolay Izhikov
As far as I know we have several places to manage cluster state: 1. Java API - Ignite#cluster#state 2. CLI utility - control.sh 3. JMX beans(can we manage cluster state from JMX?) I think we should add new parameter to the all management APIs. What do you think? > 30 янв. 2020 г., в 12:51,

[IGNITE-12582] Configuration by property

2020-01-30 Thread Sergey Chernolyas
Hi igniters! I would ask you to estimate the proposed solution and say how correct is. It is proposed to set repository name by Spring Expression Language. But ... it leads one question for discussion. Where do we need to write the expression? I see two options: 1) at field "cacheName". The code

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Alexey Goncharuk
Nikolay, This change will affect only the command-line utility, correct? No changes for the public API are planned? чт, 30 янв. 2020 г. в 12:46, Nikolay Izhikov : > Hello, Alexey. > > Thanks for the feedback. > It seems for me as a very unexpected behavior from the users point of view. > > I

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Nikolay Izhikov
Hello, Alexey. Thanks for the feedback. It seems for me as a very unexpected behavior from the users point of view. I propose to do the following: * Update Ignite documentation and write down the fact that in-memory cache cleared on deactivation. * Disallow, by default, deactivation of the

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-30 Thread Alexey Goncharuk
Maxim, I received no updates from the IGNITE-12456 reporter and from the ticket description it does not look like a corruption, so I'm moving this ticket to 2.9 (or 2.8.1 if it will be required). Anton, Do you have any updates on IGNITE-12489? вт, 28 янв. 2020 г. в 19:29, Maxim Muzafarov : >

Re: Internal classes are exposed in public API

2020-01-30 Thread Alexey Goncharuk
Folks, I tried to re-read the whole thread and honestly got lost at the end :) Do we have a consensus (if yes, what are the steps?) or should we have a call as Maxim suggested? I think it is in our best interest to get this agreed upon fast to release AI 2.8 soon.

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-01-30 Thread Alexey Goncharuk
Nikolay, Inactive state deallocates all possible resources by design, including the data regions. If data region is not backed by a persistent storage, the data is lost, this is an expected behavior. ср, 29 янв. 2020 г. в 19:18, Nikolay Izhikov : > Hello, Igniters. > > I found really confusing

Re: Ignite Extension - TC link

2020-01-30 Thread Nikolay Izhikov
I don’t have permissions for this project. Please, give me admin access for it. I want to setup tests for the new spring auto configure modules. > 30 янв. 2020 г., в 05:11, Saikat Maitra написал(а): > > Hi Nikolay, > > Please find the TC link below > >

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-30 Thread Maxim Muzafarov
Ilya, +1 to disable auto-adjustment by default It seems the same approach can be used as implemented for disabling pme-free [1]. [1] https://jira.apache.org/jira/browse/IGNITE-12470 On Wed, 29 Jan 2020 at 20:16, Ilya Kasnacheev wrote: > Hello! > > Actually, it seems to me that such scenario