Re: SQL query timeout: in progress or abandoned

Replied in JIRA Thanks On Sat, Nov 9, 2019 at 3:13 AM Saikat Maitra wrote: > Pavel Tupitsyn, Igor Sapego > > I wanted to connect and confirm on changes for this PR. > > https://github.com/apache/ignite/pull/6490 > > Do you think keeping the change for PlatformConfigurationUtils.java will >

Re: SQL query timeout: in progress or abandoned

Pavel Tupitsyn, Igor Sapego I wanted to connect and confirm on changes for this PR. https://github.com/apache/ignite/pull/6490 Do you think keeping the change for PlatformConfigurationUtils.java will cause regression on the .NET component or C++ components? Jira :

Re: SQL query timeout: in progress or abandoned

Hi Saikat, Sorry for delay. I will do my best to check it in the beginning of this week. сб, 12 окт. 2019 г. в 08:15, Saikat Maitra : > > Hello Ivan, > > I have updated the PR as per our discussion. > > Please review and share your feedback. > > Regards, > Saikat > > On Sun, Sep 1, 2019 at 3:20

Re: SQL query timeout: in progress or abandoned

Hello Ivan, I have updated the PR as per our discussion. Please review and share your feedback. Regards, Saikat On Sun, Sep 1, 2019 at 3:20 PM Saikat Maitra wrote: > Hi Ivan, > > I have taken care of review comments and also have shared a question for > the application of default Query

Re: SQL query timeout: in progress or abandoned

Hi Ivan, I have taken care of review comments and also have shared a question for the application of default Query timeout value. Can you please review and share feedback? Regards, Saikat On Sat, Aug 24, 2019 at 7:22 PM Saikat Maitra wrote: > Hi Ivan, > > Thank you, I have shared my comments

Re: SQL query timeout: in progress or abandoned

Hi Ivan, Thank you, I have shared my comments and have few questions related to the issue. Please take a look and share your thoughts. Regards, Saikat On Tue, Aug 20, 2019 at 4:03 PM Павлухин Иван wrote: > Hi Saikat, > > I left a comment in JIRA ticket [1]. Also, I invited Andrey to help >

Re: SQL query timeout: in progress or abandoned

Hi Saikat, I left a comment in JIRA ticket [1]. Also, I invited Andrey to help with a further review. Andrey, could you please step in and continue the review? Unfortunately, for a couple of weeks I have limited access to my computer and cannot do a review in a timely manner. [1]

Re: SQL query timeout: in progress or abandoned

Hi Ivan, I have updated the PR and made changes in IgniteH2Indexing for query timeout so that default query timeout get used during query execution. Please take a look and let me know if this change looks good. I will update tests if the approach looks good. PR

Re: SQL query timeout: in progress or abandoned

Hi Ivan, Denis Thank you for your feedback, I am looking into the changes needed for this issue. I am also looking into these configurations parameters https://apacheignite.readme.io/v2.2/docs/configuration-parameters to see if there are similar attributes being used in SqlFieldsQuery and

Re: SQL query timeout: in progress or abandoned

Saikat, Denis, I left comments in the ticket [1]. [1] https://issues.apache.org/jira/browse/IGNITE-7285 вт, 13 авг. 2019 г. в 21:53, Denis Magda : > > Hi Saikat, > > Thanks for a quick turnaround! Ivan, could you please step in and do a > review? > > - > Denis > > > On Sun, Aug 11, 2019 at 6:26

Re: SQL query timeout: in progress or abandoned

Hi Saikat, Thanks for a quick turnaround! Ivan, could you please step in and do a review? - Denis On Sun, Aug 11, 2019 at 6:26 AM Saikat Maitra wrote: > Hi Denis, Ivan > > As discussed I have updated the PR and incorporated review comments. > >

Re: SQL query timeout: in progress or abandoned

Hi Denis, Ivan As discussed I have updated the PR and incorporated review comments. https://github.com/apache/ignite/pull/6490/files Please take a look and share your feedback. Regard, Saikat On Sat, Aug 10, 2019 at 5:51 PM Saikat Maitra wrote: > Hello Denis, Ivan > > Yes, I can take up

Re: SQL query timeout: in progress or abandoned

Hello Denis, Ivan Yes, I can take up the changes for IGNITE-7825. I had a doubt on the usage of the Default Query Timeout. I had raised the PR in an assumption that Default Query Timeout will only be used if user had not provided Cache Query Timeout

Re: SQL query timeout: in progress or abandoned

Ivan, thanks for sharing this discussion. Let's use it for our conversation. - Denis On Thu, Aug 8, 2019 at 11:15 PM Павлухин Иван wrote: > Just for the protocol. There was an original dev-list discussion [1]. > Added a link to the ticket as well. > > [1] >

Re: SQL query timeout: in progress or abandoned

Just for the protocol. There was an original dev-list discussion [1]. Added a link to the ticket as well. [1] http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-7285-Add-default-query-timeout-td41828.html пт, 9 авг. 2019 г. в 01:22, Denis Magda : > > Hey Saikat, > > Are you still

SQL query timeout: in progress or abandoned

Hey Saikat, Are you still working on this ticket? https://issues.apache.org/jira/browse/IGNITE-7285 Seems that's the last API that doesn't support timeouts - JDBC and ODBC drivers already go with it. If you don't have time to complete the changes then someone else from the community can take