Re: Please a reviewer for the case IGNITE-12518

2020-01-23 Thread Luis Arce
Hi Saikat, Thanks for you response: My system need a web server for work. i work correctly with Wildfly and i use Ignite as Backend for database. My problem is the combination of both is around 6 GB RAM for work in the VPS. For this reason i modified the unique plugin with webserver inside

Re: Ignite-spring-boot-autoconfigurer

2020-01-23 Thread Saikat Maitra
Hi Nikolay, Thank you for updating the PR, the changes looks good. Regards, Saikat On Wed, Jan 22, 2020 at 1:33 PM Николай Ижиков wrote: > Hello, Saikat. > > Thank you so much for the review. > > I answered your questions and resolve all the comments. > Please, take a look, one more time. > >

Re: Internal classes are exposed in public API

2020-01-23 Thread Николай Ижиков
> You want say didn't discuss? Yes. > Secondly, yes it took a lot of time due to a lot of changes. Is it problem? No, of course. My point - that your contribution that took a long time, already, can’t be an argument to postpone creation of the API in the current release. > 23 янв. 2020 г., в

Re: Internal classes are exposed in public API

2020-01-23 Thread Andrey Gura
> We don’t discuss your changes and your proposals for the Metric API. You want say didn't discuss? Actually we did it [1] but you told ok let's see code :) > So I don’t think we can make the existence of some PR is an argument to > introduce(or not introduce) this facade. You definitely right

[jira] [Created] (IGNITE-12573) Copy ML dependencies to other standalone pom files in examples

2020-01-23 Thread Stepan Pilschikov (Jira)
Stepan Pilschikov created IGNITE-12573: -- Summary: Copy ML dependencies to other standalone pom files in examples Key: IGNITE-12573 URL: https://issues.apache.org/jira/browse/IGNITE-12573

Re: Internal classes are exposed in public API

2020-01-23 Thread Николай Ижиков
Andrey. > IGNITE-11927 implementation so your changes are incompatible with my changes We don’t discuss your changes and your proposals for the Metric API. So I don’t think we can make the existence of some PR is an argument to introduce(or not introduce) this facade. Moreover, As far as I

Re: Feature masks for thin clients

2020-01-23 Thread Pavel Tupitsyn
Igor, great idea, I think this should be our priority for all thin clients. Alexei, protocol version bump can be still required for major changes (e.g. if we want to change handshake format). But for simpler things like new features that don't affect existing ones, feature masks allow us to keep

Re: Add user attributes to thin clients

2020-01-23 Thread Pavel Tupitsyn
> Well, my understanding was a binary object with compact footer = false is totally standalone entity and can be read without any external metadata Not exactly: type name and field names are unknown, you only have typeId, field ids and positions. There is one more Marshaller "mode":

Re: Internal classes are exposed in public API

2020-01-23 Thread Andrey Gura
Nikolay, as I wrote early in this thread API significantly changed during IGNITE-11927 implementation so your changes are incompatible with my changes. ReadOnlyMetricRegistry will be removed at all (still exists in a couple of places where it uses). Also I don't want to introduce IgniteMetric

[jira] [Created] (IGNITE-12572) Get rid of synchronous cache destroying in multiple caches group.

2020-01-23 Thread Alexey Scherbakov (Jira)
Alexey Scherbakov created IGNITE-12572: -- Summary: Get rid of synchronous cache destroying in multiple caches group. Key: IGNITE-12572 URL: https://issues.apache.org/jira/browse/IGNITE-12572

[jira] [Created] (IGNITE-12571) Statistics of query cache statements

2020-01-23 Thread Konstantin Orlov (Jira)
Konstantin Orlov created IGNITE-12571: - Summary: Statistics of query cache statements Key: IGNITE-12571 URL: https://issues.apache.org/jira/browse/IGNITE-12571 Project: Ignite Issue

Re: [MTCGA]: new failures in builds [4944565] needs to be handled

2020-01-23 Thread Alex Plehanov
Ivan, yes, it's https://issues.apache.org/jira/browse/IGNITE-12562 The ticket is already fixed, tests passed. Zhenya Stanilovsky has agreed to have a look at fix in the near future (when hi will have some time). But I would appreciate it if someone else reviews the ticket shortly. It's just a

Re: Re[4]: Text queries/indexes (GridLuceneIndex, @QueryTextFiled)

2020-01-23 Thread Yuriy Shuliga
Hi Ivan, Actually I have engaged another developer to help bring TextQueries to correctly working state. For now we have solution that adds Ordering functionality to distributed TextQueries . This is developed and tested locally. I can share details here, then we can discuss and decide whether to

Re: AWS EBS Discovery: Contributor Wanted

2020-01-23 Thread Emmanouil Gkatziouras
Hi all! Yes It seems possible to get some free quota for integration tests on AWS [1] however most probably they are not gonna last forever. [1] https://aws.amazon.com/blogs/opensource/aws-promotional-credits-open-source-projects/ King Regards *Emmanouil Gkatziouras* https://egkatzioura.com/ |

Re: [MTCGA]: new failures in builds [4944565] needs to be handled

2020-01-23 Thread Ivan Pavlukhin
Sorry, missed it https://issues.apache.org/jira/browse/IGNITE-12562 чт, 23 янв. 2020 г. в 16:30, Ivan Pavlukhin : > > Do we have a ticket for it? > > ср, 22 янв. 2020 г. в 09:21, Alex Plehanov : > > > > It was caused by my fix. I will try to fix it shortly. > > > > > > ср, 22 янв. 2020 г. в

Re: [MTCGA]: new failures in builds [4944565] needs to be handled

2020-01-23 Thread Ivan Pavlukhin
Do we have a ticket for it? ср, 22 янв. 2020 г. в 09:21, Alex Plehanov : > > It was caused by my fix. I will try to fix it shortly. > > > ср, 22 янв. 2020 г. в 00:56, : > > > Hi Igniters, > > > > I've detected some new issue on TeamCity to be handled. You are more than > > welcomed to help. > >

Re: Apache Ignite contribution

2020-01-23 Thread Ilya Kasnacheev
Hello! I have added you to Contributors of our project, you can now assign issues to yourself. Please read https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute Regards, -- Ilya Kasnacheev чт, 23 янв. 2020 г. в 15:31, Лев Киселев : > Hello, > I want to take part in the

Re: Feature masks for thin clients

2020-01-23 Thread Taras Ledkov
Alexei, After the flags is introduced we can change the flag set instead of change protocol version. Of course, we will need to up the protocol  version for introducing flags. On 23.01.2020 15:47, Alexei Scherbakov wrote: Igor Sapego, I do not understand how feature masks can remove the

Re: Feature masks for thin clients

2020-01-23 Thread Taras Ledkov
Hi, The great idea! What do you think about thin JDBC and ODBC? Should we have common feature flags set and client specific feature flag set? Or each client has independent flags set even if they are duplicated? On 23.01.2020 15:36, Igor Sapego wrote: Hi Igniters, As we have a lot of

Feature masks for thin clients

2020-01-23 Thread Igor Sapego
Hi Igniters, As we have a lot of different thin clients now, maintained by different people, the issues with our backward compatibility mechanism becomes more and more prominent. Currently, we use protocol versioning as the only approach to provide backward compatibility. The main issue of this

Apache Ignite contribution

2020-01-23 Thread Лев Киселев
Hello, I want to take part in the development of Apache Ignite. Primary skills: Java SE, Java 8, Spring framework, SQL. Also: Multithreading (incl. FJP), Design Patterns, Algorithms and Data Structures. My JIRA ID: l4ndsc4pe Thanks.

Re: Add user attributes to thin clients

2020-01-23 Thread Dmitrii Ryabov
Alexei, yes, compactFooter is used only in 1 place. ``` BinaryWriterExImpl.marshal0() { BinaryClassDescriptor desc = ctx.descriptorForClass(cls); // descriptor transportation fails here ... desc.write(obj, this); // compactFooter here } ``` чт, 23 янв. 2020 г., 14:15 Pavel

Re: Add user attributes to thin clients

2020-01-23 Thread Pavel Tupitsyn
> If we support only strings it will be necessary to encode binary values to > something like BASE64 which is not sounds good from usability side There should be no need to put binary values to attributes. What's the use case? On Thu, Jan 23, 2020 at 2:08 PM Alexei Scherbakov <

Re: Add user attributes to thin clients

2020-01-23 Thread Alexei Scherbakov
> Footer is checked in postWrite - much later class descriptor check. Well, my understanding was a binary object with compact footer = false is totally standalone entity and can be read without any external metadata. Dmitrii Ryabov can you double check ? If we support only strings it will be

Re: Add user attributes to thin clients

2020-01-23 Thread Nikita Amelchev
+1 for the hardcoded String type only чт, 23 янв. 2020 г. в 13:15, Pavel Tupitsyn : > > - Cross-platform binary objects are totally possible, all those thin > clients support them. > - User attributes can be useful, no objections here > > However, I don't think we should allow arbitrary objects

Re: Add user attributes to thin clients

2020-01-23 Thread Pavel Tupitsyn
- Cross-platform binary objects are totally possible, all those thin clients support them. - User attributes can be useful, no objections here However, I don't think we should allow arbitrary objects in user attributes. Let's make them string only, much less to worry about. And using attributes

Re: Add user attributes to thin clients

2020-01-23 Thread Dmitrii Ryabov
> Even if compact footer is disabled ? Footer is checked in postWrite - much later class descriptor check. чт, 23 янв. 2020 г., 12:23 Alexei Scherbakov : > чт, 23 янв. 2020 г. в 12:17, Dmitrii Ryabov : > > > > The protocol must be language-agnostic. If we add some features there, > > let's make

Re: Add user attributes to thin clients

2020-01-23 Thread Alexei Scherbakov
чт, 23 янв. 2020 г. в 12:17, Dmitrii Ryabov : > > The protocol must be language-agnostic. If we add some features there, > let's make sure they are usable from anywhere. > > That's why I want to allow primitives only. Any language can send numbers > and strings. > In general it's possible to

Re: Add user attributes to thin clients

2020-01-23 Thread Dmitrii Ryabov
> The protocol must be language-agnostic. If we add some features there, let's make sure they are usable from anywhere. That's why I want to allow primitives only. Any language can send numbers and strings. Binary marshaller, before packing object to byte[], will try to use discovery processor

Re: Add user attributes to thin clients

2020-01-23 Thread Alex Plehanov
Hello, User attributes also (besides authentication) can be used to pass some info about an application that uses a client and then display this information in monitoring tools. Other vendors use such approach (Oracle DB, for example, have DBMS_APPLICATION_INFO package, PostgreeSQL have

Re: Add user attributes to thin clients

2020-01-23 Thread Alexei Scherbakov
Folks, I did the initial review for a contribution. The ultimate goal is to have the possibility to pass user defined attribute-value pairs in all types of clients, same as user attributes in java configuration [1]. Later they can be used on server side for various things, for example in

[jira] [Created] (IGNITE-12570) What is the root cause of IgniteCheckedException: Invalid handshake message

2020-01-23 Thread shubhendra sen (Jira)
shubhendra sen created IGNITE-12570: --- Summary: What is the root cause of IgniteCheckedException: Invalid handshake message Key: IGNITE-12570 URL: https://issues.apache.org/jira/browse/IGNITE-12570

Re: Apache Ignite 2.8 RELEASE [Time, Scope, Manager]

2020-01-23 Thread Ivan Bessonov
Hi igniters, there's a potential data corruption fix that I'd like you to include in the next release: https://issues.apache.org/jira/browse/IGNITE-12486https://issues.apache.org/jira/browse/IGNITE-12486 Can you please cherry-pick it? Thank