Re: Broken/Flaky Tests

Reminder that we've still got lots of open flaky issues: https://issues.apache.org/jira/issues/?jql=project%20% 3D%20IMPALA%20AND%20status%20in%20(Open%2C%20%22In% 20Progress%22%2C%20Reopened)%20AND%20labels%20in%20(Flaky% 2C%20broken-build)%20ORDER%20BY%20priority%20DESC Master has been healthy

Re: Broken/Flaky Tests

I'm concerned that for the last couple of days we've been finding new issues faster than we're fixing them. I'll start pushing back on some higher-risk changes (e.g. in race-prone parts of the code) until we've cleared up some of the issues. On Tue, Jun 12, 2018 at 1:31 PM, Tim Armstrong wrote:

Re: Broken/Flaky Tests

We still have a lot of broken build and flaky test issues open, so let's continue to be careful about what we merge: https://issues.apache.org/jira/issues/?jql=project%20%3D%20IMPALA%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20labels%20in%20(Flaky%2C%20broken-build)

Re: Broken/Flaky Tests

All of the major known issues except an S3 infra issue are fixed. We got broken in a minor way by a Hive change: https://issues.apache.org/jira/browse/IMPALA-7143 so I disabled the tests until we can sort that out. We should start to think about how to merge outstanding changes in an orderly way.

Re: UDA debugging, was Re: Broken/Flaky Tests

Hi! I have left some comments in the code (lines starting with /// ) + removed the md5 implementation parts to make the answer shorter. Note that I am not sure about the goal you want to achieve with the UDA - can you explain what countMD5 would be used for? > void md5(const unsigned char m

?????? UDA debugging, was Re: Broken/Flaky Tests

. -- -- ??: ""<865392...@qq.com>; : 2018??6??7??(??) 8:32 ??: "dev"; : ?? UDA debugging, was Re: Broken/Flaky Tests md5_udaf.h #ifndef _MD5_UDAF_H_ #define _MD5_UDAF_H_ #include&

?????? UDA debugging, was Re: Broken/Flaky Tests

r, 17); return StringVal(copy,17); } define function SQL in impala-shell: create aggregate function countMD5(string) returns string location 'hdfs://nameservice1:8020//user/hive/udfjars/libmd5udaf.so' init_fn='init_func' update_fn=

Re: Broken/Flaky Tests

We ran into some test issues cherry-picking the latest set of changes to 2.x. I pushed out a fix and I'm merging now. Once that is done the main build fixes should be on both 2.x and master. On Tue, Jun 5, 2018 at 6:08 PM, Tim Armstrong wrote: > Ok, so 2/3 of those fixes are merged and the other

Re: UDA debugging, was Re: Broken/Flaky Tests

greener to C++. > Thank you,very much! > > > > > > -- 原始邮件 -- > *发件人:* "Tim Armstrong"; > *发送时间:* 2018年6月6日(星期三) 中午12:38 > *收件人:* "dev"; > *主题:* Re: UDA debugging, was Re: Broken/Flaky Tests > > We're happ

?????? UDA debugging, was Re: Broken/Flaky Tests

-- -- ??: "Tim Armstrong"; ????: 2018??6??6??(??) 12:38 ??: "dev"; : Re: UDA debugging, was Re: Broken/Flaky Tests We're happy to give you pointers. If you could share your uda code and "c

?????? UDA debugging, was Re: Broken/Flaky Tests

-- -- ??: "Tim Armstrong"; : 2018??6??6??(??????) ????12:38 ??: "dev"; : Re: UDA debugging, was Re: Broken/Flaky Tests We're happy to give you pointers. If you could share your uda code and "create f

Re: UDA debugging, was Re: Broken/Flaky Tests

? > > > > > > > > > > -- 原始邮件 ------ > > 发件人: "Tim Armstrong"; > > 发送时间: 2018年6月6日(星期三) 上午9:08 > > 收件人: "dev@impala"; > > > > 主题: Re: Broken/Flaky Tests > > > > > > > >

UDA debugging, was Re: Broken/Flaky Tests

I get the null value every time. That is why? > > > > > -- 原始邮件 -- > 发件人: "Tim Armstrong"; > 发送时间: 2018年6月6日(星期三) 上午9:08 > 收件人: "dev@impala"; > > 主题: Re: Broken/Flaky Tests > > > > Ok, so 2/3 of those fix

?????? Broken/Flaky Tests

) 9:08 ??: "dev@impala"; ????: Re: Broken/Flaky Tests Ok, so 2/3 of those fixes are merged and the other is being merged. We still have a long list of flaky issues but I went through and we've either mitigated them or we're blocked on being able to repro them. I&#

Re: Broken/Flaky Tests

Ok, so 2/3 of those fixes are merged and the other is being merged. We still have a long list of flaky issues but I went through and we've either mitigated them or we're blocked on being able to repro them. I'll see how things look tomorrow, but if you have some low-risk changes in mind, let me k

Re: Broken/Flaky Tests

Things are starting to look healthier now. I went through the broken-build JIRAs and downgraded some of the infrequent infrastructure issues to critical so we have a clearer idea of what's actually breaking the build now versus what's an occasional infra issue: https://issues.apache.org/jira/issue

Re: Broken/Flaky Tests

While it may be frustrating to have 15 changes queued up, the goal is to get the builds green. Allowing changes that are deemed low risk won't help this cause. Let's concentrate on addressing the build issues

Re: Broken/Flaky Tests

So while its definitely better, there are still a large number of failing builds. We've been hit by at least: IMPALA-6642 , IMPALA-6956 , IMPALA-7101

Re: Broken/Flaky Tests

Hi Thomas, Can you give an update on where we are with the builds? We currently have ~15 changes with a +2: https://gerrit.cloudera.org/#/q/status:open+project:Impala-ASF+branch:master+label:Code-Review%253D2 Thanks, Lars On Fri, May 25, 2018 at 5:20 PM, Henry Robinson wrote: > +1 - thanks fo

Re: Broken/Flaky Tests

+1 - thanks for worrying about build health. On 25 May 2018 at 17:18, Jim Apple wrote: > Sounds good to me. Thanks for taking ownership! > > On Fri, May 25, 2018 at 5:10 PM Thomas Tauber-Marshall < > tmarsh...@cloudera.com> wrote: > > > Hey Impala community, > > > > There seems to have been an u

Re: Broken/Flaky Tests

Sounds good to me. Thanks for taking ownership! On Fri, May 25, 2018 at 5:10 PM Thomas Tauber-Marshall < tmarsh...@cloudera.com> wrote: > Hey Impala community, > > There seems to have been an unusually large number of flaky or broken tests > < > https://issues.apache.org/jira/browse/IMPALA-7073?j

Broken/Flaky Tests

Hey Impala community, There seems to have been an unusually large number of flaky or broken tests cropp