reschke merged PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1367684369
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1367684369
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366999447
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366990047
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366990047
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#issuecomment-1772704828
@smiroslav , its working fine on my system, I ran the same command and it
executed successfully.
% mvn clean install -Dtest=AzureRepositoryLockTest
[INFO] Scanning for
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1362470833
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
smiroslav commented on PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#issuecomment-1766591419
Got an error running the test in oak-segment-azure
```
> mvn clean install -Dtest=AzureRepositoryLockTest
...
[INFO] T E S T S
[INFO]
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1361878571
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1361878571
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1361859235
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1361859235
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1360591727
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1360590863
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1354338494
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1354338494
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1354326449
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
My bad, I added the new dependency of testcontainers but
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1354326449
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
my bad, I added the new dependency of testcontainers but
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352503502
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352344860
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
I was/am confused because I would have assumed that
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352342828
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
No, testcontainers dependency is defined under
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352270547
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352268966
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352092119
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352130678
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
But isn't that automatically inherited?
--
This is
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352125451
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
oak-lucene uses the MongoConnectionFactory in IT(s)
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352125451
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
oak lucene uses the MongoConnectionFactory in IT(s)
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352117183
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352111852
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352093896
##
oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzuriteDockerRule.java:
##
@@ -16,55 +16,88 @@
*/
package
31 matches
Mail list logo
