[GitHub] jena issue #503: JENA-1645: Use uri predicate in concrete subject query.

2018-12-05 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/503 cc @osma @xristy for review as main devs in this area ---

[GitHub] jena pull request #501: JENA-1643: Use transactional dataset in clear().

2018-11-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/501#discussion_r237831448 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/store/GraphTDB.java --- @@ -171,7 +171,10 @@ protected final int graphBaseSize() { @Override

[GitHub] jena pull request #492: JENA-1623: Endpoint access control lists

2018-11-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/492#discussion_r235398663 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuilder.java --- @@ -70,16 +69,42 @@ public static void

[GitHub] jena pull request #492: JENA-1623: Endpoint access control lists

2018-11-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/492#discussion_r235395467 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuilder.java --- @@ -70,16 +69,42 @@ public static void

[GitHub] jena pull request #492: JENA-1623: Endpoint access control lists

2018-11-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/492#discussion_r235394477 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/auth/AuthPolicy.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache

[GitHub] jena issue #489: Merged store literals once for JENA-1630

2018-11-14 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/489 So basically this is just avoiding redundantly storing the literal value multiple times. The actual literal value is always stored at least once but may be indexed multiple times in many non

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs Agreed, many folks are going to migrate Java 8 -> Java 11 because of the LTS release status are are skipping interim versions ---

[GitHub] jena pull request #476: Fix JDK10 Build (JENA-1609)

2018-10-03 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/476 Fix JDK10 Build (JENA-1609) Simplified version of PR #474 avoiding the dependency weirdness by adding the missing dependency only for the execution of the Javadoc plugin on the offending module

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 I think there is a simpler solution to this, I have Jena JDBC building locally under JDK10 and will push a new PR shortly ---

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r222388084 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs https://github.com/rvesse/airline/blob/master/pom.xml#L495-L497 which I discovered via JIRA https://issues.apache.org/jira/browse/MJAVADOC-475 ---

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-02 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs For some projects where I have added JDK 9/10 support I have had to create separate profiles activated by JDK version for the Javadoc plugin because there are breaking changes between the plugin

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221884001 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221885106 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT

[GitHub] jena pull request #465: JENA-1594: Per-graph access control for Fuseki

2018-08-28 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/465#discussion_r213250204 --- Diff: jena-fuseki2/jena-fuseki-access/src/main/java/org/apache/jena/fuseki/access/DataAccessCtl.java --- @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] jena pull request #465: JENA-1594: Per-graph access control for Fuseki

2018-08-28 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/465#discussion_r213249005 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/DatasetGraphFilteredView.java --- @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #463: Cleanup

2018-08-20 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r211191248 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/DynamicDatasets.java --- @@ -56,8 +55,8 @@ public static DatasetGraph dynamicDataset

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-13 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209539897 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java --- @@ -288,28 +294,77 @@ protected void execDeleteItem

[GitHub] jena pull request #449: JENA-1578

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r207151396 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1739,250 @@ public String toString

[GitHub] jena pull request #449: JENA-1578

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r207152306 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1739,250 @@ public String toString

[GitHub] jena pull request #449: JENA-1578

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r207148170 --- Diff: jena-arq/src/test/java/org/apache/jena/query/TestParameterizedSparqlString.java --- @@ -1925,4 +1926,190 @@ public void test_param_string_bug_04

[GitHub] jena pull request #449: JENA-1578

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r207150857 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1739,250 @@ public String toString

[GitHub] jena pull request #449: JENA-1578

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r207147377 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1739,250 @@ public String toString

[GitHub] jena pull request #449: JENA-1578

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r207150287 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1739,250 @@ public String toString

[GitHub] jena pull request #449: JENA-1578

2018-07-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r206083636 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1739,237 @@ public String toString

[GitHub] jena pull request #441: Improved Travis Configuration

2018-06-28 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/441 Improved Travis Configuration - Skips Travis install phase - Test on both Oracle and Open JDK - Build full profile - Fix environment specification You can merge this pull request

[GitHub] jena pull request #440: Fix SSE parsing on table with boolean values (JENA-1...

2018-06-27 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/440#discussion_r198545901 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/syntax/TestSSE_Builder.java --- @@ -233,4 +249,42 @@ public void testBuildExpr_14

[GitHub] jena pull request #440: Fix SSE parsing on table with boolean values (JENA-1...

2018-06-27 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/440#discussion_r198490652 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/syntax/TestSSE_Builder.java --- @@ -233,4 +249,42 @@ public void testBuildExpr_14

[GitHub] jena pull request #440: Fix SSE parsing on table with boolean values (JENA-1...

2018-06-27 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/440#discussion_r198489213 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/syntax/TestSSE_Builder.java --- @@ -233,4 +247,54 @@ public void testBuildExpr_14

[GitHub] jena pull request #440: Fix SSE parsing on table with boolean values (JENA-1...

2018-06-27 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/440#discussion_r198484085 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/syntax/TestSSE_Builder.java --- @@ -233,4 +247,54 @@ public void testBuildExpr_14

[GitHub] jena pull request #440: Fix SSE parsing on table with boolean values (JENA-1...

2018-06-27 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/440#discussion_r198484184 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/syntax/TestSSE_Builder.java --- @@ -233,4 +247,54 @@ public void testBuildExpr_14

[GitHub] jena pull request #440: Fix SSE parsing on table with boolean values (JENA-1...

2018-06-27 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/440 Fix SSE parsing on table with boolean values (JENA-1566) JENA-1566 reports an issue with round tripping through SSE of tables that contain boolean literals i.e. `true` and `false

[GitHub] jena issue #439: JENA-1565: Print the throwable and stacktrace

2018-06-25 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/439 @afs If you want to merge this now I was about to cut the RC for 3.8.0 ---

[GitHub] jena issue #439: JENA-1565: Print the throwable and stacktrace

2018-06-25 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/439 Do you want this in 3.8.0? ---

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/436 @xristy I think you can just merge as you would normally though you probably need to be explicit about the remote and branch you are using for remote operations: ``` > git checkout mas

[GitHub] jena pull request #433: JENA-1561: Enable TDB2 in Fuseki UI and on the comma...

2018-06-11 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/433#discussion_r194342614 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java --- @@ -351,15 +356,13 @@ private static void

[GitHub] jena pull request #431: JENA-1559: Alternative PrefixMapping implementation;...

2018-06-11 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/431#discussion_r194339397 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/PrefixMappingOver.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #431: JENA-1559: Alternative PrefixMapping implementation;...

2018-06-11 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/431#discussion_r194338419 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/PrefixMappingBase.java --- @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #431: JENA-1559: Alternative PrefixMapping implementation;...

2018-06-11 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/431#discussion_r194338879 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/PrefixMappingBase.java --- @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #431: JENA-1559: Alternative PrefixMapping implementation;...

2018-06-11 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/431#discussion_r194338271 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/PrefixMappingBase.java --- @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #426: JENA-1552: Phased loader

2018-06-04 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/426#discussion_r192681609 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/loader/parallel/LoaderPlan.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #426: JENA-1552: Phased loader

2018-06-04 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/426#discussion_r192680143 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/loader/parallel/LoaderPlan.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #426: JENA-1552: Phased loader

2018-06-04 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/426#discussion_r192680996 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/loader/parallel/LoaderPlan.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #414: JENA-1542: Integrate Lucene index in transaction lif...

2018-05-24 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/414#discussion_r190532549 --- Diff: jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/txn/TransactionCoordinator.java --- @@ -142,41 +141,56 @@ public

[GitHub] jena pull request #414: JENA-1542: Integrate Lucene index in transaction lif...

2018-05-24 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/414#discussion_r190533210 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/TestTextTxn.java --- @@ -0,0 +1,341 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #424: JENA-1550: TDB2 loader

2018-05-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/424#discussion_r189542354 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/loader/parallel/LoaderConst.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #424: JENA-1550: TDB2 loader

2018-05-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/424#discussion_r189542444 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/loader/parallel/LoaderParallel.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] jena pull request #424: JENA-1550: TDB2 loader

2018-05-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/424#discussion_r189542491 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/loader/parallel/LoaderParallel.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] jena pull request #424: JENA-1550: TDB2 loader

2018-05-21 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/424#discussion_r189540060 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Timer.java --- @@ -69,4 +69,13 @@ static public String timeStr(long timeInterval

[GitHub] jena pull request #407: Cleanup

2018-04-24 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/407#discussion_r183809337 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/store/DatasetGraphSwitchable.java --- @@ -111,7 +112,8 @@ public Graph getDefaultGraph

[GitHub] jena pull request #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/395#discussion_r181083359 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/filter/TestSelectiveFoldingFilter.java --- @@ -0,0 +1,135 @@ +/** + * Licensed

[GitHub] jena issue #393: JENA-1517: Implement missing override in OpVarsPattern visi...

2018-04-09 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/393 +1 ---

[GitHub] jena pull request #391: JENA-1516: ObjectFileStorage fix

2018-04-05 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/391#discussion_r179407258 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/lib/NodeLib.java --- @@ -53,26 +52,32 @@ // Characters in IRIs that are illegal and cause SSE

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 @xristy Yes I don't think there is any harm in supporting both the explicit form as well as supporting literal datatypes directly ---

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 Btw as you are now a committer you can follow the instructions at https://reference.apache.org/committer/github to get added to the Apache GitHub org so you'll show up as `Member` and not just

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 Looks like a really nice extension to the current machinery! I notice there is a unit test for the assembler support but no unit tests for using some of these new features, would it be possible

[GitHub] jena pull request #370: Fix delimiter parsing logic (JENA-1497)

2018-03-05 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/370 Fix delimiter parsing logic (JENA-1497) Logical flaws in using continue vs break inside inner loops where causing the wrong delimiter positions to be detected and leading to false positives

[GitHub] jena pull request #365: JENA-1490: Handle blank nodes client-server when usi...

2018-02-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/365#discussion_r170621100 --- Diff: jena-rdfconnection/src/main/java/org/apache/jena/rdfconnection/RDFConnectionRemoteBuilder.java --- @@ -0,0 +1,324 @@ +/* + * Licensed

[GitHub] jena pull request #366: JENA-1494: Reader properties

2018-02-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/366#discussion_r170616197 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/SysRIOT.java --- @@ -50,14 +51,20 @@ /** * Context key for old style RDFWriter

[GitHub] jena pull request #366: JENA-1494: Reader properties

2018-02-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/366#discussion_r170616897 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/lang/ReaderRIOTRDFXML.java --- @@ -116,17 +154,29 @@ public void parse() { arp.getHandlers

[GitHub] jena pull request #360: Make sure to use datasets transactionally (JENA-1486...

2018-02-12 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/360 Make sure to use datasets transactionally (JENA-1486) textindexer did not use datasets transactionally which could fail for dataset implementations that require transactional usage

[GitHub] jena issue #345: JENA-1468: Retain variables in op (table)

2018-01-30 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/345 @afs Thanks for the more detailed explanation +1 to merge ---

[GitHub] jena issue #345: JENA-1468: Retain variables in op (table)

2018-01-29 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/345 Does https://github.com/apache/jena/blob/cc038809fb622779933831011909714e22ef494c/jena-arq/src/main/java/org/apache/jena/sparql/algebra/optimize/TransformPromoteTableEmpty.java#L160 need to change

[GitHub] jena pull request #330: [WIP] Obfuscation Support

2017-12-15 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/330 [WIP] Obfuscation Support Early WIP on obfuscation support based on our internal implementation approach. Note various TODOs here and there, I am focusing on getting the basics working before

[GitHub] jena issue #315: Add --stop-warnings to riot (JENA-1434)

2017-11-24 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/315 Reworked based on @afs's feedback in the JIRA ---

[GitHub] jena pull request #315: Add --stop-warnings to riot (JENA-1434)

2017-11-23 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/315 Add --stop-warnings to riot (JENA-1434) Add the option to allow riot to abort on warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/rvesse

[GitHub] jena pull request #308: JENA-1384: Canonical literals: lexical form and lang...

2017-11-22 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/308#discussion_r152523288 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/process/normalize/CanonicalizeLiteral.java --- @@ -73,6 +76,36 @@ public Node apply(Node node

[GitHub] jena pull request #297: Enable parallel testing for Elephas IO (JENA-1407)

2017-11-03 Thread rvesse
Github user rvesse closed the pull request at: https://github.com/apache/jena/pull/297 ---

[GitHub] jena issue #297: Enable parallel testing for Elephas IO (JENA-1407)

2017-11-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/297 I think leaving at 2 is good, I was playing with using `false` though obviously that lessens the benefit. I think we can close this out though if we've delivered noticeable improvements already

[GitHub] jena issue #297: Enable parallel testing for Elephas IO (JENA-1407)

2017-10-27 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/297 I have now changed this to dynamically set test parallelism to use 50% of available cores ---

[GitHub] jena issue #297: Enable parallel testing for Elephas IO (JENA-1407)

2017-10-27 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/297 Parallelism of 2 gives similar benefits. I have a quad core machine personally. One possible approach is to use the `build-helper:cpu-count` plugin - http://www.mojohaus.org/build-helper-maven

[GitHub] jena pull request #297: Enable parallel testing for Elephas IO (JENA-1407)

2017-10-26 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/297 Enable parallel testing for Elephas IO (JENA-1407) Using parallelism of 4 reduces build time for Elephas IO to approximately 3-4 minutes in my testing. Also fixed one test

[GitHub] jena pull request #294: Fix and tests for possible NPE (JENA-1405)

2017-10-25 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/294#discussion_r146852236 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/adapters/AdapterFileManager.java --- @@ -285,6 +286,12 @@ protected Model readModelWorker(Model model

[GitHub] jena pull request #294: Fix and tests for possible NPE (JENA-1405)

2017-10-25 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/jena/pull/294 Fix and tests for possible NPE (JENA-1405) Fixes a possible NPE in AdaptorFileManager by aligning its behaviour with FileManager to throw NotFoundException Adds specific tests

[GitHub] jena issue #291: Bad regular expression patterns should throw ExprEvalExcept...

2017-10-23 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/291 LGTM +1 ---

[GitHub] jena issue #285: JENA-1398: Marked archaic FOAF terms in the vocabulary as d...

2017-10-12 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/285 Thanks for the updates, looks good to me We aim to release approximately every three months, the last release was July so we are probably due another release soon. However everything is done

[GitHub] jena pull request #285: JENA-1398: Marked archaic FOAF terms in the vocabula...

2017-10-11 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/285#discussion_r144011336 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/vocabulary/FOAF.java --- @@ -19,242 +19,282 @@ package org.apache.jena.sparql.vocabulary

[GitHub] jena issue #281: Slice out old Codehaus JXR Maven plugin invocation

2017-10-02 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/281 +1 ---

[GitHub] jena pull request #237: JENA-1313: compare using a Collator when both litera...

2017-04-12 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/237#discussion_r111201417 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java --- @@ -784,10 +786,15 @@ private static int compare(NodeValue nv1, NodeValue nv2

[GitHub] jena issue #234: Changes to jena-elephas to update it for RIOT/RDFParser cha...

2017-04-06 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/234 Thanks for starting on this, one of the first things I thought of when you started on the API improvements was that it would make life much easier for components like Elephas that need to manipulate

[GitHub] jena issue #230: JENA-733 add documentation for narrower data type case

2017-03-31 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/230 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] jena issue #219: Upgrade to Lucene 6.4.1 in jena-text and jena-spatial (JENA...

2017-03-10 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/219 Thanks for adding the more informative error message, the wording is extremely clear and should avoid lots of user confusion --- If your project is set up for it, you can reply to this email and have

[GitHub] jena issue #219: Upgrade to Lucene 6.4.1 in jena-text and jena-spatial (JENA...

2017-03-07 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/219 Is there a logical place where we could catch that specific exception and provide a more obvious error e.g. Index format is no longer supported, please rebuild the text index with Jena X.Y.Z or higher

[GitHub] jena pull request #222: JENA-1306: RDFParser

2017-03-07 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/222#discussion_r104627436 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java --- @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #222: JENA-1306: RDFParser

2017-03-07 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/222#discussion_r104627292 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java --- @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena issue #212: JENA-1284: Improvements for bulk graph operations in GraphU...

2017-02-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/212 My concern is that depending on the underlying storage of the data in the graphs a call to `contains()` might be quite expensive and it would be more efficient to simply call `delete()` directly

[GitHub] jena issue #205: JENA-1277: don't use sorting in spatial queries, for much b...

2017-02-02 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/205 We should already have support for most of the trigonometric functions built into ARQ as extension functions - https://github.com/apache/jena/tree/59e5e06c85c98c9c65a9c1addbc4252626e9d061/jena-arq/src

[GitHub] jena issue #212: JENA-1284: Improvements for bulk graph operations in GraphU...

2017-02-01 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/212 I presume this was motivated by a real-world performance concern? It would be interesting to know how much difference it makes. My only concern is what happens when there is only a slight

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92839505 --- Diff: jena-integration-tests/src/test/java/org/apache/jena/test/rdfconnection/AbstractTestRDFConnection.java --- @@ -0,0 +1,382 @@ +/* + * Licensed

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92839346 --- Diff: jena-integration-tests/README.md --- @@ -0,0 +1,11 @@ +Jena Intrgration Tests --- End diff -- Typo r -> e --- If your project is

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92839569 --- Diff: jena-integration-tests/src/test/java/org/apache/jena/test/rdfconnection/AbstractTestRDFConnection.java --- @@ -0,0 +1,382 @@ +/* + * Licensed

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92840442 --- Diff: jena-rdfconnection/Documentation.md --- @@ -0,0 +1,205 @@ +# RDF Connection : SPARQL operations API + +`RDFConnection` provides a unified

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92840570 --- Diff: jena-rdfconnection/Documentation.md --- @@ -0,0 +1,205 @@ +# RDF Connection : SPARQL operations API + +`RDFConnection` provides a unified

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92840274 --- Diff: jena-rdfconnection/Documentation.md --- @@ -0,0 +1,205 @@ +# RDF Connection : SPARQL operations API + +`RDFConnection` provides a unified

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92841987 --- Diff: jena-rdfconnection/src/main/java/org/apache/jena/rdfconnection/RDFConnectionRemote.java --- @@ -0,0 +1,478 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92841380 --- Diff: jena-rdfconnection/src/main/java/org/apache/jena/rdfconnection/RDFConnectionFactory.java --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #197: JENA-1267: RDFConnection

2016-12-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/197#discussion_r92840841 --- Diff: jena-rdfconnection/Documentation.md --- @@ -0,0 +1,205 @@ +# RDF Connection : SPARQL operations API + +`RDFConnection` provides a unified

[GitHub] jena issue #180: JENA-1248: Fuseki registry update

2016-10-19 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/180 Looks good to me My only concern is how Shiro behaves in a environment where each invaded server may have a different security configuration. --- If your project is set up for it, you can

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-13 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/151 The incorrect/ overridden plug-ins can certainly be removed. They are probably just cruft from the early days of development. Historically AspectJ was used in order to inject trace level

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

2016-10-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/151 @ajs6f provided that those examples are available at some point then this is fine with me. I'm not sure how we could incorporate test cases to this aspect because you would need an endpoint protected

  1   2   >