Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-23 Thread Jun Rao
Joe, Verified quickstart on both the src and binary release. They all look good. The javadoc doesn't seem to include those in clients. Could you add them? Thanks, Jun On Tue, Oct 21, 2014 at 1:58 PM, Joe Stein wrote: > This is the first candidate for release of Apache Kafka 0.8.2-beta > > Rel

Jenkins build is back to normal : Kafka-trunk #316

2014-10-23 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2014-10-23 Thread Chris Richardson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182295#comment-14182295 ] Chris Richardson commented on KAFKA-1716: - I just realized that I left out the thr

Review Request 27124: Patch for KAFKA-1721

2014-10-23 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27124/ --- Review request for kafka. Bugs: KAFKA-1721 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1721: - Status: Patch Available (was: Open) > Snappy compressor is not thread safe >

[jira] [Updated] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1721: - Attachment: KAFKA-1721.patch > Snappy compressor is not thread safe >

[jira] [Commented] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182280#comment-14182280 ] Ewen Cheslack-Postava commented on KAFKA-1721: -- Created reviewboard https://r

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182276#comment-14182276 ] Joel Koshy commented on KAFKA-391: -- Yeah I see your point. That's interesting - I actually

Re: Review Request 27060: Patch for KAFKA-1725

2014-10-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27060/#review58189 --- Ship it! Ship It! - Neha Narkhede On Oct. 22, 2014, 11:52 p.m.,

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182260#comment-14182260 ] Honghai Chen commented on KAFKA-391: Not that two line cause two responses. We just hit

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182258#comment-14182258 ] Jun Rao commented on KAFKA-1716: Hmm, then it's not clear why SimpleConsumer is blocked on

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182253#comment-14182253 ] Jun Rao commented on KAFKA-1667: The server side already has a dependency on clients. So,

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58185 --- Ship it! Looks good - can you upload an updated RB incorporating th

Re: ConsumerFetcherThread deadlock?

2014-10-23 Thread Jack Foy
On Oct 23, 2014, at 5:09 PM, Neha Narkhede wrote: > This can also happen if at least one of the consumer threads (not the > fetcher threads) die. You can inspect the thread dump to see if all your > consumer threads are alive. Thanks very much — that’s probably what is happening, and we’ll invest

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182240#comment-14182240 ] Joel Koshy commented on KAFKA-391: -- You mean two responses to the caller of send? I don't

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Chris Cope (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182233#comment-14182233 ] Chris Cope commented on KAFKA-1501: --- Unfortunately same issues, 9/100 tests had a bunch

Re: Bad link on the document

2014-10-23 Thread Jun Rao
Sorry for the delay. Fixed the link. Thanks, Jun On Tue, Oct 14, 2014 at 8:18 PM, Azuryy Yu wrote: > Hi, > Usage information on the hadoop consumer can be found here > . > > the Link is broken, who can kindly fix it, thanks >

Re: ConsumerFetcherThread deadlock?

2014-10-23 Thread Neha Narkhede
This can also happen if at least one of the consumer threads (not the fetcher threads) die. You can inspect the thread dump to see if all your consumer threads are alive. On Thu, Oct 23, 2014 at 5:05 PM, Guozhang Wang wrote: > Jack, > > The fetchers are blocked on the queue since it is full, is

[jira] [Resolved] (KAFKA-1711) WARN Property topic is not valid when running console producer

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1711. Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Joe Crobak Thanks for the patch. Committed

Re: ConsumerFetcherThread deadlock?

2014-10-23 Thread Guozhang Wang
Jack, The fetchers are blocked on the queue since it is full, is your consumer iterator stopped and hence not getting more data from it? Guozhang On Thu, Oct 23, 2014 at 3:53 PM, Jack Foy wrote: > Hi all, > > We run kafka 0.8.1.1. We’re tracking down a problem where consumer groups > stop pull

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182219#comment-14182219 ] Jay Kreps commented on KAFKA-1710: -- Well so we need to do a very quick lock around the in

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2014-10-23 Thread Chris Richardson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182203#comment-14182203 ] Chris Richardson commented on KAFKA-1716: - No. I am using the default. > hang dur

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58171 --- Ship it! Besides the minor stylistic comment, rest looks good. co

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-23 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182198#comment-14182198 ] Bhavesh Mistry commented on KAFKA-1710: --- [~jkreps], Sorry to bug you again. Did yo

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182197#comment-14182197 ] Jun Rao commented on KAFKA-391: --- Which version of Kafka are you using? Is that easily reprodu

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58168 --- Ship it! LGTM, one minor thing upon check in. core/src/main/scala

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182165#comment-14182165 ] Ewen Cheslack-Postava commented on KAFKA-1642: -- Updated reviewboard https://r

[jira] [Commented] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-23 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182166#comment-14182166 ] Jiangjie Qin commented on KAFKA-1719: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-23 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1719: Attachment: KAFKA-1719_2014-10-23_16:20:22.patch > Make mirror maker exit when one consumer/producer

[jira] [Updated] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1642: - Attachment: KAFKA-1642_2014-10-23_16:19:41.patch > [Java New Producer Kafka Trunk]

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- (Updated Oct. 23, 2014, 11:20 p.m.) Review request for kafka. Bugs: KAFKA-171

Re: Review Request 26885: Patch for KAFKA-1642

2014-10-23 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26885/ --- (Updated Oct. 23, 2014, 11:19 p.m.) Review request for kafka. Bugs: KAFKA-164

Re: Review Request 26885: Patch for KAFKA-1642

2014-10-23 Thread Ewen Cheslack-Postava
> On Oct. 23, 2014, 9:43 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java, > > lines 197-199 > > > > > > It seems that in this case, the nextReadyCheckDelayMs

[jira] [Resolved] (KAFKA-1700) examples directory - README and shell scripts are out of date

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1700. Resolution: Fixed Assignee: Geoffrey Anderson Thanks for the patch. +1 and committed to trunk. > exam

[jira] [Commented] (KAFKA-1675) bootstrapping tidy-up

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182138#comment-14182138 ] Jun Rao commented on KAFKA-1675: Thanks for the patch. Looks good. It doesn't seem to appl

[jira] [Commented] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182130#comment-14182130 ] Ewen Cheslack-Postava commented on KAFKA-1721: -- I have the trivial patch, but

[jira] [Commented] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182127#comment-14182127 ] Jun Rao commented on KAFKA-1721: Bhavesh, Do you want to submit a patch to upgrade the sn

[jira] [Commented] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182126#comment-14182126 ] Ewen Cheslack-Postava commented on KAFKA-1471: -- This was already applied, jus

[jira] [Updated] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-10-23 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1471: - Resolution: Fixed Fix Version/s: 0.8.2 Status: Resolved (was: Pa

[jira] [Commented] (KAFKA-1695) Authenticate connection to Zookeeper

2014-10-23 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182123#comment-14182123 ] Gwen Shapira commented on KAFKA-1695: - Agree! I do not want to change everything that

[jira] [Commented] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182117#comment-14182117 ] Jun Rao commented on KAFKA-1471: Ewen, It seems that the necessary changes are already in

ConsumerFetcherThread deadlock?

2014-10-23 Thread Jack Foy
Hi all, We run kafka 0.8.1.1. We’re tracking down a problem where consumer groups stop pulling from their respective partitions a few minutes or hours into execution. It looks like all ConsumerFetcherThreads associated with that consumer are blocking while waiting to write data to a LinkedBlock

[jira] [Commented] (KAFKA-2) a restful producer API

2014-10-23 Thread Anand Iyer (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182111#comment-14182111 ] Anand Iyer commented on KAFKA-2: Since the Kafka APIs are undergoing changes in upcoming vers

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182097#comment-14182097 ] Honghai Chen commented on KAFKA-391: Yes, after add more information to the error mess

[jira] [Updated] (KAFKA-1641) Log cleaner exits if last cleaned offset is lower than earliest offset

2014-10-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1641: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Pushed to trun

[jira] [Commented] (KAFKA-1695) Authenticate connection to Zookeeper

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182090#comment-14182090 ] Jun Rao commented on KAFKA-1695: Option 2 is probably too big a change. Let's see if we ca

Re: Review Request 26390: Fix KAFKA-1641

2014-10-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/#review58144 --- core/src/main/scala/kafka/log/LogCleanerManager.scala

Re: Review Request 26390: Fix KAFKA-1641

2014-10-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/#review58117 --- Ship it! - Joel Koshy On Oct. 9, 2014, 8:04 p.m., Guozhang Wang w

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182070#comment-14182070 ] Jun Rao commented on KAFKA-1716: Chris, Did you change fetch.wait.max.ms in the consumer

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182057#comment-14182057 ] Jun Rao commented on KAFKA-391: --- The client should always receive one response per request. A

[jira] [Resolved] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1727. Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Muneyuki Noguchi Thanks for the patch. +1 a

[jira] [Commented] (KAFKA-1683) Implement a "session" concept in the socket server

2014-10-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182024#comment-14182024 ] Jay Kreps commented on KAFKA-1683: -- Here is what I was imagining, not sure if this is wha

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-23 Thread Ewen Cheslack-Postava
Yeah, the version on Precise is really old, 1.0, and on Trusty is 1.4. Using the PPA version worked fine for me on Trusty. -Ewen On Thu, Oct 23, 2014, at 10:02 AM, Joe Stein wrote: > hmmm. > > I just launched a bootstrap clean room (per release docs). Installed > latest > gradle > > sudo add-ap

Re: Review Request 26885: Patch for KAFKA-1642

2014-10-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26885/#review57513 --- Thanks for the patch. Looks good to me. Some minor comments below.

Re: Review Request 26373: Patch for KAFKA-1647

2014-10-23 Thread Jiangjie Qin
> On Oct. 23, 2014, 12:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 531-538 > > > > > > I am not sure that I understand how Option.flatten works. Would it be > > clearly if

[jira] [Commented] (KAFKA-1688) Add authorization interface and naive implementation

2014-10-23 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181997#comment-14181997 ] Gwen Shapira commented on KAFKA-1688: - The Wiki specifies: PermissionManager.isPermitt

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2014-10-23 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181947#comment-14181947 ] Gwen Shapira commented on KAFKA-1684: - Its a large patch, so I didn't do a full review

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Chris Cope (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181928#comment-14181928 ] Chris Cope commented on KAFKA-1501: --- Awesome! I should know shortly, spinning off 100 j

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181795#comment-14181795 ] Jay Kreps commented on KAFKA-1501: -- Nice! > transient unit tests failures due to port al

Re: Documentation with patches

2014-10-23 Thread Gwen Shapira
+1 On Thu, Oct 23, 2014 at 11:45 AM, Sriram Subramanian wrote: > I actually think it is a pretty good idea to have the docs in git. > Summarizing the benefits - > > 1. If a contributor/committer makes any significant changes to how a > functionality works, they could always update the docs in par

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Jiangjie Qin
> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > > > > > Is this change intended? > > Jiangjie Qin wrote: > Yes, it is intended, so that we c

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Guozhang Wang
> On Oct. 22, 2014, 9:32 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 271 > > > > > > Is there any value in setting this to true? It seems that just checking > > if it is fals

Re: Documentation with patches

2014-10-23 Thread Sriram Subramanian
I actually think it is a pretty good idea to have the docs in git. Summarizing the benefits - 1. If a contributor/committer makes any significant changes to how a functionality works, they could always update the docs in parallel and reviewers can enforce this if they find the change deems a docum

Review Request 27101: Fix KAFKA-1501 by enabling reuse address

2014-10-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27101/ --- Review request for kafka. Bugs: KAFKA-1501 https://issues.apache.org/jira/b

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58049 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1501: - Assignee: Guozhang Wang Status: Patch Available (was: Open) > transient unit tests failures

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181734#comment-14181734 ] Guozhang Wang commented on KAFKA-1501: -- Created reviewboard https://reviews.apache.or

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Joel Koshy
> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > > > > > Is this change intended? > > Jiangjie Qin wrote: > Yes, it is intended, so that we c

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1501: - Attachment: KAFKA-1501.patch > transient unit tests failures due to port already in use >

[jira] [Commented] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-23 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181730#comment-14181730 ] Bhavesh Mistry commented on KAFKA-1721: --- [~ewencp], Thanks for fixing this issue.

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181725#comment-14181725 ] Guozhang Wang commented on KAFKA-1501: -- I can re-produce the issue from time to time

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-23 Thread Jiangjie Qin
> On Oct. 22, 2014, 9:32 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 271 > > > > > > Is there any value in setting this to true? It seems that just checking > > if it is fals

[jira] [Commented] (KAFKA-1683) Implement a "session" concept in the socket server

2014-10-23 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181696#comment-14181696 ] Gwen Shapira commented on KAFKA-1683: - Very good points [~jkreps] and [~joestein]. Th

Re: Documentation with patches

2014-10-23 Thread Gwen Shapira
With two patches, we'll need a two-phase commit to maintain consistency, and we all know what a PITA this can be. (Sorry, couldn't resist the pun. Carry on.) On Thu, Oct 23, 2014 at 10:32 AM, Jay Kreps wrote: > That makes sense. I agree that moving to another doc system isn't a high > priority (i

Re: Documentation with patches

2014-10-23 Thread Jay Kreps
That makes sense. I agree that moving to another doc system isn't a high priority (it isn't as much work as it sounds because the HTML can all remain as is, just the includes would get converted). But actually I don't think that having a patch for docs and a patch for the code is too big a hurdle e

[jira] [Commented] (KAFKA-1641) Log cleaner exits if last cleaned offset is lower than earliest offset

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181600#comment-14181600 ] Guozhang Wang commented on KAFKA-1641: -- [~jjkoshy] Could you take another look? > Lo

[jira] [Commented] (KAFKA-1683) Implement a "session" concept in the socket server

2014-10-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181569#comment-14181569 ] Jay Kreps commented on KAFKA-1683: -- I had imagined the auth happening in the network laye

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-23 Thread Joe Stein
hmmm. I just launched a bootstrap clean room (per release docs). Installed latest gradle sudo add-apt-repository ppa:cwchien/gradle sudo apt-get update sudo apt-get install gradle wget https://people.apache.org/~joestein/kafka-0.8.2-beta-candidate1/kafka-0.8.2-beta-src.tgz tar -xvf kafka-0.8.2-b

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-23 Thread Neha Narkhede
Joe, I downloaded the source distro and ran into this error. Followed the steps listed on the release process wiki to validate the release. vagrant@precise64:~/kafka-0.8.2-beta-src$ gradle FAILURE: Build failed with an exception. * Where: Script '/home/vagrant/kafka-0.8.2-beta-src/scala.gradle'

[jira] [Commented] (KAFKA-1718) "Message Size Too Large" error when only small messages produced with Snappy

2014-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181470#comment-14181470 ] Jun Rao commented on KAFKA-1718: Evan, Thanks for updating the wiki. The MagicByte curren

[jira] [Resolved] (KAFKA-1726) Wrong message format description

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1726. -- Resolution: Fixed > Wrong message format description > > >

[jira] [Closed] (KAFKA-1726) Wrong message format description

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang closed KAFKA-1726. Assignee: Guozhang Wang > Wrong message format description > > >

[jira] [Commented] (KAFKA-1726) Wrong message format description

2014-10-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181459#comment-14181459 ] Guozhang Wang commented on KAFKA-1726: -- Thanks Oleg for pointing this out, I just fix

Re: Documentation with patches

2014-10-23 Thread Joe Stein
I like how we have things in SVN. My issue is having two patches from contributors (one for tests + code and another for docs) that I am trying to solve. If we copy the entire SVN docs directory into git under /docs then contributions can patch the docs in their git patch. Committers can do 1 com

[jira] [Commented] (KAFKA-1718) "Message Size Too Large" error when only small messages produced with Snappy

2014-10-23 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181348#comment-14181348 ] Evan Huus commented on KAFKA-1718: -- [~junrao] I already have wiki permissions, so I made

[jira] [Commented] (KAFKA-1683) Implement a "session" concept in the socket server

2014-10-23 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181323#comment-14181323 ] Joe Stein commented on KAFKA-1683: -- [~gwenshap] We need to be careful with auth once only

[jira] [Updated] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Muneyuki Noguchi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Muneyuki Noguchi updated KAFKA-1727: Attachment: KAFKA-1727.patch > Fix comment about message format > --

Review Request 27075: Patch for KAFKA-1727

2014-10-23 Thread Muneyuki Noguchi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27075/ --- Review request for kafka. Bugs: KAFKA-1727 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Muneyuki Noguchi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181308#comment-14181308 ] Muneyuki Noguchi commented on KAFKA-1727: - Created reviewboard https://reviews.apa

[jira] [Created] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Muneyuki Noguchi (JIRA)
Muneyuki Noguchi created KAFKA-1727: --- Summary: Fix comment about message format Key: KAFKA-1727 URL: https://issues.apache.org/jira/browse/KAFKA-1727 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-1726) Wrong message format description

2014-10-23 Thread Oleg Golovin (JIRA)
Oleg Golovin created KAFKA-1726: --- Summary: Wrong message format description Key: KAFKA-1726 URL: https://issues.apache.org/jira/browse/KAFKA-1726 Project: Kafka Issue Type: Bug Compon

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2014-10-23 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181180#comment-14181180 ] Ivan Lyutov commented on KAFKA-1684: The high-level description is available in docs/S

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2014-10-23 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181176#comment-14181176 ] Ivan Lyutov commented on KAFKA-1684: Created reviewboard https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-1684) Implement TLS/SSL authentication

2014-10-23 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1684: --- Attachment: KAFKA-1684.patch > Implement TLS/SSL authentication > > >

[jira] [Updated] (KAFKA-1684) Implement TLS/SSL authentication

2014-10-23 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1684: --- Status: Patch Available (was: Open) > Implement TLS/SSL authentication >

Review Request 27071: Patch for KAFKA-1684

2014-10-23 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27071/ --- Review request for kafka. Bugs: KAFKA-1684 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181170#comment-14181170 ] Honghai Chen commented on KAFKA-391: Why this fix add this line code? Sometimes got 2 r