---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31566/#review74973
---
Tong, could you address Jun's last comments before committing?
-
Jun, I have most everything looks good except I keep getting test failures
from wget
https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/kafka-0.8.2.1-src.tgz
tar -xvf kafka-0.8.2.1-src.tgz cd kafka-0.8.2.1-src gradle
./gradlew test
kafka.api.ProducerFailureHandlingTest
[
https://issues.apache.org/jira/browse/KAFKA-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1999:
Attachment: KAFKA-1999.patch
Simple fix to the test.
Fix failing unit-test:
[
https://issues.apache.org/jira/browse/KAFKA-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1999:
Status: Patch Available (was: Open)
Fix failing unit-test: kafka.api.ProducerFailureHandlingTest
Hi,
Good catch, Joe. Releasing with a broken test is not a good habit.
I provided a small patch that fixes the issue in KAFKA-1999.
Gwen
On Tue, Mar 3, 2015 at 9:08 AM, Joe Stein joe.st...@stealth.ly wrote:
Jun, I have most everything looks good except I keep getting test failures
from wget
Gwen Shapira created KAFKA-1999:
---
Summary: Fix failing unit-test:
kafka.api.ProducerFailureHandlingTest testNotEnoughReplicasAfterBrokerShutdown
Key: KAFKA-1999
URL:
[
https://issues.apache.org/jira/browse/KAFKA-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt reassigned KAFKA-1688:
---
Assignee: Parth Brahmbhatt (was: Sriharsha Chintalapani)
Add authorization
Yes. It was addressed in the latest patch set. A private method called
toPositive was added so that the partition selection is preserved cross this
and previous versions.
Thanks
Sent from my iPhone
On Mar 4, 2015, at 12:49 AM, Guozhang Wang wangg...@gmail.com wrote:
This is an
It would also be good to think through how we can use those new admin
requests in the producer/consumer client as well. Currently, both the
producer and the consumer use TopicMetadataRequest to obtain the metadata,
which will trigger a topic creation if auto topic creation is enabled. This
is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review74985
---
Ship it!
Ship It!
- Guozhang Wang
On Feb. 26, 2015, 6:54 p.m.,
KIP-3 passed with 3 binding +1 and 2 non-binding +1.
On 2/26/15, 9:02 PM, Neha Narkhede n...@confluent.io wrote:
+1 (binding)
On Thu, Feb 26, 2015 at 2:14 PM, Joel Koshy jjkosh...@gmail.com wrote:
+1 (binding)
On Tue, Feb 24, 2015 at 06:37:53PM -0800, Guozhang Wang wrote:
+1 binding
On March 3, 2015, 4:10 a.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 560
https://reviews.apache.org/r/29467/diff/4/?file=882247#file882247line560
This seems to call initiateClose() twice, once in initiateClose and
then
On March 3, 2015, 5:37 a.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 533
https://reviews.apache.org/r/29467/diff/4/?file=882247#file882247line533
Now there is a bit of duplicate code between the two close methods.
Maybe
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1852:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
committed to trunk
[
https://issues.apache.org/jira/browse/KAFKA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1986:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk
Producer
Sriharsha Chintalapani created KAFKA-2000:
-
Summary: Delete consumer offsets from kafka once the topic is
deleted
Key: KAFKA-2000
URL: https://issues.apache.org/jira/browse/KAFKA-2000
Hey Jun,
Initially I was thinking about instead of 3-4 state that global config
changes
take effect only after broker restart. So it's just:
3-4. On each broker startup apply global config from ZK
In other words, the comprehensive workflow is the following:
1. Issue ChangeGlobalConfigRequest
2.
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345612#comment-14345612
]
Joel Koshy commented on KAFKA-1852:
---
(As noted in RB we need a separate jira to handle
Thanks for sending that out Joe - I don't think I will be able to make
it today, so if notes can be sent out afterward that would be great.
On Mon, Mar 02, 2015 at 09:16:13AM -0800, Gwen Shapira wrote:
Thanks for sending this out Joe. Looking forward to chatting with everyone :)
On Mon, Mar
Ok, lets fix the transient test failure on trunk agreed not a blocker.
+1 quick start passed, verified artifacts, updates in scala
https://github.com/stealthly/scala-kafka/tree/0.8.2.1 and go
https://github.com/stealthly/go_kafka_client/tree/0.8.2.1 look good
~ Joe Stein
- - - - - - - - - - - -
On March 3, 2015, 5:43 p.m., Mayuresh Gharat wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, line 413
https://reviews.apache.org/r/31306/diff/3/?file=878588#file878588line413
This will mean that if there are unkeyed messages we will neglect them
and not throw an exception
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review74992
---
Ship it!
Ship It!
- Mayuresh Gharat
On Feb. 26, 2015, 6:54
[
https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345866#comment-14345866
]
Gwen Shapira commented on KAFKA-1992:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31706/
---
Review request for kafka.
Bugs: KAFKA-1997
Details in the wiki.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+Filtering
--
Jeff Holoman
Systems Engineer
[
https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-1997:
Status: Patch Available (was: Open)
Refactor Mirror Maker
-
[
https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345879#comment-14345879
]
Jiangjie Qin commented on KAFKA-1997:
-
Created reviewboard
+1 (non-binding)
On 3/3/15, 1:17 PM, Gwen Shapira gshap...@cloudera.com wrote:
+1 (non-binding)
On Tue, Mar 3, 2015 at 12:44 PM, Jeff Holoman jholo...@cloudera.com
wrote:
Details in the wiki.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+F
iltering
--
Jeff
See https://builds.apache.org/job/Kafka-trunk/415/changes
Changes:
[jjkoshy] KAFKA-1755; Reject compressed and unkeyed messages sent to compacted
topics; reviewed by Mayuresh Gharat, Neha Narkhede and Guozhang Wang
[jjkoshy] KAFKA-1852; Reject offset commits to unknown topics; reviewed by Joel
[
https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-1997:
Attachment: KAFKA-1997.patch
Refactor Mirror Maker
-
Key:
Thanks Gwen!
One thing that I forgot to mention during the meeting is that we need to
create a KIP for another producer API change also (KAFKA-1660). The code is
almost ready and we just need to figure out some details about interacting
with concurrent flush() calls.
Guozhang
On Tue, Mar 3,
+1 (non-binding)
On Tue, Mar 3, 2015 at 12:44 PM, Jeff Holoman jholo...@cloudera.com wrote:
Details in the wiki.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+Filtering
--
Jeff Holoman
Systems Engineer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31591/
---
(Updated March 3, 2015, 10:16 p.m.)
Review request for kafka.
Bugs:
Details are in the wiki:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-2+-+Refactor+brokers+to+allow+listening+on+multiple+ports+and+IPs
Hi,
I put together a (very) short summary of the discussion and decisions:
KIPs:
We reviewed the list of KIPs posted here:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
* KIP-2: Ready for formal vote
* KIP-3: Discussion closed. There’s a new KIP (14) for
+1 non-binding
On Tue, Mar 3, 2015, at 12:39 PM, Jeff Holoman wrote:
+1 non-binding of course
On Tue, Mar 3, 2015 at 3:18 PM, Joe Stein joe.st...@stealth.ly wrote:
+1
~ Joe Stein
- - - - - - - - - - - - - - - - -
http://www.stealth.ly
- - - - - - - - - - - - - - - - -
On
[
https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1992:
Attachment: KAFKA-1992_2015-03-03_14:16:34.patch
Following KAFKA-1697,
+1 non-binding of course
On Tue, Mar 3, 2015 at 3:18 PM, Joe Stein joe.st...@stealth.ly wrote:
+1
~ Joe Stein
- - - - - - - - - - - - - - - - -
http://www.stealth.ly
- - - - - - - - - - - - - - - - -
On Tue, Mar 3, 2015 at 3:14 PM, Gwen Shapira gshap...@cloudera.com
wrote:
Details
+1
~ Joe Stein
- - - - - - - - - - - - - - - - -
http://www.stealth.ly
- - - - - - - - - - - - - - - - -
On Tue, Mar 3, 2015 at 3:14 PM, Gwen Shapira gshap...@cloudera.com wrote:
Details are in the wiki:
Jun Rao created KAFKA-2001:
--
Summary: OffsetCommitTest hang during setup
Key: KAFKA-2001
URL: https://issues.apache.org/jira/browse/KAFKA-2001
Project: Kafka
Issue Type: Bug
Components:
On March 3, 2015, 4:48 p.m., Guozhang Wang wrote:
Tong, could you address Jun's last comments before committing?
Yes. absolutely, doing it now. Thanks.
- Tong
---
This is an automatically generated e-mail. To reply, visit:
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tong Li updated KAFKA-1988:
---
Attachment: KAFKA-1988_2015-03-03_19:00:21.patch
org.apache.kafka.common.utils.Utils.abs method returns
See https://builds.apache.org/job/Kafka-trunk/416/changes
Changes:
[jjkoshy] KAFKA-2001; Trivial commit to prevent OffsetCommitTest from hanging
[jjkoshy] KAFKA-2001; Trivial commit to fix OffsetCommitTest
--
[...truncated 1121 lines...]
[
https://issues.apache.org/jira/browse/KAFKA-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1999:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
Thanks for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31591/#review75120
---
Thanks for the patch. A few minor comments below.
Thanks Gwen!
-Jay
On Tue, Mar 3, 2015 at 12:12 PM, Gwen Shapira gshap...@cloudera.com wrote:
Hi,
I put together a (very) short summary of the discussion and decisions:
KIPs:
We reviewed the list of KIPs posted here:
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346038#comment-14346038
]
Tong Li commented on KAFKA-1988:
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31566/
---
(Updated March 4, 2015, midnight)
Review request for kafka.
Bugs: KAFKA-1988
[
https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346083#comment-14346083
]
Geoffrey Anderson commented on KAFKA-902:
-
Thanks for the feedback.
Is there any
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31706/#review75110
---
core/src/main/scala/kafka/tools/MirrorMaker.scala
Jeff,
I am wondering if the IP filtering rule can be enforced at the socket
server level instead of the Kafka API level?
Guozhang
On Tue, Mar 3, 2015 at 2:24 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
+1 (non-binding)
On 3/3/15, 1:17 PM, Gwen Shapira gshap...@cloudera.com wrote:
+1
+1 binding.
On Tue, Mar 3, 2015 at 1:08 PM, Harsha ka...@harsha.io wrote:
+1 non-binding
On Tue, Mar 3, 2015, at 12:39 PM, Jeff Holoman wrote:
+1 non-binding of course
On Tue, Mar 3, 2015 at 3:18 PM, Joe Stein joe.st...@stealth.ly wrote:
+1
~ Joe Stein
- - - - - - - - - -
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345891#comment-14345891
]
Ashish K Singh commented on KAFKA-1994:
---
[~junrao] Your suggestion makes sense.
Thanks Gwen!
On Tue, Mar 03, 2015 at 12:12:24PM -0800, Gwen Shapira wrote:
Hi,
I put together a (very) short summary of the discussion and decisions:
KIPs:
We reviewed the list of KIPs posted here:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
* KIP-2:
[
https://issues.apache.org/jira/browse/KAFKA-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy reassigned KAFKA-2001:
-
Assignee: Joel Koshy
I'll take a quick look at this
OffsetCommitTest hang during setup
[
https://issues.apache.org/jira/browse/KAFKA-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-2001.
---
Resolution: Fixed
This was due to a change I made as part of KAFKA-1755
I added compression.type
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31706/
---
(Updated March 4, 2015, 12:28 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-1997:
Attachment: KAFKA-1997_2015-03-03_16:28:46.patch
Refactor Mirror Maker
-
On March 4, 2015, midnight, Guozhang Wang wrote:
core/src/main/scala/kafka/tools/MirrorMaker.scala, line 682
https://reviews.apache.org/r/31706/diff/1/?file=883687#file883687line682
Instead of a wrapper rebalancer, I think it is cleaner to just
instantiate the
[
https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346096#comment-14346096
]
Jiangjie Qin commented on KAFKA-1997:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-1976.
Resolution: Duplicate
Duplicate of KAFKA-1999.
transient unit test failure in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review75112
---
core/src/test/scala/unit/kafka/log/CleanerTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31715/
---
Review request for kafka.
Bugs: KAFKA-902
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31711/#review75115
---
Thanks for the patch. A comment below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31591/
---
(Updated March 4, 2015, 1:17 a.m.)
Review request for kafka.
Bugs:
See https://builds.apache.org/job/KafkaPreCommit/29/changes
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1994:
--
Attachment: KAFKA-1994.patch
Evaluate performance effect of chroot check on Topic creation
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346125#comment-14346125
]
Ashish K Singh commented on KAFKA-1994:
---
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31706/#review75071
---
Guozhang,
Yes, I have rebased and updated the patch set to resolve the couple
comments for code comments. Also removed the trailing spaces (which always
annoying. :-) ), Please see the new patch set here. Sorry for the delay.
https://reviews.apache.org/r/31566/
Thanks.
Tong Li
OpenStack
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review75047
---
core/src/test/scala/unit/kafka/log/CleanerTest.scala
[
https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346162#comment-14346162
]
Gwen Shapira commented on KAFKA-1992:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1992:
Attachment: KAFKA-1992_2015-03-03_17:17:43.patch
Following KAFKA-1697,
See https://builds.apache.org/job/KafkaPreCommit/28/changes
Changes:
[jjkoshy] KAFKA-1755; Reject compressed and unkeyed messages sent to compacted
topics; reviewed by Mayuresh Gharat, Neha Narkhede and Guozhang Wang
[jjkoshy] KAFKA-1852; Reject offset commits to unknown topics; reviewed by
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tong Li updated KAFKA-1988:
---
Attachment: KAFKA-1988_2015-03-03_19:03:31.patch
org.apache.kafka.common.utils.Utils.abs method returns
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31711/
---
Review request for kafka.
Bugs: KAFKA-1994
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1994:
--
Status: Patch Available (was: Open)
Evaluate performance effect of chroot check on Topic
Guozhang,
The way the patch is implemented, the check is done in the acceptor thread
accept() method of the Socket Server, just before connectionQuotas.
Thanks
Jeff
On Tue, Mar 3, 2015 at 7:59 PM, Guozhang Wang wangg...@gmail.com wrote:
Jeff,
I am wondering if the IP filtering rule can be
See https://builds.apache.org/job/Kafka-trunk/417/changes
[
https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345918#comment-14345918
]
Guozhang Wang commented on KAFKA-1660:
--
+1 on creating a new KIP. Especially, I think
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346045#comment-14346045
]
Tong Li commented on KAFKA-1988:
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31566/
---
(Updated March 4, 2015, 12:03 a.m.)
Review request for kafka.
Bugs:
On March 4, 2015, midnight, Guozhang Wang wrote:
core/src/main/scala/kafka/tools/MirrorMaker.scala, line 67
https://reviews.apache.org/r/31706/diff/1/?file=883687#file883687line67
Are we sure that one producer io thread is sufficient for all cases?
Jiangjie Qin wrote:
The
[
https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346149#comment-14346149
]
Geoffrey Anderson commented on KAFKA-902:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Anderson updated KAFKA-902:
Attachment: KAFKA-902.patch
Randomize backoff on the clients for metadata requests
On March 4, 2015, midnight, Guozhang Wang wrote:
core/src/main/scala/kafka/tools/MirrorMaker.scala, line 67
https://reviews.apache.org/r/31706/diff/1/?file=883687#file883687line67
Are we sure that one producer io thread is sufficient for all cases?
Jiangjie Qin wrote:
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/
---
(Updated March 4, 2015, 1:51 a.m.)
Review request for kafka.
Bugs:
On March 4, 2015, 12:48 a.m., Guozhang Wang wrote:
core/src/main/scala/kafka/tools/MirrorMaker.scala, line 524
https://reviews.apache.org/r/31706/diff/2/?file=884005#file884005line524
On the other hand we should avoid checking for each message as
System.currentTimeMillis() is not
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346214#comment-14346214
]
Ashish K Singh commented on KAFKA-1982:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31711/#review75132
---
core/src/main/scala/kafka/utils/ZkUtils.scala
On March 4, 2015, 1:59 a.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/ZkUtils.scala, lines 817-826
https://reviews.apache.org/r/31711/diff/1/?file=884018#file884018line817
We will need to remember the result of client.exist(). If
isNamespaceChecked is true, we will throw a
On March 4, 2015, 1:59 a.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/ZkUtils.scala, lines 817-826
https://reviews.apache.org/r/31711/diff/1/?file=884018#file884018line817
We will need to remember the result of client.exist(). If
isNamespaceChecked is true, we will throw a
Hey Joel, good questions
As a first thought, my experience with customers in large corporate
environments probably has me somewhat jaded :). You know it really
shouldn't take 3 weeks to get ports opened on a load balancer, but, that
really does happen. Coordination across those teams also can and
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1994:
--
Attachment: KAFKA-1994_2015-03-03_18:19:45.patch
Evaluate performance effect of chroot check
On March 4, 2015, 1:59 a.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/ZkUtils.scala, lines 817-826
https://reviews.apache.org/r/31711/diff/1/?file=884018#file884018line817
We will need to remember the result of client.exist(). If
isNamespaceChecked is true, we will throw a
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346253#comment-14346253
]
Ashish K Singh commented on KAFKA-1994:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346274#comment-14346274
]
Guozhang Wang commented on KAFKA-1988:
--
Thanks [~tongli], +1 and committed to trunk.
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1988:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Attachment: KAFKA-1982_2015-03-03_17:50:57.patch
change kafka.examples.Producer to use the new
On March 3, 2015, 5:42 a.m., Jun Rao wrote:
Thanks for the review Jun! Addressed your concerns.
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/#review74895
1 - 100 of 106 matches
Mail list logo
