tps://reviews.apache.org/r/24704/#comment121241>
Not sure what you mean - can you elaborate?
- Joel Koshy
On Dec. 26, 2014, 4:09 p.m., Manikumar Reddy O wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review74614
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 27, 2015, 9:50 p.m
+1
On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote:
> Wow. That was quick :-)
> Any committers who would also like to give a +1?
>
> On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh wrote:
>
> > +1
> >
> > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira
> > wrote:
> >
> > > Actually,
t be a val
core/src/main/scala/kafka/server/MetadataCache.scala
<https://reviews.apache.org/r/29912/#comment121176>
Should probably do this inReadLock
- Joel Koshy
On Feb. 18, 2015, 9:13 p.m., Sriharsha Chintalapani wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31449/#review74380
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 25, 2015, 11:54 p.m
+1 (binding)
On Tue, Feb 24, 2015 at 06:37:53PM -0800, Guozhang Wang wrote:
> +1 binding
>
> On Tue, Feb 24, 2015 at 5:24 PM, Gwen Shapira wrote:
>
> > +1 (non-binding)
> >
> > On Tue, Feb 24, 2015 at 5:14 PM, Jiangjie Qin
> > wrote:
> >
> > >
> > >
> > https://cwiki.apache.org/confluence/disp
[
https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339225#comment-14339225
]
Joel Koshy commented on KAFKA-1987:
---
Looking at the code I think this is possible
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338907#comment-14338907
]
Joel Koshy commented on KAFKA-1755:
---
Updated reviewboard https://reviews.apache.o
nt but also slightly more complicated.
- Joel Koshy
On Feb. 26, 2015, 6:54 p.m., Joel Koshy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1755:
--
Attachment: KAFKA-1755_2015-02-26_10:54:50.patch
> Improve error handling in log clea
/unit/kafka/message/ByteBufferMessageSetTest.scala
73a26377eb63ab9989698e0491049434f032cba2
Diff: https://reviews.apache.org/r/31306/diff/
Testing
---
Thanks,
Joel Koshy
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review74201
---
On Feb. 23, 2015, 10:29 p.m., Joel Koshy wrote:
>
> --
[
https://issues.apache.org/jira/browse/KAFKA-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334253#comment-14334253
]
Joel Koshy commented on KAFKA-1379:
---
We have been thinking through various alternat
al)
- Joel Koshy
On Feb. 23, 2015, 10:29 p.m., Joel Koshy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31306/
> --
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1755:
--
Attachment: KAFKA-1755_2015-02-23_14:29:54.patch
> Improve error handling in log clea
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334000#comment-14334000
]
Joel Koshy commented on KAFKA-1755:
---
Updated reviewboard https://reviews.apache.o
73a26377eb63ab9989698e0491049434f032cba2
Diff: https://reviews.apache.org/r/31306/diff/
Testing
---
Thanks,
Joel Koshy
> On Feb. 23, 2015, 7:05 p.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 209
> > <https://reviews.apache.org/r/31306/diff/1/?file=872917#file872917line209>
> >
> > In doing !compactedTopic here I'm forcing
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review73618
---
On Feb. 23, 2015, 2:43 p.m., Joel Koshy wrote:
>
> ---
> This is an automati
<https://reviews.apache.org/r/31306/#comment120029>
In doing !compactedTopic here I'm forcing iteration over the messages
below. I can also do an in-place verification here to avoid iteration (and
creation of message objects).
- Joel Koshy
On Feb. 23, 2015, 2:43 p.m., Joel
one line at the end of the cleaner line.
(BTW, which jmx value are you referring to?)
- Joel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review73584
-------
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1489#comment-1489
]
Joel Koshy commented on KAFKA-1755:
---
Also, I have an incremental patch that prev
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1487#comment-1487
]
Joel Koshy commented on KAFKA-1755:
---
I thought a bit more about this and here
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1755:
--
Attachment: KAFKA-1755.patch
> Improve error handling in log clea
b623e
core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala
73a26377eb63ab9989698e0491049434f032cba2
Diff: https://reviews.apache.org/r/31306/diff/
Testing
---
Thanks,
Joel Koshy
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1755:
--
Status: Patch Available (was: Open)
> Improve error handling in log clea
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1460#comment-1460
]
Joel Koshy commented on KAFKA-1755:
---
Created reviewboard https://reviews.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328493#comment-14328493
]
Joel Koshy commented on KAFKA-1729:
---
Need to also update the protocol guide wiki
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328467#comment-14328467
]
Joel Koshy commented on KAFKA-1546:
---
No, we don't have any timestamp
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328465#comment-14328465
]
Joel Koshy commented on KAFKA-1546:
---
Re: your concern - yes that does seem to be v
/DelayedItem.scala
<https://reviews.apache.org/r/31199/#comment119405>
May be better to name the argument delayMs
- Joel Koshy
On Feb. 19, 2015, 5:51 p.m., Yasuhiro Matsuda wrote:
>
> ---
> This is an automatically generated e
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327524#comment-14327524
]
Joel Koshy commented on KAFKA-1729:
---
It has been pushed to trunk, but I will keep
+1 (binding)
On Wed, Feb 18, 2015 at 07:03:26PM -0500, Joe Stein wrote:
> +1 binding
>
> ~ Joestein
> On Feb 18, 2015 6:50 PM, "Jay Kreps" wrote:
>
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-8+-+Add+a+flush+method+to+the+producer+API
> >
> > +1 binding
> >
> > -Jay
> >
at on check-in if everything else looks good to you.
- Joel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31169/#review73057
---
On Feb
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1729:
--
Attachment: KAFKA-1729_2015-02-18_17:30:37.patch
> add doc for Kafka-based offset management in 0.
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326862#comment-14326862
]
Joel Koshy commented on KAFKA-1729:
---
Updated reviewboard https://reviews.apache.o
1c25aa3332f9e4f0222db715b524d9179b5306cf
Diff: https://reviews.apache.org/r/31169/diff/
Testing
---
Thanks,
Joel Koshy
://reviews.apache.org/r/31174/diff/
Testing
---
Thanks,
Joel Koshy
tps://reviews.apache.org/r/31169/#comment119238>
ack - yes. thanks for catching that.
- Joel Koshy
On Feb. 18, 2015, 11:55 p.m., Joel Koshy wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
browse/KAFKA-1659
> > > >> https://issues.apache.org/jira/browse/KAFKA-1660
> > > >>
> > > >> Also, I recall that there is timeout also added to batch to indicate
> > how
> > > >> long "message" can retain in memory before e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31168/#review73035
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 19, 2015, 12:01 a.m
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326764#comment-14326764
]
Joel Koshy commented on KAFKA-1729:
---
Created reviewboard https://reviews.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1729:
--
Attachment: KAFKA-1729.patch
> add doc for Kafka-based offset management in 0.
://reviews.apache.org/r/31169/diff/
Testing
---
Thanks,
Joel Koshy
als(Assert.java:64)
> > at junit.framework.Assert.assertEquals(Assert.java:130)
> > at
> > kafka.server.SimpleFetchTest.testReadFromLog(SimpleFetchTest.scala:145)
>
> Joel Koshy wrote:
> For (1) I noted this on the review but it is convenient to have the total
> under BrokerT
w73020
---
On Feb. 17, 2015, 11:46 p.m., Aditya Auradkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30570/
> -------
[
https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1959.
---
Resolution: Fixed
Assignee: Tong Li
Thanks for the patch - committed to trunk.
> Cl
[
https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1960.
---
Resolution: Fixed
Assignee: Tong Li
Thanks for the patch - committed to trunk.
> .gitign
> On Feb. 4, 2015, 2:15 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/api/OffsetCommitRequest.scala, line 48
> > <https://reviews.apache.org/r/27391/diff/11/?file=832423#file832423line48>
> >
> > I our convention is to include the if in the previo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31097/#review72911
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 16, 2015, 9:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31088/#review72910
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 16, 2015, 4:37 p.m
> On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/server/OffsetManager.scala, line 215
> > <https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215>
> >
> > Minor comment. I think this may be better to
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325327#comment-14325327
]
Joel Koshy commented on KAFKA-1953:
---
Updated reviewboard https://reviews.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1953:
--
Attachment: KAFKA-1953_2015-02-17_18:23:55.patch
> Disambiguate metrics from different purgator
/
Testing
---
Thanks,
Joel Koshy
parameters otherwise it is
not always clear from the call itself what the parameter actually means.
- Joel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31140/#review72875
[
https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1914.
---
Resolution: Fixed
Committed to trunk
> Count TotalProduceRequestRate and TotalFetchRequestRate
[
https://issues.apache.org/jira/browse/KAFKA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1943.
---
Resolution: Fixed
Committed to trunk
> Producer request failure rate should not incl
ightly weird. i.e., each expired key counts toward the aggregate even
if it is all from one single producer request.
- Joel Koshy
On Feb. 18, 2015, 12:48 a.m., Joel Koshy wrote:
>
> ---
> This is an automatically generated e-
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1953:
--
Status: Patch Available (was: Open)
> Disambiguate metrics from different purgator
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1953:
--
Attachment: KAFKA-1953.patch
> Disambiguate metrics from different purgator
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325219#comment-14325219
]
Joel Koshy commented on KAFKA-1953:
---
Created reviewboard https://reviews.apache.o
/main/scala/kafka/server/ReplicaManager.scala
ce36cc72606fb5441335f1c7466a7db8da3db499
core/src/test/scala/unit/kafka/server/DelayedOperationTest.scala
93f52d3222fc10b6d22ef6278365f6b026180418
Diff: https://reviews.apache.org/r/31140/diff/
Testing
---
Thanks,
Joel Koshy
[
https://issues.apache.org/jira/browse/KAFKA-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy reassigned KAFKA-1962:
-
Assignee: Joel Koshy
I'll combine this with KAFKA-1953
> Restore delayed request
/KafkaRequestHandler.scala
<https://reviews.apache.org/r/30570/#comment118952>
I think the aggregate rates here are redundant to what's already there in
RequestChannel's request metrics; but I think it is convenient to have it here
as well.
- Joel Koshy
On Feb. 17, 2015, 11:46 p.m., Adity
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30848/#review72837
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 10, 2015, 10:17 p.m
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324917#comment-14324917
]
Joel Koshy commented on KAFKA-1961:
---
Yes it would be inconsistent in that you w
Joel Koshy created KAFKA-1963:
-
Summary: Add unit tests to check presence of all metrics
Key: KAFKA-1963
URL: https://issues.apache.org/jira/browse/KAFKA-1963
Project: Kafka
Issue Type: Bug
Joel Koshy created KAFKA-1962:
-
Summary: Restore delayed request metrics
Key: KAFKA-1962
URL: https://issues.apache.org/jira/browse/KAFKA-1962
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1946:
--
Summary: Fix various broker metrics (was: Improve BrokerTopicMetrics
reporting)
> Fix various bro
Joel Koshy created KAFKA-1953:
-
Summary: Disambiguate metrics from different purgatories
Key: KAFKA-1953
URL: https://issues.apache.org/jira/browse/KAFKA-1953
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1697:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch. Pushed to
our handling for clearing out offsets on a delete topic is done yet -
Onur Karaman did it for ZK based offsets but we need a separate jira to delete
Kafka-based offsets.
- Joel Koshy
On Feb. 13, 2015, 12:46 a.m., Sriharsha Chintalapani wrote:
>
> --
that up.
- Joel Koshy
On Feb. 13, 2015, 2:57 a.m., Gwen Shapira wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
t; reserving
> > > > for intra-cluster communication, and you would prefer to not have it
> > > > advertised at all. Perhaps it is blocked by a firewall rule or other
> > > > authentication method. This could also allow you to duplicate a
> > security
> > > > protocol
eouts:
> http://docs.oracle.com/javase/7/docs/api/java/io/OutputStream.html#flush()
>
> -Jay
>
> On Tue, Feb 10, 2015 at 10:41 AM, Joel Koshy wrote:
>
> > I think tryFlush with a timeout sounds good to me. This is really more
> > for consistency than anything else.
> On Feb. 12, 2015, 2:31 p.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/server/ReplicaManager.scala, line 271
> > <https://reviews.apache.org/r/29647/diff/6/?file=861625#file861625line271>
> >
> > This is good, but maybe call this canRespondNow ? Si
tps://reviews.apache.org/r/29912/#comment118171>
Can we just add an exists(topic) method to metadataCache?
That way we can just do something like
offsetMetadata.groupBy((topicPartition, offsetMetadata) =>
metadataCache.contains(topicPartition.topic))
- Joel Koshy
On Jan. 19, 2015,
is no
data.
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
<https://reviews.apache.org/r/29647/#comment118160>
Is this change necessary?
- Joel Koshy
On Feb. 12, 2015, 7:14 a.m., Gwen Shapira wrote:
>
> --
- Can you enable test logging (see the README) and see if you can
figure out which test is getting stuck or taking forever?
- A thread-dump may help.
On Thu, Feb 12, 2015 at 08:57:11AM -0500, Tong Li wrote:
>
>
> Hi, folks,
> How are you all doing?
> New bee here. Run gradle --daemon t
The description that Jun gave for (2) was the detail I was looking for
- Gwen can you update the KIP with that for completeness/clarity?
I'm +1 as well overall. However, I think it would be good if we also
get an ack from someone who is more experienced on the operations side
(say, Todd) to review
won't work? Basically I
> think you guys have thought about this more so I may be missing something.
> If so let's flag it while we still have leeway on the consumer.
>
> If we think that will work, well I do think it is conceptually a lot
> simpler than the current cod
[
https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316739#comment-14316739
]
Joel Koshy commented on KAFKA-1852:
---
Thanks for the ping - will take a
[
https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316714#comment-14316714
]
Joel Koshy commented on KAFKA-1374:
---
I can review this next week. However, as fa
[
https://issues.apache.org/jira/browse/KAFKA-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1945.
---
Resolution: Invalid
> MetaData Response - Broker hostname is wr
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316222#comment-14316222
]
Joel Koshy commented on KAFKA-1944:
---
Sure - I think this can wait until that i
that makes the MM usable in a few other mirroring-like applications.
Joel
> On Tue, Feb 10, 2015 at 12:31 PM, Joel Koshy wrote:
>
> >
> >
> > On Tue, Feb 10, 2015 at 12:13:46PM -0800, Neha Narkhede wrote:
> > > I think all of us agree that we want to desi
scala
<https://reviews.apache.org/r/29647/#comment117873>
Do we need this here?
- Joel Koshy
On Feb. 11, 2015, 1:06 a.m., Gwen Shapira wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
Thanks for the comments - however, it is not clear to me what your
preference is on making NotEnoughReplicasAfterAppend retriable vs
non-retriable.
As for me, my preference is to leave it as retriable since it is clear
that the produce may succeed on a retry (and may introduce a
duplicate). I agre
try on
NotEnoughReplicasAfterAppendException. The side-effect in question here is
duplicates. Duplicates can arise even for other errors (e.g., request timed
out). So that side-effect is not compelling enough to warrant a change to make
this non-retriable.
- Joel Koshy
On Jan. 14, 2015, 11:41 p.m., Gwen Shapira
rue that the code already has special cases for requiredAcks == 0 -
however, that code is executed in the callback from replica manager. So it's
not a 100% clean separation.
- Joel Koshy
On Jan. 14, 2015, 11:41 p.m., Gwen Shapira wrote:
>
> -
/NotEnoughReplicasAfterAppendException.java
<https://reviews.apache.org/r/29647/#comment117734>
Understood, but if someone uses required.acks -1 they would most likely be
okay with duplicates and would rather have the data persisted with guarantees.
What do you think?
- Joel Koshy
On Jan. 14, 20
this individually on their own.
>
> Also the KIP still refers to the data channel in a few places (Motivation
> and "On consumer rebalance" sections). Can you update the wiki so it is
> easier to review the new design, especially the data loss part.
>
>
> On
cheduler and test the appendMessages call.
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/29647/#comment117712>
Should we just do Errors.INVALID_REQUIRED_ACKS?
- Joel Koshy
On Jan. 14, 2015, 11:41 p.m.,
tps://reviews.apache.org/r/30810/#comment117707>
previously mentioned race -> "if a message is held by the producer thread
by not handed to the producer"
- Joel Koshy
On Feb. 9, 2015, 11:58 p.m., Jiangjie Qin wrote:
>
> ---
tps://reviews.apache.org/r/30810/#comment117705>
The node itself may not be inserted into the list yet, so the current
implementation of remove could throw an NPE
- Joel Koshy
On Feb. 9, 2015, 11:58 p.m., Jiangjie Qin wrote:
>
> ---
I think tryFlush with a timeout sounds good to me. This is really more
for consistency than anything else. I cannot think of any standard
blocking calls off the top of my head that don't have a timed variant.
E.g., Thread.join, Object.wait, Future.get Either that, or they
provide an entirely non-bl
et sent, lingering around in case of new writes is
> silly. But in the absense of flush there is no way to say that. As you say
> you only may that penalty on one of the get() calls, but if the linger.ms
> is high (say 60 seconds) that will be a huge penalty.
>
> -Jay
>
> On
I think the message handler adds little to no complexity to the mirror
maker. Jay/Neha, the MM became scary due to the rearchitecture we did
for 0.8 due to performance issues compared with 0.7 - we should remove
the data channel if it can match the current throughput. I agree it is
worth prototypin
- WRT the motivation: "if you set linger.ms > 0 to encourage batching
of messages, which is likely a good idea for this kind of use case,
then the second for loop will block for a ms" -> however, in
practice this will really only be for the first couple of calls
right? Since the subsequent
501 - 600 of 1553 matches
Mail list logo
