Re: [DISCUSS] KIP-21 Configuration Management

2015-05-15 Thread Jun Rao
@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management The wiki says: There will be 3 paths within config /config/clients/client_id /config/topics/topic_name /config/brokers/broker_id Didn't we decide that brokers will not be configured dynamically, rather we will keep the config

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-15 Thread Aditya Auradkar
@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management The lack of audit could be addressed to some degree by an internal __config_changes topic which can have very long retention. Also, per the hangout summary that Gwen sent out it appears that we decided against supporting SIGHUP/dynamic

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-15 Thread Gwen Shapira
, May 12, 2015 1:09 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management The lack of audit could be addressed to some degree by an internal __config_changes topic which can have very long retention. Also, per the hangout summary that Gwen sent out it appears that we

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-15 Thread Aditya Auradkar
Yes we did. I just overlooked that line.. cleaning it up now. Aditya From: Gwen Shapira [gshap...@cloudera.com] Sent: Friday, May 15, 2015 12:55 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management The wiki says

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-12 Thread Jay Kreps
@kafka.apache.org javascript:; Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-12 Thread Joel Koshy
:;] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org javascript:; Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Jay Kreps
From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Gwen Shapira
tackle these things in a later KIP? Thanks, Aditya From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Gwen Shapira
tackle these things in a later KIP? Thanks, Aditya From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Aditya Auradkar
From: Joel Koshy [jjkosh...@gmail.com] Sent: Monday, May 11, 2015 4:54 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management So the general concern here is the dichotomy of configs (which we already have - i.e., in the form of broker config files vs topic configs

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Joel Koshy
? Thanks, Aditya From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Ashish Singh
javascript:; Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Gwen Shapira
, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-10 Thread Gwen Shapira
From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-10 Thread Todd Palino
...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-07 Thread Aditya Auradkar
/controller API. Aditya From: Ashish Singh [asi...@cloudera.com] Sent: Thursday, May 07, 2015 8:19 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Agreed :). However, the other concerns remain. Do you think just providing

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-07 Thread Jun Rao
From: Neha Narkhede [n...@confluent.io javascript:;] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org javascript:; Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Ashish Singh
: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating the default value

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Jun Rao
From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Ashish Singh
...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Ashish Singh
@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Jun Rao
To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-05 Thread Gwen Shapira
From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-05 Thread Joel Koshy
, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-05 Thread Neha Narkhede
in a central place. Are there any concerns if we tackle these things in a later KIP? Thanks, Aditya From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-04 Thread Joe Stein
type exposed by each broker? Thanks, Aditya From: Joe Stein [joe.st...@stealth.ly] Sent: Friday, May 01, 2015 5:25 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Hi Aditya, thanks for the write up and focusing

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-04 Thread Aditya Auradkar
KIP? Thanks, Aditya From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-04 Thread Aditya Auradkar
. Thanks, Aditya From: Jay Kreps [jay.kr...@gmail.com] Sent: Monday, May 04, 2015 2:00 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Hey Aditya, 1. I would argue for either staying with what we have or else moving

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-04 Thread Jay Kreps
notification or a request type exposed by each broker? Thanks, Aditya From: Joe Stein [joe.st...@stealth.ly] Sent: Friday, May 01, 2015 5:25 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Hi Aditya

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-04 Thread Aditya Auradkar
these things piece by piece. Thanks, Aditya From: Jay Kreps [jay.kr...@gmail.com] Sent: Friday, May 01, 2015 12:53 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Hey Aditya, This is a great! A couple of comments: 1. Leaving

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-04 Thread Jay Kreps
Kreps [jay.kr...@gmail.com] Sent: Friday, May 01, 2015 12:53 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Hey Aditya, This is a great! A couple of comments: 1. Leaving the file config in place is definitely the least disturbance. But let's really think

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-03 Thread Aditya Auradkar
From: Joe Stein [joe.st...@stealth.ly] Sent: Friday, May 01, 2015 5:25 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Hi Aditya, thanks for the write up and focusing on this piece. Agreed we need something that we can do

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-03 Thread Neha Narkhede
Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating the default value? If not, where does the admin look to find the default values, ZK or local

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-03 Thread Aditya Auradkar
@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating the default value

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-02 Thread Jay Kreps
Hey Aditya, This is a great! A couple of comments: 1. Leaving the file config in place is definitely the least disturbance. But let's really think about getting rid of the files and just have one config mechanism. There is always a tendency to make everything pluggable which so often just leads

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-01 Thread Aditya Auradkar
From: Joel Koshy [jjkosh...@gmail.com] Sent: Thursday, April 30, 2015 5:14 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-21 Configuration Management 1. I have deep concerns about managing configuration in ZooKeeper. First, Producers and Consumers shouldn't

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-01 Thread Joe Stein
Hi Aditya, thanks for the write up and focusing on this piece. Agreed we need something that we can do broker changes dynamically without rolling restarts. I think though if every broker is getting changes it with notifications it is going to limit which configs can be dynamic. We could never

Re: [DISCUSS] KIP-21 Configuration Management

2015-04-30 Thread Joel Koshy
1. I have deep concerns about managing configuration in ZooKeeper. First, Producers and Consumers shouldn't depend on ZK at all, this seems to add back a dependency we are trying to get away from. The KIP probably needs to be clarified here - I don't think Aditya was referring to

[DISCUSS] KIP-21 Configuration Management

2015-04-28 Thread Aditya Auradkar
Hey everyone, Wrote up a KIP to update topic, client and broker configs dynamically via Zookeeper. https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration Please read and provide feedback. Thanks, Aditya PS: I've intentionally kept this discussion separate from KIP-5