Ewen,
This is quite useful. I used the command that is suggested in the ASFBot
comment:
git pull https://github.com/[contribuer-name]/kafka KAFKA-
to apply the patch locally. But this would actually better I think, just
that it requires installing hub first. Maybe we can add this to the
Hi Ewen,
On Fri, Jul 24, 2015 at 5:32 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
One other thing that might be worth mentioning in The Review Process
section is the hub tool: https://hub.github.com/ I only ever use one
feature, but it's immensely useful if you're reviewing PRs on
Thank you for voting. 72 hours have elapsed and the vote has passed with 4
binding +1s. There were also 8 non-binding +1s.
I removed the In Progress warning from:
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
It would be good for a committer to review (and
+1 (non-binding)
One other thing that might be worth mentioning in The Review Process
section is the hub tool: https://hub.github.com/ I only ever use one
feature, but it's immensely useful if you're reviewing PRs on Github. You
can just copy the URL into a command to checkout the PR branch:
hub
+1 (non binding)
Can we have a wiki for procedure and let people verify the steps? After
that we can update the Apache project page.
On Tue, Jul 21, 2015 at 5:38 PM, Edward Ribeiro edward.ribe...@gmail.com
wrote:
+1 (non binding)
On Tue, Jul 21, 2015 at 7:36 PM, Jay Kreps j...@confluent.io
Hi,
On 22 Jul 2015 19:32, Jiangjie Qin j...@linkedin.com.invalid wrote:
+1 (non binding)
Can we have a wiki for procedure and let people verify the steps? After
that we can update the Apache project page.
Yes, I linked to the page in the original message:
+1 . I think phasing out a good idea but rather than x months we should move
to github PRs for any new JIRAs that are not already in review board.
For the JIRA’s that are in review board we can continue to use that until they
merged in.
-Harsha
On July 21, 2015 at 8:11:17 AM, Ashish Singh
+1 (binding)
Agree with Ismael. We may not want to rush to push the PR right away.
Having said that, if it works well with say, 10 patches, I'd consider that
enough to require the new JIRAs to submit patches using the PRs instead.
Thanks,
Neha
On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha
+1 non-binding.
A suggestion, we should try to phase out old system of reviews gradually,
instead of forcing it over a night. Maybe a time bound switch? We can say
like in x months from now we will completely move to PRs?
On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
On Tue, Jul 21, 2015 at 4:11 PM, Ashish Singh asi...@cloudera.com wrote:
+1 non-binding.
A suggestion, we should try to phase out old system of reviews gradually,
instead of forcing it over a night.
I agree.
Maybe a time bound switch? We can say
like in x months from now we will
+1 (non binding)
On Tue, Jul 21, 2015 at 7:36 PM, Jay Kreps j...@confluent.io wrote:
+1
-Jay
On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start a vote on switching to GitHub pull requests for new
contributions. To be precise, the
+1 non-binding
On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede n...@confluent.io wrote:
+1 (binding)
Agree with Ismael. We may not want to rush to push the PR right away.
Having said that, if it works well with say, 10 patches, I'd consider that
enough to require the new JIRAs to submit
+1
On Tue, Jul 21, 2015 at 9:31 AM, Grant Henke ghe...@cloudera.com wrote:
+1 non-binding
On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede n...@confluent.io wrote:
+1 (binding)
Agree with Ismael. We may not want to rush to push the PR right away.
Having said that, if it works well
+1 (binding) on using PRs.
It sounds like we need additional discussion on how the transition
will happen. Maybe move that to a separate thread, to keep the vote
easy to follow.
On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start a vote on
+1 (non-binding)
Thanks
Parth
On 7/21/15, 10:24 AM, Gwen Shapira gshap...@cloudera.com wrote:
+1 (binding) on using PRs.
It sounds like we need additional discussion on how the transition
will happen. Maybe move that to a separate thread, to keep the vote
easy to follow.
On Tue, Jul 21, 2015
+1
-Jay
On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start a vote on switching to GitHub pull requests for new
contributions. To be precise, the vote is on whether we should:
* Update the documentation to tell users to use pull requests
Hi all,
I would like to start a vote on switching to GitHub pull requests for new
contributions. To be precise, the vote is on whether we should:
* Update the documentation to tell users to use pull requests instead of
patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349)
* Use pull
17 matches
Mail list logo
