[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-16 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173425#comment-14173425 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi Jun, thx for juicy feedback, few

[jira] [Updated] (KAFKA-1506) Cancel kafka-reassign-partitions Job

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1506: - Labels: newbie++ (was: ) Cancel kafka-reassign-partitions Job

[jira] [Updated] (KAFKA-1506) Cancel kafka-reassign-partitions Job

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1506: - Reviewer: Neha Narkhede Assignee: (was: Neha Narkhede) Cancel kafka-reassign-partitions

Review Request 26811: Patch for KAFKA-1196

2014-10-16 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26811/ --- Review request for kafka. Bugs: KAFKA-1196

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-16 Thread Neha Narkhede
Another JIRA that will be nice to include as part of 0.8.2-beta is https://issues.apache.org/jira/browse/KAFKA-1481 that fixes the mbean naming. Looking for people's thoughts on 2 things here - 1. How do folks feel about doing a 0.8.2-beta release right now and 0.8.2 final 4-5 weeks later? 2. Do

[jira] [Commented] (KAFKA-1196) java.lang.IllegalArgumentException Buffer.limit on FetchResponse.scala + 33

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173941#comment-14173941 ] Ewen Cheslack-Postava commented on KAFKA-1196: -- Created reviewboard

[jira] [Updated] (KAFKA-1196) java.lang.IllegalArgumentException Buffer.limit on FetchResponse.scala + 33

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1196: - Assignee: Ewen Cheslack-Postava Status: Patch Available (was: Open)

[jira] [Commented] (KAFKA-1196) java.lang.IllegalArgumentException Buffer.limit on FetchResponse.scala + 33

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173943#comment-14173943 ] Ewen Cheslack-Postava commented on KAFKA-1196: -- This is a wip patch to fix

[jira] [Resolved] (KAFKA-1707) ConsumerOffsetChecker shows none partitions assigned

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1707. -- Resolution: Won't Fix This is a known issue but there are a few things to check. Did you run

[jira] [Resolved] (KAFKA-1708) Consumers intermittently stop consuming till restart

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1708. -- Resolution: Won't Fix Same here. Please direct this to the mailing list where people can help

[jira] [Updated] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1710: - Reviewer: Jun Rao Assignee: (was: Jun Rao) [New Java Producer Potential Deadlock]

[jira] [Commented] (KAFKA-1492) Getting error when sending producer request at the broker end with a single broker

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173987#comment-14173987 ] Neha Narkhede commented on KAFKA-1492: -- bq. This seems more appropriate for the Kafka

Re: Review Request 26770: Patch for KAFKA-1108

2014-10-16 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26770/#review56956 --- core/src/main/scala/kafka/server/KafkaServer.scala

[jira] [Updated] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1653: - Reviewer: Neha Narkhede Duplicate broker ids allowed in replica assignment

Re: Review Request 26666: Patch for KAFKA-1653

2014-10-16 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/#review56958 --- Since you fixed some other tools as well, can we also fix the

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174052#comment-14174052 ] Neha Narkhede commented on KAFKA-1476: -- [~balaji.sesha...@dish.com] Thanks for the

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174061#comment-14174061 ] Neha Narkhede commented on KAFKA-328: - Thanks for the patch. Would you mind using our

[jira] [Commented] (KAFKA-1654) Provide a way to override server configuration from command line

2014-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174101#comment-14174101 ] Neha Narkhede commented on KAFKA-1654: -- [~jarcec] Thanks for the patch. Overall looks

Re: Review Request 26373: Patch for KAFKA-1647

2014-10-16 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review56989 --- This is a fairly tricky patch and I'm not 100% sure that we haven't

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174178#comment-14174178 ] Ewen Cheslack-Postava commented on KAFKA-1710: -- This looks like a red herring

Re: Security JIRAS

2014-10-16 Thread Michael Herstine
Thanks, Jay. I¹m new to the project, and I¹m wondering how things proceed from hereŠ are folks working on these tasks, or do they get assigned, orŠ? On 10/7/14, 5:15 PM, Jay Kreps jay.kr...@gmail.com wrote: Hey guys, As promised, I added a tree of JIRAs for the stuff in the security wiki (

Re: Security JIRAS

2014-10-16 Thread Gwen Shapira
Wondering the same here :) I think there are some parallel threads here (SSL is independent of Kerberos, as far as I can see). Kerberos work is blocked on https://issues.apache.org/jira/browse/KAFKA-1683 - Implement a session concept in the socket server. So there's no point in picking up other

Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- (Updated Oct. 16, 2014, 8:50 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Oliver updated KAFKA-1493: Attachment: KAFKA-1493_2014-10-16_13:49:34.patch Use a well-documented LZ4 compression format and

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174217#comment-14174217 ] James Oliver commented on KAFKA-1493: - Updated reviewboard

[jira] [Assigned] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Oliver reassigned KAFKA-1493: --- Assignee: James Oliver (was: Ivan Lyutov) Use a well-documented LZ4 compression format and

[jira] [Commented] (KAFKA-1108) when controlled shutdown attempt fails, the reason is not always logged

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174222#comment-14174222 ] Ewen Cheslack-Postava commented on KAFKA-1108: -- Updated reviewboard

[jira] [Updated] (KAFKA-1108) when controlled shutdown attempt fails, the reason is not always logged

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1108: - Attachment: KAFKA-1108_2014-10-16_13:53:11.patch when controlled shutdown

Re: Review Request 26770: Patch for KAFKA-1108

2014-10-16 Thread Ewen Cheslack-Postava
On Oct. 16, 2014, 5:55 p.m., Neha Narkhede wrote: core/src/main/scala/kafka/server/KafkaServer.scala, line 239 https://reviews.apache.org/r/26770/diff/1/?file=722474#file722474line239 Should this be WARN instead? ERROR wouldn't be ideal since this operation is retried later. Also

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-16 Thread Joe Stein
+1 for a 0.8.2-beta next week and 0.8.2.0 final 4-5 weeks later. I agree to the tickets you brought up to have in 0.8.2-beta and also https://issues.apache.org/jira/browse/KAFKA-1493 for lz4 compression. /*** Joe Stein Founder, Principal Consultant Big

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry commented on KAFKA-1710: --- [~ewencp], Thanks for looking into this.

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:32 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:33 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:34 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:33 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:34 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:34 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:36 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:38 PM:

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174305#comment-14174305 ] Jun Rao commented on KAFKA-1493: James, Thanks for the patch. There are a few things

Re: Review Request 26666: Patch for KAFKA-1653

2014-10-16 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- (Updated Oct. 16, 2014, 9:54 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1653: - Attachment: KAFKA-1653_2014-10-16_14:54:07.patch Duplicate broker ids allowed in

[jira] [Commented] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174319#comment-14174319 ] Ewen Cheslack-Postava commented on KAFKA-1653: -- Updated reviewboard

Re: Review Request 26666: Patch for KAFKA-1653

2014-10-16 Thread Ewen Cheslack-Postava
On Oct. 16, 2014, 6:10 p.m., Neha Narkhede wrote: Since you fixed some other tools as well, can we also fix the preferred replica election command where we can de-dup the partitions? This was already removing duplicates, I had it generate an exception instead since duplicates may

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174278#comment-14174278 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/16/14 9:56 PM:

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-16 Thread Guozhang Wang
Regarding 1634, I was intended to work on that after 1583 since it will changes the commit offset request handling logic a lot. If people think 1583 is only a few days away before check-in, we can leave in in 0.8.2-beta; otherwise we can push to 0.8.3. Guozhang On Thu, Oct 16, 2014 at 2:19 PM,

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-16 Thread Jun Rao
+1 on doing an 0.8.2 beta. Guozhang, kafka-1583 is relatively large. Given that we are getting close to releasing 0.8.2 beta, my feeling is that we probably shouldn't include it in 0.8.2 beta even if we can commit it in a few days. Thanks, Jun On Thu, Oct 16, 2014 at 3:01 PM, Guozhang Wang

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174356#comment-14174356 ] James Oliver commented on KAFKA-1493: - Jun, My pleasure. The TODOs are parts of the

[jira] [Comment Edited] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174356#comment-14174356 ] James Oliver edited comment on KAFKA-1493 at 10/16/14 10:23 PM:

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-16 Thread Guozhang Wang
Agree. On Oct 16, 2014 3:16 PM, Jun Rao jun...@gmail.com wrote: +1 on doing an 0.8.2 beta. Guozhang, kafka-1583 is relatively large. Given that we are getting close to releasing 0.8.2 beta, my feeling is that we probably shouldn't include it in 0.8.2 beta even if we can commit it in a few

[jira] [Comment Edited] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174356#comment-14174356 ] James Oliver edited comment on KAFKA-1493 at 10/16/14 10:30 PM:

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174373#comment-14174373 ] Ewen Cheslack-Postava commented on KAFKA-1710: -- [~Bmis13] That approach just

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-16 Thread Joel Koshy
+1 on the beta. I think KAFKA-1583 should only be on trunk, not 0.8.2 so that will only go out with 0.8.3. Joel On Thu, Oct 16, 2014 at 03:25:39PM -0700, Guozhang Wang wrote: Agree. On Oct 16, 2014 3:16 PM, Jun Rao jun...@gmail.com wrote: +1 on doing an 0.8.2 beta. Guozhang,

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174403#comment-14174403 ] Bhavesh Mistry commented on KAFKA-1710: --- [~ewencp], Thanks for the looking into

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2014-10-16 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174462#comment-14174462 ] Bhavesh Mistry commented on KAFKA-1642: --- [~jkreps], Did you get chance to

Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/#review57005 --- Thanks for the patch. Looks good overall. Some minor comments

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174473#comment-14174473 ] Jun Rao commented on KAFKA-1493: James, Thanks for the answer. We can leave the TODOs

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-16 Thread Guozhang Wang
On Oct. 16, 2014, 1:29 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 167 https://reviews.apache.org/r/24676/diff/9/?file=720184#file720184line167 Should replica manager be offset manager? This is replica manager actually, when it tries to write the

Re: Review Request 24676: Fix KAFKA-1583

2014-10-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 17, 2014, 4:15 a.m.) Review request for kafka. Summary

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-16 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174709#comment-14174709 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard

Re: Review Request 26658: Patch for KAFKA-1493

2014-10-16 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- (Updated Oct. 17, 2014, 4:25 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174716#comment-14174716 ] James Oliver commented on KAFKA-1493: - Updated reviewboard

[jira] [Updated] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-10-16 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Oliver updated KAFKA-1493: Attachment: KAFKA-1493_2014-10-16_21:25:23.patch Use a well-documented LZ4 compression format and