Re: Review Request 35867: Patch for KAFKA-1901

On Aug. 20, 2015, 2:03 a.m., Joel Koshy wrote: build.gradle, line 389 https://reviews.apache.org/r/35867/diff/5/?file=1035356#file1035356line389 This gives an error in detached mode (i.e., not on any branch). Updated code to handle detached mode. thanks for the review. -

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704563#comment-14704563 ] Ismael Juma commented on KAFKA-2084: I noticed that a number of classes inherit from

[jira] [Commented] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705310#comment-14705310 ] Ben Stopford commented on KAFKA-2015: - I think we should move this to 0.8.3? It would

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated Aug. 20, 2015, 7:08 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704414#comment-14704414 ] Manikumar Reddy commented on KAFKA-1901: Updated reviewboard

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901_2015-08-20_12:35:00.patch Move Kafka version to be generated in code

[jira] [Updated] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Stopford updated KAFKA-2015: Status: Patch Available (was: In Progress) Enable ConsoleConsumer to use new consumer

[jira] [Commented] (KAFKA-2454) Dead lock between delete log segment and shutting down.

[ https://issues.apache.org/jira/browse/KAFKA-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706019#comment-14706019 ] Joel Koshy commented on KAFKA-2454: --- I'm a bit unclear on the root cause that you

[jira] [Commented] (KAFKA-2454) Dead lock between delete log segment and shutting down.

[ https://issues.apache.org/jira/browse/KAFKA-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706021#comment-14706021 ] Jiangjie Qin commented on KAFKA-2454: - [~jjkoshy] Here are the two threads: Thread 1:

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704649#comment-14704649 ] Ismael Juma commented on KAFKA-1683: [~gwenshap], KAFKA-1690 has been merged (as you

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704713#comment-14704713 ] Manikumar Reddy commented on KAFKA-2213: Updated reviewboard

Re: Review Request 36578: Patch for KAFKA-2338

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review95943 --- core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)

[jira] [Commented] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704757#comment-14704757 ] Manikumar Reddy commented on KAFKA-2295: [~guozhang] Can we go ahead and commit

Re: Review Request 36578: Patch for KAFKA-2338

On Aug. 20, 2015, 11:07 a.m., Edward Ribeiro wrote: Also do want to include patch for second point given in JIRA decription.. just read previous reviews..ignore my comment. - Manikumar Reddy --- This is an automatically generated

Re: Review Request 34805: Patch for KAFKA-2213

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated Aug. 20, 2015, 11:37 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Attachment: KAFKA-2213_2015-08-20_17:04:28.patch Log cleaner should write compacted messages

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704731#comment-14704731 ] Flavio Junqueira commented on KAFKA-873: [~granthenke] I'm more than happy to let

Re: Review Request 35880: Patch for KAFKA-2295

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- (Updated Aug. 20, 2015, 12:17 p.m.) Review request for kafka. Bugs:

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review95934 --- Thanks for addressing the issues raised in the previous review. We

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704662#comment-14704662 ] Ismael Juma commented on KAFKA-2210: [~parth.brahmbhatt], also reviewed it. In

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Attachment: KAFKA-2295_2015-08-20_17:44:56.patch Dynamically loaded classes (encoders, etc.)

[jira] [Commented] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704749#comment-14704749 ] Manikumar Reddy commented on KAFKA-2295: Updated reviewboard

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review95942 --- One more thing: it may be a good idea to rebase against trunk since

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706103#comment-14706103 ] Sriharsha Chintalapani commented on KAFKA-1683: --- [~gwenshap] got your point

[jira] [Updated] (KAFKA-1897) Enhance MockProducer for more sophisticated tests

[ https://issues.apache.org/jira/browse/KAFKA-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1897: Fix Version/s: (was: 0.8.3) Enhance MockProducer for more sophisticated tests

[jira] [Resolved] (KAFKA-1855) Topic unusable after unsuccessful UpdateMetadataRequest

[ https://issues.apache.org/jira/browse/KAFKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-1855. - Resolution: Cannot Reproduce Topic unusable after unsuccessful UpdateMetadataRequest

[jira] [Updated] (KAFKA-1877) Expose version via JMX for 'new' producer

[ https://issues.apache.org/jira/browse/KAFKA-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1877: Fix Version/s: (was: 0.8.3) Expose version via JMX for 'new' producer

[jira] [Commented] (KAFKA-2170) 10 LogTest cases failed for file.renameTo failed under windows

[ https://issues.apache.org/jira/browse/KAFKA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705922#comment-14705922 ] ASF GitHub Bot commented on KAFKA-2170: --- GitHub user mpoindexter opened a pull

[GitHub] kafka pull request: KAFKA-2170, KAFKA-1194: Fixes for Windows

GitHub user mpoindexter opened a pull request: https://github.com/apache/kafka/pull/154 KAFKA-2170, KAFKA-1194: Fixes for Windows This branch fixes several Windows specific issues, both in the code and in the tests. With these changes the whole test suite passes on my Windows

[GitHub] kafka pull request: KAFKA-1683: persisting session information in ...

GitHub user gwenshap opened a pull request: https://github.com/apache/kafka/pull/155 KAFKA-1683: persisting session information in Requests You can merge this pull request into a Git repository by running: $ git pull https://github.com/gwenshap/kafka KAFKA-1683 Alternatively

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706096#comment-14706096 ] Sriharsha Chintalapani commented on KAFKA-1683: --- [~gwenshap] Hmm if the

[jira] [Commented] (KAFKA-1898) compatibility testing framework

[ https://issues.apache.org/jira/browse/KAFKA-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706121#comment-14706121 ] Gwen Shapira commented on KAFKA-1898: - Looping back here [~granders], is this

[jira] [Updated] (KAFKA-1912) Create a simple request re-routing facility

[ https://issues.apache.org/jira/browse/KAFKA-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1912: Fix Version/s: (was: 0.8.3) Create a simple request re-routing facility

[jira] [Updated] (KAFKA-1911) Log deletion on stopping replicas should be async

[ https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1911: Fix Version/s: (was: 0.8.3) Log deletion on stopping replicas should be async

[jira] [Resolved] (KAFKA-1913) App hungs when calls producer.send to wrong IP of Kafka broker

[ https://issues.apache.org/jira/browse/KAFKA-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-1913. - Resolution: Duplicate App hungs when calls producer.send to wrong IP of Kafka broker

[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706128#comment-14706128 ] ASF GitHub Bot commented on KAFKA-1566: --- GitHub user harshach opened a pull request:

[GitHub] kafka pull request: KAFKA-1566: Kafka environment configuration (k...

GitHub user harshach opened a pull request: https://github.com/apache/kafka/pull/156 KAFKA-1566: Kafka environment configuration (kafka-env.sh) You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/kafka KAFKA-1566

[jira] [Updated] (KAFKA-1893) Allow regex subscriptions in the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1893: Reviewer: Gwen Shapira Allow regex subscriptions in the new consumer

[jira] [Updated] (KAFKA-2007) update offsetrequest for more useful information we have on broker about partition

[ https://issues.apache.org/jira/browse/KAFKA-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2007: Fix Version/s: (was: 0.8.3) update offsetrequest for more useful information we have on broker

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706135#comment-14706135 ] Parth Brahmbhatt commented on KAFKA-1683: - [~gwenshap] I agree, the original KIP

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705911#comment-14705911 ] Edward Ribeiro commented on KAFKA-873: -- Sorry, I didn't follow here. Guava is not

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705909#comment-14705909 ] Edward Ribeiro commented on KAFKA-873: -- Sorry, I didn't follow here. Guava is not

[jira] [Updated] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1566: Reviewer: Gwen Shapira Kafka environment configuration (kafka-env.sh)

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705917#comment-14705917 ] Parth Brahmbhatt commented on KAFKA-873: Sorry, i misunderstood the original

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review96009 --- core/src/main/scala/kafka/api/FetchResponse.scala (line 172)

[jira] [Created] (KAFKA-2455) Test Failure: kafka.consumer.MetricsTest testMetricsLeak

Gwen Shapira created KAFKA-2455: --- Summary: Test Failure: kafka.consumer.MetricsTest testMetricsLeak Key: KAFKA-2455 URL: https://issues.apache.org/jira/browse/KAFKA-2455 Project: Kafka

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706099#comment-14706099 ] Gwen Shapira commented on KAFKA-1683: - [~harsha_ch] mmm... I'm talking about returning

[jira] [Commented] (KAFKA-1194) The kafka broker cannot delete the old log files after the configured time

[ https://issues.apache.org/jira/browse/KAFKA-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705947#comment-14705947 ] Michael Poindexter commented on KAFKA-1194: --- I have created a PR that should

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706097#comment-14706097 ] ASF GitHub Bot commented on KAFKA-1683: --- GitHub user gwenshap opened a pull request:

[jira] [Created] (KAFKA-2456) Disable SSLv3 for ssl.enabledprotocols config on client broker side

Sriharsha Chintalapani created KAFKA-2456: - Summary: Disable SSLv3 for ssl.enabledprotocols config on client broker side Key: KAFKA-2456 URL: https://issues.apache.org/jira/browse/KAFKA-2456

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1792: Fix Version/s: (was: 0.8.3) change behavior of --generate to produce assignment config with

[jira] [Updated] (KAFKA-1802) Add a new type of request for the discovery of the controller

[ https://issues.apache.org/jira/browse/KAFKA-1802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1802: Fix Version/s: (was: 0.8.3) Add a new type of request for the discovery of the controller

[jira] [Updated] (KAFKA-1842) New producer/consumer should support configurable connection timeouts

[ https://issues.apache.org/jira/browse/KAFKA-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1842: Fix Version/s: (was: 0.8.3) New producer/consumer should support configurable connection

[jira] [Updated] (KAFKA-1817) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

[ https://issues.apache.org/jira/browse/KAFKA-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1817: Fix Version/s: (was: 0.8.3) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

[jira] [Updated] (KAFKA-1796) Sanity check partition command line tools

[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1796: Fix Version/s: (was: 0.8.3) Sanity check partition command line tools

[jira] [Updated] (KAFKA-1772) Add an Admin message type for request response

[ https://issues.apache.org/jira/browse/KAFKA-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1772: Fix Version/s: (was: 0.8.3) Add an Admin message type for request response

[jira] [Updated] (KAFKA-1775) Re-factor TopicCommand into thew handerAdminMessage call

[ https://issues.apache.org/jira/browse/KAFKA-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1775: Fix Version/s: (was: 0.8.3) Re-factor TopicCommand into thew handerAdminMessage call

[jira] [Updated] (KAFKA-1786) implement a global configuration feature for brokers

[ https://issues.apache.org/jira/browse/KAFKA-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1786: Fix Version/s: (was: 0.8.3) implement a global configuration feature for brokers

[jira] [Updated] (KAFKA-1774) REPL and Shell Client for Admin Message RQ/RP

[ https://issues.apache.org/jira/browse/KAFKA-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1774: Fix Version/s: (was: 0.8.3) REPL and Shell Client for Admin Message RQ/RP

[jira] [Updated] (KAFKA-1777) Re-factor reasign-partitions into CLI

[ https://issues.apache.org/jira/browse/KAFKA-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1777: Fix Version/s: (was: 0.8.3) Re-factor reasign-partitions into CLI

[jira] [Updated] (KAFKA-1778) Create new re-elect controller admin function

[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1778: Fix Version/s: (was: 0.8.3) Create new re-elect controller admin function

[jira] [Created] (KAFKA-2454) Dead lock between delete log segment and shutting down.

Jiangjie Qin created KAFKA-2454: --- Summary: Dead lock between delete log segment and shutting down. Key: KAFKA-2454 URL: https://issues.apache.org/jira/browse/KAFKA-2454 Project: Kafka Issue

Re: KAFKA-2364 migrate docs from SVN to git

Also can we migrate svn repo to git repo? This will help us to fix occasional doc changes/bug fixes through github PR. On Thu, Aug 20, 2015 at 4:04 AM, Guozhang Wang wangg...@gmail.com wrote: Gwen: I remembered it wrong. We would not need another round of voting. On Wed, Aug 19, 2015 at

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705442#comment-14705442 ] Edward Ribeiro commented on KAFKA-873: -- [~granthenke], [~fpj], [~ijuma] Please, count

[jira] [Commented] (KAFKA-2454) Dead lock between delete log segment and shutting down.

[ https://issues.apache.org/jira/browse/KAFKA-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705491#comment-14705491 ] ASF GitHub Bot commented on KAFKA-2454: --- GitHub user becketqin opened a pull

[GitHub] kafka pull request: KAFKA-2454: Deadlock between log segment delet...

GitHub user becketqin opened a pull request: https://github.com/apache/kafka/pull/153 KAFKA-2454: Deadlock between log segment deletion and server shutdown. You can merge this pull request into a Git repository by running: $ git pull https://github.com/becketqin/kafka

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705537#comment-14705537 ] Parth Brahmbhatt commented on KAFKA-2210: - [~ijuma] [~junrao] Thanks for the

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705538#comment-14705538 ] Parth Brahmbhatt commented on KAFKA-1683: - [~gwenshap] Given this blocks

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/ --- (Updated Aug. 20, 2015, 6:27 p.m.) Review request for kafka. Bugs:

Re: Review Request 34492: Patch for KAFKA-2210

On Aug. 20, 2015, 10:29 a.m., Ismael Juma wrote: core/src/main/scala/kafka/network/RequestChannel.scala, line 48 https://reviews.apache.org/r/34492/diff/10/?file=1037026#file1037026line48 Normally one would use `Option[Session]` here. Are we using `null` due to efficiency

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Attachment: KAFKA-2210_2015-08-20_11:27:18.patch KafkaAuthorizer: Add all public entities,

[jira] [Updated] (KAFKA-2454) Dead lock between delete log segment and shutting down.

[ https://issues.apache.org/jira/browse/KAFKA-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2454: Status: Patch Available (was: Open) Dead lock between delete log segment and shutting down.

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705505#comment-14705505 ] Parth Brahmbhatt commented on KAFKA-2210: - Updated reviewboard

Re: Review Request 34492: Patch for KAFKA-2210

On Aug. 20, 2015, 1:07 a.m., Jun Rao wrote: core/src/main/scala/kafka/security/auth/Acl.scala, lines 84-87 https://reviews.apache.org/r/34492/diff/10/?file=1037027#file1037027line84 Do we need the case match here since acls is always a Set? Fixed. On Aug. 20, 2015, 1:07 a.m.,

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Status: Patch Available (was: In Progress) KafkaAuthorizer: Add all public entities,

Re: Review Request 34492: Patch for KAFKA-2210

On Aug. 20, 2015, 10:30 a.m., Ismael Juma wrote: One more thing: it may be a good idea to rebase against trunk since the large SSL/TLS patch has now been merged (not sure if there are any conflicts). Done. - Parth --- This is

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705513#comment-14705513 ] Jay Kreps commented on KAFKA-873: - Curator will add a transitive dependency on Guava for

[jira] [Assigned] (KAFKA-2452) enable new consumer in mirror maker

[ https://issues.apache.org/jira/browse/KAFKA-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-2452: --- Assignee: Jiangjie Qin enable new consumer in mirror maker

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705540#comment-14705540 ] Gwen Shapira commented on KAFKA-1683: - I think I'm good, expect a patch by Friday.

Re: Review Request 34492: Patch for KAFKA-2210

On Aug. 20, 2015, 10:29 a.m., Ismael Juma wrote: core/src/main/scala/kafka/security/auth/Operation.scala, line 42 https://reviews.apache.org/r/34492/diff/10/?file=1037030#file1037030line42 Generally a good idea to set the result type for public methods. This makes it possible to

[jira] [Comment Edited] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705003#comment-14705003 ] Jordan Zimmerman edited comment on KAFKA-873 at 8/20/15 2:30 PM:

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705003#comment-14705003 ] Jordan Zimmerman commented on KAFKA-873: NOTE: Curator's PersistenEphemeralNode

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705044#comment-14705044 ] Flavio Junqueira commented on KAFKA-873: Ah! That's what I was looking for, thanks

[jira] [Assigned] (KAFKA-1543) Changing replication factor

[ https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov reassigned KAFKA-1543: Assignee: Alexander Pakulov Changing replication factor

[jira] [Updated] (KAFKA-2411) remove usage of BlockingChannel in the broker

[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2411: --- Status: Patch Available (was: In Progress) Addressed feedback from Gwen, so setting status to Patch

[jira] [Created] (KAFKA-2451) Exception logged but not managed

Gwenhaël PASQUIERS created KAFKA-2451: - Summary: Exception logged but not managed Key: KAFKA-2451 URL: https://issues.apache.org/jira/browse/KAFKA-2451 Project: Kafka Issue Type: Bug

[GitHub] kafka pull request: KAFKA-2411; remove usage of blocking channel

Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: KAFKA-2411; remove usage of blocking channel

GitHub user ijuma reopened a pull request: https://github.com/apache/kafka/pull/151 KAFKA-2411; remove usage of blocking channel You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705145#comment-14705145 ] ASF GitHub Bot commented on KAFKA-2411: --- GitHub user ijuma reopened a pull request:

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705068#comment-14705068 ] nicu marasoiu commented on KAFKA-1282: -- Hi, I noticed that the dependencies are done

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705071#comment-14705071 ] Ismael Juma commented on KAFKA-873: --- Would there be an advantage to going to the bridge

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705096#comment-14705096 ] Flavio Junqueira commented on KAFKA-873: ZkClient is used in a number of places

[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705144#comment-14705144 ] ASF GitHub Bot commented on KAFKA-2411: --- Github user ijuma closed the pull request

[jira] [Updated] (KAFKA-1651) Removed some extra whitespace in KafkaServer.scala

[ https://issues.apache.org/jira/browse/KAFKA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1651: --- Resolution: Fixed Status: Resolved (was: Patch Available) These unwanted

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1901: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch - committed to

[GitHub] kafka pull request: KAFKA-2015: Enable ConsoleConsumer to use new ...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2015: - Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.3

[jira] [Commented] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705664#comment-14705664 ] ASF GitHub Bot commented on KAFKA-2015: --- Github user asfgit closed the pull request

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review96003 --- Ship it! Ship It! - Joel Koshy On Aug. 20, 2015, 7:08 a.m.,

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705842#comment-14705842 ] Flavio Junqueira commented on KAFKA-873: can we use shading to solve this problem?

  1   2   >