---
On Jan. 22, 2015, 10:35 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30196
a5386a03b62956bc440b40783247c8cdf7432315
Diff: https://reviews.apache.org/r/30527/diff/
Testing
---
Thanks,
Aditya Auradkar
On Jan. 26, 2015, 1:28 a.m., Neha Narkhede wrote:
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 235
https://reviews.apache.org/r/30196/diff/1/?file=831148#file831148line235
what is the purpose of this sleep?
Aditya Auradkar wrote:
I wanted to make
cbef84ac76e62768981f74e71d451f2bda995275
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
aeb7a19acaefabcc161c2ee6144a56d9a8999a81
Diff: https://reviews.apache.org/r/30196/diff/
Testing
---
Added an integration test to PrimitiveAPITest.scala.
Thanks,
Aditya Auradkar
asserts to the SimpleFetchTest to count the number of fetch
requests. I'm going to file an additional jira to add unit tests for all the
BrokerTopicMetrics updated via ReplicaManager
Thanks,
Aditya Auradkar
/consumer/SimpleConsumer.scala
cbef84ac76e62768981f74e71d451f2bda995275
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
a5386a03b62956bc440b40783247c8cdf7432315
Diff: https://reviews.apache.org/r/30196/diff/
Testing
---
Thanks,
Aditya Auradkar
://reviews.apache.org/r/30196/diff/
Testing (updated)
---
Added an integration test to PrimitiveAPITest.scala.
Thanks,
Aditya Auradkar
On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java,
line 21
https://reviews.apache.org/r/27799/diff/4/?file=828377#file828377line21
nit. Can we remove the public from the interface methods?
Jay Kreps
On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java,
line 21
https://reviews.apache.org/r/27799/diff/4/?file=828377#file828377line21
nit. Can we remove the public from the interface methods?
Jay Kreps
methods?
- Aditya Auradkar
On Jan. 21, 2015, 4:47 p.m., Jay Kreps wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/#review72817
---
On Feb. 17, 2015, 11:46 p.m., Aditya Auradkar wrote
/
Testing
---
I've added asserts to the SimpleFetchTest to count the number of fetch
requests. I'm going to file an additional jira to add unit tests for all the
BrokerTopicMetrics updated via ReplicaManager
Thanks,
Aditya Auradkar
://reviews.apache.org/r/30570/#review72845
---
On Feb. 17, 2015, 11:46 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/browse/KAFKA-1848
Repository: kafka
Description
---
Locally commit minor fix
Diffs
-
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
191a8677444e53b043e9ad6e94c5a9191c32599e
Diff: https://reviews.apache.org/r/29728/diff/
Testing
---
Thanks,
Aditya
/diff/
Testing
---
Thanks,
Aditya Auradkar
/#review71646
---
On Feb. 3, 2015, 7:13 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570
. And in general I think we might better record the request-level
metrics on KafkaApis layer intead of the ReplicaManager layer. There are
some previous work on isolating the request-level information in KafkaApis
layer.
Aditya Auradkar wrote:
All the BrokerTopicMetrics reporting happens below
---
On Feb. 3, 2015, 7:13 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/
---
(Updated
fb948b9ab28c516e81dab14dcbe211dcd99842b6
Diff: https://reviews.apache.org/r/30848/diff/
Testing
---
Thanks,
Aditya Auradkar
/SimpleFetchTest.scala
525c835803b048c952667567cd205b4b06824391
Diff: https://reviews.apache.org/r/31168/diff/
Testing (updated)
---
All unit tests now pass.
BUILD SUCCESSFUL
Total time: 9 mins 35.296 secs
Thanks,
Aditya Auradkar
525c835803b048c952667567cd205b4b06824391
Diff: https://reviews.apache.org/r/31168/diff/
Testing
---
Thanks,
Aditya Auradkar
/SimpleFetchTest.scala
525c835803b048c952667567cd205b4b06824391
Diff: https://reviews.apache.org/r/31168/diff/
Testing (updated)
---
All unit tests now pass.
Thanks,
Aditya Auradkar
PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Posted a KIP for quotas in kafka.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas
Appreciate any feedback.
Aditya
.
Thanks,
Jun
On Wed, Mar 4, 2015 at 3:51 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Posted a KIP for quotas in kafka.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas
Appreciate any
Hi Andrii,
Thanks for the writeup.
IMO, we should be able to support dynamically changing certain configs. For
example: the Quota proposal relies on such a mechanism for changing quotas on
the fly.
Aditya
From: Andrii Biletskyi
://reviews.apache.org/r/31967/#comment124158
Interesting point. I thought that it would be enough to simply check the
lag value. But yes, this will cause the HW to be inconsistent.
- Aditya Auradkar
On March 12, 2015, 8:42 p.m., Aditya Auradkar wrote
,
Aditya Auradkar
://reviews.apache.org/r/31967/#comment124449
Renamed.
We can use the raw offset directly, but in general the code is passing the
LogOffsetMetadata objects and it made sense to remain consistent.
- Aditya Auradkar
On March 16, 2015, 6:32 p.m., Aditya Auradkar wrote
, 2015 at 3:51 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Posted a KIP for quotas in kafka.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas
Appreciate any feedback.
Aditya
that this KIP doesn't need to block on the
migration of the metrics package.
Thanks,
Jun
On Wed, Mar 18, 2015 at 4:02 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Thanks for the great discussion. There are currently a few points on this
KIP that need addressing and I want
on the approach. Much better than before.
Thanks,
Jun
On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Details in the KIP, Jira and RB.
https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
https://issues.apache.org/jira
Rather, 6 binding +1's.
Aditya
From: Aditya Auradkar
Sent: Sunday, March 15, 2015 10:39 PM
To: dev@kafka.apache.org
Subject: RE: [VOTE] KIP-16: Replica Lag Tuning
Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark
as accepted
/scala/unit/kafka/server/LogRecoveryTest.scala
92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
/LogRecoveryTest.scala
92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
to integrate the backoff calculation with that algorithm
(assuming that is what we are using).
Cheers,
-Jay
On Wed, Mar 4, 2015 at 3:51 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Posted a KIP for quotas in kafka.
https://cwiki.apache.org/confluence/display/KAFKA
?
- Aditya Auradkar
On March 14, 2015, 12:13 a.m., Joseph Holsten wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32063
doing a good job of the windowed
metrics,
but
we'll want to integrate the backoff calculation with that
algorithm
(assuming that is what we are using).
Cheers,
-Jay
On Wed, Mar 4, 2015 at 3:51 PM, Aditya Auradkar
aaurad
Details in the KIP, Jira and RB.
https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
https://issues.apache.org/jira/browse/KAFKA-1546
https://reviews.apache.org/r/31967/
Aditya
c124c8df5b5079e5ffbd0c4ea359562a66aaf317
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya
- - - - - - - - - - - - - - - - -
On Thu, Mar 12, 2015 at 4:36 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
I wrote a KIP for this after some discussion on KAFKA-1546.
https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
The RB is here: https://reviews.apache.org/r/31967
I wrote a KIP for this after some discussion on KAFKA-1546.
https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
The RB is here: https://reviews.apache.org/r/31967/
Thanks,
Aditya
/
Testing
---
Thanks,
Aditya Auradkar
/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
c124c8df5b5079e5ffbd0c4ea359562a66aaf317
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya
Hey everyone,
Picking up this discussion after yesterdays KIP hangout. For anyone who did not
join the meeting, we have 2 different metrics packages being used by the
clients (custom package) and the server (codahale). We are discussing whether
to migrate the server to the new package.
What
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
92d6b2c672f74cdd526f2e98da8f7fb3696a88e3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
efb457334bd87e4c5b0dd2c66ae1995993cd0bc1
Diff: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya
to do this anyway since the new clients
are on KM metrics.
Thanks,
Joel
On Fri, Mar 27, 2015 at 06:48:48PM +, Aditya Auradkar wrote:
Adding to what Jay said.
The library maintains 1k samples by default. The UniformSample has a
long array so about 8k overhead per
Posted a KIP for quotas in kafka.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas
Appreciate any feedback.
Aditya
Thanks for the writeup and RB Joe/Dmitry.
Is it possible to describe the proposed partition reassignment algorithm in
more detail on the KIP? In fact, it would be really easy to understand if we
had some concrete examples comparing partition assignment with the old
algorithm and the new.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30196/#review71556
---
On Feb. 2, 2015, 9:57 p.m., Aditya Auradkar wrote:
---
This is an automatically
Congrats!
From: Andrew Otto [ao...@wikimedia.org]
Sent: Wednesday, February 25, 2015 12:06 PM
To: us...@kafka.apache.org
Cc: dev@kafka.apache.org
Subject: Re: Announcing the Confluent Platform built on Apache Kafka
Wow, .deb packages. I love you.
On
/browse/KAFKA-1986
Repository: kafka
Description
---
Patch for KAFKA-1986
Diffs
-
core/src/main/scala/kafka/server/ReplicaManager.scala
586cf4caa95f58d5b2e6c7429732d25d2b3635c8
Diff: https://reviews.apache.org/r/31449/diff/
Testing
---
Thanks,
Aditya Auradkar
: https://reviews.apache.org/r/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
these issues, and ripped them out. Whether they are really useful
or not, I don't know. Averages can be pretty misleading so it can be nice
but I don't know that it is critical.
-Jay
On Thu, Mar 26, 2015 at 1:58 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
From what I can tell
/AbstractFetcherThread.scala
https://reviews.apache.org/r/31366/#comment126602
Can you add some documentation for this class?
- Aditya Auradkar
On March 27, 2015, 10:31 p.m., Sriharsha Chintalapani wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31967/#review77799
---
On March 25, 2015, 8:27 p.m., Aditya Auradkar wrote
/31967/diff/
Testing
---
Thanks,
Aditya Auradkar
/GC performance. IIRC, when I was looking into codahale at LinkedIn,
I remember it having quite a few memory management and GC issues while
using histograms. In comparison, histograms in the new metrics package
aren't very well tested.
Thanks,
Neha
On Wed, Mar 25, 2015 at 8:25 AM, Aditya
/#review77810
---
On March 25, 2015, 8:27 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31967
: Aditya Auradkar
Sent: Friday, April 03, 2015 10:10 AM
To: dev@kafka.apache.org
Subject: RE: [KIP-DISCUSSION] KIP-13 Quotas
Thanks Jun.
Some thoughts:
10) I think it is better we throttle regardless of the produce/fetch version.
This is a nice feature where clients can tell if they are being throttled
On Wed, Apr 1, 2015 at 3:27 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
I've made changes to the KIP to capture our discussions over the last
couple of weeks.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas
I'll start a voting thread after people
9186c90de5a983a73b042fcb42987bfabae14fcf
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing (updated)
---
New tests added
Thanks,
Aditya Auradkar
/DelayedOperationTest.scala
9186c90de5a983a73b042fcb42987bfabae14fcf
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing
---
New tests added
Thanks,
Aditya Auradkar
/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing
---
Thanks,
Aditya Auradkar
-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
/ClientQuotaMetricsTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review80130
---
On April 21, 2015, 7:21 p.m., Aditya Auradkar wrote
---
Thanks,
Aditya Auradkar
://reviews.apache.org/r/33551/#comment132029
I was thinking that you could still process the fetchRequest outside the
locked segment. Is there a reason a flag wouldn't work?
- Aditya Auradkar
On April 25, 2015, 2:48 p.m., Sriharsha Chintalapani wrote
. The fetch request can still be performed outside
the locked segment.
- Aditya Auradkar
On April 25, 2015, 2:48 p.m., Sriharsha Chintalapani wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
Hey everyone,
Wrote up a KIP to update topic, client and broker configs dynamically via
Zookeeper.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
Please read and provide feedback.
Thanks,
Aditya
PS: I've intentionally kept this discussion separate from KIP-5
-client. That makes sense.
On Fri, Apr 24, 2015 at 11:02:29PM +, Aditya Auradkar wrote:
I think Joel's suggestion is quite good. It's still possible to throttle
other types of requests using purgatory but we will need a separate purgatory
and DelayedOperation variants of different request
Hey Joe,
Can you elaborate what you mean by a stop the world change? In this protocol,
we can target notifications to a subset of brokers in the cluster (controller
if we need to). Is the AdminChangeNotification a ZK notification or a request
type exposed by each broker?
Thanks,
Aditya
Hey Gwen,
Thanks for the feedback. As Joel said, these client configs do not introduce a
producer/consumer zk dependency. It is configuration that is needed by the
broker.
From your comments, I gather that you are more worried about managing broker
internal configs via Zookeeper since we
/
Testing (updated)
---
Thanks,
Aditya Auradkar
since it almost always leads to transient test failures.
Consider using TestUtils.waitUntilTrue().
Aditya Auradkar wrote:
Thanks Neha. I missed this review comment.
I agree sleeping isn't ideal here but I don't think there is a condition
I can wait on to trigger this specific
://reviews.apache.org/r/30196/diff/
Testing
---
Added an integration test to PrimitiveAPITest.scala.
Thanks,
Aditya Auradkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33551/#review81693
---
Ship it!
Ship It!
- Aditya Auradkar
On April 25, 2015, 8:35 p.m
manager updates this reference.
d. The KafkaConfiguration is the thing that allows doing the
configuration.onChange(my.config, callback)
-Jay
On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Wrote up a KIP to update topic, client
://reviews.apache.org/r/33049/#review82382
---
On April 28, 2015, 12:38 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
/
Testing
---
Thanks,
Aditya Auradkar
/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
., a DB). Possible options:
- ZooKeeper
- Kafka topic
- other? E.g. making it pluggable?
Any other requirements?
Thanks,
Joel
On Tue, May 05, 2015 at 01:38:09AM +, Aditya Auradkar
wrote:
Hey Neha
,
Aditya Auradkar
.
- Aditya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/#review82389
---
On May 7, 2015, 1:36 a.m., Aditya Auradkar wrote
tests added
Thanks,
Aditya Auradkar
/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
,
Aditya Auradkar
gradually.
-Jay
On Mon, May 4, 2015 at 1:31 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey Jay,
Thanks for the feedback.
1. We can certainly discuss what it means to remove the file configuration
as a thought exercise. However, is this something we want to do for real?
IMO
On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Wrote up a KIP to update topic, client and broker configs dynamically via
Zookeeper.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
Please read
the
configuration.onChange(my.config, callback)
-Jay
On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Wrote up a KIP to update topic, client and broker configs dynamically via
Zookeeper.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21
? E.g. making it pluggable?
Any other requirements?
Thanks,
Joel
On Tue, May 05, 2015 at 01:38:09AM +, Aditya Auradkar
wrote:
Hey Neha,
Thanks for the feedback.
1. In my earlier exchange
Thanks,
Aditya Auradkar
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
/ConsumerConnector.java
https://reviews.apache.org/r/34070/#comment134315
How does this work if the consumer doesn't own these partitions? Is it
possible to commit offsets for any topic? Just curious..
- Aditya Auradkar
On May 12, 2015, 1:39 a.m., Jiangjie Qin wrote
1 - 100 of 429 matches
Mail list logo
