Not able to download tests jar of kafka and kafka-streams from maven repo.

2016-09-13 Thread Satish Duggana
Hi, Below dependency is added in one of our repos to use EmbeddedKafkaCluster but dependency installation fails with an error mentioned later. org.apache.kafka kafka-streams 0.10.0.0 test-jar test This fails with an

Re: [DISCUSS] KIP-209 Connection String Support

2017-10-17 Thread Satish Duggana
You may need to update KIP with the details discussed in this thread in proposed changes section. >>My proposed format for the connection string would be: >>IP1:host1,IP2:host2,...IPN:hostn;parameterName=value1;parameterName2=value2;... parameterNameN=valueN Format should be

Re: [VOTE] KIP-207:The Offsets which ListOffsetsResponse returns should monotonically increase even during a partition leader change

2017-10-17 Thread Satish Duggana
+1 (non binding) Thanks, Satish. On Wed, Oct 18, 2017 at 1:56 AM, Jun Rao wrote: > Hi, Colin, > > Thanks for the KIP. +1. Just a minor comment. For the old client requests, > would it be better to return a LEADER_NOT_AVAILABLE error instead? > > Jun > > On Tue, Oct 17, 2017

Re: [VOTE] 0.11.0.2 RC0

2017-11-15 Thread Satish Duggana
+1 (non-binding) - Ran testAll on source - Verified signatures on binaries built with Scala-2.11 - Ran through quickstart of core/streams On Wed, Nov 15, 2017 at 12:46 AM, Gwen Shapira wrote: > +1 (binding) > > Validated signatures, compiled sources, ran through quickstart

Re: [VOTE] 1.0.0 RC4

2017-10-31 Thread Satish Duggana
+1 (non-binding) Verified signatures, ran tests on src dist. Thanks, Satish. On Wed, Nov 1, 2017 at 12:37 AM, Jeff Chao wrote: > +1 (non-binding). We ran our usual performance and regression suite and > found no noticeable negative impacts. > > - Jeff > Heroku > > On

Re: [kafka-clients] [VOTE] 2.0.0 RC1

2018-07-02 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll on 1.1.0-rc0 tag - Ran through quickstart of core/streams on builds. Thanks, Satish. On Sun, Jul 1, 2018 at 6:00 AM, Ted Yu wrote: > +1 > > Checked signatures > Ran test suite > > On Sat, Jun 30, 2018 at 2:37 AM, Rajini Sivaram > wrote: > > >

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

2017-12-26 Thread Satish Duggana
Thanks for the KIP, +1 from me. On Wed, Dec 27, 2017 at 7:42 AM, Bill Bejeck wrote: > Thanks for the KIP. +1 for me. > > On Tue, Dec 26, 2017 at 6:22 PM Ted Yu wrote: > > > +1 from me as well. > > > > On Tue, Dec 26, 2017 at 10:41 AM, Matthias J. Sax

Re: [VOTE] 1.1.1 RC0

2018-06-21 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll on 1.1.0-rc0 tag - Ran through quickstart of core/streams on builds. Thanks, Satish. On Thu, Jun 21, 2018 at 11:51 AM, zhenya Sun wrote: > +1 non-binding > > > 在 2018年6月21日,下午2:18,Andras Beni 写道: > > > > +1 (non-binding) > > > > Built .tar.gz,

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-13 Thread Satish Duggana
+1 (non binding) Thanks Vahid, On Tue, Aug 14, 2018 at 2:22 AM, Gwen Shapira wrote: > +1 (binding) > > On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < > vahidhashem...@us.ibm.com> wrote: > > > Hi all, > > > > I'd like to start a vote on KIP-289 to modify the default group id of > >

Re: [VOTE] KIP-325: Extend Consumer Group Command to Show Beginning Offsets

2018-08-16 Thread Satish Duggana
+1 Thanks, Satish. On Fri, Aug 17, 2018 at 1:45 AM, Bill Bejeck wrote: > +1 > > Thanks, > Bill > > On Thu, Aug 16, 2018 at 3:13 PM Ted Yu wrote: > > > +1 > > > > On Thu, Aug 16, 2018 at 12:05 PM Vahid S Hashemian < > > vahidhashem...@us.ibm.com> wrote: > > > > > I would like to start a vote

Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-24 Thread Satish Duggana
Hi Mani, Just a minor comment on the output of the command as given in KIP-357, you may want to remove "User:User1 has " as it is redundant for each ACL. It may be good to accept multiple principals option to avoid running this script multiple times with each principal to achieve the same. >>

Re: [VOTE] KIP-357: Add support to list ACLs per principal

2018-08-27 Thread Satish Duggana
+1 (non-binding) On Tue, Aug 28, 2018 at 2:59 AM, Harsha wrote: > +1 (binding) > > -Harsha > > On Mon, Aug 27, 2018, at 12:46 PM, Jakub Scholz wrote: > > +1 (non-binding) > > > > On Mon, Aug 27, 2018 at 6:24 PM Manikumar > wrote: > > > > > Hi All, > > > > > > I would like to start voting on

Re: [VOTE] KIP-336: Consolidate ExtendedSerializer/Serializer and ExtendedDeserializer/Deserializer

2018-08-22 Thread Satish Duggana
+1 On Wed, Aug 22, 2018 at 4:45 PM, Ted Yu wrote: > +1 > Original message From: Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> Date: 8/22/18 3:19 AM (GMT-08:00) To: > dev@kafka.apache.org Subject: Re: [VOTE] KIP-336: Consolidate > ExtendedSerializer/Serializer and

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-08-22 Thread Satish Duggana
Congrats Dong Lin! On Wed, Aug 22, 2018 at 10:08 AM, Abhimanyu Nagrath < abhimanyunagr...@gmail.com> wrote: > Congratulations, Dong! > > On Wed, Aug 22, 2018 at 6:20 AM Dhruvil Shah wrote: > > > Congratulations, Dong! > > > > On Tue, Aug 21, 2018 at 4:38 PM Jason Gustafson > > wrote: > > > > >

Re: [VOTE] 2.0.0 RC2

2018-07-15 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll on 2.0.0-rc2 tag - Ran through quickstart of core/streams on builds generated from tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks, Satish. On Sun 15 Jul, 2018, 9:55 PM Rajini Sivaram, wrote: > Hi Ismael, > > Thank you

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Satish Duggana
ages based on that header value. Thanks, Satish. On Fri, Aug 31, 2018 at 1:32 AM, Satish Duggana wrote: > Hi, > Thanks for the KIP. > > "* For us, the message keys represent some metadata which we use to > either ignore messages (if a loop-back to the sender), or log s

Re: [VOTE] KIP-322: Return new error code for DeleteTopics API when topic deletion disabled.

2018-07-04 Thread Satish Duggana
+1 Thanks, Satish. On Wed, Jul 4, 2018 at 4:11 PM, Daniele Ascione wrote: > +1 > > Thanks, > Daniele > > Il giorno mar 3 lug 2018 alle ore 23:55 Harsha ha > scritto: > > > +1. > > > > Thanks, > > Harsha > > > > On Tue, Jul 3rd, 2018 at 9:22 AM, Ted Yu wrote: > > > > > > > > > > > > > > +1 >

Re: [VOTE] 1.1.1 RC3

2018-07-09 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll on 1.1.0-rc0 tag with jdk-8. - Ran through quickstart of core/streams on builds. - Ran few internal apps targeting to topics on 3 node cluster. Thanks, Satish. On Mon, Jul 9, 2018 at 11:39 PM, Harsha wrote: > +1. > > * Ran unit tests > *

Re: [VOTE] KIP-249: Add Delegation Token Operations to Kafka Admin Client

2018-01-24 Thread Satish Duggana
+1, thanks for the KIP. ~Satish. On Wed, Jan 24, 2018 at 5:09 AM, Jun Rao wrote: > Hi, Mani, > > Thanks for the KIP. +1 > > Jun > > On Sun, Jan 21, 2018 at 7:44 AM, Manikumar > wrote: > > > Hi All, > > > > I would like to start a vote on KIP-249

Re: [ANNOUNCE] New committer: Matthias J. Sax

2018-01-17 Thread Satish Duggana
Congratulations Mathias! On Tue, Jan 16, 2018 at 11:52 AM, Becket Qin wrote: > Congrats, Matthias! > > On Mon, Jan 15, 2018 at 9:54 PM, Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Matthias! Congratulations! > > > > Konstantine > > > > On Mon, Jan 15,

Re: [VOTE] 1.1.0 RC2

2018-03-13 Thread Satish Duggana
Hi Damian, Given release plan link in earlier mail is about 1.0 release. You may want to replace that with 1.1.0 release plan link[1]. 1 - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75957546 Thanks, Satish. On Wed, Mar 14, 2018 at 12:47 AM, Damian Guy

Re: [VOTE] 1.1.0 RC2

2018-03-13 Thread Satish Duggana
, Satish Duggana <satish.dugg...@gmail.com> wrote: > Hi Damian, > Given release plan link in earlier mail is about 1.0 release. You may want > to replace that with 1.1.0 release plan link[1]. > > 1 - https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=75957

Re: [VOTE] 1.1.0 RC2

2018-03-14 Thread Satish Duggana
> > > > > > > > * Documentation: > > > http://kafka.apache.org/11/documentation.html > > > <http://kafka.apache.org/1/documentation.html> > > > > > > * Protocol: > > > http://kafka.apache.org/11/protocol.html > >

Re: [ANNOUNCE] New Committer: Manikumar Reddy

2018-10-15 Thread Satish Duggana
Congratulations Mani! On Fri, Oct 12, 2018 at 9:41 PM Colin McCabe wrote: > > Congratulations, Manikumar! Well done. > > best, > Colin > > > On Fri, Oct 12, 2018, at 01:25, Edoardo Comar wrote: > > Well done Manikumar ! > > -- > > > > Edoardo

Re: [VOTE] 2.0.1 RC0

2018-11-05 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll on 2.0.1 - Ran through quickstart of core/streams on builds generated from tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks, Satish. On Sat, Nov 3, 2018 at 2:32 AM Ewen Cheslack-Postava wrote: > > +1 > > -Ewen > > On Thu,

Re: [VOTE] 2.1.0 RC0

2018-11-05 Thread Satish Duggana
Hi Dong, Is there a RC1 planned with configs documentation fixes and https://github.com/apache/kafka/pull/5857 ? Thanks, Satish. On Thu, Nov 1, 2018 at 4:05 PM Jakub Scholz wrote: > > +1 (non-binding) ... I used the staged binaries and checked it with > different clients. > > On Wed, Oct 24,

Re: [VOTE] KIP-359: Verify leader epoch in produce requests

2018-09-02 Thread Satish Duggana
Thanks for the KIP, +1 (non-binding) On Sun, Sep 2, 2018 at 7:59 PM, Matthias J. Sax wrote: > +1 (binding) > > On 8/30/18 11:30 PM, Dongjin Lee wrote: > > Thanks for the KIP. I'm +1 (non-binding). > > > > Best, > > Dongjin > > > > On Fri, Aug 31, 2018 at 9:25 AM Dong Lin wrote: > > > >> Thanks

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-09-26 Thread Satish Duggana
Thanks for the KIP! +1 (non-binding) On Tue, Sep 25, 2018 at 1:38 PM, Ismael Juma wrote: > Thanks, +1 (binding). > > Ismael > > On Thu, Sep 20, 2018 at 8:12 PM Chia-Ping Tsai wrote: > >> KIP-336[1] has been merged so it is time to activate this thread >> (KIP-331[2]). Last discussion is about

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-25 Thread Satish Duggana
Congratulations Colin! On Wed, Sep 26, 2018 at 5:52 AM, Vahid Hashemian wrote: > Congratulations Colin! > > Regards. > --Vahid > > On Tue, Sep 25, 2018 at 3:43 PM Colin McCabe wrote: > >> Thanks, everyone! >> >> best, >> Colin >> >> >> On Tue, Sep 25, 2018, at 15:26, Robert Barrett wrote: >>

Re: [VOTE] KIP-371: Add a configuration to build custom SSL principal name

2018-09-23 Thread Satish Duggana
+1 (non binding) Thanks, Satish. On Fri, Sep 21, 2018 at 3:26 PM, Rajini Sivaram wrote: > Hi Manikumar, > > Thanks for the KIP! > > +1 (binding) > > On Thu, Sep 20, 2018 at 8:53 PM, Priyank Shah wrote: > >> +1(non-binding) >> >> On 9/20/18, 9:18 AM, "Harsha Chintalapani" wrote: >> >> +1

Re: [VOTE] 2.1.0 RC1

2018-11-18 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll on 2.1.0 successfully without any failures. - Ran through quickstart of core/streams on builds generated from tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks, Satish. On Sun, Nov 18, 2018 at 4:58 AM Jakub Scholz wrote: > >

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-15 Thread Satish Duggana
Congratulations Vahid! On Tue, Jan 15, 2019 at 5:47 PM Yishun Guan wrote: > > Congratulations! > > On Tue, Jan 15, 2019, 16:46 James Cheng wrote: > > > Congrats, Vahid!! > > > > -James > > > > > On Jan 15, 2019, at 2:44 PM, Jason Gustafson wrote: > > > > > > Hi All, > > > > > > The PMC for

Re: Fail-fast builds?

2018-12-21 Thread Satish Duggana
>>This would allow for fast failure on compilation and checkstyle problems, but let the whole test suite run in spite of test failures. +1 for that as it will be very useful. Thanks, Satish. On Fri, Dec 21, 2018 at 8:10 PM David Arthur wrote: > > Since this is a relatively simple change, I

Re: [DISCUSS] KIP-395: Encypt-then-MAC Delegation token metadata

2018-12-11 Thread Satish Duggana
Agree with Manikumar on having pluggable mechanism for entities required/created for delegation token mechanism. I will cover that as part of KAFKA-7694. Thanks, Satish. On Tue, Dec 11, 2018 at 12:35 PM Manikumar wrote: > > Hi, > > Thanks for the KIP. > > Currently, master/secret key is stored

Re: [VOTE] 2.2.0 RC0

2019-02-27 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll successfully with NO failures. - Ran through quickstart of core/streams on builds generated from 2.2.0-rc0 tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks for running the release Matthias! On Tue, Feb 26, 2019 at 8:17 PM

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-21 Thread Satish Duggana
Thanks for the KIP +1 (non-binding) On Thu, Feb 21, 2019 at 9:38 AM Harsha wrote: > > +1 (binding). > > Thanks, > Harsha > > On Tue, Feb 19, 2019, at 7:53 AM, Andrew Schofield wrote: > > Thanks for the KIP. > > > > +1 (non-binding) > > > > On 18/02/2019, 12:48, "Stanislav Kozlovski" wrote: > >

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

2019-02-21 Thread Satish Duggana
Thanks for the KIP, +1 (non-binding) ~Satish. On Thu, Feb 21, 2019 at 3:58 PM Rajini Sivaram wrote: > > I would like to start vote on KIP-430 to optionally obtain authorized > operations when describing resources: > >

Re: Release Date : 2.2.0

2019-02-26 Thread Satish Duggana
KAFKA-7895 is addressed in 2.2.0-rc0. You can look at https://github.com/apache/kafka/commits/2.2.0-rc0 which has the respective commit . Thanks, Satish. On Wed, Feb 27, 2019 at 9:36 AM Vaibhav Shukla wrote: > I

Re: [VOTE] 2.2.0 RC2

2019-03-19 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll successfully with no failures. - Ran through quickstart of core/streams on builds generated from 2.2.0-rc2 tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks for running the release Matthias! On Wed, Mar 20, 2019 at 12:43 AM

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-14 Thread Satish Duggana
Nice work Konstantine! +1 (non-binding) On Fri, Mar 15, 2019 at 7:48 AM Ewen Cheslack-Postava wrote: > +1 (binding) > > -Ewen > > On Wed, Mar 13, 2019 at 2:04 PM Randall Hauch wrote: > > > Excellent work, Konstantine! > > > > +1 (binding) > > > > On Mon, Mar 11, 2019 at 8:05 PM Konstantine

Re: [VOTE] KIP-436 Add a metric indicating start time

2019-03-07 Thread Satish Duggana
Thanks for the KIP, +1 (non-binding) ~Satish. On Thu, Mar 7, 2019 at 11:58 PM Manikumar wrote: > +1 (binding). > > Thanks for the KIP. > > Thanks, > Manikumar > > > On Thu, Mar 7, 2019 at 11:52 PM Colin McCabe wrote: > > > +1 (binding). > > > > Thanks, Stanislav. > > > > best, > > Colin > > >

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-02-06 Thread Satish Duggana
Thanks, Harsha for the KIP. It is a good start for tiered storage in Kafka. I have a few comments/questions. It may be good to have a configuration to keep the number of local segments instead of keeping only the active segment. This config can be exposed at cluster and topic levels with default

Re: [ANNOUNCE] New Committer: Randall Hauch

2019-02-15 Thread Satish Duggana
Congratulations Randall! On Fri, Feb 15, 2019 at 1:51 PM Mickael Maison wrote: > > Congrats Randall! > > On Fri, Feb 15, 2019 at 6:37 AM James Cheng wrote: > > > > Congrats, Randall! Well deserved! > > > > -James > > > > Sent from my iPhone > > > > > On Feb 14, 2019, at 6:16 PM, Guozhang Wang

Re: [DISCUSS] KIP-430 - Return Authorized Operations in Describe Responses

2019-02-13 Thread Satish Duggana
Hi Rajini, Thanks for the KIP. KIP proposes to add a new field called `authorized_operations` which is an array of Byte values. I guess these are APIKeys#id for respective operations. Do you plan to have an array of ids or an array of respective ApiKeys enum values in

Re: [ANNOUNCE] New Committer: Bill Bejeck

2019-02-13 Thread Satish Duggana
Congratulations Bill! On Thu, Feb 14, 2019 at 6:41 AM Marcelo Barbosa wrote: > > Wow! Congrats Bill! > Cheers, > Barbosa > Em quarta-feira, 13 de fevereiro de 2019 23:03:54 BRST, Guozhang Wang > escreveu: > > Hello all, > > The PMC of Apache Kafka is happy to announce that we've added

Re: [DISCUSS] KIP-430 - Return Authorized Operations in Describe Responses

2019-02-13 Thread Satish Duggana
Hi Rajini, That makes sense, thanks for the clarification. Satish. On Wed, Feb 13, 2019 at 7:30 PM Rajini Sivaram wrote: > > Thanks for the reviews! > > Hi Satish, > > The authorised operations returned will use the same values as the > operations returned by the existing DescribeAclsResponse.

Re: [VOTE] 2.1.1 RC2

2019-02-11 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll successfully with NO failures. - Ran through quickstart of core/streams on builds generated from tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks for running the release Colin! Satish. On Mon, Feb 11, 2019 at 2:29 PM

Re: [VOTE] 2.2.1 RC1

2019-06-01 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll successfully with no failures. - Ran through quickstart of core/streams on builds generated from 2.2.1-rc1 tag - Ran few internal apps targeting to topics on 3 node cluster. Thanks, Satish. On Sat, Jun 1, 2019 at 5:12 AM Matthias J. Sax wrote: >

Re: [VOTE] KIP-434: Dead replica fetcher and log cleaner metrics

2019-06-05 Thread Satish Duggana
Thanks Viktor, proposed metrics are really useful to monitor replication status on brokers. +1 (non-binding) On Thu, Jun 6, 2019 at 2:05 AM Colin McCabe wrote: > +1 (binding) > > best, > Colin > > > On Wed, Jun 5, 2019, at 03:38, Viktor Somogyi-Vass wrote: > > Hi Folks, > > > > This vote sunk

Re: [VOTE] 2.3.0 RC2

2019-06-17 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll successfully with no failures. - Ran through quickstart of core/streams on builds generated from 2.3.0-rc2 tag. - Ran few internal apps targeting to topics on 3 node cluster. Thanks, Satish. On Mon, Jun 17, 2019 at 7:25 PM David Arthur wrote: > >

Re: [ANNOUNCE] New Kafka PMC member: Sriharsh Chintalapan

2019-04-19 Thread Satish Duggana
Congrats Harsha! On Fri, Apr 19, 2019 at 2:58 PM Mickael Maison wrote: > Congratulations Harsha! > > > On Fri, Apr 19, 2019 at 5:49 AM Manikumar > wrote: > > > > Congrats Harsha!. > > > > On Fri, Apr 19, 2019 at 7:43 AM Dong Lin wrote: > > > > > Congratulations Sriharsh! > > > > > > On Thu,

Re: [ANNOUNCE] New Kafka PMC member: Matthias J. Sax

2019-04-19 Thread Satish Duggana
Congratulations Matthias! On Fri, Apr 19, 2019 at 2:59 PM Jorge Quilcate wrote: > Congrats Matthias!! > > On 4/19/19 11:28 AM, Mickael Maison wrote: > > Congrats Matthias! > > > > On Fri, Apr 19, 2019 at 6:07 AM Vahid Hashemian > > wrote: > >> Congratulations Matthias! > >> > >> --Vahid > >> >

Re: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-16 Thread Satish Duggana
Hi Sandeep, Thanks for the KIP, I have few comments below. >>“To take advantage of these custom algorithms, we want to support java >>security provider parameter in security config. This param can be used by >>kafka brokers or kafka clients(when connecting to the kafka brokers). The >>security

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-06-25 Thread Satish Duggana
+1 (non-binding) On Wed, Jun 26, 2019 at 8:37 AM Satish Duggana wrote: > > +1 Matthias/Andy. > IMHO, interface is about the contract, it should not have/expose any > implementation. I am fine with either way as it is more of taste or > preference. > > Agree wit

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-06-25 Thread Satish Duggana
; >>>> Thanks, > > >>>> > > >>>> Andy > > >>>> > > >>>> On Mon, 17 Jun 2019 at 19:01, Ryanne Dolan > > >> wrote: > > >>>> > > >>>>> Andy, while I agree that the new inter

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-13 Thread Satish Duggana
Hi Colin, Thanks for the KIP. Optional fields and var length encoding support is a great improvement for the protocol. >>Optional fields can have any type, except that they cannot be arrays. Note that the restriction against having tagged arrays is just to simplify serialization. We can relax

Re: [VOTE] KIP-492 Add java security providers in Kafka Security config

2019-07-29 Thread Satish Duggana
+1 (non-binding) Thanks, Satish. On Tue, Jul 30, 2019 at 5:18 AM Harsha Chintalapani wrote: > > Thanks for the KIP Sandeep. > > +1 (binding) > > Thanks, > Harsha > On Jul 29, 2019, 12:22 PM -0700, Sandeep Mopuri , wrote: > > Hi all, after some good discussion > >

Re: [DISCUSS] KIP-505 : Add new public method to only update assignment metadata in consumer

2019-08-11 Thread Satish Duggana
Hi Jungtaek, Thanks for the KIP. I have a couple of questions here. Is not Spark using Kafka's consumer group management across multiple consumers? Is Spark using KafkaConsumer#subscribe(Pattern pattern, ConsumerRebalanceListener listener) only to get all the topics for a pattern based

Re: [VOTE] KIP-503: deleted topics metric

2019-08-18 Thread Satish Duggana
+1(non-binding), very useful metrics for admin/ops. Thanks, Satish. On Sat, Aug 17, 2019 at 4:08 PM Manikumar wrote: > +1 (binding). > > Thanks for the KIP. LGTM. > > Thanks, > Manikumar > > On Wed, Aug 14, 2019 at 11:54 PM David Jacot wrote: > > > +1 (non-binding) > > > > Thanks for the

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-18 Thread Satish Duggana
or without array values). It seems struct types are currently not serialized with total length. I may be missing something here. Thanks, Satish. On Wed, Aug 14, 2019 at 8:03 AM Satish Duggana wrote: > > Hi Colin, > Thanks for the KIP. Optional fields and var length encoding support is a

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-18 Thread Satish Duggana
AM Satish Duggana wrote: > > Sorry! Colin, I may not have been clear in my earlier query about > optional field type restriction. It is mentioned in one of your > replies "optional fields are serialized starting with their total > length". This brings the question of whethe

Re: [VOTE] KIP-497: Add inter-broker API to alter ISR

2019-08-14 Thread Satish Duggana
+1 (non-binding), Thanks Jason for nice improvements on ISR propagation protocol! On Wed, Aug 14, 2019 at 8:29 PM David Arthur wrote: > > +1 binding, this looks great! > > -David > > On Tue, Aug 13, 2019 at 4:55 PM Guozhang Wang wrote: > > > +1 (binding). This is a great KIP, thanks Jason! > >

Re: [DISCUSS] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-08-21 Thread Satish Duggana
Hi David, Thanks for the KIP. I have a couple of questions. >> For the Java client, the idea is to define two constants in the code to >> store its name and its version. If possible, the version will be set >> automatically based on metadata coming from gradle (or the repo itself) to >> avoid

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-08-21 Thread Satish Duggana
Hi Jason, +1 (non binding) Thanks for the KIP! Do we need to have a separate JIRA to update the docs as it introduces new metrics and a change in behavior for the existing metric? On Wed, Aug 21, 2019 at 2:41 PM Mickael Maison wrote: > +1 (non binding) > Thanks Jason > > On Wed, Aug 21, 2019

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread Satish Duggana
+1 (non-binding) Thanks for the nice KIP. You may want to update the KIP saying that optional tagged fields do not support complex types(or structs). On Wed, Sep 4, 2019 at 3:43 AM Jose Armando Garcia Sancio wrote: > > +1 (non-binding) > > Looking forward to this improvement. > > On Tue, Sep 3,

Re: [DISCUSS] KIP-491: Preferred Leader Deprioritized List (Temporary Blacklist)

2019-09-16 Thread Satish Duggana
uld be > > > > > preferred leader should be modified. The broker in the preferred > > > > > leader > > > > > blacklist should be moved to the end (lowest priority) when > > > > > determining leadership. > > > > > > > > >

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-17 Thread Satish Duggana
Hi Kevin, Thanks for adding useful metrics with the KIP. On Wed, 18 Sep, 2019, 1:49 AM Kevin Lu, wrote: > Hi Manikumar, > > Thanks for the support. > > Since we have added a couple additional metrics, I have renamed the KIP > title to reflect the content better: KIP-517: Add consumer metrics

Re: [DISCUSS] KIP-487: Automatic Topic Creation on Producer

2019-08-06 Thread Satish Duggana
think I missed. > > Thank you, > Justine > > On Tue, Aug 6, 2019 at 12:01 PM Satish Duggana > wrote: > > > Hi Justine, > > Thanks for the KIP. This is a nice addition to the producer client > > without running admin-client’s create topic APIs. Does p

Re: [DISCUSS] KIP-491: Preferred Leader Deprioritized List (Temporary Blacklist)

2019-08-07 Thread Satish Duggana
), then try to move the leaders away from this broker, before doing > > an actual reassignment to change its preferred leader, try to put this > > preferred_leader_blacklist in the Topic Level config, and run preferred > > leader election, and see whether CPU decreases for th

Re: [DISCUSS] KIP-504 - Add new Java Authorizer Interface

2019-08-07 Thread Satish Duggana
I felt the same need when we want to add a pluggable API for core server functionality. This does not need to be part of this KIP, it can be a separate KIP. I can contribute those refactoring changes if others are OK with that. It is better to have a structure like below. kafka-common: common

Re: [DISCUSS] KIP-487: Automatic Topic Creation on Producer

2019-08-06 Thread Satish Duggana
Hi Justine, Thanks for the KIP. This is a nice addition to the producer client without running admin-client’s create topic APIs. Does producer wait for the topic to be created successfully before it tries to publish messages to that topic? I assume that this will not throw an error that the topic

[DISCUSS] Modularization of kafka client separating server related classes/interfaces

2019-08-08 Thread Satish Duggana
Hi, There are many classes in the client module that are not really related to the client. It is good to have common modules structure with respective classes/interfaces. Implementors/providers need to have dependency only on those modules instead of having a dependency on the client module.

Re: [VOTE] KIP-499 - Unify connection name flag for command line tool

2019-08-09 Thread Satish Duggana
+1 (non-binding) Thanks for the KIP, so useful. On Fri, Aug 9, 2019 at 4:42 PM Mickael Maison wrote: > +1 (non binding) > Thanks for the KIP! > > On Fri, Aug 9, 2019 at 9:36 AM Andrew Schofield > wrote: > > > > +1 (non-binding) > > > > On 09/08/2019, 08:39, "Sönke Liebau" > wrote: > > > >

Re: [DISCUSS] KIP-504 - Add new Java Authorizer Interface

2019-08-08 Thread Satish Duggana
actoring > clients so that others who are not following this KIP also notice the > discussion. Satish, would you like to start a discussion thread on dev? > > Regards, > > Rajini > > > On Wed, Aug 7, 2019 at 6:21 PM Satish Duggana > wrote: > > > I felt t

Re: [DISCUSS] KIP-491: Preferred Leader Deprioritized List (Temporary Blacklist)

2019-07-19 Thread Satish Duggana
Thanks for the KIP. I have put my comments below. This is a nice improvement to avoid cumbersome maintenance. >> The following is the requirements this KIP is trying to accomplish: The ability to add and remove the preferred leader deprioritized list/blacklist. e.g. new ZK path/node or new

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-07-25 Thread Satish Duggana
>>Under the proposed definition of RemoteTier, would it be possible to have an implementation that transfers older log segments to a slower storage tier, but one that is still local? Examples of slower local(ie mounted locally) tiers being HDDs vs SSDs, or NFS volumes. No, it does not allow

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-06-13 Thread Satish Duggana
Hi Andy, Thanks for the KIP. This is a good change and it gives the user a better handle on Admin client usage. I agree with the proposal except the new `Admin` interface having all the methods from `AdminClient` abstract class. It should be kept clean having only the admin operations as methods

Re: Subject: [VOTE] 2.2.2 RC2

2019-11-08 Thread Satish Duggana
+1 (non-binding) - Ran testAll/releaseTarGzAll successfully with no failures. - Ran through quickstart of core/streams on builds generated from 2.3.0-rc2 tag. - Ran a few internal apps with ~2500 topic-partitions on 5 a node cluster. Thanks, Satish. On Sat, Nov 9, 2019 at 4:41 AM Bill Bejeck

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-06 Thread Satish Duggana
that they are identical copies. > > Jun > > > On Fri, Nov 1, 2019 at 4:26 AM Satish Duggana > wrote: > > > Hi Jun, > > Thanks for looking into the updated KIP and clarifying our earlier queries. > > > > >20. It's fine to keep the HDFS binding

Re: [VOTE] KIP-514 Add a bounded flush() API to Kafka Producer

2019-11-07 Thread Satish Duggana
+1 (non-binding) On Thu, Nov 7, 2019 at 8:58 PM Ismael Juma wrote: > > +1 (binding) > > On Thu, Oct 24, 2019 at 9:33 PM radai wrote: > > > Hello, > > > > I'd like to initiate a vote on KIP-514. > > > > links: > > the kip - > >

Re: [DISCUSS] KIP-501 Avoid out-of-sync or offline partitions when follower fetch requests not processed in time

2019-11-06 Thread Satish Duggana
sts are tracked? > > Thanks, > Dhruvil > > On Mon, Oct 28, 2019 at 9:43 PM Satish Duggana > wrote: > > > Hi All, > > I wrote a short KIP about avoiding out-of-sync or offline partitions > > when follower fetch requests are not processed in time by the leader >

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-01 Thread Satish Duggana
> Thanks, > > Jun > > On Mon, Oct 28, 2019 at 9:11 PM Satish Duggana > wrote: > > > Hi Viktor, > > >1. Can we allow RLM Followers to serve read requests? After all segments > > on > > the cold storage are closed ones, no modification is allowed. Besi

Re: [VOTE] KIP-531: Drop support for Scala 2.11 in Kafka 2.5

2019-11-18 Thread Satish Duggana
+1 (non-binding), Thanks Ismael for the KIP. I believe it is time to drop Scala 2.11. On Mon, Nov 18, 2019 at 7:10 PM Ivan Yurchenko wrote: > > Do I understand correctly, that non-commiters can also vote, despite their > votes don't decide? > > If so, then +1 from me. > > Ivan > > > On Mon, 18

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-06 Thread Satish Duggana
>So that means a consumer which gets behind by half an hour will find its reads being served from remote storage. And, if I understand the proposed algorithm, each such consumer fetch request could result in a separate fetch request from the remote storage. I.e. there's no mechanism to amortize

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-06 Thread Satish Duggana
7, 2019 at 8:33 AM Satish Duggana wrote: > > >So that means a consumer which gets behind by half an hour will find its > reads being served from remote storage. And, if I understand the proposed > algorithm, each such consumer fetch request could result in a separate > fetch reque

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-06 Thread Satish Duggana
eLogIndexEntry are offset index entries pointing to record > > batches inside a segment. That seems to be the same as the .index file? > > > > Thanks, > > > > Jun > > > > On Mon, Oct 28, 2019 at 9:11 PM Satish Duggana > > wrote: > > >

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-06 Thread Satish Duggana
t 7:55 AM Satish Duggana wrote: > > >Depends on the implementation, the data of one segment may not necessary be > stored in a single file. > There could be a maximum object / chunk / file size restriction on the > remote storage. So, one Kafka > segment could be saved in mul

Re: [ANNOUNCE] New committer: Mickael Maison

2019-11-08 Thread Satish Duggana
Congratulations Mickael!! On Fri, Nov 8, 2019 at 2:50 PM Rajini Sivaram wrote: > > Congratulations, Mickael, well deserved!! > > Regards, > > Rajini > > On Fri, Nov 8, 2019 at 9:08 AM David Jacot wrote: > > > Congrats Mickeal, well deserved! > > > > On Fri, Nov 8, 2019 at 8:56 AM Tom Bentley

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-12-05 Thread Satish Duggana
Hi Jun, Thanks for your reply. Currently, `listRemoteSegments` is called at the configured interval(not every second, defaults to 30secs). Storing remote log metadata in a strongly consistent store for S3 RSM is raised in PR-comment[1]. RLM invokes RSM at regular intervals and RSM can give remote

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-10-24 Thread Satish Duggana
reside in > > > other repositories. If I understand the intention correctly, you are > > > proposing to have an HDFS and S3 implementation as part of the Kafka > > > repository working out of the box. Is that correct? > > > > > > Thanks > > > Eno >

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-10-24 Thread Satish Duggana
repositories. If I understand the intention correctly, you are > > proposing to have an HDFS and S3 implementation as part of the Kafka > > repository working out of the box. Is that correct? > > > > Thanks > > Eno > > > > On Wed, Oct 23, 2019 at 5:01 AM Satish

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-10-25 Thread Satish Duggana
gt; > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Apr 1, 2019, at 1:02 AM, Viktor Somogyi-Vass wrote: > > > > > > > > > Hey Harsha, > > > > > > > > > > > &g

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-10-28 Thread Satish Duggana
> >> > It's probably worth it making it clearer in the KIP what exact > >> > libraries will be added to libs, if any. The KIP specifies the remote > >> > storage interface but it isn't clear if particular implementations > >> > will be added to Ka

[DISCUSS] KIP-501 Avoid out-of-sync or offline partitions when follower fetch requests not processed in time

2019-10-28 Thread Satish Duggana
Hi All, I wrote a short KIP about avoiding out-of-sync or offline partitions when follower fetch requests are not processed in time by the leader replica. KIP-501 is located at https://s.apache.org/jhbpn Please take a look, I would like to hear your feedback and suggestions. JIRA:

Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-22 Thread Satish Duggana
Thanks Jason for the KIP. +1 (non-binding). I assume this change will be added to the upgrade notes as the new values are effective for clusters that were using earlier defaults. Cluster may get into the race condition of having lower replica.lag.time.max.ms on a leader than

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-10-22 Thread Satish Duggana
; > > > > the project so that it could be built and released separately > > > from > > > > > > the > > > > > > > > main > > > > > > > > > Kafka packages." >

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-10-21 Thread Satish Duggana
g > > > > for > > > > > > > > other storage implementations. > > > > > > > > > > > > > > > > Best, > > > > > > > > Viktor > > > > > > > > > > > > > > >

Re: [DISCUSS] KIP-501 Avoid out-of-sync or offline partitions when follower fetch requests not processed in time

2019-11-18 Thread Satish Duggana
ason > > On Wed, Nov 6, 2019 at 8:14 AM Satish Duggana > wrote: > > > Hi Dhruvil, > > Thanks for looking into the KIP. > > > > 10. I have an initial sketch of the KIP-500 in commit[a] which > > discusses tracking the pending fetch requests. Tracking i

Re: [DISCUSS] KIP-405: Kafka Tiered Storage

2019-11-18 Thread Satish Duggana
Hi Jun, Thanks for your detailed review and comments. >40. Local segment metadata storage: The KIP makes the assumption that the metadata for the archived log segments are cached locally in every broker and provides a specific implementation for the local storage in the framework. We probably

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-22 Thread Satish Duggana
Thanks for the KIP, +1 (non binding) This looks to be a useful API for admin tools. When we worked on an admin tool for Kafka, we had to explicitly call the config API for showing the configs for the newly created topic. I have a minor-nit comment on `CreateResult` which seems to be a slightly

  1   2   3   4   >