Re: Review Request 35867: Patch for KAFKA-1901

. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review95902 --- On Aug. 20, 2015, 7:08 a.m., Manikumar Reddy O wrote

Re: Review Request 35867: Patch for KAFKA-1901

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 36578: Patch for KAFKA-2338

://reviews.apache.org/r/36578/#comment151144 The warning message can be : WARNING: %s has been increased beyond the default max value of %d, update producer and consumer settings as well Also do want to include patch for second point given in JIRA decription.. - Manikumar Reddy O On July

Re: Review Request 36578: Patch for KAFKA-2338

On Aug. 20, 2015, 11:07 a.m., Edward Ribeiro wrote: Also do want to include patch for second point given in JIRA decription.. just read previous reviews..ignore my comment. - Manikumar Reddy --- This is an automatically generated

Re: Review Request 34805: Patch for KAFKA-2213

://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

db1b0ee9113215b5ad7fda0f93915f3bdd34ac55 core/src/main/scala/kafka/utils/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

--- On Aug. 9, 2015, 9:37 a.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867

Re: Review Request 34641: Patch for KAFKA-2214

://reviews.apache.org/r/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

--- On Aug. 5, 2015, 3:19 p.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641

Re: Review Request 34641: Patch for KAFKA-2214

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92024 --- On Aug. 5, 2015, 3:19 p.m., Manikumar Reddy O wrote

Re: Review Request 34641: Patch for KAFKA-2214

/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

advertised, so you only notice this once your deployment script breaks). Manikumar Reddy O wrote: Yes, we can consider in-progress as errors. Other option could be returning a different error code. Let us wait for others suggestions/concerns. Gwen Shapira wrote: I wouldn't consider

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review91574 --- On July 14, 2015, 12:32 p.m., Manikumar Reddy O wrote

Re: Review Request 35867: Patch for KAFKA-1901

: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

://reviews.apache.org/r/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

the System.exit(1). Also, I'm afraid that printing the entire stack trace is intimidating to non-developers who use the CLI. Perhaps the stack trace should go under log.error(...)? Manikumar Reddy O wrote: Calling System.exit(1) in catch block results unexecuted finally block

Re: Review Request 35867: Patch for KAFKA-1901

/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c core/src/main/scala/kafka/server/KafkaServer.scala 18917bc4464b9403b16d85d20c3fd4c24893d1d3 Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35454: Patch for KAFKA-2159

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

--- On July 6, 2015, 6:05 a.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880

Re: Review Request 34805: Patch for KAFKA-2213

Reddy O On July 10, 2015, 2:50 p.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated

Re: Review Request 34805: Patch for KAFKA-2213

://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/#review91310 --- On July 10, 2015, 5:44 p.m., Manikumar Reddy O wrote

Re: Review Request 34641: Patch for KAFKA-2214

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

--- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

db1b0ee9113215b5ad7fda0f93915f3bdd34ac55 core/src/main/scala/kafka/utils/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

--- On June 25, 2015, 4:25 p.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880

Re: Review Request 35867: Patch for KAFKA-1901

. To reply, visit: https://reviews.apache.org/r/35867/#review89379 --- On June 25, 2015, 10:11 a.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 35867: Patch for KAFKA-1901

core/src/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c core/src/main/scala/kafka/server/KafkaServer.scala 52dc728bb1ab4b05e94dc528da1006040e2f28c9 Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35867: Patch for KAFKA-1901

/MetricsTest.java 544e120594de78c43581a980b1e4087b4fb98ccb core/src/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

: https://reviews.apache.org/r/35867/#review89364 --- On June 25, 2015, 10:11 a.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 35880: Patch for KAFKA-2295

/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35503: Patch for KAFKA-2012

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/#review88470 --- On June 19, 2015, 1:27 p.m., Manikumar Reddy O wrote

Re: Review Request 35503: Patch for KAFKA-2012

a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35503: Patch for KAFKA-2012

a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35610: Patch for KAFKA-2265

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35454: Patch for KAFKA-2159

b320ce9f6a12c0ee392e91beb82e8804d167f9f4 core/src/main/scala/kafka/server/OffsetManager.scala 5cca85cf727975f6d3acb2223fd186753ad761dc Diff: https://reviews.apache.org/r/35454/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34805: Patch for KAFKA-2213

: https://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35503: Patch for KAFKA-2012

8e095d652851f05365e1d3bbe3e9e1c3345b7a40 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35454: Patch for KAFKA-2159

2d75186a110075e0c322db4b9f7a8c964a7a3e88 core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 Diff: https://reviews.apache.org/r/35454/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35437: Patch for KAFKA-2202

903318d15893af08104a97499798c9ad0ba98013 Diff: https://reviews.apache.org/r/35437/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35421: Patch for KAFKA-2026

/ Testing --- Thanks, Manikumar Reddy O

Review Request 35418: Patch for KAFKA-2264

b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb Diff: https://reviews.apache.org/r/35418/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35419: Patch for KAFKA-2262

Reddy O

Review Request 35424: Patch for KAFKA-2234

912b718ec9ad58b1c2d42337ed85bbb1b88162d6 Diff: https://reviews.apache.org/r/35424/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 34805: Patch for KAFKA-2213

c9ade7208798fbd92d4ff49e183fe5f8925c82a9 core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 471ddff9bff1bdfa277c071e59e5c6b749b9c74f Diff: https://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 33049: Patch for KAFKA-2084

://reviews.apache.org/r/33049/#comment137140 Are we using clientID as uniqueKey?. But as of now, clientID is not mandatory and it need not be unique acorss different producer and consumers. - Manikumar Reddy O On May 26, 2015, 6:53 p.m., Aditya Auradkar wrote

Re: Review Request 34641: Patch for KAFKA-2214

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review85154 --- On May 24, 2015, 11:58 a.m., Manikumar Reddy O wrote

Review Request 34403: Patch for KAFKA-2198

--- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

://reviews.apache.org/r/34403/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

://reviews.apache.org/r/34403/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

produced, 1136608 rows of data consumed (88.6% reduction). De-duplicating and validating output files... Validated 899853 values, 0 mismatches. Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

... Logging consumed messages to /tmp/kafka-log-cleaner-consumed-63626021421841220.txt 1000 rows of data produced, 1136608 rows of data consumed (88.6% reduction). De-duplicating and validating output files... Validated 899853 values, 0 mismatches. Thanks, Manikumar Reddy O

Re: Review Request 30801: Patch for KAFKA-1758

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 30801: Patch for KAFKA-1758

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30801/#review81622 --- On May 9, 2015, 7:02 a.m., Manikumar Reddy O wrote

Review Request 33334: Patch for KAFKA-2131

/producer/ProducerConfig.java ca1c7fedbde7f53d64426da3a1aa3aeeafd2e9ad Diff: https://reviews.apache.org/r/4/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 30321: Patch for kafka-1902

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69813 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 27, 2015, 4:16

Re: Review Request 30078: Patch for KAFKA-1885

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69532 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 24, 2015, 5:13

Re: Review Request 30078: Patch for KAFKA-1885

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69533 --- Ship it! Non-Binding +1 - Manikumar Reddy O On Jan. 24, 2015, 5

Review Request 30128: Patch for KAFKA-1861

/browse/KAFKA-1861 Repository: kafka Description --- include clients test jar in maven artifacts Diffs - build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28 Diff: https://reviews.apache.org/r/30128/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 30073: Patch for KAFKA-1109

--- Thanks, Manikumar Reddy O

Re: Review Request 30022: Patch for KAFKA-1761

88689df718364f5a9bef143d4cb7e807a9251786 Diff: https://reviews.apache.org/r/30022/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 30022: Patch for KAFKA-1761

: https://reviews.apache.org/r/30022/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

produced, 1136608 rows of data consumed (88.6% reduction). De-duplicating and validating output files... Validated 899853 values, 0 mismatches. Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

clients/src/main/java/org/apache/kafka/common/MetricName.java 4e810d56b753b7eeb662b99af5cdf36bcfba7ea7 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29756: Patch for KAFKA-1854

Reddy O On Jan. 9, 2015, 8:09 a.m., Jaikiran Pai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/ --- (Updated Jan. 9

Re: Review Request 29523: Patch for KAFKA-1723

/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29523/#review67246 --- On Jan. 9, 2015, 6:15 p.m., Manikumar Reddy O wrote

Re: Review Request 29523: Patch for KAFKA-1723

://reviews.apache.org/r/29523/#review67314 --- On Jan. 9, 2015, 6:15 p.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 29756: Patch for KAFKA-1854

On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: kafka-patch-review.py, line 96 https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96 Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking

Re: Review Request 29523: Patch for KAFKA-1723

/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29756: Patch for KAFKA-1854

/#comment111442 Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue(). - Manikumar Reddy O On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote

Re: Review Request 29756: Patch for KAFKA-1854

On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: kafka-patch-review.py, line 96 https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96 Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking

Re: Review Request 29738: Patch for kafka-1797

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29738/#review67374 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 9, 2015, 1:22 a.m

Re: Review Request 29724: Patch for KAFKA-1566

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29724/#review67376 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 8, 2015, 8:47 p.m

Re: Review Request 29590: 1. Removed defaults for serializer/deserializer. 2. Converted type cast exception to serialization exception in the producer. 3. Added string ser/deser. 4. Moved the isKey fl

/StringSerializer.java https://reviews.apache.org/r/29590/#comment111066 we should support null values right?. This is required for compaction.. - Manikumar Reddy O On Jan. 5, 2015, 7:47 p.m., Jun Rao wrote: --- This is an automatically

Re: Review Request 29523: Patch for KAFKA-1723

clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 29523: Patch for KAFKA-1723

9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 24704: Patch for KAFKA-1499

://reviews.apache.org/r/24704/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 24704: Patch for KAFKA-1499

--- On Dec. 26, 2014, 4:09 p.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65316 --- On Dec. 26, 2014, 4:09 p.m., Manikumar Reddy O wrote: --- This is an automatically

Re: Review Request 24704: Patch for KAFKA-1499

, Manikumar Reddy O

Re: Review Request 28536: Patch for KAFKA-1799

8d886105341555a548ecc7b2901e7fc5d6b1ee8c Diff: https://reviews.apache.org/r/28536/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 28536: Patch for KAFKA-1799

/config/AbstractConfig.java 8d886105341555a548ecc7b2901e7fc5d6b1ee8c clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28536/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 28536: Patch for KAFKA-1799

. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28536/#review63295 --- On Nov. 30, 2014, 10:35 a.m., Manikumar Reddy O wrote

Review Request 28536: Patch for KAFKA-1799

://reviews.apache.org/r/28536/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 27684: Patch for KAFKA-1743

/consumer/ZookeeperConsumerConnectorTest.scala bad099a904967651bc3a38b6bb9a9cdb592b832b Diff: https://reviews.apache.org/r/27684/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 27684: Patch for KAFKA-1743

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review61863 --- On Nov. 18, 2014, 5:29 a.m., Manikumar Reddy O wrote

Re: Review Request 27684: Patch for KAFKA-1743

://reviews.apache.org/r/27684/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 27684: Patch for KAFKA-1743

/27684/#review61486 --- On Nov. 16, 2014, 6:42 a.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684

Re: Review Request 27684: Patch for KAFKA-1743

07677c1c26768ef9c9032626180d0015f12cb0e0 Diff: https://reviews.apache.org/r/27684/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 27684: Patch for KAFKA-1743

be confused with 2 methods, one w/o parenthsis and one with 1 parameter having a default? Could you try compiling the code on all scala versions? Manikumar Reddy O wrote: Currently below classes uses the new method commitOffsets(true). kafka/javaapi/consumer

Re: Review Request 27684: Patch for KAFKA-1743

be confused with 2 methods, one w/o parenthsis and one with 1 parameter having a default? Could you try compiling the code on all scala versions? Manikumar Reddy O wrote: Currently below classes uses the new method commitOffsets(true). kafka/javaapi/consumer

Re: Review Request 27684: Patch for KAFKA-1743

. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60652 --- On Nov. 8, 2014, 6:20 a.m., Manikumar Reddy O wrote

Review Request 27722: Patch for KAFKA-1749

/27722/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 27723: Patch for KAFKA-1739

/27723/diff/ Testing --- Thanks, Manikumar Reddy O

  1   2   >