Review Request 58554: KYLIN-2557:The kylin will start failed because of creating HBase table confict when multiple instances of the kylin are started at the same time.

: https://reviews.apache.org/r/58554/diff/1/ Testing --- Thanks, pengjianhua

Review Request 58610: Failed to create HDFS directory because of the property 'kylin.env.hdfs-working-dir' can not be empty in check-env.sh but we didn't check it in this script.

--- Thanks, pengjianhua

Review Request 60858: KYLIN-2742 Spring security 4.x will use a dynamically generated default login page when no login page is specified.

' to access kylin, or refresh on login page, will jump to spring security dynamically generated login page. Diffs - server/src/main/resources/kylinSecurity.xml 53ed5115d Diff: https://reviews.apache.org/r/60858/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60858: KYLIN-2742 Spring security 4.x will use a dynamically generated default login page when no login page is specified.

://reviews.apache.org/r/60858/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 61022: KYLIN-2703 kylin supports managing access rights for project and cube through apache ranger.

/partials/cubes/cube_detail.html 4319b94e2 webapp/app/partials/projects/project_detail.html 5cfc091ab Diff: https://reviews.apache.org/r/61022/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 61022: KYLIN-2703 kylin supports managing access rights for project and cube through apache ranger.

/kylinProperties.js 645ed2f3d webapp/app/partials/cubes/cube_detail.html 4319b94e2 webapp/app/partials/projects/project_detail.html 5cfc091ab Diff: https://reviews.apache.org/r/61022/diff/2/ Changes: https://reviews.apache.org/r/61022/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 60420: KYLIN-2684 Failed to build cube with spark engine

eDesc.java 82d0b1b24 Diff: https://reviews.apache.org/r/60420/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60456: KYLIN-2688 When the model has a ready cube, should not allow user to edit model JSON in web.

- webapp/app/js/controllers/models.js fd218459d webapp/app/partials/models/models_tree.html c7b55a31e Diff: https://reviews.apache.org/r/60456/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60673: KYLIN-2713 Kylin failed to compile?ITJdbcSourceTableLoaderTest.java and ITJdbcTableReaderTest.java missing license

/ITJdbcSourceTableLoaderTest.java a84dca9bd kylin-it/src/test/java/org/apache/kylin/source/jdbc/ITJdbcTableReaderTest.java 7850952c8 Diff: https://reviews.apache.org/r/60673/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60673: KYLIN-2713 Kylin failed to compile, ITJdbcSourceTableLoaderTest.java and ITJdbcTableReaderTest.java missing license

7850952c8 Diff: https://reviews.apache.org/r/60673/diff/1/ Testing --- Thanks, pengjianhua

Review Request 58701: When we execute the script 'kylin_port_replace_util.sh' to modify kylin port, it will reset other property in kylin.properties.

n_port_replace_util.sh 47b0d74f7 Diff: https://reviews.apache.org/r/58701/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 58786: Kylin failed to start because of parsing 'hcatalog_home' error in 'find-hive-dependency.sh'

/' as a delimiter, the result is that getting the wrong hive_home : '/opt/parcels' Diffs - build/bin/find-hive-dependency.sh aa39da0ab Diff: https://reviews.apache.org/r/58786/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 58554: KYLIN-2557:The kylin will start failed because of creating HBase table confict when multiple instances of the kylin are started at the same time.

://reviews.apache.org/r/58554/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 59165: Execute sample.sh script failure in hdfs federation environment

/ Testing --- Thanks, pengjianhua

Re: Review Request 59165: KYLIN-2605: Execute sample.sh script failure in hdfs federation environment

/ Diffs - build/bin/sample.sh 617b67182 examples/sample_cube/create_sample_tables.sql 24f26f88b Diff: https://reviews.apache.org/r/59165/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59173: KYLIN-2609 Grant role access to the project failed on the project manage page.

d. Finally I refresh the page and re-execute the second step, it grants access successfully. Diffs - webapp/app/js/controllers/access.js 0e0664a4f Diff: https://reviews.apache.org/r/59173/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 58943: KYLIN-2582 'Server Config' should be refreshed automatically in web page 'System', after we update it successfully.

the page to see the modified configuration items. 'Reload Config' has the same problem. Diffs - webapp/app/js/controllers/admin.js 783ab1794 Diff: https://reviews.apache.org/r/58943/diff/2/ Testing --- Thanks, pengjianhua

Review Request 59270: KYLIN-2621 The user of the LDAP group named "admin" always has ROLE_ADMIN permission

se/src/main/java/org/apache/kylin/rest/security/AuthoritiesPopulator.java 2b290ce8f Diff: https://reviews.apache.org/r/59270/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 58554: KYLIN-2557:The kylin will start failed because of creating HBase table confict when multiple instances of the kylin are started at the same time.

://reviews.apache.org/r/58554/diff/2-3/ Testing --- Thanks, pengjianhua

Review Request 59875: KYLIN-2660 "Load Hive Table From Tree" page always show "Loading Databases" without error tips, when hive error occurs and can not be connected.

d6656 Diff: https://reviews.apache.org/r/59875/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59521: KYLIN-2644 When I refresh the insight page and click "Add Project" button, but the new project pop-up page is not showing.

404 (Not Found)" error in the browser console. Diffs - webapp/app/partials/query/query.html 69fe6491c Diff: https://reviews.apache.org/r/59521/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59488: KYLIN-2641 The current selected project is incorrect after we delete a project.

/ Testing --- Thanks, pengjianhua

Review Request 59449: KYLIN-2637 The tips is not shown after creating project successfully.

oject", newProj.name); location.reload(); 'SweetAlert' is invoked before 'location.reload()', so it cannot be shown. Diffs - webapp/app/js/controllers/page.js 056cc488f Diff: https://reviews.apache.org/r/59449/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59449: KYLIN-2637 The tips is not shown after creating project successfully.

ache.org/r/59449/diff/2-3/ Testing --- Thanks, pengjianhua

Review Request 59712: KYLIN-2655 There are some minor problems with the duration of the job when resuming the error job or stopped job.

/src/main/java/org/apache/kylin/engine/mr/common/JobInfoConverter.java 189e0194e tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java 068dbda4f Diff: https://reviews.apache.org/r/59712/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59822: KYLIN-2656 Support Zookeeper ACL

://reviews.apache.org/r/59822/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59911: KYLIN-2661 Cube list page has some minor problems when using MODELER or ANALYST users.

rg/r/59911/diff/1/ Testing --- Thanks, pengjianhua

Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

: https://reviews.apache.org/r/62346/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

keykwords in query box. Please see 1.jpg. Diffs (updated) - webapp/app/partials/query/query.html 894113e0d Diff: https://reviews.apache.org/r/62346/diff/3/ Changes: https://reviews.apache.org/r/62346/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

) to list keywords in query box. Please see 1.jpg. Diffs - webapp/app/partials/query/query.html 894113e0d Diff: https://reviews.apache.org/r/62346/diff/3/ Testing --- Thanks, pengjianhua

Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

) to list keywords in query box. Please see 1.jpg. Diffs - webapp/app/partials/query/query.html 894113e0d Diff: https://reviews.apache.org/r/62346/diff/3/ Testing --- Thanks, pengjianhua

Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

keywords in query box. Please see 1.jpg. Diffs (updated) - webapp/app/partials/query/query.html 894113e0d Diff: https://reviews.apache.org/r/62346/diff/4/ Changes: https://reviews.apache.org/r/62346/diff/3-4/ Testing --- Thanks, pengjianhua

Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

) to list keykwords in query box. Please see 1.jpg. Diffs - webapp/app/partials/query/query.html 894113e0d Diff: https://reviews.apache.org/r/62346/diff/2/ Testing --- Thanks, pengjianhua

Review Request 62537: KYLIN-2901 After truncated table, the web page still keep the original cardinality

/TableExtDesc.java 18fefc23b source-hive/src/main/java/org/apache/kylin/source/hive/cardinality/HiveColumnCardinalityUpdateJob.java 246822c55 Diff: https://reviews.apache.org/r/62537/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 61022: KYLIN-2703 kylin supports managing access rights for project and cube through apache ranger.

://reviews.apache.org/r/61022/diff/6/ Changes: https://reviews.apache.org/r/61022/diff/5-6/ Testing --- Thanks, pengjianhua

Review Request 62916: KYLIN-2931 Update correct cardinality for the modified table

e7e Diff: https://reviews.apache.org/r/62916/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63140: KYLIN-2947 Changed the Pop-up box when no project selected

. Diffs - webapp/app/js/controllers/admin.js 0437942ef Diff: https://reviews.apache.org/r/63140/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63234: KYLIN-2934 Write user guide for KYLIN-2656

/63234/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63237: KYLIN-2960 We should submit a new feature that it support the authentication for user and role and the authentication for user and group when the LDAP authentication was enabled.

/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63246: KYLIN-2925 Provide document for Ranger security integration

/howto_install_ranger_kylin_plugin.md PRE-CREATION Diff: https://reviews.apache.org/r/63246/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 63237: KYLIN-2960 We should submit a new feature that it support the authentication for user and role and the authentication for user and group when the LDAP authentication was enab

/1-2/ Testing --- Thanks, pengjianhua

Review Request 63747: KYLIN-3034 In the models tree, the "Edit(JSON)" option is missing partly.

iv, which can give more space to options. Diffs - webapp/app/partials/models/models_tree.html 399f839 Diff: https://reviews.apache.org/r/63747/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63720: KYLIN-3030 In the cubes table, the options of last column action are missing partly.

can give more space to options. Diffs - webapp/app/partials/cubes/cubes.html d43b857 Diff: https://reviews.apache.org/r/63720/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 63825: KYLIN-3042: In query results page, the results data table should resize when click "fullscreen" button

e.org/r/63825/diff/3/ Changes: https://reviews.apache.org/r/63825/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 63825: KYLIN-3042: In query results page, the results data table should resize when click "fullscreen" button

f/2/ Changes: https://reviews.apache.org/r/63825/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 63825: KYLIN-3042: In query results page, the results data table should resize when click "fullscreen" button

le is much smaller than its parent frame. So we hope that the results data table will resize when click "fullScreen" button. Diffs - webapp/app/js/directives/ui-grid.js 352e919a4 Diff: https://reviews.apache.org/r/63825/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64060: KYLIN-3058 We should limit the integer type ID for "Kafka Setting" in "Streaming Cluster" page

code, it also show the ID must be integer, as follow: public class BrokerConfig implements Serializable{ @JsonProperty("id") private int id; It means the parameter ID isn't allowed for non-integer types, so we should solve it at the web page. Diffs - webapp/app/partials/cubeDesigner/streamingConfig.html 5dc9788 Diff: https://reviews.apache.org/r/64060/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 63946: KYLIN-3049 Filter the invalid zero value of "Auto Merge Thresholds" parameter when you create or upate a cube.

lue of "Auto Merge Thresholds" parameter is invalid, so we should filter it before sending it to server. Diffs (updated) - webapp/app/js/controllers/cubeEdit.js 5f78b61 Diff: https://reviews.apache.org/r/63946/diff/2/ Changes: https://reviews.apache.org/r/63946/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 64063: KYLIN-3060 The logical processing of creating or updating streaming table has a bug in server, which will cause a NullPointerException.

Diff: https://reviews.apache.org/r/64063/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64026: KYLIN-3053 When aggregation group verification failed, the error message about aggregation group number does not match with the actual on the Advanced Setting page

://reviews.apache.org/r/64026/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64157: KYLIN-3061 When we cancel the Topic modification for 'Kafka Setting' of streaming table, the 'Cancel' operation will make a mistake.

ttps://reviews.apache.org/r/64157/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64201: KYLIN-3073 When you save a new query condition, the 'Saved Queries' tab page will not be automatically refreshed.

, the code doesn't trigger refreshing 'Saved Queries' tab. I have repaired this code, please check the patch, thanks! Diffs - webapp/app/js/controllers/query.js 945ddef Diff: https://reviews.apache.org/r/64201/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 64060: KYLIN-3058 We should limit the integer type ID for "Kafka Setting" in "Streaming Cluster" page

Serializable{ @JsonProperty("id") private int id; It means the parameter ID isn't allowed for non-integer types, so we should solve it at the web page. Diffs (updated) ----- webapp/app/partials/cubeDesigner/advanced_settings.html 5d53075 webapp/app/partials/cubeDesigner/measures.html aa7a096 webapp/app/partials/cubeDesigner/streamingConfig.html 5dc9788 Diff: https://reviews.apache.org/r/64060/diff/3/ Changes: https://reviews.apache.org/r/64060/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 64060: KYLIN-3058 We should limit the integer type ID for "Kafka Setting" in "Streaming Cluster" page

y("id") private int id; It means the parameter ID isn't allowed for non-integer types, so we should solve it at the web page. Diffs (updated) - webapp/app/partials/cubeDesigner/streamingConfig.html 5dc9788 Diff: https://reviews.apache.org/r/64060/diff/2/ Changes: https://reviews.apache.org/r/64060/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 63946: KYLIN-3049 Filter the invalid zero value of "Auto Merge Thresholds" parameter when you create or upate a cube.

s://reviews.apache.org/r/63946/diff/2-3/ Testing --- Thanks, pengjianhua

Review Request 64108: KYLIN-3063 load-hive-conf.sh should not get the commented configuration item

--- Thanks, pengjianhua

Review Request 64207: KYLIN-3075 Improvement kylin.sh, remove duplicate dependency check, let kylin start faster.

/browse/KYLIN-3075 Repository: kylin Description --- Improvement kylin.sh, remove duplicate dependency check, let kylin start faster. Diffs - build/bin/kylin.sh bf1c862ed Diff: https://reviews.apache.org/r/64207/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 64244: KYLIN-3076: Make kylin remember the choices we have made in the "Monitor>Jobs" page

is page. Diffs (updated) - webapp/app/js/controllers/job.js 8e460fae0 webapp/app/js/model/jobListModel.js 95e0be3bc Diff: https://reviews.apache.org/r/64244/diff/2/ Changes: https://reviews.apache.org/r/64244/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 64244: KYLIN-3076: Make kylin remember the choices we have made in the "Monitor>Jobs" page

this page. Diffs (updated) - webapp/app/js/controllers/job.js 8e460fae0 webapp/app/js/controllers/page.js 0b5ded742 webapp/app/js/model/jobListModel.js 95e0be3bc Diff: https://reviews.apache.org/r/64244/diff/4/ Changes: https://reviews.apache.org/r/64244/diff/3-4/ Testing --- Thanks, pengjianhua

Review Request 64598: KYLIN-3104: When the user log out from "Monitor" page, an alert dialog will pop up warning "Failed to load query."

65bb8 Diff: https://reviews.apache.org/r/64598/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 64157: KYLIN-3061 When we cancel the Topic modification for 'Kafka Setting' of streaming table, the 'Cancel' operation will make a mistake.

09c6 webapp/app/partials/cubeDesigner/streamingConfig.html 24b3438 Diff: https://reviews.apache.org/r/64157/diff/2/ Changes: https://reviews.apache.org/r/64157/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 64244: KYLIN-3076: Make kylin remember the choices we have made in the "Monitor>Jobs" page

app/js/controllers/job.js 8e460fae0 webapp/app/js/controllers/page.js 0b5ded742 webapp/app/js/model/jobListModel.js 95e0be3bc Diff: https://reviews.apache.org/r/64244/diff/3/ Changes: https://reviews.apache.org/r/64244/diff/2-3/ Testing --- Thanks, pengjianhua

Review Request 64566: KYLIN-3099 Add restart operation for kylin.sh

. Diffs - build/bin/kylin.sh bf1c862 Diff: https://reviews.apache.org/r/64566/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 63720: KYLIN-3030 In the cubes table, the options of last column action are missing partly.

so "View Cube" is missing partly; So we can modify cubes.html, add the margin-right setting for div, which can give more space to options. Diffs (updated) - webapp/app/partials/cubes/cubes.html d43b857 Diff: https://reviews.apache.org/r/63720/diff/3/ Changes: https://reviews.apache.org/r/63720/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 63720: KYLIN-3030 In the cubes table, the options of last column action are missing partly.

57 Diff: https://reviews.apache.org/r/63720/diff/2/ Changes: https://reviews.apache.org/r/63720/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 63747: KYLIN-3034 In the models tree, the "Edit(JSON)" option is missing partly.

ps://reviews.apache.org/r/63747/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 63720: KYLIN-3030 In the cubes table, the options of last column action are missing partly.

nges: https://reviews.apache.org/r/63720/diff/3-4/ Testing --- Thanks, pengjianhua

Re: Review Request 63693: KYLIN-3024 Limit the "Auto Merge Thresholds" text box to be input a negative number

2fe50 Diff: https://reviews.apache.org/r/63693/diff/2/ Changes: https://reviews.apache.org/r/63693/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 63237: KYLIN-2960 We should submit a new feature that it support the authentication for user and role and the authentication for user and group when the LDAP authentication was enab

/apache/kylin/rest/security/LDAPAuthoritiesPopulator.java PRE-CREATION server/src/main/resources/kylinSecurity.xml ca49255 Diff: https://reviews.apache.org/r/63237/diff/3/ Changes: https://reviews.apache.org/r/63237/diff/2-3/ Testing --- Thanks, pengjianhua

Review Request 63459: KYLIN-2981 Fix misspelled in Cube Refresh Setting page.

--- Thanks, pengjianhua

Review Request 63610: KYLIN-3017 Footer covers the selection box and some options can not be selected

/browse/KYLIN-3017 Repository: kylin Description --- Footer covers the selection box and some options can not be selected Diffs - webapp/app/less/component.less d99ddbbd6 Diff: https://reviews.apache.org/r/63610/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63693: KYLIN-3024 Limit the "Auto Merge Thresholds" text box to be input a negative number

u will find the text box can be input negative numbers, which can be summited, it should be invalid. Diffs - webapp/app/partials/cubeDesigner/refresh_settings.html 522fe50 Diff: https://reviews.apache.org/r/63693/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63660: KYLIN-3023 Grant project admin permission to modeler or analyst user, but these users can not manage the cube which belongs to the project.

on project-level. Diffs - webapp/app/js/model/projectModel.js 77f47e82b webapp/app/partials/cubes/cube_detail.html 674e3f0d7 webapp/app/partials/cubes/cubes.html d43b857a8 Diff: https://reviews.apache.org/r/63660/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64289: KYLIN-3074 Change cube access to project access in ExternalAclProvider.java

/models/models_tree.html d8aae3487 Diff: https://reviews.apache.org/r/64289/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64369: KYLIN-3086 When you load Hive table metadata from server, the intermediate tables should not be loaded.

, which should not be showed to client, so I filter them in the server, please check the patch, thanks! Diffs - server-base/src/main/java/org/apache/kylin/rest/service/TableService.java ffb71a6 Diff: https://reviews.apache.org/r/64369/diff/1/ Testing --- Thanks, pengjianhua

Review Request 64530: KYLIN-3101: The "search" icon will separate from the "Filter" textbox when click the "showSteps" button of a job in the jobList

d when you resize the browser, it may also happen. Diffs - webapp/app/partials/jobs/jobList.html 0e4552252 Diff: https://reviews.apache.org/r/64530/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63290: KYLIN-2967 Can't drop model when no project found for this model

- core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectManager.java 804479777 Diff: https://reviews.apache.org/r/63290/diff/1/ Testing --- Thanks, pengjianhua

Review Request 63291: KYLIN-2968 misspelled word in table_load.html

, pengjianhua

Re: Review Request 63290: KYLIN-2967 Can't drop model when the project was deleted

--- Thanks, pengjianhua

Review Request 65066: KYLIN-3159 Remove unnecessary cube access request

/browse/KYLIN-3159 Repository: kylin Description --- Remove unnecessary cube access request Diffs - webapp/app/partials/cubes/cubes.html 81077307b Diff: https://reviews.apache.org/r/65066/diff/1/ Testing --- Thanks, pengjianhua

Review Request 65283: KYLIN-3191 Remove the deprecated configuration item kylin.security.acl.default-role

/65283/diff/1/ Testing --- Thanks, pengjianhua

Review Request 65279: KYLIN-3190 When revoke access, got error "Missing URI template variable 'entityType' for method parameter of type String"

iff: https://reviews.apache.org/r/65279/diff/1/ Testing --- Thanks, pengjianhua