Review Request 39606: LENS-843 : Columns in having clause not getting push down

2015-10-23 Thread Sushil Mohanty
... SUCCESS [33.597s] [INFO] [INFO] BUILD SUCCESS [INFO] Thanks, Sushil Mohanty

Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Sushil Mohanty
ps://reviews.apache.org/r/39598/#review103920 ------- On Oct. 23, 2015, 4:15 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail.

Review Request 39650: LENS-846: Not all filters on fact is getting push down

2015-10-26 Thread Sushil Mohanty
/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dad Diff: https://reviews.apache.org/r/39650/diff/ Testing --- JDBC tests are running fine. Will update all test result shortly. Thanks, Sushil Mohanty

Re: Review Request 39650: LENS-846: Not all filters on fact is getting push down

2015-10-26 Thread Sushil Mohanty
shortly. Thanks, Sushil Mohanty

Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-23 Thread Sushil Mohanty
] [INFO] Total time: 51:33.965s [INFO] Finished at: Fri Oct 23 20:36:19 IST 2015 [INFO] Final Memory: 185M/1352M [INFO] Thanks, Sushil Mohanty

Re: November report

2015-11-10 Thread Sushil Mohanty
+1 On Tue, Nov 10, 2015 at 1:08 PM, Balasugavaneswaran Nathan < bala.nat...@flipkart.com> wrote: > + 1 > On Nov 10, 2015 12:35 PM, "Raghavendra Singh" < > raghavendra.si...@inmobi.com> > wrote: > > > +1 > > On 10-Nov-2015 12:33 PM, "Rajat Khandelwal" wrote: > > > > > +1 > >

Review Request 39483: LENS-838 : Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-20 Thread Sushil Mohanty
0 16:38:12 UTC 2015 [INFO] Final Memory: 196M/1690M [INFO] Thanks, Sushil Mohanty

Review Request 39315: LENS-821:Filters with comma in IN filters not replacing table alias properly

2015-10-14 Thread Sushil Mohanty
] Final Memory: 196M/1665M Thanks, Sushil Mohanty

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-04 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-07 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 37648: LENS-737: Throw single error out with LensMultiException

2015-09-03 Thread Sushil Mohanty
-------- Thanks, Sushil Mohanty

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

2015-09-30 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38889/#review101108 --- Ship it! Ship It! - Sushil Mohanty On Sept. 30, 2015, 12:14

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-11 Thread Sushil Mohanty
able cannot be inherited with different arguments: and - Sushil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109943 ----------

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-11 Thread Sushil Mohanty
UTC 2015 [INFO] Final Memory: 200M/2134M [INFO] Thanks, Sushil Mohanty

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-11 Thread Sushil Mohanty
ated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109919 ------- On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote: > > --- > This is a

Review Request 41508: LENS-905 : Group by is not promoted when keys projected along with having clause

2015-12-17 Thread Sushil Mohanty
/1504M [INFO] Thanks, Sushil Mohanty

Review Request 41448: LENS-903 : No candidate dim available exception should contain only brief error

2015-12-16 Thread Sushil Mohanty
SUCCESS [INFO] [INFO] Total time: 30:24.410s [INFO] Finished at: Wed Dec 16 16:34:19 UTC 2015 [INFO] Final Memory: 181M/1102M [INFO] Thanks, Sushil Mohanty

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

2015-12-10 Thread Sushil Mohanty
eviews.apache.org/r/41193/#review109731 --- On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 48317: LENS-1164 : Query getting stuck in queue for inmemory queries

2016-06-06 Thread Sushil Mohanty
] [INFO] Total time: 32:44.083s [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016 [INFO] Final Memory: 190M/2057M [INFO] Thanks, Sushil Mohanty

Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for inmemory queries

2016-06-08 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48317/#review136611 ------- On June 8, 2016, 7:19 a.m., Sushil Mohanty wrote: > > --- &g

Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for inmemory queries

2016-06-08 Thread Sushil Mohanty
[INFO] Thanks, Sushil Mohanty

Re: Review Request 48317: LENS-1164 : Query getting stuck in queue for inmemory queries

2016-06-13 Thread Sushil Mohanty
] Finished at: Tue Jun 07 05:34:19 UTC 2016 [INFO] Final Memory: 190M/2057M [INFO] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-09 Thread Sushil Mohanty
] [INFO] Total time: 31:15.500s [INFO] Finished at: Tue Feb 02 13:22:32 UTC 2016 [INFO] Final Memory: 181M/1136M [INFO] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-09 Thread Sushil Mohanty
------ On Feb. 9, 2016, 12:11 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43086/ > ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-09 Thread Sushil Mohanty
------ On Feb. 9, 2016, 12:11 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43086/ > ---

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-10 Thread Sushil Mohanty
le=1238399#file1238399line1688> > > > > putting future start time? Put start and end time to past and future respectively. - Sushil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-10 Thread Sushil Mohanty
enerated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118601 --- On Feb. 9, 2016, 12:11 p.m., Sushil Mohanty wrote: > > --- > This is an automatically ge

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-10 Thread Sushil Mohanty
] [INFO] Total time: 31:15.500s [INFO] Finished at: Tue Feb 02 13:22:32 UTC 2016 [INFO] Final Memory: 181M/1136M [INFO] Thanks, Sushil Mohanty

Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-02 Thread Sushil Mohanty
UTC 2016 [INFO] Final Memory: 181M/1136M [INFO] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-15 Thread Sushil Mohanty
[INFO] [INFO] Total time: 31:15.500s [INFO] Finished at: Tue Feb 02 13:22:32 UTC 2016 [INFO] Final Memory: 181M/1136M [INFO] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-15 Thread Sushil Mohanty
e? Fact start time is "now -10 days" and part time is "today - 300 hours", so that it falls behind start time. - Sushil --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-15 Thread Sushil Mohanty
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review119269 --- On Feb. 15, 2016, 5:14 p.m., Sushil Mohanty wrote: > >

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-16 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-19 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-11 Thread Sushil Mohanty
[INFO] [INFO] Total time: 31:15.500s [INFO] Finished at: Tue Feb 02 13:22:32 UTC 2016 [INFO] Final Memory: 181M/1136M [INFO] Thanks, Sushil Mohanty

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-11 Thread Sushil Mohanty
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118851 --- On Feb. 11, 2016, 6:12 p.m., Sushil Mohanty wrote: &

Re: Review Request 43086: LENS-932 : Skip partition registration for very old and future dates for a fact tables

2016-02-22 Thread Sushil Mohanty
] [INFO] Total time: 38:47.991s [INFO] Finished at: Mon Feb 22 07:53:17 UTC 2016 [INFO] Final Memory: 201M/2076M [INFO] Thanks, Sushil Mohanty

Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-10 Thread Sushil Mohanty
SUCCESS [INFO] [INFO] Total time: 36:20.155s [INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016 [INFO] Final Memory: 210M/2450M [INFO] Thanks, Sushil

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-19 Thread Sushil Mohanty
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review123110 --- On March 17, 2016, 9:04 a.m., Sushil Mohanty wrote: > > --- > This is an automatica

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-19 Thread Sushil Mohanty
] [INFO] Total time: 37:49.065s [INFO] Finished at: Thu Mar 17 08:51:02 UTC 2016 [INFO] Final Memory: 173M/2915M [INFO] Thanks, Sushil Mohanty

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-19 Thread Sushil Mohanty
to be more appropriate with CubeSegmentation. - Sushil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review123111 -----------

Re: Review Request 45748: LENS-39 : Add tags to cube column

2016-04-05 Thread Sushil Mohanty
] [INFO] Total time: 47:44.019s [INFO] Finished at: Tue Apr 05 14:13:50 UTC 2016 [INFO] Final Memory: 210M/2441M [INFO] Thanks, Sushil Mohanty

Review Request 45748: LENS-39 : Add tags to cube column

2016-04-05 Thread Sushil Mohanty
3f2ffc0 lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae Diff: https://reviews.apache.org/r/45748/diff/ Testing --- Thanks, Sushil Mohanty

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-26 Thread Sushil Mohanty
] [INFO] Total time: 36:51.163s [INFO] Finished at: Sat Mar 26 08:49:16 UTC 2016 [INFO] Final Memory: 197M/1720M [INFO] Thanks, Sushil Mohanty

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-23 Thread Sushil Mohanty
w class. - Sushil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44612/#review124358 --- On March 18, 2016, 11:12 a.m., Sushil Mohanty wrote: &g

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-23 Thread Sushil Mohanty
] [INFO] Total time: 38:00.676s [INFO] Finished at: Fri Mar 18 11:10:09 UTC 2016 [INFO] Final Memory: 195M/1539M [INFO] Thanks, Sushil Mohanty

Re: Review Request 44612: LENS-975 : Add cube-segmentation specification

2016-03-23 Thread Sushil Mohanty
:51.827s [INFO] Finished at: Wed Mar 23 15:31:55 UTC 2016 [INFO] Final Memory: 194M/1485M [INFO] Thanks, Sushil Mohanty

Re: Review Request 45382: LENS-995 : QueryContextPriorityComparator should compare the priorities instead of cost

2016-03-29 Thread Sushil Mohanty
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45382/#review125812 --- On March 28, 2016, 5:03 p.m., Sushil Mohanty wrote: > > -

Re: Review Request 45382: LENS-995 : QueryContextPriorityComparator should compare the priorities instead of cost

2016-03-29 Thread Sushil Mohanty
] [INFO] Total time: 38:26.722s [INFO] Finished at: Mon Mar 28 16:36:26 UTC 2016 [INFO] Final Memory: 199M/1745M [INFO] Thanks, Sushil Mohanty

Re: Review Request 45382: LENS-995 : QueryContextPriorityComparator should compare the priorities instead of cost

2016-03-28 Thread Sushil Mohanty
[INFO] Final Memory: 199M/1745M [INFO] Thanks, Sushil Mohanty

Re: Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-11 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-11 Thread Sushil Mohanty
] [INFO] Total time: 31:23.276s [INFO] Finished at: Mon May 09 15:04:12 UTC 2016 [INFO] Final Memory: 163M/2144M [INFO] Thanks, Sushil Mohanty

Re: Review Request 47415: LENS-1040 : cubesegmentation commands are conflicting with cube commands

2016-05-17 Thread Sushil Mohanty
C 2016 [INFO] Final Memory: 200M/2555M [INFO] Thanks, Sushil Mohanty

Re: Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-13 Thread Sushil Mohanty
SUCCESS [INFO] [INFO] Total time: 31:23.276s [INFO] Finished at: Mon May 09 15:04:12 UTC 2016 [INFO] Final Memory: 163M/2144M [INFO] Thanks, Sushil Mohanty

Re: Review Request 47415: LENS-1040 : cubesegmentation commands are conflicting with cube commands

2016-05-16 Thread Sushil Mohanty
ell>describe segmentation --name required --name: ; no default value Thanks, Sushil Mohanty

Review Request 47415: LENS-1040 : cubesegmentation commands are conflicting with cube commands

2016-05-16 Thread Sushil Mohanty
value Thanks, Sushil Mohanty

Re: Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-02 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-02 Thread Sushil Mohanty
] [INFO] Total time: 34:31.633s [INFO] Finished at: Mon May 02 10:19:12 UTC 2016 [INFO] Final Memory: 183M/2727M [INFO] Thanks, Sushil Mohanty

Re: Review Request 45748: LENS-39 : Add tags to cube column

2016-04-19 Thread Sushil Mohanty
SUCCESS [INFO] [INFO] Total time: 48:03.576s [INFO] Finished at: Tue Apr 19 08:20:15 UTC 2016 [INFO] Final Memory: 172M/2793M [INFO] Thanks, Sushil Mohanty

Re: Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-09 Thread Sushil Mohanty
------ On May 3, 2016, 5:10 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46890/ > -

Re: Review Request 46890: LENS-1028 : Convert dimension filter to fact filters for perfomace improvement on outer join queries

2016-05-09 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 47820: LENS-1155 : Seeing INTERNAL_SERVER_ERROR for JDBC queries due to connection unavailability

2016-05-25 Thread Sushil Mohanty
:54.713s [INFO] Finished at: Wed May 25 09:26:53 UTC 2016 [INFO] Final Memory: 201M/2506M [INFO] Thanks, Sushil Mohanty

Re: Review Request 47820: LENS-1155 : Seeing INTERNAL_SERVER_ERROR for JDBC queries due to connection unavailability

2016-05-25 Thread Sushil Mohanty
t: https://reviews.apache.org/r/47820/#review134729 ----------- On May 25, 2016, 9:01 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e

Re: Review Request 47820: LENS-1155 : Seeing INTERNAL_SERVER_ERROR for JDBC queries due to connection unavailability

2016-05-25 Thread Sushil Mohanty
/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 67f6c1f lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java a0691a5 Diff: https://reviews.apache.org/r/47820/diff/ Testing --- Thanks, Sushil Mohanty

Re: Review Request 50714: LENS-197 : Allow start and end times for columns in fact tables

2016-08-03 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Re: Review Request 50714: LENS-197 : Allow start and end times for columns in fact tables

2016-08-05 Thread Sushil Mohanty
[INFO] Thanks, Sushil Mohanty

Review Request 51177: LENS-1241 : Fix tests failures with setup and teardown issues

2016-08-17 Thread Sushil Mohanty
] Final Memory: 200M/2421M [INFO] Thanks, Sushil Mohanty

Re: Report for the month of February

2017-02-01 Thread Sushil Mohanty
+1 Thanks, Sushil On Wed, Feb 1, 2017 at 4:05 PM, Puneet Gupta wrote: > +1 > > Thanks, > Puneet > > On Wed, Feb 1, 2017 at 3:42 PM, Raju Bairishetti wrote: > > > +1. Looks good to me > > > > On Wed, Feb 1, 2017 at 5:59 PM, Jean-Baptiste Onofré

Re: Review Request 51177: LENS-1241 : Fix tests failures with setup and teardown issues

2016-08-19 Thread Sushil Mohanty
] [INFO] Total time: 40:44.037s [INFO] Finished at: Wed Aug 17 13:03:45 UTC 2016 [INFO] Final Memory: 200M/2421M [INFO] Thanks, Sushil Mohanty

Review Request 52117: LENS-1334 : Full outer join queries join conditions not rewritten correctly when more than two table involved

2016-09-21 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Review Request 51964: LENS-317: Server side calls for updating database jars

2016-09-16 Thread Sushil Mohanty
] [INFO] Total time: 49:44.002s [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 [INFO] Final Memory: 178M/2490M [INFO] Thanks, Sushil Mohanty

Re: Review Request 52117: LENS-1334 : Full outer join queries join conditions not rewritten correctly when more than two table involved

2016-09-22 Thread Sushil Mohanty
[INFO] Finished at: Wed Sep 21 17:13:00 IST 2016 [INFO] Final Memory: 66M/1537M [INFO] Thanks, Sushil Mohanty

Re: November 2016 report

2016-11-09 Thread Sushil Mohanty
+1 On Wed, Nov 9, 2016 at 1:28 PM, Rajat Khandelwal wrote: > +1 > > On Wed, Nov 9, 2016 at 12:28 PM Puneet Gupta > wrote: > > > +1 > > > > Thanks, > > Puneet Gupta > > > > On Wed, Nov 9, 2016 at 11:06 AM, Amareshwari Sriramdasu < > >

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-08 Thread Sushil Mohanty
:08 IST 2016 [INFO] Final Memory: 178M/2490M [INFO] Thanks, Sushil Mohanty

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-08 Thread Sushil Mohanty
not sure how its corresponding local jar file is added to classloader. > > If hdfs jar is getting added, it wont work. > > > > might have to pass the corresponding local jar as the location value > > for ResourceEntry. > > Sushil Mohanty wrote: >

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-08 Thread Sushil Mohanty
eviews.apache.org/r/51964/#review154869 ------- On Nov. 3, 2016, 5:31 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-14 Thread Sushil Mohanty
] [INFO] Total time: 49:44.002s [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 [INFO] Final Memory: 178M/2490M [INFO] Thanks, Sushil Mohanty

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-25 Thread Sushil Mohanty
] [INFO] Total time: 49:44.002s [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 [INFO] Final Memory: 178M/2490M [INFO] Thanks, Sushil Mohanty

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-25 Thread Sushil Mohanty
; [INFO] Lens UI ... SUCCESS [19.454s] > [INFO] > -------- > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 49:44.002s > [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 > [INFO] Final Memory: 178M/2490M > [INFO] > > > > Thanks, > > Sushil Mohanty > >

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-20 Thread Sushil Mohanty
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review152818 --- On Oct. 14, 2016, 8:29 a.m., Sushil Mohanty wrote: > > -

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-20 Thread Sushil Mohanty
: 49:44.002s [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 [INFO] Final Memory: 178M/2490M [INFO] Thanks, Sushil Mohanty

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-03 Thread Sushil Mohanty
he.org/r/51964/#review153851 --- On Oct. 25, 2016, 10:11 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-03 Thread Sushil Mohanty
] Thanks, Sushil Mohanty

Review Request 57869: LENS-1403 : Measures getting repeated in inner select of union query

2017-03-23 Thread Sushil Mohanty
://reviews.apache.org/r/57869/diff/1/ Testing --- Thanks, Sushil Mohanty

Re: Review Request 57869: LENS-1403 : Measures getting repeated in inner select of union query

2017-03-24 Thread Sushil Mohanty
, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 548.377 sec - in TestSuite Results : Tests run: 418, Failures: 0, Errors: 0, Skipped: 0 Thanks, Sushil Mohanty

Re: Review Request 57418: LENS-1400: Convert CubeTestSetup to setup using xml files instead of code

2017-03-27 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57418/#review170132 --- Ship it! Ship It! - Sushil Mohanty On March 9, 2017, 11:28

Re: Review Request 57869: LENS-1403 : Measures getting repeated in inner select of union query

2017-03-27 Thread Sushil Mohanty
: 548.377 sec - in TestSuite Results : Tests run: 418, Failures: 0, Errors: 0, Skipped: 0 Thanks, Sushil Mohanty

Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-03-31 Thread Sushil Mohanty
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 567c929 Diff: https://reviews.apache.org/r/58102/diff/1/ Testing --- Thanks, Sushil Mohanty

Re: Review Request 57418: LENS-1400: Convert CubeTestSetup to setup using xml files instead of code

2017-03-22 Thread Sushil Mohanty
g/r/57418/#comment242215> Looks like this the same class present in org.apache.lens.server.metastore. Can't we import the static methods and reuse instead of creating a copy of the class. - Sushil Mohanty On March 9, 2017, 11:28 a.m., Rajat Khan

Re: Review Request 58141: LENS-1408 : Fix test cases after LENS-1399

2017-04-03 Thread Sushil Mohanty
at: Mon Apr 03 16:42:11 IST 2017 [INFO] Final Memory: 72M/1807M [INFO] Thanks, Sushil Mohanty

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-04 Thread Sushil Mohanty
: https://reviews.apache.org/r/58102/diff/2/ Changes: https://reviews.apache.org/r/58102/diff/1-2/ Testing --- Thanks, Sushil Mohanty

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-04 Thread Sushil Mohanty
t; > > Seems CubeQueryContext as instance variable is not required. Can we > > remove? > > Sushil Mohanty wrote: > In few test cases its being used to get getLensExceptionInRewrite and > assert eg: TestTimeRangeResolver#testFactValidity > > Amareshwari Srira

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-11 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58102/#review171090 ------- On April 5, 2017, 5:38 a.m., Sushil Mohanty wrote: > > -

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-11 Thread Sushil Mohanty
/TestDataUtils.java 0400519 lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 567c929 Diff: https://reviews.apache.org/r/58102/diff/3/ Changes: https://reviews.apache.org/r/58102/diff/2-3/ Testing --- Thanks, Sushil Mohanty

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-11 Thread Sushil Mohanty
eviews.apache.org/r/58102/#review170705 --- On April 5, 2017, 5:38 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-11 Thread Sushil Mohanty
; > Can we avoid throwing direct LensException like this? > > Sushil Mohanty wrote: > The resolver flow work in multiple phases either with single > StorageCandidate or complex Candidate(Join or Union). Object type check > performed to ensure there is no type mismatc

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-11 Thread Sushil Mohanty
eviews.apache.org/r/58102/#review171091 --- On April 5, 2017, 5:38 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-11 Thread Sushil Mohanty
tps://github.com/apache/lens/blob/master/lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java#L333 > > > > Can we summarize why the change was done? > > Sushil Mohanty wrote: > Line 56 : Timerange is not answerable by neither a singl

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-03 Thread Sushil Mohanty
--- On March 31, 2017, 10:02 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58102/ > -

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

2017-04-03 Thread Sushil Mohanty
named it. - Sushil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58102/#review170696 --- On March 31, 2017, 10:02 a.m., Sushil M

  1   2   3   4   >