Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated April 5, 2018, 10:03 a.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa7 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f77 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be8 
  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
9d732c1c 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
c30a2d72 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 903b19fe 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358d 
  lens-server/src/main/resources/lensserver-default.xml 28b1db29 
  lens-server/src/test/resources/lens-site.xml 7e5f522e 
  tools/scripts/lens-ctl 304b4f5a 


Diff: https://reviews.apache.org/r/66081/diff/8/

Changes: https://reviews.apache.org/r/66081/diff/7-8/


Testing
---

unit testing


Thanks,

Ankit Kailaswar

Re: Review Request 66081: Kerberos authentication in lens

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200541
---




lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 130 (patched)


can you add a comment why this is required.



lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java
Lines 148 (patched)


Can you import SecurityUtil ?



lens-server/src/main/java/org/apache/lens/server/LensServices.java
Lines 299 (patched)


can you move the KDC code to a separate method ?



lens-server/src/main/java/org/apache/lens/server/LensServices.java
Lines 304 (patched)


Should we catch Exception instead in this case ?


- Puneet Gupta


On April 5, 2018, 5:41 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated April 5, 2018, 5:41 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
> 9d732c1c 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> c30a2d72 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 903b19fe 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db29 
>   lens-server/src/test/resources/lens-site.xml 7e5f522e 
>   tools/scripts/lens-ctl 304b4f5a 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/7/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated April 5, 2018, 5:41 a.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa7 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f77 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be8 
  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
9d732c1c 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
c30a2d72 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 903b19fe 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358d 
  lens-server/src/main/resources/lensserver-default.xml 28b1db29 
  lens-server/src/test/resources/lens-site.xml 7e5f522e 
  tools/scripts/lens-ctl 304b4f5a 


Diff: https://reviews.apache.org/r/66081/diff/7/

Changes: https://reviews.apache.org/r/66081/diff/6-7/


Testing
---

unit testing


Thanks,

Ankit Kailaswar

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

> On April 3, 2018, 12:06 p.m., Puneet Gupta wrote:
> > lens-server/src/main/resources/lensserver-default.xml
> > Lines 971 (patched)
> > 
> >
> > can you update this

changed this to 360 minutes


- Ankit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200352
---


On April 3, 2018, 8:14 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated April 3, 2018, 8:14 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> c30a2d72 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db29 
>   lens-server/src/test/resources/lens-site.xml 7e5f522e 
>   tools/scripts/lens-ctl 304b4f5a 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/5/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated April 3, 2018, 12:18 p.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa7 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f77 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be8 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
c30a2d72 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358d 
  lens-server/src/main/resources/lensserver-default.xml 28b1db29 
  lens-server/src/test/resources/lens-site.xml 7e5f522e 
  tools/scripts/lens-ctl 304b4f5a 


Diff: https://reviews.apache.org/r/66081/diff/6/

Changes: https://reviews.apache.org/r/66081/diff/5-6/


Testing
---

unit testing


Thanks,

Ankit Kailaswar

Re: Review Request 66081: Kerberos authentication in lens

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200353
---


Ship it!




Ship It!

- Puneet Gupta


On April 3, 2018, 8:14 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated April 3, 2018, 8:14 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> c30a2d72 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db29 
>   lens-server/src/test/resources/lens-site.xml 7e5f522e 
>   tools/scripts/lens-ctl 304b4f5a 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/5/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated April 3, 2018, 8:14 a.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa7 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f77 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be8 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
c30a2d72 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358d 
  lens-server/src/main/resources/lensserver-default.xml 28b1db29 
  lens-server/src/test/resources/lens-site.xml 7e5f522e 
  tools/scripts/lens-ctl 304b4f5a 


Diff: https://reviews.apache.org/r/66081/diff/5/

Changes: https://reviews.apache.org/r/66081/diff/4-5/


Testing
---

unit testing


Thanks,

Ankit Kailaswar

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated April 2, 2018, 12:58 p.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa706c648b50dce1bbb5360ddd22a242295 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f77643d5723ab7735f5b666ce6bfa75a782 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be8b1d0c6c1e63da049c1cba712a5817903 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
c30a2d72d27acdbab4c175e6e723f6369d934de9 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358d0a1747b1dbfe1d6dacaf0fb82556475d 
  lens-server/src/main/resources/lensserver-default.xml 
28b1db29a8be7dc9762a2ce413a988d3b14b8543 
  lens-server/src/test/resources/lens-site.xml 
7e5f522ea581e83dfd85210f27f10473e93c0097 
  tools/scripts/lens-ctl 304b4f5a8b82a5d313cdf31852cf502a214ba83b 


Diff: https://reviews.apache.org/r/66081/diff/3/

Changes: https://reviews.apache.org/r/66081/diff/2-3/


Testing
---

unit testing


Thanks,

Ankit Kailaswar

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

> On March 20, 2018, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
> > Lines 125 (patched)
> > 
> >
> > This class is also redundant. Can we reuse 
> > `org.apache.hive.service.cli.thrift.RetryingThriftCLIServiceClient.InvocationResult`?

it is protected inner class, usage are scoped within package only. Wont be a 
good idea to follow package struture for single class in lens. cant even extend 
outside package, no default ctor available for InvocationResult in 
RetryingThriftCLIServiceClient.


> On March 20, 2018, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
> > Lines 137-182 (patched)
> > 
> >
> > Both these methods can be easily avoided by simply extending 
> > `RetryingThriftCLIServiceClient`.

it can't be extended form RetryingThriftCLIServiceClient please read above 
reply to puneet's comment.


On March 20, 2018, 6:37 a.m., Ankit Kailaswar wrote:
> > Current design:
> > ```java
> > HiveConf conf;
> > if (conf.auth == Kerberose) {
> > org.apache.lens.driver.hive.RetryingThriftCLIServiceClientSasl.newClient
> > } else {
> > 
> > org.apache.hive.service.cli.thrift.RetryingThriftCLIServiceClient.newClient
> > }
> > 
> > 
> > class RetryingThriftCLIServiceClientSasl {
> > // some reuse from RetryingThriftCLIServiceClient
> > // some code copied from RetryingThriftCLIServiceClient
> > }
> > 
> > ```
> > 
> > Proposal: 
> > 
> > 
> > ```java
> > HiveConf conf;
> > 
> > org.apache.lens.driver.hive.client.thrift.RetryingThriftCLIServiceClient.newClient
> > 
> > class RetryingThriftCLIServiceClient extends 
> > org.apache.hive.service.cli.thrift.RetryingThriftCLIServiceClient {
> > @Override
> > protected synchronized TTransport connect(HiveConf conf) throws 
> > HiveSQLException, TTransportException {
> > if (this.transport != null && this.transport.isOpen()) {
> > this.transport.close();
> > }
> > 
> > String host = conf.getVar(ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST);
> > int port = conf.getIntVar(ConfVars.HIVE_SERVER2_THRIFT_PORT);
> > LOG.info("Connecting to " + host + ":" + port);
> > this.transport = new TSocket(host, port);
> > 
> > ((TSocket)this.transport).setTimeout((int)conf.getTimeVar(ConfVars.SERVER_READ_SOCKET_TIMEOUT,
> >  TimeUnit.SECONDS) * 1000);
> > 
> > try {
> > 
> > ((TSocket)this.transport).getSocket().setKeepAlive(conf.getBoolVar(ConfVars.SERVER_TCP_KEEP_ALIVE));
> > } catch (SocketException var8) {
> > LOG.error("Error setting keep alive to " + 
> > conf.getBoolVar(ConfVars.SERVER_TCP_KEEP_ALIVE), var8);
> > }
> > /* Move the following code to new method getTransport below in 
> > the else part: 
> > String userName = 
> > conf.getVar(ConfVars.HIVE_SERVER2_THRIFT_CLIENT_USER);
> > String passwd = 
> > conf.getVar(ConfVars.HIVE_SERVER2_THRIFT_CLIENT_PASSWORD);
> > 
> > try {
> > this.transport = PlainSaslHelper.getPlainTransport(userName, 
> > passwd, this.transport);
> > } catch (SaslException var7) {
> > LOG.error("Error creating plain SASL transport", var7);
> > }
> > */
> > this.transport = getTransport(conf);
> > TProtocol protocol = new TBinaryProtocol(this.transport);
> > this.transport.open();
> > this.base = new ThriftCLIServiceClient(new Client(protocol));
> > LOG.info("Connected!");
> > return this.transport;
> > }
> > protected TTransport getTransport(HiveConf conf) {
> > if (conf.auth == Kerberose) {
> > // use KerberoseSaslHelper
> > } else {
> > // use PlainSaslHelper
> > }
> > }
> > }
> > 
> > ```

member variables of base class cant be accesses from derived class.


- Ankit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review199524
---


On March 20, 2018, 8:43 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated March 20, 2018, 8:43 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos 

Re: Review Request 66081: Kerberos authentication in lens

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200175
---




lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 64 (patched)


can be removed if not required



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 177 (patched)


Can you explain why is the kerberos implementation skipped here?



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 78 (patched)


comment should be corrected


- Rajitha R


On March 20, 2018, 8:43 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated March 20, 2018, 8:43 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b9fcdd8b 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/2/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Rajat Khandelwal]

> On March 21, 2018, 1:58 a.m., Ankit Kailaswar wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
> > Lines 36 (patched)
> > 
> >
> > If we try to extend RetryingThriftCLIServiceClient then it forces us to 
> > override all member functions since we cant access private data members of 
> > base class in derived class. we are doing it now anyhow but invokeInternal 
> > in base class refer to inner protected class "InvocationResult" if we try 
> > to overide invokeinternal then we are force to use "InvocationResult" in 
> > our implementation. since this class is inner protected class it cant be 
> > accessed from outside the class. This problem can be solved by extending 
> > InvocationResult. This require initialising base class in derived class's 
> > constructor causing same issue of not been able to use class outside 
> > package.
> 
> Rajat Khandelwal wrote:
> This can be solved by making the package of this class 
> `org.apache.hive.service.cli.thrift`.

Also the method `invokeInternal` and member `base` will need to be copied.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review199570
---


On March 21, 2018, 2:13 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated March 21, 2018, 2:13 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b9fcdd8b 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/2/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Rajat Khandelwal]

> On March 21, 2018, 1:58 a.m., Ankit Kailaswar wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
> > Lines 36 (patched)
> > 
> >
> > If we try to extend RetryingThriftCLIServiceClient then it forces us to 
> > override all member functions since we cant access private data members of 
> > base class in derived class. we are doing it now anyhow but invokeInternal 
> > in base class refer to inner protected class "InvocationResult" if we try 
> > to overide invokeinternal then we are force to use "InvocationResult" in 
> > our implementation. since this class is inner protected class it cant be 
> > accessed from outside the class. This problem can be solved by extending 
> > InvocationResult. This require initialising base class in derived class's 
> > constructor causing same issue of not been able to use class outside 
> > package.

This can be solved by making the package of this class 
`org.apache.hive.service.cli.thrift`.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review199570
---


On March 21, 2018, 2:13 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated March 21, 2018, 2:13 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b9fcdd8b 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/2/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated March 20, 2018, 8:43 p.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa7 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f77 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be8 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
b9fcdd8b 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358d 


Diff: https://reviews.apache.org/r/66081/diff/2/

Changes: https://reviews.apache.org/r/66081/diff/1-2/


Testing
---

unit testing


Thanks,

Ankit Kailaswar

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review199570
---




lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 34 (patched)


added.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 36 (patched)


If we try to extend RetryingThriftCLIServiceClient then it forces us to 
override all member functions since we cant access private data members of base 
class in derived class. we are doing it now anyhow but invokeInternal in base 
class refer to inner protected class "InvocationResult" if we try to overide 
invokeinternal then we are force to use "InvocationResult" in our 
implementation. since this class is inner protected class it cant be accessed 
from outside the class. This problem can be solved by extending 
InvocationResult. This require initialising base class in derived class's 
constructor causing same issue of not been able to use class outside package.



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 37-42 (patched)


added



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 44 (patched)


removed



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 51 (patched)


made it private



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 61 (patched)


added this



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 68 (patched)


made it private



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 88 (patched)


made it private



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 116 (patched)


corrected



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 120 (patched)


added



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
Lines 722 (patched)


corrected



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 177 (patched)


yes..



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 578 (patched)


added


- Ankit Kailaswar


On March 20, 2018, 10:27 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated March 20, 2018, 10:27 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b9fcdd8 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/1/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Ankit Kailaswar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/
---

(Updated March 20, 2018, 10:27 a.m.)


Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and Puneet 
Gupta.


Repository: lens


Description
---

https://issues.apache.org/jira/browse/LENS-1506

This patch contains code changes to enable kerberos authentication for 
1. lens to hive 
2. lens to metastore
3. lens to hdfs

code changes are as follows,
1. new http thrift client for hive driver to support sasl transport for 
kerberozied hive server.
2. cron to update KDC ticket before it expires.


Diffs
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
2eb94aa 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 54885f7 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
d5273be 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b9fcdd8 
  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 31ac358 


Diff: https://reviews.apache.org/r/66081/diff/1/


Testing
---

unit testing


Thanks,

Ankit Kailaswar